From eccfd691ba1b43598dfca31a25d8923b3cce6b1e Mon Sep 17 00:00:00 2001
From: "James Truher [MSFT]" <jimtru@microsoft.com>
Date: Wed, 9 Aug 2017 14:15:17 -0700
Subject: [PATCH] Improve code coverage for Get-Item cmdlet (#4385)

---
 .../Get-Item.Tests.ps1                        | 94 +++++++++++++++++++
 1 file changed, 94 insertions(+)

diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Item.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Item.Tests.ps1
index 1a1b4ab6c..93ef537a1 100644
--- a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Item.Tests.ps1
+++ b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Item.Tests.ps1
@@ -1,4 +1,12 @@
 Describe "Get-Item" -Tags "CI" {
+    BeforeAll {
+        if ( $IsWindows ) {
+            $skipNotWindows = $false
+        }
+        else {
+            $skipNotWindows = $true
+        }
+    }
     It "Should list all the items in the current working directory when asterisk is used" {
         $items = Get-Item (Join-Path -Path $PSScriptRoot -ChildPath "*")
         ,$items | Should BeOfType 'System.Object[]'
@@ -17,7 +25,93 @@ Describe "Get-Item" -Tags "CI" {
         $childitem | Should BeOfType 'System.IO.FileInfo'
     }
 
+    It "Using -literalpath should find no additional files" {
+        $null = New-Item -type file "$TESTDRIVE/file[abc].txt"
+        $null = New-Item -type file "$TESTDRIVE/filea.txt"
+        # if literalpath is not correct we would see filea.txt
+        $item = Get-Item -literalpath "$TESTDRIVE/file[abc].txt"
+        @($item).Count | Should Be 1
+        $item.Name | Should Be 'file[abc].txt'
+    }
+
     It "Should have mode flags set" {
         Get-ChildItem $PSScriptRoot | foreach-object { $_.Mode | Should Not BeNullOrEmpty }
     }
+
+    It "Should not return the item unless force is used if hidden" {
+        ${hiddenFile} = "${TESTDRIVE}/.hidden.txt"
+        ${item} = New-Item -type file "${hiddenFile}"
+        if ( ${IsWindows} ) {
+            attrib +h "$hiddenFile"
+        }
+        ${result} = Get-Item "${hiddenFile}" -ErrorAction SilentlyContinue
+        ${result} | Should BeNullOrEmpty
+        ${result} = Get-Item -force "${hiddenFile}" -ErrorAction SilentlyContinue
+        ${result}.FullName | Should Be ${item}.FullName
+    }
+
+    Context "Test for Include, Exclude, and Filter" {
+        BeforeAll {
+            ${testBaseDir} = "${TESTDRIVE}/IncludeExclude"
+            $null = New-Item -Type Directory "${testBaseDir}"
+            $null = New-Item -Type File "${testBaseDir}/file1.txt"
+            $null = New-Item -Type File "${testBaseDir}/file2.txt"
+        }
+        It "Should respect -Exclude" {
+            $result = Get-Item "${testBaseDir}/*" -Exclude "file2.txt"
+            ($result).Count | Should Be 1
+            $result.Name | should be "file1.txt"
+        }
+        It "Should respect -Include" {
+            $result = Get-Item "${testBaseDir}/*" -Include "file2.txt"
+            ($result).Count | Should Be 1
+            $result.Name | should be "file2.txt"
+        }
+        It "Should respect -Filter" {
+            $result = Get-Item "${testBaseDir}/*" -Filter "*2*"
+            ($result).Count | Should Be 1
+            $result.Name | should be "file2.txt"
+        }
+        It "Should respect combinations of filter, include, and exclude" {
+            $result = get-item "${testBaseDir}/*" -filter *.txt -include "file[12].txt" -exclude file2.txt
+            ($result).Count | Should Be 1
+            $result.Name | should be "file1.txt"
+        }
+    }
+
+    Context "Error Condition Checking" {
+        It "Should return an error if the provider does not exist" {
+            { Get-Item BadProvider::/BadFile -ErrorAction Stop } | ShouldBeErrorId "ProviderNotFound,Microsoft.PowerShell.Commands.GetItemCommand"
+        }
+
+        It "Should return an error if the drive does not exist" {
+            { Get-Item BadDrive:/BadFile -ErrorAction Stop } | ShouldBeErrorId "DriveNotFound,Microsoft.PowerShell.Commands.GetItemCommand"
+        }
+    }
+
+    Context "Alternate Stream Tests" {
+        BeforeAll {
+            if ( $skipNotWindows )
+            {
+                return
+            }
+            $altStreamPath = "$TESTDRIVE/altStream.txt"
+            $stringData = "test data"
+            $streamName = "test"
+            $item = new-item -type file $altStreamPath
+            Set-Content -path $altStreamPath -Stream $streamName -Value $stringData
+        }
+        It "Should find an alternate stream if present" -skip:$skipNotWindows {
+            $result = Get-Item $altStreamPath -Stream $streamName
+            $result.Length | Should Be ($stringData.Length + [Environment]::NewLine.Length)
+            $result.Stream | Should Be $streamName
+        }
+    }
+
+    Context "Registry Provider" {
+        It "Can retrieve an item from registry" -skip:$skipNotWindows {
+            ${result} = Get-Item HKLM:/Software
+            ${result} | Should BeOfType "Microsoft.Win32.RegistryKey"
+        }
+    }
 }