maxmustermann/PowerShell
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Document why PackageVersion is used in PowerShell.Common.props (#12523)

Browse source 
Co-Authored-By: Nick Guerrera <nicholg@microsoft.com>
This commit is contained in:
xtqqczze 2020-04-30 17:35:54 +01:00 committed by GitHub
parent 9e3b34035f
commit ef1c0d7d51
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
PowerShell.Common.props
View file

@ -56,12 +56,12 @@
<ProductVersion>$(PSCoreFormattedVersion)</ProductVersion>
<!--
We have explicitly assign 'PackageVersion'
because there is a bug: 'PackageVersion' is correctly assigned as 'Version' in 'NuGet.targets'
but then immediately redefined as '1.0.0'.
Tracking Issue https://github.com/dotnet/sdk/issues/1557
We have to explicitly assign 'PackageVersion' here because we're changing 'Version' in a target.
Before any targets have run (during static evaluation), 'Version' will have defaulted to '1.0.0' and PackageVersion will have defaulted to 'Version'.
See https://github.com/dotnet/sdk/issues/1557
-->
<PackageVersion>$(PSCoreBuildVersion)</PackageVersion>
<ApplicationIcon Condition="$(ProductVersion.Contains('preview'))">..\..\assets\Powershell_av_colors.ico</ApplicationIcon>
<ApplicationIcon Condition="!$(ProductVersion.Contains('preview'))">..\..\assets\Powershell_black.ico</ApplicationIcon>