Commit graph

222 commits

Author SHA1 Message Date
Aditya Patwardhan
5ff8fadd19
Build tar packages only when building on Ubuntu (#11766) 2020-02-04 11:21:08 -08:00
Travis Plunk
8206e96ba1
Fix Symlink creation in packaging.psm1 (#11723) 2020-01-29 14:24:38 -08:00
Ilya
aefb82a308
Correct casing for automatic variables (#11568)
* Remove BOM, insert newline at EOF

* Correct case of $MyInvocation special variable

* Correct case of $OFS special variable

* Correct case of $NestedPromptLevel special variable

* Correct case of $Matches special variable

* Correct case of $LASTEXITCODE special variable

* Correct case of $StackTrace special variable

* Correct case of $args special variable

* Correct case of $this special variable

* Correct case of $input special variable

* Correct case of $PSCmdlet special variable

* Correct case of $error special variable

* Correct case of $PSDefaultParameterValues special variable

* Correct case of $PSScriptRoot special variable

* Correct case of $PWD special variable

* Correct case of $null special variable

* Correct case of $true special variable

* Correct case of $false special variable

* Correct case of $PSModuleAutoLoadingPreference special variable

* Correct case of $IsLinux special variable

* Correct case of $IsMacOS special variable

* Correct case of $IsWindows special variable

* Correct case of $IsCoreCLR special variable

* Correct case of $DebugPreference special variable

* Correct case of $VerbosePreference special variable

* Correct case of $InformationPreference special variable

* Correct case of $ExecutionContext special variable

* Correct case of $HOME special variable

* Correct case of $Host special variable

* Correct case of $PID special variable

* Correct case of $PSCulture special variable

* Correct case of $PSHOME special variable

* Correct case of $PSUICulture special variable

* Correct case of $PSVersionTable special variable

* Fix false positives
2020-01-14 21:39:30 +05:00
Dongbo Wang
be813a2fd9 Generate the correct reference assembly for Microsoft.PowerShell.ConsoleHost NuGet package (#11545) 2020-01-13 15:58:02 -08:00
xtqqczze
e0d2e2aade Correct case of $PSHOME special variable 2020-01-13 19:35:33 +00:00
xtqqczze
4a9d70fdcd Correct case of $PWD special variable 2020-01-13 19:24:10 +00:00
xtqqczze
42d50434f8 Correct case of $PSCmdlet special variable 2020-01-13 19:19:12 +00:00
xtqqczze
70d9ed4d55 Remove Unicode BOM from text files (#11546) 2020-01-11 12:15:34 +05:00
Steve Lee
f61c0d4444 Update building of MSIX for RC to use 100 range revision (#11526) 2020-01-09 11:58:51 -08:00
Aditya Patwardhan
0b97d6d5cf Fix symbolic links on Debian 10 packages (#11474) 2020-01-07 16:54:03 -08:00
Travis Plunk
2c0d68c1c2
Add script to rebuild WIX component refs (#11485)
* Add script to rebuild component refs

* fix type

* fix document we get componentGroup from

* update files.wxs

* fix dependencies
2020-01-04 12:14:35 -08:00
Aditya Patwardhan
395c29cff8 Update dependencies from PowerShell Gallery and NuGet (#11323) 2019-12-11 15:21:03 -08:00
Aditya Patwardhan
8e76ad00e2 Bump .NET to 3.1.0 (#11260) 2019-12-04 13:17:16 -08:00
Travis Plunk
2ee9df5a5d fixes #11187 (#11236) 2019-12-03 19:39:06 +00:00
Travis Plunk
b60381f922 Update macOS minimum version (#11163) 2019-11-24 17:41:53 +05:00
Aditya Patwardhan
8fcd772353 Bump .NET core framework to 3.1-preview.3 (#11079) 2019-11-14 17:06:46 -08:00
dependabot-preview[bot]
7411ca8331 Bump Newtonsoft.Json (#11037)
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.2 to 12.0.3.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
- [Commits](https://github.com/JamesNK/Newtonsoft.Json/compare/12.0.2...12.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-12 10:42:44 +05:00
Travis Plunk
57a071e9e6
Add Debian 10, 11 and CentOS 8 packages (#11028) 2019-11-11 12:29:24 -08:00
Aditya Patwardhan
08e120ca2b
Bump .NET core framework to 3.1-preview.2 (#10993) 2019-11-07 11:45:17 -08:00
Steve Lee
87bb1e6f74 Update AppX Manifest and Packaging module to conform to MS Sto… (#10878) 2019-10-24 13:50:28 -07:00
Aditya Patwardhan
49e906bc3b Select the files for compliance tests which are owned by PowerShell (#10837)
* Move fxd compliance to the top to avoid binskim and apiscan on fxd folder

* Choose only the files we build for compliance

* Update tools/packaging/packaging.psm1

Co-Authored-By: Travis Plunk <travis.plunk@microsoft.com>
2019-10-19 10:32:34 -07:00
Aditya Patwardhan
74eaf1980f
Move to .NET Core 3.1 preview 1 (#10798) 2019-10-18 16:49:25 -07:00
Dongbo Wang
74517923cf Make Add-Type usable in application that hosts PowerShell (#10587) 2019-09-25 16:26:19 -07:00
Christoph Bergmeister [MVP]
3b93fd285e Update to .Net Core 3.0 RTM (#10604) 2019-09-23 13:10:58 -07:00
Steve Lee
becb4d98a6 Update MSIX packaging so the version to Store requirements (#10588)
update packaging msix so version conforms to Store requirment
2019-09-23 12:26:19 -07:00
Christoph Bergmeister [MVP]
6bf5c7656b Upgrade .Net Core 3.0 version from Preview 9 to RC1 (#10552) 2019-09-16 15:14:21 -07:00
Christoph Bergmeister [MVP]
5a66306c71 Upgrade to Netcoreapp3.0 preview9 (#10484) 2019-09-06 12:15:49 -07:00
Travis Plunk
704ee90d5c
Update the combined package build to release the daily builds (#10449) 2019-08-28 09:44:02 -07:00
Reece Dunham
da748549e3 Remove yet another appveyor reference (#10445) 2019-08-27 10:26:42 -07:00
Aditya Patwardhan
428784f52e
Some dependencies for Alpine need linux-x64 folder (#10407) 2019-08-21 14:30:56 -07:00
Steve Lee
4220271e0e Move to .NET Core 3.0 preview.8 (#10351) 2019-08-15 13:42:17 -07:00
Tyler James Leonhardt
38a63eaf64 Add Microsoft.PowerShell.CoreCLR.Eventing.dll to exception list for build fix (#10337) 2019-08-12 09:59:02 -07:00
Christoph Bergmeister [MVP]
7af38294db Update PowerShell to build against .NET Core 3.0-preview7 (#10227) 2019-08-05 09:56:29 -07:00
Aditya Patwardhan
540737ebe1 Split the fxdependent package on Windows into two packages (#10134) 2019-07-12 17:18:11 -07:00
Aditya Patwardhan
7150308de6 Revert "Bump System.Security.Principal.Windows (#10101)" (#10133)
This reverts commit f75c635ce4.
2019-07-11 18:10:16 -07:00
Aditya Patwardhan
b6f4d79ef8 Revert "Bump System.Security.AccessControl (#10102)" (#10132)
This reverts commit 729a29ab15.
2019-07-11 17:45:22 -07:00
dependabot-preview[bot]
729a29ab15 Bump System.Security.AccessControl (#10102)
Bumps System.Security.AccessControl from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-11 16:25:27 +05:00
dependabot-preview[bot]
f75c635ce4 Bump System.Security.Principal.Windows (#10101)
Bumps System.Security.Principal.Windows from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-11 16:24:38 +05:00
dependabot-preview[bot]
8e736d247a Bump System.Security.AccessControl (#10100)
Bumps System.Security.AccessControl from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-11 13:51:37 +05:00
Christoph Bergmeister [MVP]
fe56f9d902 Upgrade .Net Core 3 SDK from preview5 to preview6 and related out of band Nuget packages from 2.1 to 3.0-preview6 (#9888) 2019-07-09 14:35:08 -07:00
Tyler James Leonhardt
df8e01e95a Add to /etc/shells on macOS (#10066)
Co-Authored-By: Robert Holt <rjmholt@gmail.com>
2019-07-06 16:50:40 -07:00
Aditya Patwardhan
142f5dcad5
Update copyright symbol for NuGet packages (#9936) 2019-06-27 17:27:19 -07:00
Aditya Patwardhan
76e632402e Merged PR 8547: Fix the PowerShell version number in MSI packages
Fix the PowerShell version number in MSI packages
2019-05-29 22:37:18 +00:00
Aditya Patwardhan
ab7168f62e Merged PR 8510: Update the target framework for reference assemblies to netcoreapp3.0
Update the target framework for reference assemblies to netcoreapp3.0
2019-05-24 20:17:31 +00:00
Steve Lee
29e21470d9 Port PowerShell to .NET Core 3.0 (#9597) 2019-05-21 13:43:51 +08:00
Steve Lee
a96b4c0404 Update use of "PowerShell Core" to just "PowerShell" (#9513) 2019-05-10 15:34:27 -07:00
Steve Lee
3e1f630695 Add Preview assets for msix (#9375) 2019-04-22 10:41:34 -07:00
dependabot[bot]
ecbde6c020 Build(deps): Bump Newtonsoft.Json (#9431)
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.1 to 12.0.2.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
- [Commits](https://github.com/JamesNK/Newtonsoft.Json/compare/12.0.1...12.0.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-22 13:37:09 +05:00
Steve Lee
73114ee36c Enable building of msix package (#9289)
Add support in packaging.psm1 to produce a .msix AppX package.  Update the docker image to use the new msix package type.  Update the associated yml files so AzDevOps performs the build.

## PR Context

Enable publishing PSCore6 to Microsoft Store
2019-04-15 17:07:15 -07:00
Travis Plunk
e2bfced875
Update repo for Ubuntu 14.04 EOL (#9324)
Update repo for Ubuntu 14.04 EOL
  - also remove a missed instance of Fedora 27
2019-04-09 17:54:13 -07:00
Christoph Bergmeister [MVP]
f5fc0535ac Preserve user shortcuts pinned to Taskbar during MSI upgrade (#9305)
Fixes #8919 

Preserve user shortcuts pinned to Taskbar during MSI upgrade by not removing shortcuts in this case (assuming the user has not changed the installation directory), see https://stackoverflow.com/a/33402698/1810304
This also requires the Guid to not always be re-generated, which PR #7701 originally added to ensure shortcuts get removed when RTM and preview are installed, the underlying problem was rather that RTM and preview shared the same GUIDs, therefore the GUIDs are hard-coded again but different for RTM and preview, therefore the shortcuts will still always get removed on uninstall. But this also means those GUIDs should change when the default installation directory changes, i.e. in PowerShell 7. Should we write the code to already take this into account that it does not get forgotten?

Tested by first reproducing the issue by building installers locally (and bumping the patch version. Then the fix was applied to verify the solution, it. For this to take effect the version from which an MSI is being upgraded must have this fix already, i.e. if this fix got shipped in `6.2.1`, then on upgrading to it, the issue would still occur but when upgrading `6.2.1` to `6.2.2` the shortcut would start being preserved. I am wondering if we could maybe improve this to show effect earlier by trying to extract the used (auto-generated) GUIDs in the `6.2.0` and `6.2.0-rc` packages out and use them...
Please not that we probably need to take this out for `7.0` because the base installation directory will change. This also assumes that the user has not specified a different installation directory on upgrade but this is a bit of an edge case where I think other things might break as well.
2019-04-07 12:25:56 -07:00
Aditya Patwardhan
337ce63734
Use IL assemblies for NuGet packages to reduce size (#9171) 2019-03-21 10:03:46 -07:00
Aditya Patwardhan
753d31809b
Publish global tool packages to pwshtool blob and bug fixes (#9163) 2019-03-20 13:44:40 -07:00
Reece Dunham
1e49d09d29 Remove appveyor references from packaging tools (#9117)
Removes appveyor stuff


## PR Context

<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
#8686 , appveyor removed
2019-03-12 12:13:55 -07:00
Bram Crielaard
b115dff0eb Remove AppImage from tools (#9100) 2019-03-11 16:19:05 -07:00
Travis Plunk
d7dd4b5dd2
Fix MSI Upgrade failure for preview builds (#9013) 2019-02-28 14:05:27 -08:00
Aditya Patwardhan
fb05169a51
Build Global tool for PowerShell and SDK container (#8984)
* Add shim dll to redirect to appropriate runtime
* Build updates for creating global tool package
* Add building global tool to nuget.yml
* Add azure upload of nuget packages
2019-02-26 12:56:29 -08:00
Aditya Patwardhan
ec12f373ec Fix daily CI builds to publish tar package as artifacts (#8775)
Update the packaging script to always create the tar.gz packages.

## PR Context  

Daily builds for Linux and MacOS do not publish tar.gz package.
2019-02-04 14:53:25 -08:00
Travis Plunk
6b447423a0
Add instrumentation for Start-PSPackage (#8811)
Add instrumentation for start-PSPackage saying what parameters it thinks you used
2019-02-04 11:48:48 -08:00
Travis Plunk
e96b0bf85b
Refactor Unified Release Build (#8804)
Refactor Unified Release Build
  - Make injecting the nuget.config a template
  - Make setting the version variable a template
  - Add parameters to templates where needed
  - Run defender scan before uploading linux packages (and rename step to plain english)
2019-01-31 15:10:19 -08:00
Aditya Patwardhan
53c76d1658 Update the universal build with framework dependent package for dotnet sdk (#8773)
Update the universal build to also build the framework package needed for the dotnet sdk container image.

## PR Context  

We build the package in individual builds. This change brings over the steps in the universal build.
2019-01-29 10:59:30 -08:00
Travis Plunk
b779b88c79
Merge `release-v6.2.0-preview.4'
# Conflicts:
#	test/Test.Common.props
#	tools/packaging/packaging.psm1
2019-01-28 13:50:00 -08:00
Travis Plunk
d798ce7f5e
Make every csproj files have its own folder (#8750)
* move csproj files into individual folders

* get csproj files from individual folders
2019-01-25 13:44:25 -08:00
Dongbo Wang
1264a00a76 Update packaging script to build reference assembly targeting netcoreapp2.1 and use actual .csproj files (#8729) 2019-01-25 11:10:47 -08:00
xtqqczze
863528881f Use https in URLs where available (#8622)
Use https in URLS across the repository where the domain serves content by https.
2019-01-24 12:50:11 -08:00
Dongbo Wang
cab8f26386
Generate and deploy reference assembly for Microsoft.PowerShell.Commands.Utility.dll (#8716)
Update `New-ReferenceAssembly` and `New-UnifiedNugetPackage` to generate reference assembly for `Microsoft.PowerShell.Commands.Utility.dll` and properly deploy it for `Microsoft.PowerShell.Commands.Utility` NuGet package and `Microsoft.PowerShell.SDK` NuGet package.

An incremental step to fix, eventually, #8121
2019-01-23 11:43:18 -08:00
Dongbo Wang
86516ad0b6 Generate and deploy reference assembly for Microsoft.PowerShell.Commands.Utility.dll (#8716)
Update `New-ReferenceAssembly` and `New-UnifiedNugetPackage` to generate reference assembly for `Microsoft.PowerShell.Commands.Utility.dll` and properly deploy it for `Microsoft.PowerShell.Commands.Utility` NuGet package and `Microsoft.PowerShell.SDK` NuGet package.

An incremental step to fix, eventually, #8121
2019-01-23 11:42:32 -08:00
Travis Plunk
c4b2105a73 Merged PR 6648: Bump SDK and Runtime Versions
Bump SDK and Runtime Versions
  - Also, fix alpine docker file
  - Also, fix extra files being added to some Modules after these changes
2019-01-23 02:18:44 +00:00
Aditya Patwardhan
cf013dd072 Fix the build for fxdependent build for dotnet sdk (#8670) 2019-01-22 11:25:25 -08:00
Travis Plunk
f1218bd3d9
Remove Debian 8 references as it is EOL (#8678)
Remove Debian 8 references as it is EOL
2019-01-17 16:30:39 -08:00
Sergey Vasin
6f6c286bca Fix a typo in packaging.psm1 (#8647) 2019-01-15 17:18:20 -08:00
Aditya Patwardhan
be4b82c730
Add function to create a framework dependent package dotnet-sdk containers (#8644) 2019-01-15 16:28:52 -08:00
Dongbo Wang
ab75626f22 Fix installing fpm and ronn in macOS CI by avoid installing docs for them (#8656) 2019-01-15 14:23:59 -08:00
xtqqczze
1a3aadfc4e Regularize redirection operator spacing in *.ps1 and *.ps1m (#8581)
Add space after redirection operator.
2019-01-03 12:59:14 +05:00
Steve Lee
725bfdaf88 Enable install of Preview MSI release side-by-side with Stable release (#8513)
When installing (or upgrading) Preview builds the component ids for the files are the same as the installed files from the stable MSI.  MSI sees this and assumes the file is already installed so skips installing files that haven't changed (been updated) which results in missing files in the preview install folder and pwsh fails to start.  Fix is to dynamically generate new component ids (and compoentrefs) in `files.wxs` using `_Preview` suffix and use that when building a preview package.

Tested manually.

cc @bergmeister if you can help validate different scenarios.

Fix https://github.com/PowerShell/PowerShell/issues/8289
2019-01-02 12:00:43 -08:00
Alex Earl
74de391193 Add Linux ARM64 build support (#8016) 2018-12-05 10:55:09 -08:00
Christoph Bergmeister [MVP]
7c021e42e9 Update resgen, typegen to use .Net Core 2.1 (#8369) 2018-12-04 09:40:40 -08:00
Aditya Patwardhan
b0daa1e724 Build Alpine tar.gz package in release builds (#8340)
Enable building tar.gz package for Alpine in release builds.

## PR Checklist

- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    - Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] [Change is not breaking](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)
- [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
    - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready.
- **User-facing changes**
    - [x] Not Applicable
    - **OR**
    - [ ] User-facing [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
        - [ ] Issue filed - Issue link:
- **Testing - New and feature**
    - [x] Not Applicable or can only be tested interactively
    - **OR**
    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
        - [ ] [Add `[feature]` if the change is significant or affects feature tests](https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr)
2018-11-27 10:45:49 -08:00
Travis Plunk
ab809d95d9 Merged PR 5818: Port changes to allow AzDevOps NuGet feeds for Mac build
Port changes to allow AzDevOps NuGet feeds for Mac build
2018-11-14 01:04:39 +00:00
Travis Plunk
6698af81b7
Remove tilde from Linux preview packages (#8244)
Remove tilde from Linux preview packages.
  - Since we have a separate package for preview, we don't need a second indicator that these packages are preview.
  - Also, many system we use to release don't like the `~` character, which leads to manual interventions and errors.
2018-11-13 09:52:48 -08:00
Aditya Patwardhan
eb84c3d928 Merged PR 5379: Improve debugging of nuget package generation and add type to filtering 2018-10-16 20:23:57 +00:00
Aditya Patwardhan
5fcab21111 Remove PDBs from fxdependent pacakge (#8006) 2018-10-11 18:08:28 -07:00
Jellyfrog
8f6bbdf11e Add dependencies for SUSE (#7938) 2018-10-03 12:29:13 -07:00
Dongbo Wang
4926e15984
Make Start-PSPackage give better message about how to fix 'files.wxs' (#7841) 2018-09-25 09:53:42 -07:00
Aditya Patwardhan
8d4dd1e58f Remove packaging, building and installation scripts for Ubuntu 17.10 (#7773) 2018-09-17 14:48:23 -07:00
Travis Plunk
172a8a014d
Make sure MSI build works when not preview (#7752)
The variable was set to empty (meaning to delete the variable) in the non-preview case and the build fails.
The fix avoids setting the variable to empty
2018-09-10 14:35:02 -07:00
Aditya Patwardhan
abad087fa1 Build and package framework dependent package (#7729)
Add the functionality to build a framework dependent (shared framework) package for PowerShell.

The changes create two packages, one for Windows and other for Linux, due to #if code.
2018-09-10 12:47:32 -07:00
Travis Plunk
e2a45f0992
Add tests to report when package references are out of date (#7661)
Add tests to report when package references are out of date
  - Also, update the packaging script to generate updated `files.wxs`
2018-08-31 12:50:51 -07:00
Dan Travison
1abf290f83 Add symbolic links for libssl and libcrypto to Debian 9 builds to make remoting work. (#7609)
On Debian 9, libmi cannot resolve libssl and libcrypto. This change adds symbolic links to packaging and build to the $PSHOME directory to resolve the issue.

The fix was verified interactively connecting to office 365, importing the session, and ensuring Get-MailBox and Get-User succeed.

Fix #7598
2018-08-24 15:20:22 -07:00
Aditya Patwardhan
abb8f6bc80 Merged PR 4645: Fix SDK dependencies
Removed old dependencies from SMA and fixed the netcoreapp version.
2018-08-20 23:47:40 +00:00
Aditya Patwardhan
f19c5dae1f Update NuGet package metadata (#7517) 2018-08-14 13:31:58 -07:00
Greg Zimmerman
f0ea0d380f Add preview icon to macOS launcher (#7448) 2018-08-05 11:00:39 -07:00
Aditya Patwardhan
ac8ac4f25b Update NuGet packaging code for the new markdown assembly (#7431) 2018-08-02 23:00:54 -07:00
Steve Lee
1244278e7e [package] (#7345)
enable `pwsh-preview` to work on Windows
2018-07-25 13:32:10 -07:00
Aditya Patwardhan
ed4a454ac4 Make MUSL NuGet package optional (#7316) 2018-07-20 11:08:25 -07:00
Greg Zimmerman
d9c570a90d Fix macOS launcher app to allow release and preview versions. (#7306)
Fixes #7074. This PR allows concurrent versions of the macOS launcher app to exist. The application name will be either PowerShell or PowerShell-preview. It is now dynamically built and removed post fpm to avoid post build conflicts, see #5262 .
2018-07-20 10:53:09 -07:00
Travis Plunk
b15709f444 update to latest package references, runtime framework, and SDK (#7272)
* update to latest package references

* update runtime framework

* update sdk

* automatically read NuGet package dependency info from csproj, where version info is fully qualified

* update file.wxs
2018-07-13 09:00:35 +05:00
Steve Lee
167b51c4d6 update build and packaging modules for Alpine (#7149) 2018-06-27 15:30:38 -07:00
Christoph Bergmeister
0487a1be2f Disambiguate icon on Windows for preview builds/installers to use Powershell_av_colors and make daily build use Powershell_avatar instead (#7086)
Closes #6317
Using the preview side-by-side with the RTM version is a pain/confusing due to the icons being the same.
This makes the preview build (i.e. the embedded icon in `pwsh.exe`) and MSI installer package (shortcut icon and context menu) use the [Powershell_av_colors icon](https://raw.githubusercontent.com/PowerShell/PowerShell/master/assets/Powershell_av_colors.ico)
![image](https://user-images.githubusercontent.com/9250262/41491336-6e354936-70f0-11e8-965e-9b5e83be925b.png)

Therefore change the icon of the daily build (which used to use the Powershell_av_colors icon) to [Powershell_avatar](https://raw.githubusercontent.com/PowerShell/PowerShell/master/assets/Powershell_avatar.ico)
![image](https://user-images.githubusercontent.com/9250262/41491346-80f890a0-70f0-11e8-9ab5-bb789454c134.png)
This means that people like me who have a shortcut to pwsh of the daily build pinned to the taskbar, probably need to re-pin it to the taskbar to receive all changes (otherwise one will only get the change in the icon of the window)

Note: The `Test-IsPreview` method had to be moved to the build module, which is OK because the packaging module has a declared dependency on the build module in its manifest.
2018-06-18 15:54:11 -07:00
Travis Plunk
4342922268
make sure all references to the Pkg ID for previews packages is powershell-preview (#7066)
* make sure all references to the Pkg ID for previews are com.microsoft.powershell-preview
fixes #7065
2018-06-14 10:01:09 -07:00