Andrew Schwartzmeyer
|
674ca43046
|
Use just LOGIN_NAME_MAX
The +1 is unnecessary since LOGIN_NAME_MAX includes null.
|
2015-08-13 20:32:30 -07:00 |
|
Andrew Schwartzmeyer
|
c6aa25acd5
|
Use length() instead of size()
To be consistent with everything else.
|
2015-08-13 20:32:30 -07:00 |
|
Andrew Schwartzmeyer
|
db7117bd47
|
Use length() instead of size()
To be consistent with everything else.
|
2015-08-13 20:32:30 -07:00 |
|
Andrew Schwartzmeyer
|
91345a149e
|
Use 0 instead of '\0'
To be consistent with tests
|
2015-08-13 20:32:30 -07:00 |
|
Andrew Schwartzmeyer
|
fc8f5d18c4
|
Use 0 instead of '\0'
To be consistent with tests
|
2015-08-13 20:32:30 -07:00 |
|
Andrew Schwartzmeyer
|
bef9deeb84
|
Remove std::string utf8
Not used consistently. Use in-place for comparison.
|
2015-08-13 17:53:28 -07:00 |
|
Andrew Schwartzmeyer
|
bb67bfaae7
|
Remove std::string utf8
Not used consistently. Use in-place for comparison.
|
2015-08-13 17:53:28 -07:00 |
|
Andrew Schwartzmeyer
|
454d1f276a
|
Return FALSE instead of 0
|
2015-08-13 17:44:05 -07:00 |
|
Andrew Schwartzmeyer
|
46677d776b
|
Return FALSE instead of 0
|
2015-08-13 17:44:05 -07:00 |
|
Andrew Schwartzmeyer
|
40ba6c214e
|
Fix GetUserName unit test
A deadlock was occurring when executing `whoami` through
System.Diagnostics.Process because we were calling `WaitForExit()`
before `StandardOutput.ReadToEnd()`. According to the documentation, "To
avoid deadlocks, always read the output stream first and then wait,"
which is what we do here now.
Additionally, `Process` implements IDisposable, and is now automatically
disposed via the `using` block.
https://msdn.microsoft.com/en-us/library/system.diagnostics.process.standardoutput(v=vs.110).aspx
https://msdn.microsoft.com/en-us/library/System.Diagnostics.Process(v=vs.110).aspx
|
2015-08-13 15:45:13 -07:00 |
|
Zachary Folwick
|
5968e97eaa
|
changed PowerShell code to get Split-Path -Qualifier working in linux
|
2015-08-13 11:40:07 -07:00 |
|
Aaron
|
6bb2c69782
|
New line for {
|
2015-08-13 10:53:09 -07:00 |
|
Aaron
|
72ea5abd0b
|
New line for {
|
2015-08-13 10:53:09 -07:00 |
|
Aaron
|
1b537f0c8f
|
Changed based of feedback
|
2015-08-13 10:48:38 -07:00 |
|
Aaron
|
e900fc89d6
|
Changed based of feedback
|
2015-08-13 10:48:38 -07:00 |
|
Aaron
|
dfb7a49c21
|
Added changes to code based on additional documention and using a 16 bit string
|
2015-08-13 09:47:10 -07:00 |
|
Aaron
|
f496f91af0
|
Added changes to code based on additional documention and using a 16 bit string
|
2015-08-13 09:47:10 -07:00 |
|
Aaron
|
e10abd1971
|
Fixed Merge Confilct with CMakeLists.txt
|
2015-08-12 14:04:39 -07:00 |
|
Aaron
|
01f85ecf1c
|
Fixed Merge Confilct with CMakeLists.txt
|
2015-08-12 14:04:39 -07:00 |
|
Aaron
|
6fc54d4e42
|
changes to pal.h
|
2015-08-12 13:56:55 -07:00 |
|
Aaron
|
f2ce0d713d
|
changes to pal.h
|
2015-08-12 13:56:55 -07:00 |
|
Zachary Folwick
|
fd75d29628
|
changed ParsePathCommand.cs to get Split-Path unit tests to pass
|
2015-08-11 16:03:00 -07:00 |
|
Andrew Schwartzmeyer
|
864e32f331
|
Merge branch 'develop' into dev/fix-nuget
|
2015-08-11 08:59:28 -07:00 |
|
Andrew Schwartzmeyer
|
c9e1b6cbb1
|
Use NuGet APIv3
|
2015-08-11 08:56:29 -07:00 |
|
Andrew Schwartzmeyer
|
8d34bbea0a
|
Repin monad and monad-native
|
2015-08-10 13:37:17 -07:00 |
|
Andrew Schwartzmeyer
|
a99c56eea3
|
Convert to Allman style with 4-space indentation
|
2015-08-07 18:43:58 -07:00 |
|
Andrew Schwartzmeyer
|
9a42b894f2
|
Convert to Allman style with 4-space indentation
|
2015-08-07 18:43:58 -07:00 |
|
Andrew Schwartzmeyer
|
095ef2c385
|
Assert GetUserName unit test against whoami
|
2015-08-07 16:56:19 -07:00 |
|
Andrew Schwartzmeyer
|
b1ef23d707
|
Merge branch 'develop' into dev/67-GetUserName
|
2015-08-07 16:00:59 -07:00 |
|
Zach Folwick
|
5979596de2
|
Merge pull request 109 from dev/153-format-list-tests into develop
|
2015-08-07 21:51:42 +00:00 |
|
Zachary Folwick
|
749a92dff8
|
made string calls more precise
|
2015-08-07 14:52:19 -07:00 |
|
Andrew Schwartzmeyer
|
d35e13afdb
|
Fix list of props test and merge cruft
|
2015-08-07 14:39:17 -07:00 |
|
Zachary Folwick
|
6ef2590331
|
merged changes from upstream
|
2015-08-07 14:25:38 -07:00 |
|
Zachary Folwick
|
fd8a9d25ac
|
added a beforeEach clause
|
2015-08-07 14:12:40 -07:00 |
|
Andrew Schwartzmeyer
|
f4e84a84bd
|
Refactor and add tests
|
2015-08-07 14:07:03 -07:00 |
|
Andrew Schwartzmeyer
|
e5ca617d2a
|
Repin monad and monad-native
|
2015-08-07 13:11:21 -07:00 |
|
Andrew Schwartzmeyer
|
f35efda7e7
|
Add -Wall to CMAKE_CXX_FLAGS
|
2015-08-07 12:07:19 -07:00 |
|
Andrew Schwartzmeyer
|
da1e65cfaf
|
Add -Wall to CMAKE_CXX_FLAGS
|
2015-08-07 12:07:19 -07:00 |
|
Andrew Schwartzmeyer
|
467fdeeb0c
|
Map getlogin_r()'s ERANGE to ERROR_GEN_FAILURE
ERROR_INSUFFICIENT_BUFFER should never occur here and would be a
misleading error for the user.
|
2015-08-07 12:05:07 -07:00 |
|
Andrew Schwartzmeyer
|
665f8f1e87
|
Map getlogin_r()'s ERANGE to ERROR_GEN_FAILURE
ERROR_INSUFFICIENT_BUFFER should never occur here and would be a
misleading error for the user.
|
2015-08-07 12:05:07 -07:00 |
|
Andrew Schwartzmeyer
|
062eb5a7b4
|
Fix style issues
- Use Doxygen style comments (with better comments)
- Use `type* ident` instead of `type *ident`
- Start { on new lines
- Use TRUE/FALSE from PAL.H
|
2015-08-07 12:03:31 -07:00 |
|
Andrew Schwartzmeyer
|
f8e9dfde8c
|
Fix style issues
- Use Doxygen style comments (with better comments)
- Use `type* ident` instead of `type *ident`
- Start { on new lines
- Use TRUE/FALSE from PAL.H
|
2015-08-07 12:03:31 -07:00 |
|
Zachary Folwick
|
22348bdb91
|
removed unnecessary comments and matched style
|
2015-08-07 11:34:36 -07:00 |
|
Zachary Folwick
|
a8a8e2091c
|
changed filtering test to be better
|
2015-08-07 11:31:50 -07:00 |
|
Zachary Folwick
|
bbed466ada
|
resolved style and readability comments
|
2015-08-07 10:12:37 -07:00 |
|
Andrew Schwartzmeyer
|
1b18bfd5e1
|
Clean up CMakeLists
|
2015-08-06 17:03:53 -07:00 |
|
Andrew Schwartzmeyer
|
c8f9777481
|
Clean up CMakeLists
|
2015-08-06 17:03:53 -07:00 |
|
Zachary Folwick
|
49d5bf1121
|
added custom powershell object to properly mock the test function
|
2015-08-06 16:40:10 -07:00 |
|
Andrew Schwartzmeyer
|
afab62205a
|
Rename to GetUserNameW since it is Unicode
|
2015-08-06 16:28:29 -07:00 |
|
Andrew Schwartzmeyer
|
b379fb4a6b
|
Rename to GetUserNameW since it is Unicode
|
2015-08-06 16:28:29 -07:00 |
|