maxmustermann/PowerToys
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
PowerToys/.github/pull_request_template.md

24 lines
967 B
Markdown
Raw Permalink Normal View History

FancyZones and Shortcut Guide initial commit Co-authored-by: Alexis Campailla <alexis@janeasystems.com> Co-authored-by: Bret Anderson <bretan@microsoft.com> Co-authored-by: Enrico Giordani <enrico.giordani@gmail.com> Co-authored-by: Jaime Bernardo <jaime@janeasystems.com> Co-authored-by: Jeff Bogdan <jeffbog@microsoft.com> Co-authored-by: March Rogers <marchr@microsoft.com> Co-authored-by: Mike Harsh <mharsh@microsoft.com> Co-authored-by: Nachum Bundak <Nachum.Bundak@microsoft.com> Co-authored-by: Oliver Jones <ojones@microsoft.com> Co-authored-by: Patrick Little <plittle@microsoft.com>
2019-09-04 18:26:26 +02:00
## Summary of the Pull Request
Updating PR template (#8843) * Updating PR template due to a few recent misses, going to be a bit more rigorous * Update .github/pull_request_template.md Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com> * Update pull_request_template.md Didn't update one instance of wxs Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
2020-12-31 19:00:26 +01:00
**What is this about:**
FancyZones and Shortcut Guide initial commit Co-authored-by: Alexis Campailla <alexis@janeasystems.com> Co-authored-by: Bret Anderson <bretan@microsoft.com> Co-authored-by: Enrico Giordani <enrico.giordani@gmail.com> Co-authored-by: Jaime Bernardo <jaime@janeasystems.com> Co-authored-by: Jeff Bogdan <jeffbog@microsoft.com> Co-authored-by: March Rogers <marchr@microsoft.com> Co-authored-by: Mike Harsh <mharsh@microsoft.com> Co-authored-by: Nachum Bundak <Nachum.Bundak@microsoft.com> Co-authored-by: Oliver Jones <ojones@microsoft.com> Co-authored-by: Patrick Little <plittle@microsoft.com>
2019-09-04 18:26:26 +02:00
Updating PR template (#8843) * Updating PR template due to a few recent misses, going to be a bit more rigorous * Update .github/pull_request_template.md Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com> * Update pull_request_template.md Didn't update one instance of wxs Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
2020-12-31 19:00:26 +01:00
**What is include in the PR:**
FancyZones and Shortcut Guide initial commit Co-authored-by: Alexis Campailla <alexis@janeasystems.com> Co-authored-by: Bret Anderson <bretan@microsoft.com> Co-authored-by: Enrico Giordani <enrico.giordani@gmail.com> Co-authored-by: Jaime Bernardo <jaime@janeasystems.com> Co-authored-by: Jeff Bogdan <jeffbog@microsoft.com> Co-authored-by: March Rogers <marchr@microsoft.com> Co-authored-by: Mike Harsh <mharsh@microsoft.com> Co-authored-by: Nachum Bundak <Nachum.Bundak@microsoft.com> Co-authored-by: Oliver Jones <ojones@microsoft.com> Co-authored-by: Patrick Little <plittle@microsoft.com>
2019-09-04 18:26:26 +02:00
Updating PR template (#8843) * Updating PR template due to a few recent misses, going to be a bit more rigorous * Update .github/pull_request_template.md Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com> * Update pull_request_template.md Didn't update one instance of wxs Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
2020-12-31 19:00:26 +01:00
**How does someone test / validate:**
Update pull_request_template.md
2020-07-28 01:24:53 +02:00
Updating PR template (#8843) * Updating PR template due to a few recent misses, going to be a bit more rigorous * Update .github/pull_request_template.md Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com> * Update pull_request_template.md Didn't update one instance of wxs Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
2020-12-31 19:00:26 +01:00
## Quality Checklist
FancyZones and Shortcut Guide initial commit Co-authored-by: Alexis Campailla <alexis@janeasystems.com> Co-authored-by: Bret Anderson <bretan@microsoft.com> Co-authored-by: Enrico Giordani <enrico.giordani@gmail.com> Co-authored-by: Jaime Bernardo <jaime@janeasystems.com> Co-authored-by: Jeff Bogdan <jeffbog@microsoft.com> Co-authored-by: March Rogers <marchr@microsoft.com> Co-authored-by: Mike Harsh <mharsh@microsoft.com> Co-authored-by: Nachum Bundak <Nachum.Bundak@microsoft.com> Co-authored-by: Oliver Jones <ojones@microsoft.com> Co-authored-by: Patrick Little <plittle@microsoft.com>
2019-09-04 18:26:26 +02:00
Updating PR template (#8843) * Updating PR template due to a few recent misses, going to be a bit more rigorous * Update .github/pull_request_template.md Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com> * Update pull_request_template.md Didn't update one instance of wxs Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
2020-12-31 19:00:26 +01:00
- [ ] **Linked issue:** #xxx
- [ ] **Communication:** I've discussed this with core contributors in the issue.
- [ ] **Tests:** Added/updated and all pass
- [ ] **Installer:** Added/updated and all pass
- [ ] **Localization:** All end user facing strings can be localized
- [ ] **Docs:** Added/ updated
- [ ] **Binaries:** Any new files are added to WXS / YML
- [ ] No new binaries
Prepare for renaming master -> main (#13235) This commit replaces all references to PowerToys' master branch with "main" in documentation, code and build rules. - [x] **Linked issue:** #5433 - [x] **Communication:** I've discussed this with core contributors in the issue. - [ ] **Tests:** Added/updated and all pass (not applicable) - [ ] **Installer:** Added/updated and all pass (not applicable) - [ ] **Localization:** All end user facing strings can be localized (not applicable) - [x] **Docs:** Updated - [x] **Binaries:** Any new files are added to WXS / YML - [x] No new binaries
2021-11-01 18:21:47 +01:00
- [ ] [YML for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/pipeline.user.windows.yml#L68) for new binaries
- [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries
Update pull_request_template.md
2020-07-28 01:24:53 +02:00
Updating PR template (#8843) * Updating PR template due to a few recent misses, going to be a bit more rigorous * Update .github/pull_request_template.md Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com> * Update pull_request_template.md Didn't update one instance of wxs Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
2020-12-31 19:00:26 +01:00
## Contributor License Agreement (CLA)
A CLA must be signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/PowerToys) and sign the CLA.
Reference in a new issue Copy permalink