maxmustermann/PowerToys
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Comparing exepected vs actual json strings. This fixes two issues. (#6145)

Browse source 
1) the same variables are being compared against each other.
2) BasePTSettingsTest doesn't override equals to Equals compares the objects. This change compares the json strings directly.
This commit is contained in:
ryanbodrug-microsoft 2020-08-25 09:07:44 -07:00 committed by GitHub
parent 96fdb6169a
commit 2075f9fa71
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ModelsTests/SettingsUtilsTests.cs
View file

@ -48,7 +48,7 @@ namespace CommonLibTest
BasePTSettingsTest actual_json = SettingsUtils.GetSettings<BasePTSettingsTest>(file_name);
// Assert
Assert.IsTrue(actual_json.Equals(actual_json));
Assert.AreEqual(expected_json.ToJsonString(), actual_json.ToJsonString());
}
[TestMethod]
@ -70,7 +70,7 @@ namespace CommonLibTest
BasePTSettingsTest actual_json = SettingsUtils.GetSettings<BasePTSettingsTest>(file_name);
// Assert
Assert.IsTrue(actual_json.Equals(actual_json));
Assert.AreEqual(expected_json.ToJsonString(), actual_json.ToJsonString());
}
[TestMethod]