maxmustermann/PowerToys
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

runner: only launch update threads when we know we won't be elevated and show windows for the child (#1537)

Browse source
This commit is contained in:
Andrey Nekrasov 2020-03-12 10:59:10 +03:00 committed by GitHub
parent bd2cf19ec1
commit 20e89f21ff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/common/common.cpp
View file

@ -442,6 +442,7 @@ bool run_elevated(const std::wstring& file, const std::wstring& params)
exec_info.fMask = SEE_MASK_NOCLOSEPROCESS;
exec_info.lpDirectory = 0;
exec_info.hInstApp = 0;
exec_info.nShow = SW_SHOWDEFAULT;
if (ShellExecuteExW(&exec_info))
{

22
src/runner/main.cpp
View file

@ -167,6 +167,17 @@ int runner(bool isProcessElevated)
int result = -1;
try
{
std::thread{ [] {
github_update_checking_worker();
} }.detach();
if (winstore::running_as_packaged())
{
std::thread{ [] {
start_msi_uninstallation_sequence();
} }.detach();
}
notifications::register_background_toast_handler();
chdir_current_executable();
@ -318,17 +329,6 @@ int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine
int result = 0;
try
{
std::thread{ [] {
github_update_checking_worker();
} }.detach();
if (winstore::running_as_packaged())
{
std::thread{ [] {
start_msi_uninstallation_sequence();
} }.detach();
}
// Singletons initialization order needs to be preserved, first events and
// then modules to guarantee the reverse destruction order.
SystemMenuHelperInstace();