TypeScript/tests/cases/fourslash/renameJsSpecialAssignmentRhs2.ts

/// <reference path="fourslash.ts"/>
// @allowJs: true
// @Filename: a.js
////const foo = {
////    set: function (x) {
////        this._x = x;
////    },
////    copy: function ([|x|]) {
////        this._x = [|x|].prop;
////    }
////};

verify.rangesAreRenameLocations();
Special prop assignment symbol applies only to lhs In a Javascript file, the binder assigns a SpecialPropertyAssignment marker to the BinaryExpression node of several kinds of special assignments. Then it binds a special symbol whose declaration is that BinaryExpression node. But the symbol only applies to the left-hand side of the assignment. The right-hand side is an independent expression that should have its own symbols. Previously, symbol lookup in the checker didn't check whether a Javascript node that was part of a special property assignment came from the lhs or the rhs. So the right-hand side would also incorrectly get the special symbol intended for the left-hand side. `getSpecialPropertyAssignmentSymbolFromEntityName` in the checker now checks that its argument is the left-hand side of an assignment before returning a special property assignment symbol. 2017-02-24 23:22:55 +01:00			`/// <reference path="fourslash.ts"/>`
			`// @allowJs: true`
			`// @Filename: a.js`
			`////const foo = {`
			`//// set: function (x) {`
			`//// this._x = x;`
			`//// },`
Merge branch 'master' into refactor_findallrefs 2017-03-01 17:45:41 +01:00			`//// copy: function ([\|x\|]) {`
Rename tests 2017-02-24 23:53:35 +01:00			`//// this._x = [\|x\|].prop;`
Special prop assignment symbol applies only to lhs In a Javascript file, the binder assigns a SpecialPropertyAssignment marker to the BinaryExpression node of several kinds of special assignments. Then it binds a special symbol whose declaration is that BinaryExpression node. But the symbol only applies to the left-hand side of the assignment. The right-hand side is an independent expression that should have its own symbols. Previously, symbol lookup in the checker didn't check whether a Javascript node that was part of a special property assignment came from the lhs or the rhs. So the right-hand side would also incorrectly get the special symbol intended for the left-hand side. `getSpecialPropertyAssignmentSymbolFromEntityName` in the checker now checks that its argument is the left-hand side of an assignment before returning a special property assignment symbol. 2017-02-24 23:22:55 +01:00			`//// }`
			`////};`
Merge branch 'master' into refactor_findallrefs 2017-03-01 17:45:41 +01:00
			`verify.rangesAreRenameLocations();`