2016-06-14 21:39:13 +02:00
/// <reference path="scripts/types/ambient.d.ts" />
2018-04-17 23:19:42 +02:00
// @ts-check
const cp = require ( "child_process" ) ;
const path = require ( "path" ) ;
const fs = require ( "fs" ) ;
const child_process = require ( "child_process" ) ;
const originalGulp = require ( "gulp" ) ;
const helpMaker = require ( "gulp-help" ) ;
const runSequence = require ( "run-sequence" ) ;
const concat = require ( "gulp-concat" ) ;
const clone = require ( "gulp-clone" ) ;
const newer = require ( "gulp-newer" ) ;
const tsc = require ( "gulp-typescript" ) ;
const insert = require ( "gulp-insert" ) ;
const sourcemaps = require ( "gulp-sourcemaps" ) ;
const Q = require ( "q" ) ;
const del = require ( "del" ) ;
const mkdirP = require ( "mkdirp" ) ;
const minimist = require ( "minimist" ) ;
const browserify = require ( "browserify" ) ;
const through2 = require ( "through2" ) ;
const merge2 = require ( "merge2" ) ;
const os = require ( "os" ) ;
const fold = require ( "travis-fold" ) ;
2018-05-03 00:03:42 +02:00
const ts = require ( "./lib/typescript" ) ;
2016-06-10 02:44:59 +02:00
const gulp = helpMaker ( originalGulp ) ;
2016-09-08 01:18:14 +02:00
Error . stackTraceLimit = 1000 ;
2017-10-03 02:37:40 +02:00
/ * *
* This regexp exists to capture our const enums and replace them with normal enums in our public API
* - this is fine since we compile with preserveConstEnums , and ensures our consumers are not locked
* to the TS version they compile with .
* /
const constEnumCaptureRegexp = /^(\s*)(export )?const enum (\S+) {(\s*)$/gm ;
const constEnumReplacement = "$1$2enum $3 {$4" ;
2016-06-10 02:44:59 +02:00
const cmdLineOptions = minimist ( process . argv . slice ( 2 ) , {
2018-05-23 02:01:45 +02:00
boolean : [ "debug" , "inspect" , "light" , "colors" , "lint" , "soft" , "fix" ] ,
2017-06-08 21:24:20 +02:00
string : [ "browser" , "tests" , "host" , "reporter" , "stackTraceLimit" , "timeout" ] ,
2016-06-10 02:44:59 +02:00
alias : {
2017-11-07 03:13:20 +01:00
"b" : "browser" ,
"d" : "debug" , "debug-brk" : "debug" ,
"i" : "inspect" , "inspect-brk" : "inspect" ,
"t" : "tests" , "test" : "tests" ,
"ru" : "runners" , "runner" : "runners" ,
"r" : "reporter" ,
"c" : "colors" , "color" : "colors" ,
"w" : "workers" ,
2018-05-23 02:01:45 +02:00
"f" : "fix" ,
2016-06-10 02:44:59 +02:00
} ,
default : {
soft : false ,
colors : process.env.colors || process . env . color || true ,
2017-06-08 21:24:20 +02:00
debug : process.env.debug || process . env [ "debug-brk" ] || process . env . d ,
inspect : process.env.inspect || process . env [ "inspect-brk" ] || process . env . i ,
2016-06-10 02:44:59 +02:00
host : process.env.TYPESCRIPT_HOST || process . env . host || "node" ,
2018-05-09 23:16:34 +02:00
browser : process.env.browser || process . env . b || ( os . platform ( ) === "win32" ? "edge" : "chrome" ) ,
2017-06-08 21:24:20 +02:00
timeout : process.env.timeout || 40000 ,
2016-06-10 02:44:59 +02:00
tests : process.env.test || process . env . tests || process . env . t ,
2017-11-06 20:24:17 +01:00
runners : process.env.runners || process . env . runner || process . env . ru ,
2017-10-20 02:15:54 +02:00
light : process.env.light === undefined || process . env . light !== "false" ,
2016-06-10 02:44:59 +02:00
reporter : process.env.reporter || process . env . r ,
lint : process.env.lint || true ,
2018-05-23 02:01:45 +02:00
fix : process.env.fix || process . env . f ,
2017-01-25 18:13:00 +01:00
workers : process.env.workerCount || os . cpus ( ) . length ,
2016-06-10 02:44:59 +02:00
}
} ) ;
2017-11-07 18:22:28 +01:00
const noop = ( ) = > { } ; // tslint:disable-line no-empty
2018-04-17 23:19:42 +02:00
/ * *
2018-05-03 00:03:42 +02:00
* @param { string } cmd
* @param { string [ ] } args
* @param { ( ) = > void } complete
* @param { ( e : * , status : number ) = > void } error
2018-04-17 23:19:42 +02:00
* /
function exec ( cmd , args , complete = noop , error = noop ) {
2016-06-10 02:44:59 +02:00
console . log ( ` ${ cmd } ${ args . join ( " " ) } ` ) ;
2016-06-20 23:39:29 +02:00
// TODO (weswig): Update child_process types to add windowsVerbatimArguments to the type definition
2016-06-23 22:08:27 +02:00
const subshellFlag = isWin ? "/c" : "-c" ;
2016-06-24 20:01:16 +02:00
const command = isWin ? [ possiblyQuote ( cmd ) , . . . args ] : [ ` ${ cmd } ${ args . join ( " " ) } ` ] ;
2018-04-17 23:19:42 +02:00
const ex = cp . spawn ( isWin ? "cmd" : "/bin/sh" , [ subshellFlag , . . . command ] , { stdio : "inherit" , windowsVerbatimArguments : true } ) ;
2016-06-10 02:44:59 +02:00
ex . on ( "exit" , ( code ) = > code === 0 ? complete ( ) : error ( /*e*/ undefined , code ) ) ;
ex . on ( "error" , error ) ;
}
2018-04-17 23:19:42 +02:00
/ * *
2018-05-03 00:03:42 +02:00
* @param { string } cmd
2018-04-17 23:19:42 +02:00
* /
function possiblyQuote ( cmd ) {
2016-06-24 20:01:16 +02:00
return cmd . indexOf ( " " ) >= 0 ? ` " ${ cmd } " ` : cmd ;
}
2016-06-10 02:44:59 +02:00
2018-05-03 00:03:42 +02:00
/ * *
* @param diagnostics { ts . Diagnostic [ ] }
* @param [ pretty ] { boolean }
* /
function diagnosticsToString ( diagnostics , pretty ) {
const host = {
getCurrentDirectory() { return process . cwd ( ) ; } ,
getCanonicalFileName ( fileName ) { return fileName ; } ,
getNewLine() { return os . EOL ; }
} ;
return pretty ? ts . formatDiagnosticsWithColorAndContext ( diagnostics , host ) :
ts . formatDiagnostics ( diagnostics , host ) ;
}
/** @param diagnostics {ts.Diagnostic[]} */
function reportDiagnostics ( diagnostics ) {
console . log ( diagnosticsToString ( diagnostics , process . stdout . isTTY ) ) ;
}
/** @param jsonPath {string} */
function readJson ( jsonPath ) {
const jsonText = fs . readFileSync ( jsonPath , "utf8" ) ;
const result = ts . parseConfigFileTextToJson ( jsonPath , jsonText ) ;
if ( result . error ) {
reportDiagnostics ( [ result . error ] ) ;
throw new Error ( "An error occurred during parse." ) ;
}
return result . config ;
}
2016-06-10 02:44:59 +02:00
let useDebugMode = true ;
2017-10-19 17:15:48 +02:00
let host = cmdLineOptions . host ;
2016-06-10 02:44:59 +02:00
// Constants
const compilerDirectory = "src/compiler/" ;
const harnessDirectory = "src/harness/" ;
const libraryDirectory = "src/lib/" ;
const scriptsDirectory = "scripts/" ;
const docDirectory = "doc/" ;
2017-10-03 02:16:08 +02:00
const lclDirectory = "src/loc/lcl" ;
2016-06-10 02:44:59 +02:00
const builtDirectory = "built/" ;
const builtLocalDirectory = "built/local/" ;
2017-11-06 18:23:47 +01:00
const lkgDirectory = "lib/" ;
2016-06-10 02:44:59 +02:00
const copyright = "CopyrightNotice.txt" ;
const compilerFilename = "tsc.js" ;
2017-11-06 18:23:47 +01:00
const lkgCompiler = path . join ( lkgDirectory , compilerFilename ) ;
2016-06-10 02:44:59 +02:00
const builtLocalCompiler = path . join ( builtLocalDirectory , compilerFilename ) ;
const nodeModulesPathPrefix = path . resolve ( "./node_modules/.bin/" ) ;
const isWin = /^win/ . test ( process . platform ) ;
const mocha = path . join ( nodeModulesPathPrefix , "mocha" ) + ( isWin ? ".cmd" : "" ) ;
2018-05-03 00:03:42 +02:00
/** @type {{ libs: string[], paths?: Record<string, string>, sources?: Record<string, string[]> }} */
const libraries = readJson ( "./src/lib/libs.json" ) ;
2016-06-10 02:44:59 +02:00
2017-10-19 00:46:09 +02:00
/ * *
* . lcg file is what localization team uses to know what messages to localize .
* The file is always generated in 'enu\diagnosticMessages.generated.json.lcg'
* /
const generatedLCGFile = path . join ( builtLocalDirectory , "enu" , "diagnosticMessages.generated.json.lcg" ) ;
/ * *
* The localization target produces the two following transformations :
* 1 . 'src\loc\lcl\<locale>\diagnosticMessages.generated.json.lcl' = > 'built\local\<locale>\diagnosticMessages.generated.json'
* convert localized resources into a . json file the compiler can understand
* 2 . 'src\compiler\diagnosticMessages.generated.json' = > 'built\local\ENU\diagnosticMessages.generated.json.lcg'
* generate the lcg file ( source of messages to localize ) from the diagnosticMessages . generated . json
* /
2018-05-09 23:30:07 +02:00
const localizationTargets = [ "cs" , "de" , "es" , "fr" , "it" , "ja" , "ko" , "pl" , "pt-br" , "ru" , "tr" , "zh-cn" , "zh-tw" ]
2017-11-03 23:08:50 +01:00
. map ( f = > path . join ( builtLocalDirectory , f , "diagnosticMessages.generated.json" ) )
. concat ( generatedLCGFile ) ;
2017-10-19 00:46:09 +02:00
2018-05-03 00:03:42 +02:00
const libraryTargets = libraries . libs . map ( lib = > {
const relativeSources = [ "header.d.ts" ] . concat ( libraries . sources && libraries . sources [ lib ] || [ lib + ".d.ts" ] ) ;
const relativeTarget = libraries . paths && libraries . paths [ lib ] || ( "lib." + lib + ".d.ts" ) ;
const sources = [ copyright ] . concat ( relativeSources . map ( s = > path . join ( libraryDirectory , s ) ) ) ;
const target = path . join ( builtLocalDirectory , relativeTarget ) ;
2017-11-03 23:08:50 +01:00
gulp . task ( target , /*help*/ false , [ ] , ( ) = >
gulp . src ( sources )
2016-06-20 23:39:29 +02:00
. pipe ( newer ( target ) )
2016-10-03 00:57:03 +02:00
. pipe ( concat ( target , { newLine : "\n\n" } ) )
2017-11-03 23:08:50 +01:00
. pipe ( gulp . dest ( "." ) ) ) ;
2018-05-03 00:03:42 +02:00
return target ;
} ) ;
2016-06-10 02:44:59 +02:00
2018-04-17 21:42:31 +02:00
const configurePreleleaseJs = path . join ( scriptsDirectory , "configurePrerelease.js" ) ;
const configurePreleleaseTs = path . join ( scriptsDirectory , "configurePrerelease.ts" ) ;
2016-06-10 02:44:59 +02:00
const packageJson = "package.json" ;
2016-11-15 21:53:46 +01:00
const versionFile = path . join ( compilerDirectory , "core.ts" ) ;
2016-06-10 02:44:59 +02:00
2018-04-17 23:19:42 +02:00
/ * *
2018-05-03 00:03:42 +02:00
* @param { string | string [ ] } source
* @param { string | string [ ] } dest
2018-04-17 23:19:42 +02:00
* @returns { boolean }
* /
function needsUpdate ( source , dest ) {
2016-06-10 02:44:59 +02:00
if ( typeof source === "string" && typeof dest === "string" ) {
if ( fs . existsSync ( dest ) ) {
const { mtime : outTime } = fs . statSync ( dest ) ;
const { mtime : inTime } = fs . statSync ( source ) ;
if ( + inTime <= + outTime ) {
return false ;
}
}
}
else if ( typeof source === "string" && typeof dest !== "string" ) {
const { mtime : inTime } = fs . statSync ( source ) ;
for ( const filepath of dest ) {
if ( fs . existsSync ( filepath ) ) {
const { mtime : outTime } = fs . statSync ( filepath ) ;
if ( + inTime > + outTime ) {
return true ;
}
}
else {
return true ;
}
}
return false ;
}
else if ( typeof source !== "string" && typeof dest === "string" ) {
if ( fs . existsSync ( dest ) ) {
const { mtime : outTime } = fs . statSync ( dest ) ;
for ( const filepath of source ) {
if ( fs . existsSync ( filepath ) ) {
const { mtime : inTime } = fs . statSync ( filepath ) ;
if ( + inTime > + outTime ) {
return true ;
}
}
else {
return true ;
}
}
return false ;
}
}
else if ( typeof source !== "string" && typeof dest !== "string" ) {
for ( let i = 0 ; i < source . length ; i ++ ) {
if ( ! dest [ i ] ) {
continue ;
}
if ( fs . existsSync ( dest [ i ] ) ) {
const { mtime : outTime } = fs . statSync ( dest [ i ] ) ;
const { mtime : inTime } = fs . statSync ( source [ i ] ) ;
if ( + inTime > + outTime ) {
return true ;
}
}
else {
return true ;
}
}
return false ;
}
return true ;
}
2018-04-17 23:19:42 +02:00
/ * *
2018-05-03 00:03:42 +02:00
* @param { tsc . Settings } base
2018-04-17 23:19:42 +02:00
* @param { boolean = } useBuiltCompiler
* @returns { tsc . Settings }
* /
function getCompilerSettings ( base , useBuiltCompiler ) {
const copy = /** @type {tsc.Settings} */ ( { } ) ;
2016-06-14 23:41:25 +02:00
for ( const key in base ) {
copy [ key ] = base [ key ] ;
}
2018-05-22 23:46:57 +02:00
copy . strictNullChecks = true ;
2016-06-14 21:39:13 +02:00
if ( ! useDebugMode ) {
if ( copy . removeComments === undefined ) copy . removeComments = true ;
}
2017-10-03 02:37:40 +02:00
copy . newLine = "lf" ;
2016-06-20 23:39:29 +02:00
if ( useBuiltCompiler === true ) {
2018-04-17 23:19:42 +02:00
copy . typescript = /** @type {*} */ ( require ( "./built/local/typescript.js" ) ) ;
2016-06-14 21:39:13 +02:00
}
2016-06-20 23:39:29 +02:00
else if ( useBuiltCompiler === false ) {
2018-04-17 23:19:42 +02:00
copy . typescript = /** @type {*} */ ( require ( "./lib/typescript.js" ) ) ;
2016-06-14 21:39:13 +02:00
}
return copy ;
2016-06-10 02:44:59 +02:00
}
2018-04-17 21:42:31 +02:00
gulp . task ( configurePreleleaseJs , /*help*/ false , [ ] , ( ) = > {
2018-04-17 23:19:42 +02:00
/** @type {tsc.Settings} */
const settings = {
2016-06-14 21:39:13 +02:00
declaration : false ,
removeComments : true ,
noResolve : false ,
stripInternal : false ,
2018-04-17 21:42:31 +02:00
module : "commonjs"
2016-06-14 21:39:13 +02:00
} ;
2018-04-17 21:42:31 +02:00
return gulp . src ( configurePreleleaseTs )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
. pipe ( tsc ( settings ) )
2018-04-17 21:42:31 +02:00
. pipe ( sourcemaps . write ( "." ) )
. pipe ( gulp . dest ( "./scripts" ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
// Nightly management tasks
2018-04-17 21:42:31 +02:00
gulp . task ( "configure-nightly" , "Runs scripts/configurePrerelease.ts to prepare a build for nightly publishing" , [ configurePreleleaseJs ] , ( done ) = > {
exec ( host , [ configurePreleleaseJs , "dev" , packageJson , versionFile ] , done , done ) ;
2016-06-10 02:44:59 +02:00
} ) ;
gulp . task ( "publish-nightly" , "Runs `npm publish --tag next` to create a new nightly build on npm" , [ "LKG" ] , ( ) = > {
2017-07-25 19:50:46 +02:00
return runSequence ( "clean" , "useDebugMode" , "runtests-parallel" , ( done ) = > {
2016-06-10 02:44:59 +02:00
exec ( "npm" , [ "publish" , "--tag" , "next" ] , done , done ) ;
} ) ;
} ) ;
const importDefinitelyTypedTestsDirectory = path . join ( scriptsDirectory , "importDefinitelyTypedTests" ) ;
const importDefinitelyTypedTestsJs = path . join ( importDefinitelyTypedTestsDirectory , "importDefinitelyTypedTests.js" ) ;
const importDefinitelyTypedTestsTs = path . join ( importDefinitelyTypedTestsDirectory , "importDefinitelyTypedTests.ts" ) ;
2016-06-14 21:39:13 +02:00
2017-04-05 07:34:51 +02:00
gulp . task ( importDefinitelyTypedTestsJs , /*help*/ false , [ ] , ( ) = > {
2018-04-17 23:19:42 +02:00
/** @type {tsc.Settings} */
const settings = getCompilerSettings ( {
2016-06-14 21:39:13 +02:00
declaration : false ,
removeComments : true ,
noResolve : false ,
stripInternal : false ,
outFile : importDefinitelyTypedTestsJs
} , /*useBuiltCompiler*/ false ) ;
return gulp . src ( importDefinitelyTypedTestsTs )
. pipe ( sourcemaps . init ( ) )
. pipe ( tsc ( settings ) )
2016-06-14 22:09:48 +02:00
. pipe ( sourcemaps . write ( "." ) )
2016-06-14 23:41:25 +02:00
. pipe ( gulp . dest ( "." ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
gulp . task ( "importDefinitelyTypedTests" , "Runs scripts/importDefinitelyTypedTests/importDefinitelyTypedTests.ts to copy DT's tests to the TS-internal RWC tests" , [ importDefinitelyTypedTestsJs ] , ( done ) = > {
exec ( host , [ importDefinitelyTypedTestsJs , "./" , "../DefinitelyTyped" ] , done , done ) ;
} ) ;
gulp . task ( "lib" , "Builds the library targets" , libraryTargets ) ;
// Generate diagnostics
const processDiagnosticMessagesJs = path . join ( scriptsDirectory , "processDiagnosticMessages.js" ) ;
const processDiagnosticMessagesTs = path . join ( scriptsDirectory , "processDiagnosticMessages.ts" ) ;
const diagnosticMessagesJson = path . join ( compilerDirectory , "diagnosticMessages.json" ) ;
const diagnosticInfoMapTs = path . join ( compilerDirectory , "diagnosticInformationMap.generated.ts" ) ;
const generatedDiagnosticMessagesJSON = path . join ( compilerDirectory , "diagnosticMessages.generated.json" ) ;
const builtGeneratedDiagnosticMessagesJSON = path . join ( builtLocalDirectory , "diagnosticMessages.generated.json" ) ;
// processDiagnosticMessages script
2017-04-05 07:34:51 +02:00
gulp . task ( processDiagnosticMessagesJs , /*help*/ false , [ ] , ( ) = > {
2018-04-16 22:53:30 +02:00
const diagsProject = tsc . createProject ( './scripts/processDiagnosticMessages.tsconfig.json' ) ;
return diagsProject . src ( )
2016-06-20 23:39:29 +02:00
. pipe ( newer ( processDiagnosticMessagesJs ) )
2018-04-16 22:53:30 +02:00
. pipe ( diagsProject ( ) )
. pipe ( gulp . dest ( scriptsDirectory ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
// The generated diagnostics map; built for the compiler and for the "generate-diagnostics" task
gulp . task ( diagnosticInfoMapTs , [ processDiagnosticMessagesJs ] , ( done ) = > {
if ( needsUpdate ( diagnosticMessagesJson , [ generatedDiagnosticMessagesJSON , diagnosticInfoMapTs ] ) ) {
exec ( host , [ processDiagnosticMessagesJs , diagnosticMessagesJson ] , done , done ) ;
}
else {
done ( ) ;
}
} ) ;
gulp . task ( builtGeneratedDiagnosticMessagesJSON , [ diagnosticInfoMapTs ] , ( done ) = > {
if ( fs . existsSync ( builtLocalDirectory ) && needsUpdate ( generatedDiagnosticMessagesJSON , builtGeneratedDiagnosticMessagesJSON ) ) {
fs . writeFileSync ( builtGeneratedDiagnosticMessagesJSON , fs . readFileSync ( generatedDiagnosticMessagesJSON ) ) ;
}
done ( ) ;
} ) ;
gulp . task ( "generate-diagnostics" , "Generates a diagnostic file in TypeScript based on an input JSON file" , [ diagnosticInfoMapTs ] ) ;
2017-10-03 02:16:08 +02:00
// Localize diagnostics script
const generateLocalizedDiagnosticMessagesJs = path . join ( scriptsDirectory , "generateLocalizedDiagnosticMessages.js" ) ;
const generateLocalizedDiagnosticMessagesTs = path . join ( scriptsDirectory , "generateLocalizedDiagnosticMessages.ts" ) ;
gulp . task ( generateLocalizedDiagnosticMessagesJs , /*help*/ false , [ ] , ( ) = > {
2018-04-17 23:19:42 +02:00
/** @type {tsc.Settings} */
const settings = getCompilerSettings ( {
2017-10-03 02:16:08 +02:00
target : "es5" ,
declaration : false ,
removeComments : true ,
noResolve : false ,
stripInternal : false ,
types : [ "node" , "xml2js" ]
} , /*useBuiltCompiler*/ false ) ;
return gulp . src ( generateLocalizedDiagnosticMessagesTs )
. pipe ( newer ( generateLocalizedDiagnosticMessagesJs ) )
. pipe ( sourcemaps . init ( ) )
. pipe ( tsc ( settings ) )
. pipe ( sourcemaps . write ( "." ) )
2017-10-04 01:38:47 +02:00
. pipe ( gulp . dest ( scriptsDirectory ) ) ;
2017-10-03 02:16:08 +02:00
} ) ;
// Localize diagnostics
gulp . task ( generatedLCGFile , [ generateLocalizedDiagnosticMessagesJs , diagnosticInfoMapTs ] , ( done ) = > {
if ( fs . existsSync ( builtLocalDirectory ) && needsUpdate ( generatedDiagnosticMessagesJSON , generatedLCGFile ) ) {
exec ( host , [ generateLocalizedDiagnosticMessagesJs , lclDirectory , builtLocalDirectory , generatedDiagnosticMessagesJSON ] , done , done ) ;
}
} ) ;
gulp . task ( "localize" , [ generatedLCGFile ] ) ;
2016-06-15 03:00:25 +02:00
const servicesFile = path . join ( builtLocalDirectory , "typescriptServices.js" ) ;
const standaloneDefinitionsFile = path . join ( builtLocalDirectory , "typescriptServices.d.ts" ) ;
const nodePackageFile = path . join ( builtLocalDirectory , "typescript.js" ) ;
const nodeDefinitionsFile = path . join ( builtLocalDirectory , "typescript.d.ts" ) ;
const nodeStandaloneDefinitionsFile = path . join ( builtLocalDirectory , "typescript_standalone.d.ts" ) ;
2018-04-17 23:19:42 +02:00
/** @type {string} */
let copyrightContent ;
/ * *
2018-05-03 00:03:42 +02:00
* @param { boolean } outputCopyright
2018-04-17 23:19:42 +02:00
* /
function prependCopyright ( outputCopyright = ! useDebugMode ) {
2016-06-22 03:22:30 +02:00
return insert . prepend ( outputCopyright ? ( copyrightContent || ( copyrightContent = fs . readFileSync ( copyright ) . toString ( ) ) ) : "" ) ;
}
2016-06-21 02:54:38 +02:00
2017-04-05 07:34:51 +02:00
gulp . task ( builtLocalCompiler , /*help*/ false , [ servicesFile ] , ( ) = > {
2017-04-11 18:37:31 +02:00
const localCompilerProject = tsc . createProject ( "src/compiler/tsconfig.json" , getCompilerSettings ( { } , /*useBuiltCompiler*/ true ) ) ;
2016-06-20 23:39:29 +02:00
return localCompilerProject . src ( )
. pipe ( newer ( builtLocalCompiler ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
2016-10-01 11:16:43 +02:00
. pipe ( localCompilerProject ( ) )
2016-06-22 03:22:30 +02:00
. pipe ( prependCopyright ( ) )
2016-06-20 23:39:29 +02:00
. pipe ( sourcemaps . write ( "." ) )
2017-03-01 16:57:34 +01:00
. pipe ( gulp . dest ( "src/compiler" ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
2017-04-05 07:34:51 +02:00
gulp . task ( servicesFile , /*help*/ false , [ "lib" , "generate-diagnostics" ] , ( ) = > {
2017-04-11 18:37:31 +02:00
const servicesProject = tsc . createProject ( "src/services/tsconfig.json" , getCompilerSettings ( { removeComments : false } , /*useBuiltCompiler*/ false ) ) ;
2016-06-20 23:39:29 +02:00
const { js , dts } = servicesProject . src ( )
. pipe ( newer ( servicesFile ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
2016-10-01 11:16:43 +02:00
. pipe ( servicesProject ( ) ) ;
2016-06-22 03:22:30 +02:00
const completedJs = js . pipe ( prependCopyright ( ) )
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
. pipe ( sourcemaps . write ( "." ) ) ;
2017-04-11 18:37:31 +02:00
const completedDts = dts . pipe ( prependCopyright ( /*outputCopyright*/ true ) )
2016-06-21 02:54:38 +02:00
. pipe ( insert . transform ( ( contents , file ) = > {
file . path = standaloneDefinitionsFile ;
2017-10-03 02:37:40 +02:00
return contents . replace ( constEnumCaptureRegexp , constEnumReplacement ) ;
2016-06-21 02:54:38 +02:00
} ) ) ;
return merge2 ( [
completedJs ,
completedJs . pipe ( clone ( ) )
. pipe ( insert . transform ( ( content , file ) = > ( file . path = nodePackageFile , content ) ) ) ,
completedDts ,
completedDts . pipe ( clone ( ) )
. pipe ( insert . transform ( ( content , file ) = > {
file . path = nodeDefinitionsFile ;
2017-10-03 02:37:40 +02:00
return content + "\nexport = ts;" ;
2016-06-21 02:54:38 +02:00
} ) )
2017-03-07 18:52:45 +01:00
. pipe ( gulp . dest ( "src/services" ) ) ,
2016-06-21 02:54:38 +02:00
completedDts . pipe ( clone ( ) )
. pipe ( insert . transform ( ( content , file ) = > {
file . path = nodeStandaloneDefinitionsFile ;
return content . replace ( /declare (namespace|module) ts/g , 'declare module "typescript"' ) ;
} ) )
2017-03-01 16:57:34 +01:00
] ) . pipe ( gulp . dest ( "src/services" ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
2016-09-23 01:20:27 +02:00
// cancellationToken.js
const cancellationTokenJs = path . join ( builtLocalDirectory , "cancellationToken.js" ) ;
2017-04-05 07:34:51 +02:00
gulp . task ( cancellationTokenJs , /*help*/ false , [ servicesFile ] , ( ) = > {
2017-04-11 18:37:31 +02:00
const cancellationTokenProject = tsc . createProject ( "src/server/cancellationToken/tsconfig.json" , getCompilerSettings ( { } , /*useBuiltCompiler*/ true ) ) ;
2016-09-23 01:20:27 +02:00
return cancellationTokenProject . src ( )
. pipe ( newer ( cancellationTokenJs ) )
. pipe ( sourcemaps . init ( ) )
2016-10-01 11:16:43 +02:00
. pipe ( cancellationTokenProject ( ) )
2016-09-23 01:20:27 +02:00
. pipe ( prependCopyright ( ) )
. pipe ( sourcemaps . write ( "." ) )
. pipe ( gulp . dest ( builtLocalDirectory ) ) ;
} ) ;
// typingsInstallerFile.js
const typingsInstallerJs = path . join ( builtLocalDirectory , "typingsInstaller.js" ) ;
2017-04-05 07:34:51 +02:00
gulp . task ( typingsInstallerJs , /*help*/ false , [ servicesFile ] , ( ) = > {
2017-04-11 18:37:31 +02:00
const cancellationTokenProject = tsc . createProject ( "src/server/typingsInstaller/tsconfig.json" , getCompilerSettings ( { } , /*useBuiltCompiler*/ true ) ) ;
2016-09-23 01:20:27 +02:00
return cancellationTokenProject . src ( )
. pipe ( newer ( typingsInstallerJs ) )
. pipe ( sourcemaps . init ( ) )
2016-10-01 11:16:43 +02:00
. pipe ( cancellationTokenProject ( ) )
2016-09-23 01:20:27 +02:00
. pipe ( prependCopyright ( ) )
. pipe ( sourcemaps . write ( "." ) )
2017-03-01 16:57:34 +01:00
. pipe ( gulp . dest ( "src/server/typingsInstaller" ) ) ;
2016-09-23 01:20:27 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
const serverFile = path . join ( builtLocalDirectory , "tsserver.js" ) ;
2016-06-14 21:39:13 +02:00
2017-04-05 07:34:51 +02:00
gulp . task ( serverFile , /*help*/ false , [ servicesFile , typingsInstallerJs , cancellationTokenJs ] , ( ) = > {
2017-04-11 18:37:31 +02:00
const serverProject = tsc . createProject ( "src/server/tsconfig.json" , getCompilerSettings ( { } , /*useBuiltCompiler*/ true ) ) ;
2016-06-20 23:39:29 +02:00
return serverProject . src ( )
. pipe ( newer ( serverFile ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
2016-10-01 11:16:43 +02:00
. pipe ( serverProject ( ) )
2016-06-22 03:22:30 +02:00
. pipe ( prependCopyright ( ) )
2016-06-20 23:39:29 +02:00
. pipe ( sourcemaps . write ( "." ) )
2017-03-01 16:57:34 +01:00
. pipe ( gulp . dest ( "src/server" ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
2017-07-28 01:07:50 +02:00
const typesMapJson = path . join ( builtLocalDirectory , "typesMap.json" ) ;
2016-06-10 02:44:59 +02:00
const tsserverLibraryFile = path . join ( builtLocalDirectory , "tsserverlibrary.js" ) ;
const tsserverLibraryDefinitionFile = path . join ( builtLocalDirectory , "tsserverlibrary.d.ts" ) ;
2016-06-14 21:39:13 +02:00
2017-07-28 01:22:10 +02:00
gulp . task ( tsserverLibraryFile , /*help*/ false , [ servicesFile , typesMapJson ] , ( done ) = > {
2017-10-03 20:18:22 +02:00
const serverLibraryProject = tsc . createProject ( "src/server/tsconfig.library.json" , getCompilerSettings ( { removeComments : false } , /*useBuiltCompiler*/ true ) ) ;
2018-04-17 23:19:42 +02:00
/** @type {{ js: NodeJS.ReadableStream, dts: NodeJS.ReadableStream }} */
const { js , dts } = serverLibraryProject . src ( )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
2018-04-17 23:19:42 +02:00
. pipe ( newer ( /** @type {*} */ ( { dest : tsserverLibraryFile , extra : [ "src/compiler/**/*.ts" , "src/services/**/*.ts" ] } ) ) )
2016-10-01 11:16:43 +02:00
. pipe ( serverLibraryProject ( ) ) ;
2017-07-28 01:59:31 +02:00
2016-06-20 23:39:29 +02:00
return merge2 ( [
2016-06-22 03:22:30 +02:00
js . pipe ( prependCopyright ( ) )
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
. pipe ( sourcemaps . write ( "." ) )
2017-03-07 18:52:45 +01:00
. pipe ( gulp . dest ( "src/server" ) ) ,
2017-04-11 18:37:31 +02:00
dts . pipe ( prependCopyright ( /*outputCopyright*/ true ) )
2017-01-01 02:37:51 +01:00
. pipe ( insert . transform ( ( content ) = > {
2017-10-03 02:37:40 +02:00
return content . replace ( constEnumCaptureRegexp , constEnumReplacement ) + "\nexport = ts;\nexport as namespace ts;" ;
2017-01-01 02:37:51 +01:00
} ) )
2017-03-07 18:52:45 +01:00
. pipe ( gulp . dest ( "src/server" ) )
2016-06-20 23:39:29 +02:00
] ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
2017-07-28 01:22:10 +02:00
gulp . task ( typesMapJson , /*help*/ false , [ ] , ( ) = > {
2017-07-28 01:59:31 +02:00
return gulp . src ( "src/server/typesMap.json" )
2017-07-28 01:22:10 +02:00
. pipe ( insert . transform ( ( contents , file ) = > {
JSON . parse ( contents ) ;
return contents ;
} ) )
. pipe ( gulp . dest ( builtLocalDirectory ) ) ;
2017-07-28 01:07:50 +02:00
} ) ;
2017-07-28 01:22:10 +02:00
gulp . task ( "lssl" , "Builds language service server library" , [ tsserverLibraryFile ] ) ;
2017-10-03 02:16:08 +02:00
gulp . task ( "local" , "Builds the full compiler and services" , [ builtLocalCompiler , servicesFile , serverFile , builtGeneratedDiagnosticMessagesJSON , tsserverLibraryFile , "localize" ] ) ;
2016-06-10 02:44:59 +02:00
gulp . task ( "tsc" , "Builds only the compiler" , [ builtLocalCompiler ] ) ;
// Generate Markdown spec
const word2mdJs = path . join ( scriptsDirectory , "word2md.js" ) ;
const word2mdTs = path . join ( scriptsDirectory , "word2md.ts" ) ;
const specWord = path . join ( docDirectory , "TypeScript Language Specification.docx" ) ;
const specMd = path . join ( docDirectory , "spec.md" ) ;
2017-04-05 07:34:51 +02:00
gulp . task ( word2mdJs , /*help*/ false , [ ] , ( ) = > {
2018-04-17 23:19:42 +02:00
/** @type {tsc.Settings} */
const settings = getCompilerSettings ( {
2016-06-14 21:39:13 +02:00
outFile : word2mdJs
} , /*useBuiltCompiler*/ false ) ;
return gulp . src ( word2mdTs )
2016-06-20 23:39:29 +02:00
. pipe ( newer ( word2mdJs ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
. pipe ( tsc ( settings ) )
2016-06-14 22:09:48 +02:00
. pipe ( sourcemaps . write ( "." ) )
. pipe ( gulp . dest ( "." ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
2017-04-05 07:34:51 +02:00
gulp . task ( specMd , /*help*/ false , [ word2mdJs ] , ( done ) = > {
2016-06-10 02:44:59 +02:00
const specWordFullPath = path . resolve ( specWord ) ;
const specMDFullPath = path . resolve ( specMd ) ;
const cmd = "cscript //nologo " + word2mdJs + " \"" + specWordFullPath + "\" " + "\"" + specMDFullPath + "\"" ;
console . log ( cmd ) ;
2017-11-03 23:08:50 +01:00
cp . exec ( cmd , done ) ;
2016-06-10 02:44:59 +02:00
} ) ;
gulp . task ( "generate-spec" , "Generates a Markdown version of the Language Specification" , [ specMd ] ) ;
gulp . task ( "clean" , "Cleans the compiler output, declare files, and tests" , [ ] , ( ) = > {
return del ( [ builtDirectory ] ) ;
} ) ;
2017-04-05 07:34:51 +02:00
gulp . task ( "useDebugMode" , /*help*/ false , [ ] , ( done ) = > { useDebugMode = true ; done ( ) ; } ) ;
gulp . task ( "dontUseDebugMode" , /*help*/ false , [ ] , ( done ) = > { useDebugMode = false ; done ( ) ; } ) ;
2016-06-10 02:44:59 +02:00
2017-04-05 07:34:51 +02:00
gulp . task ( "VerifyLKG" , /*help*/ false , [ ] , ( ) = > {
2016-09-23 01:20:27 +02:00
const expectedFiles = [ builtLocalCompiler , servicesFile , serverFile , nodePackageFile , nodeDefinitionsFile , standaloneDefinitionsFile , tsserverLibraryFile , tsserverLibraryDefinitionFile , typingsInstallerJs , cancellationTokenJs ] . concat ( libraryTargets ) ;
2017-10-03 02:16:08 +02:00
const missingFiles = expectedFiles .
2017-10-19 00:46:09 +02:00
concat ( localizationTargets ) .
2017-10-03 02:16:08 +02:00
filter ( f = > ! fs . existsSync ( f ) ) ;
2016-06-10 02:44:59 +02:00
if ( missingFiles . length > 0 ) {
throw new Error ( "Cannot replace the LKG unless all built targets are present in directory " + builtLocalDirectory +
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
". The following files are missing:\n" + missingFiles . join ( "\n" ) ) ;
2016-06-10 02:44:59 +02:00
}
// Copy all the targets into the LKG directory
2017-11-06 18:23:47 +01:00
return gulp . src ( [ . . . expectedFiles , path . join ( builtLocalDirectory , "**" ) , ` ! ${ path . join ( builtLocalDirectory , "tslint" ) } ` , ` ! ${ path . join ( builtLocalDirectory , "*.*" ) } ` ] ) . pipe ( gulp . dest ( lkgDirectory ) ) ;
2016-06-10 02:44:59 +02:00
} ) ;
2017-04-05 07:34:51 +02:00
gulp . task ( "LKGInternal" , /*help*/ false , [ "lib" , "local" ] ) ;
2016-06-15 02:40:33 +02:00
2016-06-24 00:48:09 +02:00
gulp . task ( "LKG" , "Makes a new LKG out of the built js files" , [ "clean" , "dontUseDebugMode" ] , ( ) = > {
2016-06-15 02:40:33 +02:00
return runSequence ( "LKGInternal" , "VerifyLKG" ) ;
2016-06-10 02:44:59 +02:00
} ) ;
// Task to build the tests infrastructure using the built compiler
const run = path . join ( builtLocalDirectory , "run.js" ) ;
2017-10-03 02:37:40 +02:00
gulp . task ( run , /*help*/ false , [ servicesFile , tsserverLibraryFile ] , ( ) = > {
2017-04-11 18:37:31 +02:00
const testProject = tsc . createProject ( "src/harness/tsconfig.json" , getCompilerSettings ( { } , /*useBuiltCompiler*/ true ) ) ;
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
return testProject . src ( )
2016-06-20 23:39:29 +02:00
. pipe ( newer ( run ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
2016-10-01 11:16:43 +02:00
. pipe ( testProject ( ) )
2017-07-07 00:56:59 +02:00
. pipe ( sourcemaps . write ( "." , { includeContent : false , sourceRoot : "." } ) )
2017-03-01 16:57:34 +01:00
. pipe ( gulp . dest ( "src/harness" ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
const internalTests = "internal/" ;
const localBaseline = "tests/baselines/local/" ;
const refBaseline = "tests/baselines/reference/" ;
const localRwcBaseline = path . join ( internalTests , "baselines/rwc/local" ) ;
const refRwcBaseline = path . join ( internalTests , "baselines/rwc/reference" ) ;
const localTest262Baseline = path . join ( internalTests , "baselines/test262/local" ) ;
2016-06-14 22:09:48 +02:00
gulp . task ( "tests" , "Builds the test infrastructure using the built compiler" , [ run ] ) ;
2016-06-10 02:44:59 +02:00
gulp . task ( "tests-debug" , "Builds the test sources and automation in debug mode" , ( ) = > {
return runSequence ( "useDebugMode" , "tests" ) ;
} ) ;
function deleteTemporaryProjectOutput() {
return del ( path . join ( localBaseline , "projectOutput/" ) ) ;
}
2018-04-17 23:19:42 +02:00
/** @type {string} */
let savedNodeEnv ;
2016-06-10 02:44:59 +02:00
function setNodeEnvToDevelopment() {
savedNodeEnv = process . env . NODE_ENV ;
process . env . NODE_ENV = "development" ;
}
function restoreSavedNodeEnv() {
process . env . NODE_ENV = savedNodeEnv ;
}
2018-04-17 23:19:42 +02:00
/ * *
2018-05-03 00:03:42 +02:00
* @param { string } defaultReporter
* @param { boolean } runInParallel
* @param { ( e? : any ) = > void } done
2018-04-17 23:19:42 +02:00
* /
function runConsoleTests ( defaultReporter , runInParallel , done ) {
2017-10-19 17:15:48 +02:00
const lintFlag = cmdLineOptions . lint ;
2016-06-10 02:44:59 +02:00
cleanTestDirs ( ( err ) = > {
if ( err ) { console . error ( err ) ; failWithStatus ( err , 1 ) ; }
2017-10-19 17:15:48 +02:00
let testTimeout = cmdLineOptions . timeout ;
const debug = cmdLineOptions . debug ;
const inspect = cmdLineOptions . inspect ;
const tests = cmdLineOptions . tests ;
2017-11-06 20:24:17 +01:00
const runners = cmdLineOptions . runners ;
2017-10-19 17:15:48 +02:00
const light = cmdLineOptions . light ;
const stackTraceLimit = cmdLineOptions . stackTraceLimit ;
2016-06-10 02:44:59 +02:00
const testConfigFile = "test.config" ;
if ( fs . existsSync ( testConfigFile ) ) {
fs . unlinkSync ( testConfigFile ) ;
}
let workerCount , taskConfigsFolder ;
if ( runInParallel ) {
// generate name to store task configuration files
const prefix = os . tmpdir ( ) + "/ts-tests" ;
let i = 1 ;
do {
taskConfigsFolder = prefix + i ;
i ++ ;
} while ( fs . existsSync ( taskConfigsFolder ) ) ;
fs . mkdirSync ( taskConfigsFolder ) ;
2017-10-19 17:15:48 +02:00
workerCount = cmdLineOptions . workers ;
2016-06-10 02:44:59 +02:00
}
if ( tests && tests . toLocaleLowerCase ( ) === "rwc" ) {
2016-07-01 18:59:30 +02:00
testTimeout = 400000 ;
2016-06-10 02:44:59 +02:00
}
2018-01-08 21:28:04 +01:00
if ( tests || runners || light || testTimeout || taskConfigsFolder ) {
writeTestConfigFile ( tests , runners , light , taskConfigsFolder , workerCount , stackTraceLimit , testTimeout ) ;
}
2017-10-19 17:15:48 +02:00
const colors = cmdLineOptions . colors ;
const reporter = cmdLineOptions . reporter || defaultReporter ;
2016-06-10 02:44:59 +02:00
// timeout normally isn"t necessary but Travis-CI has been timing out on compiler baselines occasionally
// default timeout is 2sec which really should be enough, but maybe we just need a small amount longer
if ( ! runInParallel ) {
const args = [ ] ;
args . push ( "-R" , reporter ) ;
if ( tests ) {
args . push ( "-g" , ` " ${ tests } " ` ) ;
}
if ( colors ) {
args . push ( "--colors" ) ;
}
else {
args . push ( "--no-colors" ) ;
}
2017-06-08 21:24:20 +02:00
if ( inspect ) {
args . unshift ( "--inspect-brk" ) ;
}
else if ( debug ) {
args . unshift ( "--debug-brk" ) ;
}
else {
args . push ( "-t" , testTimeout ) ;
}
2016-06-10 02:44:59 +02:00
args . push ( run ) ;
setNodeEnvToDevelopment ( ) ;
2017-11-03 23:08:50 +01:00
exec ( mocha , args , lintThenFinish , finish ) ;
2016-06-10 02:44:59 +02:00
}
else {
// run task to load all tests and partition them between workers
setNodeEnvToDevelopment ( ) ;
2017-11-03 23:08:50 +01:00
exec ( host , [ run ] , lintThenFinish , finish ) ;
2016-06-10 02:44:59 +02:00
}
} ) ;
2018-04-17 23:19:42 +02:00
/ * *
2018-05-03 00:03:42 +02:00
* @param { any = } err
* @param { number = } status
2018-04-17 23:19:42 +02:00
* /
function failWithStatus ( err , status ) {
2017-09-21 17:36:50 +02:00
if ( err || status ) {
process . exit ( typeof status === "number" ? status : 2 ) ;
2016-06-10 02:44:59 +02:00
}
2017-09-21 17:36:50 +02:00
done ( ) ;
2016-06-10 02:44:59 +02:00
}
function lintThenFinish() {
if ( lintFlag ) {
runSequence ( "lint" , finish ) ;
}
else {
finish ( ) ;
}
}
2018-04-17 23:19:42 +02:00
/ * *
2018-05-03 00:03:42 +02:00
* @param { any = } error
* @param { number = } errorStatus
2018-04-17 23:19:42 +02:00
* /
function finish ( error , errorStatus ) {
2016-06-10 02:44:59 +02:00
restoreSavedNodeEnv ( ) ;
2017-09-15 00:42:06 +02:00
deleteTestConfig ( ) . then ( deleteTemporaryProjectOutput ) . then ( ( ) = > {
2016-06-10 02:44:59 +02:00
if ( error !== undefined || errorStatus !== undefined ) {
failWithStatus ( error , errorStatus ) ;
}
else {
done ( ) ;
}
} ) ;
}
2017-09-15 00:42:06 +02:00
function deleteTestConfig() {
return del ( "test.config" ) ;
}
2016-06-10 02:44:59 +02:00
}
gulp . task ( "runtests-parallel" , "Runs all the tests in parallel using the built run.js file. Optional arguments are: --t[ests]=category1|category2|... --d[ebug]=true." , [ "build-rules" , "tests" ] , ( done ) = > {
runConsoleTests ( "min" , /*runInParallel*/ true , done ) ;
} ) ;
gulp . task ( "runtests" ,
"Runs the tests using the built run.js file. Optional arguments are: --t[ests]=regex --r[eporter]=[list|spec|json|<more>] --d[ebug]=true --color[s]=false --lint=true." ,
[ "build-rules" , "tests" ] ,
( done ) = > {
runConsoleTests ( "mocha-fivemat-progress-reporter" , /*runInParallel*/ false , done ) ;
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
const nodeServerOutFile = "tests/webTestServer.js" ;
const nodeServerInFile = "tests/webTestServer.ts" ;
2017-04-05 07:34:51 +02:00
gulp . task ( nodeServerOutFile , /*help*/ false , [ servicesFile ] , ( ) = > {
2018-04-17 23:19:42 +02:00
/** @type {tsc.Settings} */
2018-04-24 06:52:16 +02:00
const settings = getCompilerSettings ( { module : "commonjs" , target : "es2015" } , /*useBuiltCompiler*/ true ) ;
2016-06-14 21:39:13 +02:00
return gulp . src ( nodeServerInFile )
2016-06-20 23:39:29 +02:00
. pipe ( newer ( nodeServerOutFile ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
. pipe ( tsc ( settings ) )
2016-06-14 23:41:25 +02:00
. pipe ( sourcemaps . write ( "." ) )
2016-06-14 21:39:13 +02:00
. pipe ( gulp . dest ( path . dirname ( nodeServerOutFile ) ) ) ;
} ) ;
2016-06-10 02:44:59 +02:00
2018-04-17 23:19:42 +02:00
const convertMap = require ( "convert-source-map" ) ;
const sorcery = require ( "sorcery" ) ;
const Vinyl = require ( "vinyl" ) ;
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
2017-08-01 20:14:39 +02:00
const bundlePath = path . resolve ( "built/local/bundle.js" ) ;
gulp . task ( "browserify" , "Runs browserify on run.js to produce a file suitable for running tests in the browser" , [ servicesFile ] , ( done ) = > {
const testProject = tsc . createProject ( "src/harness/tsconfig.json" , getCompilerSettings ( { outFile : bundlePath , inlineSourceMap : true } , /*useBuiltCompiler*/ true ) ) ;
2018-04-17 23:19:42 +02:00
/** @type {*} */
let originalMap ;
/** @type {string} */
let prebundledContent ;
2017-08-01 20:14:39 +02:00
browserify ( testProject . src ( )
. pipe ( newer ( bundlePath ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
2016-10-04 18:08:07 +02:00
. pipe ( testProject ( ) )
2016-06-14 23:41:25 +02:00
. pipe ( through2 . obj ( ( file , enc , next ) = > {
2017-08-01 20:14:39 +02:00
if ( originalMap ) {
throw new Error ( "Should only recieve one file!" ) ;
}
console . log ( ` Saving sourcemaps for ${ file . path } ` ) ;
originalMap = file . sourceMap ;
prebundledContent = file . contents . toString ( ) ;
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
// Make paths absolute to help sorcery deal with all the terrible paths being thrown around
2017-03-20 17:07:04 +01:00
originalMap . sources = originalMap . sources . map ( s = > path . resolve ( path . join ( "src/harness" , s ) ) ) ;
2017-08-01 20:14:39 +02:00
// browserify names input files this when they are streamed in, so this is what it puts in the sourcemap
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
originalMap . file = "built/local/_stream_0.js" ;
2017-08-01 20:14:39 +02:00
next ( /*err*/ undefined , file . contents ) ;
2016-06-14 21:39:13 +02:00
} ) )
2017-08-01 20:14:39 +02:00
. on ( "error" , err = > {
return done ( err ) ;
} ) , { debug : true , basedir : __dirname } ) // Attach error handler to inner stream
. bundle ( ( err , contents ) = > {
if ( err ) {
if ( err . message . match ( /Cannot find module '.*_stream_0.js'/ ) ) {
return done ( ) ; // Browserify errors when we pass in no files when `newer` filters the input, we should count that as a success, though
}
return done ( err ) ;
}
const stringContent = contents . toString ( ) ;
const file = new Vinyl ( { contents , path : bundlePath } ) ;
console . log ( ` Fixing sourcemaps for ${ file . path } ` ) ;
// assumes contents is a Buffer, since that's what browserify yields
2017-08-30 19:02:30 +02:00
const maps = convertMap . fromSource ( stringContent ) . toObject ( ) ;
2017-08-01 20:14:39 +02:00
delete maps . sourceRoot ;
maps . sources = maps . sources . map ( s = > path . resolve ( s === "_stream_0.js" ? "built/local/_stream_0.js" : s ) ) ;
// Strip browserify's inline comments away (could probably just let sorcery do this, but then we couldn't fix the paths)
file . contents = new Buffer ( convertMap . removeComments ( stringContent ) ) ;
const chain = sorcery . loadSync ( bundlePath , {
content : {
"built/local/_stream_0.js" : prebundledContent ,
[ bundlePath ] : stringContent
} ,
sourcemaps : {
"built/local/_stream_0.js" : originalMap ,
[ bundlePath ] : maps ,
"node_modules/source-map-support/source-map-support.js" : undefined ,
}
} ) ;
const finalMap = chain . apply ( ) ;
file . sourceMap = finalMap ;
const stream = through2 . obj ( ( file , enc , callback ) = > {
return callback ( /*err*/ undefined , file ) ;
} ) ;
stream . pipe ( sourcemaps . write ( "." , { includeContent : false } ) )
. pipe ( gulp . dest ( "." ) )
. on ( "end" , done )
. on ( "error" , done ) ;
stream . write ( file ) ;
stream . end ( ) ;
} ) ;
2016-06-10 02:44:59 +02:00
} ) ;
2018-04-17 23:19:42 +02:00
/ * *
2018-05-03 00:03:42 +02:00
* @param { ( e? : any ) = > void } done
2018-04-17 23:19:42 +02:00
* /
function cleanTestDirs ( done ) {
2016-06-10 02:44:59 +02:00
// Clean the local baselines & Rwc baselines directories
del ( [
localBaseline ,
localRwcBaseline ,
] ) . then ( ( ) = > {
mkdirP ( localRwcBaseline , ( err ) = > {
if ( err ) done ( err ) ;
mkdirP ( localTest262Baseline , ( ) = > {
if ( err ) done ( err ) ;
mkdirP ( localBaseline , ( err ) = > done ( err ) ) ;
} ) ;
} ) ;
} ) ;
}
2018-04-17 23:19:42 +02:00
/ * *
* used to pass data from jake command line directly to run . js
2018-05-03 00:03:42 +02:00
* @param { string } tests
* @param { string } runners
* @param { boolean } light
* @param { string = } taskConfigsFolder
* @param { number = } workerCount
* @param { string = } stackTraceLimit
* @param { number = } timeout
2018-04-17 23:19:42 +02:00
* /
function writeTestConfigFile ( tests , runners , light , taskConfigsFolder , workerCount , stackTraceLimit , timeout ) {
2018-01-08 21:28:04 +01:00
const testConfigContents = JSON . stringify ( {
test : tests ? [ tests ] : undefined ,
runner : runners ? runners . split ( "," ) : undefined ,
light ,
workerCount ,
stackTraceLimit ,
taskConfigsFolder ,
noColor : ! cmdLineOptions . colors ,
timeout ,
} ) ;
2016-06-10 02:44:59 +02:00
console . log ( "Running tests with config: " + testConfigContents ) ;
fs . writeFileSync ( "test.config" , testConfigContents ) ;
}
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
gulp . task ( "runtests-browser" , "Runs the tests using the built run.js file like 'gulp runtests'. Syntax is gulp runtests-browser. Additional optional parameters --tests=[regex], --browser=[chrome|IE]" , [ "browserify" , nodeServerOutFile ] , ( done ) = > {
2016-06-10 02:44:59 +02:00
cleanTestDirs ( ( err ) = > {
if ( err ) { console . error ( err ) ; done ( err ) ; process . exit ( 1 ) ; }
host = "node" ;
2017-10-19 17:15:48 +02:00
const tests = cmdLineOptions . tests ;
2017-11-06 20:24:17 +01:00
const runners = cmdLineOptions . runners ;
2017-10-19 17:15:48 +02:00
const light = cmdLineOptions . light ;
2016-06-10 02:44:59 +02:00
const testConfigFile = "test.config" ;
if ( fs . existsSync ( testConfigFile ) ) {
fs . unlinkSync ( testConfigFile ) ;
}
2017-11-06 20:24:17 +01:00
if ( tests || runners || light ) {
writeTestConfigFile ( tests , runners , light ) ;
2016-06-10 02:44:59 +02:00
}
const args = [ nodeServerOutFile ] ;
2017-10-19 17:15:48 +02:00
if ( cmdLineOptions . browser ) {
args . push ( cmdLineOptions . browser ) ;
2016-06-10 02:44:59 +02:00
}
if ( tests ) {
args . push ( JSON . stringify ( tests ) ) ;
}
exec ( host , args , done , done ) ;
} ) ;
} ) ;
2016-06-14 23:56:37 +02:00
gulp . task ( "generate-code-coverage" , "Generates code coverage data via istanbul" , [ "tests" ] , ( done ) = > {
2017-10-19 17:15:48 +02:00
const testTimeout = cmdLineOptions . timeout ;
2016-06-10 02:44:59 +02:00
exec ( "istanbul" , [ "cover" , "node_modules/mocha/bin/_mocha" , "--" , "-R" , "min" , "-t" , testTimeout . toString ( ) , run ] , done , done ) ;
} ) ;
function getDiffTool() {
2017-10-19 17:15:48 +02:00
const program = process . env . DIFF ;
2016-06-10 02:44:59 +02:00
if ( ! program ) {
2016-06-14 23:56:37 +02:00
console . error ( "Add the 'DIFF' environment variable to the path of the program you want to use." ) ;
2016-06-10 02:44:59 +02:00
process . exit ( 1 ) ;
}
return program ;
}
2016-06-14 23:56:37 +02:00
gulp . task ( "diff" , "Diffs the compiler baselines using the diff tool specified by the 'DIFF' environment variable" , ( done ) = > {
2016-06-10 02:44:59 +02:00
exec ( getDiffTool ( ) , [ refBaseline , localBaseline ] , done , done ) ;
} ) ;
2016-06-14 23:56:37 +02:00
gulp . task ( "diff-rwc" , "Diffs the RWC baselines using the diff tool specified by the 'DIFF' environment variable" , ( done ) = > {
2016-06-10 02:44:59 +02:00
exec ( getDiffTool ( ) , [ refRwcBaseline , localRwcBaseline ] , done , done ) ;
} ) ;
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
gulp . task ( "baseline-accept" , "Makes the most recent test results the new baseline, overwriting the old baseline" , ( ) = > {
return baselineAccept ( "" ) ;
2016-06-10 02:44:59 +02:00
} ) ;
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
function baselineAccept ( subfolder = "" ) {
return merge2 ( baselineCopy ( subfolder ) , baselineDelete ( subfolder ) ) ;
}
function baselineCopy ( subfolder = "" ) {
return gulp . src ( [ ` tests/baselines/local/ ${ subfolder } /** ` , ` !tests/baselines/local/ ${ subfolder } /**/*.delete ` ] )
. pipe ( gulp . dest ( refBaseline ) ) ;
}
function baselineDelete ( subfolder = "" ) {
return gulp . src ( [ "tests/baselines/local/**/*.delete" ] )
. pipe ( insert . transform ( ( content , fileObj ) = > {
const target = path . join ( refBaseline , fileObj . relative . substr ( 0 , fileObj . relative . length - ".delete" . length ) ) ;
del . sync ( target ) ;
del . sync ( fileObj . path ) ;
return "" ;
} ) ) ;
}
2016-06-10 02:44:59 +02:00
gulp . task ( "baseline-accept-rwc" , "Makes the most recent rwc test results the new baseline, overwriting the old baseline" , ( ) = > {
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
return baselineAccept ( "rwc" ) ;
2016-06-10 02:44:59 +02:00
} ) ;
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
2016-06-10 02:44:59 +02:00
gulp . task ( "baseline-accept-test262" , "Makes the most recent test262 test results the new baseline, overwriting the old baseline" , ( ) = > {
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
return baselineAccept ( "test262" ) ;
2016-06-10 02:44:59 +02:00
} ) ;
// Webhost
const webhostPath = "tests/webhost/webtsc.ts" ;
const webhostJsPath = "tests/webhost/webtsc.js" ;
2017-04-05 07:34:51 +02:00
gulp . task ( webhostJsPath , /*help*/ false , [ servicesFile ] , ( ) = > {
2018-04-17 23:19:42 +02:00
const settings = getCompilerSettings ( {
2016-06-14 21:39:13 +02:00
outFile : webhostJsPath
} , /*useBuiltCompiler*/ true ) ;
return gulp . src ( webhostPath )
2016-06-20 23:39:29 +02:00
. pipe ( newer ( webhostJsPath ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
. pipe ( tsc ( settings ) )
2016-06-14 22:09:48 +02:00
. pipe ( sourcemaps . write ( "." ) )
2016-06-14 21:39:13 +02:00
. pipe ( gulp . dest ( path . dirname ( webhostJsPath ) ) ) ;
} ) ;
2016-06-10 02:44:59 +02:00
gulp . task ( "webhost" , "Builds the tsc web host" , [ webhostJsPath ] , ( ) = > {
return gulp . src ( path . join ( builtLocalDirectory , "lib.d.ts" ) ) . pipe ( gulp . dest ( "tests/webhost/" ) ) ;
} ) ;
// Perf compiler
const perftscPath = "tests/perftsc.ts" ;
const perftscJsPath = "built/local/perftsc.js" ;
2017-04-05 07:34:51 +02:00
gulp . task ( perftscJsPath , /*help*/ false , [ servicesFile ] , ( ) = > {
2018-04-17 23:19:42 +02:00
const settings = getCompilerSettings ( {
2016-06-14 21:39:13 +02:00
outFile : perftscJsPath
} , /*useBuiltCompiler*/ true ) ;
return gulp . src ( perftscPath )
2016-06-20 23:39:29 +02:00
. pipe ( newer ( perftscJsPath ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
. pipe ( tsc ( settings ) )
2016-06-14 22:09:48 +02:00
. pipe ( sourcemaps . write ( "." ) )
. pipe ( gulp . dest ( "." ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
gulp . task ( "perftsc" , "Builds augmented version of the compiler for perf tests" , [ perftscJsPath ] ) ;
// Instrumented compiler
const loggedIOpath = path . join ( harnessDirectory , "loggedIO.ts" ) ;
const loggedIOJsPath = path . join ( builtLocalDirectory , "loggedIO.js" ) ;
2017-04-05 07:34:51 +02:00
gulp . task ( loggedIOJsPath , /*help*/ false , [ ] , ( done ) = > {
2016-06-10 02:44:59 +02:00
const temp = path . join ( builtLocalDirectory , "temp" ) ;
mkdirP ( temp , ( err ) = > {
2017-04-05 07:34:51 +02:00
if ( err ) { console . error ( err ) ; done ( err ) ; process . exit ( 1 ) ; }
2017-11-06 18:23:47 +01:00
exec ( host , [ lkgCompiler , "--types" , "--target es5" , "--lib es5" , "--outdir" , temp , loggedIOpath ] , ( ) = > {
2016-06-10 02:44:59 +02:00
fs . renameSync ( path . join ( temp , "/harness/loggedIO.js" ) , loggedIOJsPath ) ;
del ( temp ) . then ( ( ) = > done ( ) , done ) ;
} , done ) ;
} ) ;
} ) ;
const instrumenterPath = path . join ( harnessDirectory , "instrumenter.ts" ) ;
const instrumenterJsPath = path . join ( builtLocalDirectory , "instrumenter.js" ) ;
2017-04-05 07:34:51 +02:00
gulp . task ( instrumenterJsPath , /*help*/ false , [ servicesFile ] , ( ) = > {
2018-04-17 23:19:42 +02:00
const settings = getCompilerSettings ( {
2017-08-23 00:39:10 +02:00
module : "commonjs" ,
2017-05-16 20:30:30 +02:00
target : "es5" ,
lib : [
"es6" ,
"dom" ,
"scripthost"
]
2016-06-14 21:39:13 +02:00
} , /*useBuiltCompiler*/ true ) ;
return gulp . src ( instrumenterPath )
2016-06-20 23:39:29 +02:00
. pipe ( newer ( instrumenterJsPath ) )
2016-06-14 21:39:13 +02:00
. pipe ( sourcemaps . init ( ) )
. pipe ( tsc ( settings ) )
2017-08-23 00:39:10 +02:00
. pipe ( sourcemaps . write ( builtLocalDirectory ) )
. pipe ( gulp . dest ( builtLocalDirectory ) ) ;
2016-06-14 21:39:13 +02:00
} ) ;
2016-06-10 02:44:59 +02:00
2017-09-27 00:55:21 +02:00
gulp . task ( "tsc-instrumented" , "Builds an instrumented tsc.js - run with --test=[testname]" , [ "local" , loggedIOJsPath , instrumenterJsPath , servicesFile ] , ( done ) = > {
2017-10-19 17:15:48 +02:00
const test = cmdLineOptions . tests || "iocapture" ;
2017-09-27 00:55:21 +02:00
exec ( host , [ instrumenterJsPath , "record" , test , builtLocalCompiler ] , done , done ) ;
2016-06-10 02:44:59 +02:00
} ) ;
gulp . task ( "update-sublime" , "Updates the sublime plugin's tsserver" , [ "local" , serverFile ] , ( ) = > {
return gulp . src ( [ serverFile , serverFile + ".map" ] ) . pipe ( gulp . dest ( "../TypeScript-Sublime-Plugin/tsserver/" ) ) ;
} ) ;
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
gulp . task ( "build-rules" , "Compiles tslint rules to js" , ( ) = > {
2018-04-17 23:19:42 +02:00
const settings = getCompilerSettings ( { module : "commonjs" , lib : [ "es6" ] } , /*useBuiltCompiler*/ false ) ;
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
const dest = path . join ( builtLocalDirectory , "tslint" ) ;
return gulp . src ( "scripts/tslint/**/*.ts" )
. pipe ( newer ( {
dest ,
ext : ".js"
} ) )
. pipe ( sourcemaps . init ( ) )
. pipe ( tsc ( settings ) )
. pipe ( sourcemaps . write ( "." ) )
. pipe ( gulp . dest ( dest ) ) ;
} ) ;
2016-06-10 02:44:59 +02:00
gulp . task ( "lint" , "Runs tslint on the compiler sources. Optional arguments are: --f[iles]=regex" , [ "build-rules" ] , ( ) = > {
[Release-2.0] Merge master into Release-2.0 (#10347)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes #9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix #10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes #10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes #10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
2016-08-18 23:49:09 +02:00
if ( fold . isTravis ( ) ) console . log ( fold . start ( "lint" ) ) ;
2018-02-17 03:38:00 +01:00
for ( const project of [ "scripts/tslint/tsconfig.json" , "src/tsconfig-base.json" ] ) {
2018-05-23 02:01:45 +02:00
const cmd = ` node node_modules/tslint/bin/tslint --project ${ project } --formatters-dir ./built/local/tslint/formatters --format autolinkableStylish ${ cmdLineOptions . fix ? " --fix" : "" } ` ;
2018-02-17 03:38:00 +01:00
console . log ( "Linting: " + cmd ) ;
child_process . execSync ( cmd , { stdio : [ 0 , 1 , 2 ] } ) ;
}
2017-09-21 17:36:50 +02:00
if ( fold . isTravis ( ) ) console . log ( fold . end ( "lint" ) ) ;
2016-06-10 02:44:59 +02:00
} ) ;
gulp . task ( "default" , "Runs 'local'" , [ "local" ] ) ;
2016-06-21 00:35:32 +02:00
gulp . task ( "watch" , "Watches the src/ directory for changes and executes runtests-parallel." , [ ] , ( ) = > {
gulp . watch ( "src/**/*.*" , [ "runtests-parallel" ] ) ;
} ) ;