From 124510e4091e8d1ce34dcd8f7e94516d88c38f54 Mon Sep 17 00:00:00 2001 From: Andy Date: Wed, 26 Jul 2017 07:09:22 -0700 Subject: [PATCH] Add comment clarifying isNotNeededPackage (#17321) --- src/compiler/moduleNameResolver.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/moduleNameResolver.ts b/src/compiler/moduleNameResolver.ts index a8345dd651..513c741ba0 100644 --- a/src/compiler/moduleNameResolver.ts +++ b/src/compiler/moduleNameResolver.ts @@ -256,6 +256,8 @@ namespace ts { for (const typeDirectivePath of host.getDirectories(root)) { const normalized = normalizePath(typeDirectivePath); const packageJsonPath = pathToPackageJson(combinePaths(root, normalized)); + // `types-publisher` sometimes creates packages with `"typings": null` for packages that don't provide their own types. + // See `createNotNeededPackageJSON` in the types-publisher` repo. // tslint:disable-next-line:no-null-keyword const isNotNeededPackage = host.fileExists(packageJsonPath) && readJson(packageJsonPath, host).typings === null; if (!isNotNeededPackage) {