maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #9159 from Microsoft/code_completion_escaping

Browse source 
Code completion escaping
This commit is contained in:
Andy 2016-06-14 10:21:40 -07:00 committed by GitHub
parent c33df015eb 6b05ecab5b
commit 13a0f5905d
3 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/harness/fourslash.ts
View file

@ -717,6 +717,8 @@ namespace FourSlash {
public verifyCompletionEntryDetails(entryName: string, expectedText: string, expectedDocumentation?: string, kind?: string) {
const details = this.getCompletionEntryDetails(entryName);
assert(details, "no completion entry available");
assert.equal(ts.displayPartsToString(details.displayParts), expectedText, this.assertionMessageAtLastKnownMarker("completion entry details text"));
if (expectedDocumentation !== undefined) {

2
src/services/services.ts
View file

@ -4141,7 +4141,7 @@ namespace ts {
if (!uniqueNames[name]) {
uniqueNames[name] = name;
const displayName = getCompletionEntryDisplayName(name, target, /*performCharacterChecks*/ true);
const displayName = getCompletionEntryDisplayName(unescapeIdentifier(name), target, /*performCharacterChecks*/ true);
if (displayName) {
const entry = {
name: displayName,

9
tests/cases/fourslash/codeCompletionEscaping.ts Normal file
View file

@ -0,0 +1,9 @@
/// <reference path="fourslash.ts" />
// @Filename: a.js
// @allowJs: true
////___foo; __foo;/**/
goTo.marker();
verify.completionListContains("__foo", undefined, undefined, "warning");
verify.completionListContains("___foo", undefined, undefined, "warning");