Accept baselines

This commit is contained in:
Anders Hejlsberg 2016-11-14 17:06:57 -08:00
parent 6d28595e5a
commit 2bcb6e9812
2 changed files with 82 additions and 0 deletions

View file

@ -0,0 +1,36 @@
tests/cases/compiler/typePredicateStructuralMatch.ts(17,12): error TS2322: Type 'Result[] | { data: Result[]; }' is not assignable to type 'Result[]'.
Type '{ data: Result[]; }' is not assignable to type 'Result[]'.
Property 'length' is missing in type '{ data: Result[]; }'.
==== tests/cases/compiler/typePredicateStructuralMatch.ts (1 errors) ====
// Repro from #12235
getResults1([]);
getResults1({data: []});
getResults2([]);
getResults2({data: []});
type Result = { value: string };
type Results = Result[];
function isResponseInData<T>(value: T | { data: T}): value is { data: T } {
return value.hasOwnProperty('data');
}
function getResults1(value: Results | { data: Results }): Results {
return isResponseInData(value) ? value.data : value;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
!!! error TS2322: Type 'Result[] | { data: Result[]; }' is not assignable to type 'Result[]'.
!!! error TS2322: Type '{ data: Result[]; }' is not assignable to type 'Result[]'.
!!! error TS2322: Property 'length' is missing in type '{ data: Result[]; }'.
}
function isPlainResponse<T>(value: T | { data: T}): value is T {
return !value.hasOwnProperty('data');
}
function getResults2(value: Results | { data: Results }): Results {
return isPlainResponse(value) ? value : value.data;
}

View file

@ -0,0 +1,46 @@
//// [typePredicateStructuralMatch.ts]
// Repro from #12235
getResults1([]);
getResults1({data: []});
getResults2([]);
getResults2({data: []});
type Result = { value: string };
type Results = Result[];
function isResponseInData<T>(value: T | { data: T}): value is { data: T } {
return value.hasOwnProperty('data');
}
function getResults1(value: Results | { data: Results }): Results {
return isResponseInData(value) ? value.data : value;
}
function isPlainResponse<T>(value: T | { data: T}): value is T {
return !value.hasOwnProperty('data');
}
function getResults2(value: Results | { data: Results }): Results {
return isPlainResponse(value) ? value : value.data;
}
//// [typePredicateStructuralMatch.js]
// Repro from #12235
getResults1([]);
getResults1({ data: [] });
getResults2([]);
getResults2({ data: [] });
function isResponseInData(value) {
return value.hasOwnProperty('data');
}
function getResults1(value) {
return isResponseInData(value) ? value.data : value;
}
function isPlainResponse(value) {
return !value.hasOwnProperty('data');
}
function getResults2(value) {
return isPlainResponse(value) ? value : value.data;
}