Merge pull request #21042 from amcasey/cannotFindModule

Make fixCannotFindModule return an empty array if there is no code action
This commit is contained in:
Andrew Casey 2018-01-05 17:51:49 -08:00 committed by GitHub
commit 4437476856
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -4,9 +4,10 @@ namespace ts.codefix {
const errorCodes = [Diagnostics.Could_not_find_a_declaration_file_for_module_0_1_implicitly_has_an_any_type.code]; const errorCodes = [Diagnostics.Could_not_find_a_declaration_file_for_module_0_1_implicitly_has_an_any_type.code];
registerCodeFix({ registerCodeFix({
errorCodes, errorCodes,
getCodeActions: context => [ getCodeActions: context => {
{ fixId, ...tryGetCodeActionForInstallPackageTypes(context.host, context.sourceFile.fileName, getModuleName(context.sourceFile, context.span.start)) } const codeAction = tryGetCodeActionForInstallPackageTypes(context.host, context.sourceFile.fileName, getModuleName(context.sourceFile, context.span.start));
], return codeAction && [{ fixId, ...codeAction }];
},
fixIds: [fixId], fixIds: [fixId],
getAllCodeActions: context => codeFixAll(context, errorCodes, (_, diag, commands) => { getAllCodeActions: context => codeFixAll(context, errorCodes, (_, diag, commands) => {
const pkg = getTypesPackageNameToInstall(context.host, getModuleName(diag.file, diag.start)); const pkg = getTypesPackageNameToInstall(context.host, getModuleName(diag.file, diag.start));