maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Actually visit expression node on empty destructuring assignment (#23744)

Browse source
This commit is contained in:
Wesley Wigham 2018-04-27 15:55:53 -07:00 committed by GitHub
parent 6d3b6e21da
commit 47385b29e0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 50 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/compiler/transformers/destructuring.ts
View file

@ -46,7 +46,7 @@ namespace ts {
value = node.right;
}
else {
return value;
return visitNode(value, visitor, isExpression);
}
}
}

7
tests/baselines/reference/emptyArrayDestructuringExpressionVisitedByTransformer.js Normal file
View file

@ -0,0 +1,7 @@
//// [emptyArrayDestructuringExpressionVisitedByTransformer.ts]
var a = [] = [1].map(_ => _);
var b = [1].map(_ => _);
//// [emptyArrayDestructuringExpressionVisitedByTransformer.js]
var a = [1].map(function (_) { return _; });
var b = [1].map(function (_) { return _; });

15
tests/baselines/reference/emptyArrayDestructuringExpressionVisitedByTransformer.symbols Normal file
View file

@ -0,0 +1,15 @@
=== tests/cases/compiler/emptyArrayDestructuringExpressionVisitedByTransformer.ts ===
var a = [] = [1].map(_ => _);
>a : Symbol(a, Decl(emptyArrayDestructuringExpressionVisitedByTransformer.ts, 0, 3))
>[1].map : Symbol(Array.map, Decl(lib.d.ts, --, --))
>map : Symbol(Array.map, Decl(lib.d.ts, --, --))
>_ : Symbol(_, Decl(emptyArrayDestructuringExpressionVisitedByTransformer.ts, 0, 21))
>_ : Symbol(_, Decl(emptyArrayDestructuringExpressionVisitedByTransformer.ts, 0, 21))
var b = [1].map(_ => _);
>b : Symbol(b, Decl(emptyArrayDestructuringExpressionVisitedByTransformer.ts, 1, 3))
>[1].map : Symbol(Array.map, Decl(lib.d.ts, --, --))
>map : Symbol(Array.map, Decl(lib.d.ts, --, --))
>_ : Symbol(_, Decl(emptyArrayDestructuringExpressionVisitedByTransformer.ts, 1, 16))
>_ : Symbol(_, Decl(emptyArrayDestructuringExpressionVisitedByTransformer.ts, 1, 16))

25
tests/baselines/reference/emptyArrayDestructuringExpressionVisitedByTransformer.types Normal file
View file

@ -0,0 +1,25 @@
=== tests/cases/compiler/emptyArrayDestructuringExpressionVisitedByTransformer.ts ===
var a = [] = [1].map(_ => _);
>a : number[]
>[] = [1].map(_ => _) : number[]
>[] : undefined[]
>[1].map(_ => _) : number[]
>[1].map : <U>(callbackfn: (value: number, index: number, array: number[]) => U, thisArg?: any) => U[]
>[1] : number[]
>1 : 1
>map : <U>(callbackfn: (value: number, index: number, array: number[]) => U, thisArg?: any) => U[]
>_ => _ : (_: number) => number
>_ : number
>_ : number
var b = [1].map(_ => _);
>b : number[]
>[1].map(_ => _) : number[]
>[1].map : <U>(callbackfn: (value: number, index: number, array: number[]) => U, thisArg?: any) => U[]
>[1] : number[]
>1 : 1
>map : <U>(callbackfn: (value: number, index: number, array: number[]) => U, thisArg?: any) => U[]
>_ => _ : (_: number) => number
>_ : number
>_ : number

2
tests/cases/compiler/emptyArrayDestructuringExpressionVisitedByTransformer.ts Normal file
View file

@ -0,0 +1,2 @@
var a = [] = [1].map(_ => _);
var b = [1].map(_ => _);