From 49639d53e7781eea3e0671c991fab8bd587472eb Mon Sep 17 00:00:00 2001 From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Date: Fri, 24 Jan 2020 11:19:51 -0800 Subject: [PATCH] remove outdated comments --- .../emitStatementsBeforeSuperCall.js | 9 -------- .../emitStatementsBeforeSuperCall.symbols | 23 ++++++++----------- .../emitStatementsBeforeSuperCall.types | 5 ---- ...atementsBeforeSuperCallWithDefineFields.js | 9 -------- ...ntsBeforeSuperCallWithDefineFields.symbols | 23 ++++++++----------- ...mentsBeforeSuperCallWithDefineFields.types | 5 ---- .../emitStatementsBeforeSuperCall.ts | 4 ---- ...atementsBeforeSuperCallWithDefineFields.ts | 4 ---- 8 files changed, 18 insertions(+), 64 deletions(-) diff --git a/tests/baselines/reference/emitStatementsBeforeSuperCall.js b/tests/baselines/reference/emitStatementsBeforeSuperCall.js index c48308f53d..72b3e7b483 100644 --- a/tests/baselines/reference/emitStatementsBeforeSuperCall.js +++ b/tests/baselines/reference/emitStatementsBeforeSuperCall.js @@ -1,9 +1,4 @@ //// [emitStatementsBeforeSuperCall.ts] -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code - class Base { } class Sub extends Base { @@ -27,10 +22,6 @@ class Test extends Base { //// [emitStatementsBeforeSuperCall.js] -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code class Base { } class Sub extends Base { diff --git a/tests/baselines/reference/emitStatementsBeforeSuperCall.symbols b/tests/baselines/reference/emitStatementsBeforeSuperCall.symbols index 05c80414fd..1a76d23631 100644 --- a/tests/baselines/reference/emitStatementsBeforeSuperCall.symbols +++ b/tests/baselines/reference/emitStatementsBeforeSuperCall.symbols @@ -1,19 +1,14 @@ === tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCall.ts === -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code - class Base { >Base : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0)) } class Sub extends Base { ->Sub : Symbol(Sub, Decl(emitStatementsBeforeSuperCall.ts, 6, 1)) +>Sub : Symbol(Sub, Decl(emitStatementsBeforeSuperCall.ts, 1, 1)) >Base : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0)) // @ts-ignore constructor(public p: number) { ->p : Symbol(Sub.p, Decl(emitStatementsBeforeSuperCall.ts, 9, 16)) +>p : Symbol(Sub.p, Decl(emitStatementsBeforeSuperCall.ts, 4, 16)) console.log('hi'); // should emit before super >console.log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --)) @@ -24,28 +19,28 @@ class Sub extends Base { >super : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0)) } field = 0; ->field : Symbol(Sub.field, Decl(emitStatementsBeforeSuperCall.ts, 12, 5)) +>field : Symbol(Sub.field, Decl(emitStatementsBeforeSuperCall.ts, 7, 5)) } class Test extends Base { ->Test : Symbol(Test, Decl(emitStatementsBeforeSuperCall.ts, 14, 1)) +>Test : Symbol(Test, Decl(emitStatementsBeforeSuperCall.ts, 9, 1)) >Base : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0)) prop: number; ->prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 16, 25)) +>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 11, 25)) // @ts-ignore constructor(public p: number) { ->p : Symbol(Test.p, Decl(emitStatementsBeforeSuperCall.ts, 19, 16)) +>p : Symbol(Test.p, Decl(emitStatementsBeforeSuperCall.ts, 14, 16)) 1; // should emit before super super(); >super : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0)) this.prop = 1; ->this.prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 16, 25)) ->this : Symbol(Test, Decl(emitStatementsBeforeSuperCall.ts, 14, 1)) ->prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 16, 25)) +>this.prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 11, 25)) +>this : Symbol(Test, Decl(emitStatementsBeforeSuperCall.ts, 9, 1)) +>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 11, 25)) } } diff --git a/tests/baselines/reference/emitStatementsBeforeSuperCall.types b/tests/baselines/reference/emitStatementsBeforeSuperCall.types index 6270b47ff9..ab731b040e 100644 --- a/tests/baselines/reference/emitStatementsBeforeSuperCall.types +++ b/tests/baselines/reference/emitStatementsBeforeSuperCall.types @@ -1,9 +1,4 @@ === tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCall.ts === -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code - class Base { >Base : Base } diff --git a/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.js b/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.js index 9c5f81d378..685c7562d6 100644 --- a/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.js +++ b/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.js @@ -1,9 +1,4 @@ //// [emitStatementsBeforeSuperCallWithDefineFields.ts] -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code - class Base { } class Sub extends Base { @@ -27,10 +22,6 @@ class Test extends Base { //// [emitStatementsBeforeSuperCallWithDefineFields.js] -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code class Base { } class Sub extends Base { diff --git a/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.symbols b/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.symbols index f40a6fe7ed..106aa7bc34 100644 --- a/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.symbols +++ b/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.symbols @@ -1,19 +1,14 @@ === tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCallWithDefineFields.ts === -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code - class Base { >Base : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0)) } class Sub extends Base { ->Sub : Symbol(Sub, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 6, 1)) +>Sub : Symbol(Sub, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 1, 1)) >Base : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0)) // @ts-ignore constructor(public p: number) { ->p : Symbol(Sub.p, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 9, 16)) +>p : Symbol(Sub.p, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 4, 16)) console.log('hi'); >console.log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --)) @@ -24,28 +19,28 @@ class Sub extends Base { >super : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0)) } field = 0; ->field : Symbol(Sub.field, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 12, 5)) +>field : Symbol(Sub.field, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 7, 5)) } class Test extends Base { ->Test : Symbol(Test, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 14, 1)) +>Test : Symbol(Test, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 9, 1)) >Base : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0)) prop: number; ->prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 16, 25)) +>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 11, 25)) // @ts-ignore constructor(public p: number) { ->p : Symbol(Test.p, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 19, 16)) +>p : Symbol(Test.p, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 14, 16)) 1; super(); >super : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0)) this.prop = 1; ->this.prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 16, 25)) ->this : Symbol(Test, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 14, 1)) ->prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 16, 25)) +>this.prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 11, 25)) +>this : Symbol(Test, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 9, 1)) +>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 11, 25)) } } diff --git a/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.types b/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.types index 53ac0be83c..29a20cbbdc 100644 --- a/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.types +++ b/tests/baselines/reference/emitStatementsBeforeSuperCallWithDefineFields.types @@ -1,9 +1,4 @@ === tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCallWithDefineFields.ts === -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code - class Base { >Base : Base } diff --git a/tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCall.ts b/tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCall.ts index 969acc749e..3c3559808b 100644 --- a/tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCall.ts +++ b/tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCall.ts @@ -1,9 +1,5 @@ // @useDefineForClassFields: false // @target: es2015 -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code class Base { } diff --git a/tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCallWithDefineFields.ts b/tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCallWithDefineFields.ts index 75c7da60d8..f1736ac8a9 100644 --- a/tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCallWithDefineFields.ts +++ b/tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCallWithDefineFields.ts @@ -1,9 +1,5 @@ // @useDefineForClassFields: true // @target: es2015 -// TODO: With false, master is correct for `Test` but incorrect for `Sub`. -// `Test` is correct because classic emit doesn't emit for definition and `Test` -// doesn't need to emit any code for initialisation because it's already -// part of the user code class Base { }