maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #20671 from Kingwl/fix-import-not-existed-module

Browse source 
error if import empty object form module not existed
This commit is contained in:
Mohamed Hegazy 2018-04-17 17:29:07 -07:00 committed by GitHub
parent e26745f129 eba4d36739
commit 52192006cf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 28 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/compiler/checker.ts
View file

@ -24465,7 +24465,10 @@ namespace ts {
checkImportBinding(importClause.namedBindings);
}
else {
forEach(importClause.namedBindings.elements, checkImportBinding);
const moduleExisted = resolveExternalModuleName(node, node.moduleSpecifier);
if (moduleExisted) {
forEach(importClause.namedBindings.elements, checkImportBinding);
}
}
}
}

8
tests/baselines/reference/importEmptyFromModuleNotExisted.errors.txt Normal file
View file

@ -0,0 +1,8 @@
tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts(1,16): error TS2307: Cannot find module 'module-not-existed'.
==== tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts (1 errors) ====
import {} from 'module-not-existed'
~~~~~~~~~~~~~~~~~~~~
!!! error TS2307: Cannot find module 'module-not-existed'.

7
tests/baselines/reference/importEmptyFromModuleNotExisted.js Normal file
View file

@ -0,0 +1,7 @@
//// [importEmptyFromModuleNotExisted.ts]
import {} from 'module-not-existed'
//// [importEmptyFromModuleNotExisted.js]
"use strict";
exports.__esModule = true;

4
tests/baselines/reference/importEmptyFromModuleNotExisted.symbols Normal file
View file

@ -0,0 +1,4 @@
=== tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts ===
import {} from 'module-not-existed'
No type information for this code.
No type information for this code.

4
tests/baselines/reference/importEmptyFromModuleNotExisted.types Normal file
View file

@ -0,0 +1,4 @@
=== tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts ===
import {} from 'module-not-existed'
No type information for this code.
No type information for this code.

1
tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts Normal file
View file

@ -0,0 +1 @@
import {} from 'module-not-existed'