Refactor code to make if statements cheaper

This commit is contained in:
zhengbli 2016-06-15 14:40:29 -07:00
parent 335443693f
commit 550d91249b
2 changed files with 5 additions and 8 deletions

View file

@ -475,10 +475,7 @@ namespace ts.server {
isRoot(info: ScriptInfo) {
if (this.languageServiceDiabled) {
if (!this.projectOptions) {
return undefined;
}
return forEach(this.projectOptions.files, file => toPath(file, file, createGetCanonicalFileName(this.projectService.host.useCaseSensitiveFileNames)) === info.path);
return undefined;
}
return this.compilerService.host.roots.some(root => root === info);
@ -1421,7 +1418,7 @@ namespace ts.server {
return errors;
}
else {
if (this.exceedTotalNonTsFileSizeLimit(projectOptions.files) && projectOptions.compilerOptions && !projectOptions.compilerOptions.disableSizeLimit) {
if (projectOptions.compilerOptions && !projectOptions.compilerOptions.disableSizeLimit && this.exceedTotalNonTsFileSizeLimit(projectOptions.files)) {
project.setProjectOptions(projectOptions);
if (project.languageServiceDiabled) {
return;

View file

@ -443,7 +443,7 @@ namespace ts.server {
const info = this.projectService.getScriptInfo(file);
const projects = this.projectService.findReferencingProjects(info);
const projectsWithLanguageServiceEnabeld = ts.filter(projects, p => !p.languageServiceDiabled);
if (projects.length === 0 || projectsWithLanguageServiceEnabeld.length === 0) {
if (projectsWithLanguageServiceEnabeld.length === 0) {
throw Errors.NoProject;
}
@ -526,7 +526,7 @@ namespace ts.server {
const info = this.projectService.getScriptInfo(file);
const projects = this.projectService.findReferencingProjects(info);
const projectsWithLanguageServiceEnabeld = ts.filter(projects, p => !p.languageServiceDiabled);
if (projects.length === 0 || projectsWithLanguageServiceEnabeld.length === 0) {
if (projectsWithLanguageServiceEnabeld.length === 0) {
throw Errors.NoProject;
}
@ -904,7 +904,7 @@ namespace ts.server {
const info = this.projectService.getScriptInfo(file);
const projects = this.projectService.findReferencingProjects(info);
const projectsWithLanguageServiceEnabeld = ts.filter(projects, p => !p.languageServiceDiabled);
if (projects.length === 0 || projectsWithLanguageServiceEnabeld.length === 0) {
if (projectsWithLanguageServiceEnabeld.length === 0) {
throw Errors.NoProject;
}