maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

super's containing class doesn't require base node

Browse source 
In a class nested inside a constructor, `super` refers to the outer
class' `super`, but when resolving a super call its containing class is
identified as the immediately containing class. Previously, the compiler
crashed, preventing the error from being reported correctly. Now it
handles this disparity and correctly reports the error.
This commit is contained in:
Nathan Shively-Sanders 2016-02-18 16:19:06 -08:00
parent 49a9d64e87
commit 67b2a17034
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/compiler/checker.ts
View file

@ -10112,8 +10112,10 @@ namespace ts {
// In super call, the candidate signatures are the matching arity signatures of the base constructor function instantiated
// with the type arguments specified in the extends clause.
const baseTypeNode = getClassExtendsHeritageClauseElement(getContainingClass(node));
const baseConstructors = getInstantiatedConstructorsForTypeArguments(superType, baseTypeNode.typeArguments);
return resolveCall(node, baseConstructors, candidatesOutArray);
if (baseTypeNode) {
const baseConstructors = getInstantiatedConstructorsForTypeArguments(superType, baseTypeNode.typeArguments);
return resolveCall(node, baseConstructors, candidatesOutArray);
}
}
return resolveUntypedCall(node);
}