From 85b32ed22198ed9860f2802cb35ccd9d8a05f6cf Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Thu, 4 Jan 2018 19:52:32 -0500 Subject: [PATCH] Added localization instructions to CONTRIBUTING.md (#20451) * Added localization instructions to CONTRIBUTING.md Fixes #20418 * Corrected mention of generated ts file * Mentioned coding guidelines --- CONTRIBUTING.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6dbb7e514a..fd0f4348c6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -183,3 +183,10 @@ jake baseline-accept ``` to establish the new baselines as the desired behavior. This will change the files in `tests\baselines\reference`, which should be included as part of your commit. It's important to carefully validate changes in the baselines. + +## Localization + +All strings the user may see are stored in [`diagnosticMessages.json`](./src/compiler/diagnosticMessages.json). +If you make changes to it, run `jake generate-diagnostics` to push them to the `Diagnostic` interface in [`diagnosticInformationMap.generated.ts`](./src/compiler/diagnosticInformationMap.generated.ts). + +See [coding guidelines on diagnostic messages](https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines#diagnostic-messages).