respond to code review comments
This commit is contained in:
parent
d8b437724d
commit
85ddc35268
|
@ -556,9 +556,7 @@ module ts {
|
|||
if (node.kind === kind) {
|
||||
return node;
|
||||
}
|
||||
else {
|
||||
node = node.parent;
|
||||
}
|
||||
node = node.parent;
|
||||
}
|
||||
break;
|
||||
}
|
||||
|
|
|
@ -1790,7 +1790,7 @@ module ts {
|
|||
return false;
|
||||
}
|
||||
|
||||
function isToken(kind: SyntaxKind) {
|
||||
function isPunctuation(kind: SyntaxKind) {
|
||||
return (SyntaxKind.FirstPunctuation <= kind && kind <= SyntaxKind.LastPunctuation);
|
||||
}
|
||||
|
||||
|
@ -1883,7 +1883,7 @@ module ts {
|
|||
|
||||
// TODO: this is a hack for now, we need a proper walking mechanism to verify that we have the correct node
|
||||
var mappedNode = getNodeAtPosition(sourceFile, TypeScript.end(node) - 1);
|
||||
if (isToken(mappedNode.kind)) {
|
||||
if (isPunctuation(mappedNode.kind)) {
|
||||
mappedNode = mappedNode.parent;
|
||||
}
|
||||
|
||||
|
@ -1905,7 +1905,6 @@ module ts {
|
|||
var containingClass = getAncestor(mappedNode, SyntaxKind.ClassDeclaration);
|
||||
isMemberCompletion = true;
|
||||
|
||||
|
||||
if (mappedNode.kind === SyntaxKind.Identifier || mappedNode.kind === SyntaxKind.QualifiedName || mappedNode.kind === SyntaxKind.PropertyAccess) {
|
||||
var symbol = typeInfoResolver.getSymbolInfo(mappedNode);
|
||||
if (symbol && symbol.flags & SymbolFlags.HasExports) {
|
||||
|
|
Loading…
Reference in a new issue