From 91c66a09635dabb3b20a5c2b50332d8803fef02d Mon Sep 17 00:00:00 2001
From: Sheetal Nandi <shkamat@microsoft.com>
Date: Wed, 25 Sep 2019 10:05:10 -0700
Subject: [PATCH] Add tsc baselining test for scenario that changed.

---
 .../unittests/tsc/declarationEmit.ts          | 63 +++++++++++++++++++
 ...ibling-package-through-indirect-symlink.js | 33 ++++++++++
 2 files changed, 96 insertions(+)
 create mode 100644 tests/baselines/reference/tsc/declarationEmit/initial-build/when-pkg-references-sibling-package-through-indirect-symlink.js

diff --git a/src/testRunner/unittests/tsc/declarationEmit.ts b/src/testRunner/unittests/tsc/declarationEmit.ts
index 5ff85a92f3..5577ad2202 100644
--- a/src/testRunner/unittests/tsc/declarationEmit.ts
+++ b/src/testRunner/unittests/tsc/declarationEmit.ts
@@ -69,5 +69,68 @@ namespace ts {
             },
             commandLineArgs: ["-p", "src/plugin-one", "--listFiles"]
         });
+
+        verifyTsc({
+            scenario: "declarationEmit",
+            subScenario: "when pkg references sibling package through indirect symlink",
+            fs: () => loadProjectFromFiles({
+                "/src/pkg1/dist/index.d.ts": utils.dedent`
+                        export * from './types';`,
+                "/src/pkg1/dist/types.d.ts": utils.dedent`
+                        export declare type A = {
+                            id: string;
+                        };
+                        export declare type B = {
+                            id: number;
+                        };
+                        export declare type IdType = A | B;
+                        export declare class MetadataAccessor<T, D extends IdType = IdType> {
+                            readonly key: string;
+                            private constructor();
+                            toString(): string;
+                            static create<T, D extends IdType = IdType>(key: string): MetadataAccessor<T, D>;
+                        }`,
+                "/src/pkg1/package.json": utils.dedent`
+                        {
+                            "name": "@raymondfeng/pkg1",
+                            "version": "1.0.0",
+                            "description": "",
+                            "main": "dist/index.js",
+                            "typings": "dist/index.d.ts"
+                        }`,
+                "/src/pkg2/dist/index.d.ts": utils.dedent`
+                        export * from './types';`,
+                "/src/pkg2/dist/types.d.ts": utils.dedent`
+                        export {MetadataAccessor} from '@raymondfeng/pkg1';`,
+                "/src/pkg2/package.json": utils.dedent`
+                        {
+                            "name": "@raymondfeng/pkg2",
+                            "version": "1.0.0",
+                            "description": "",
+                            "main": "dist/index.js",
+                            "typings": "dist/index.d.ts"
+                        }`,
+                "/src/pkg3/src/index.ts": utils.dedent`
+                        export * from './keys';`,
+                "/src/pkg3/src/keys.ts": utils.dedent`
+                        import {MetadataAccessor} from "@raymondfeng/pkg2";
+                        export const ADMIN = MetadataAccessor.create<boolean>('1');`,
+                "/src/pkg3/tsconfig.json": utils.dedent`
+                        {
+                            "compilerOptions": {
+                              "outDir": "dist",
+                              "rootDir": "src",
+                              "target": "es5",
+                              "module": "commonjs",
+                              "strict": true,
+                              "esModuleInterop": true,
+                              "declaration": true
+                            }
+                        }`,
+                "/src/pkg2/node_modules/@raymondfeng/pkg1": new vfs.Symlink("/src/pkg1"),
+                "/src/pkg3/node_modules/@raymondfeng/pkg2": new vfs.Symlink("/src/pkg2"),
+            }),
+            commandLineArgs: ["-p", "src/pkg3", "--listFiles"]
+        });
     });
 }
diff --git a/tests/baselines/reference/tsc/declarationEmit/initial-build/when-pkg-references-sibling-package-through-indirect-symlink.js b/tests/baselines/reference/tsc/declarationEmit/initial-build/when-pkg-references-sibling-package-through-indirect-symlink.js
new file mode 100644
index 0000000000..42cb6cf78c
--- /dev/null
+++ b/tests/baselines/reference/tsc/declarationEmit/initial-build/when-pkg-references-sibling-package-through-indirect-symlink.js
@@ -0,0 +1,33 @@
+//// [/lib/initial-buildOutput.txt]
+/lib/tsc -p src/pkg3 --listFiles
+src/pkg3/src/keys.ts(2,14): error TS2742: The inferred type of 'ADMIN' cannot be named without a reference to '@raymondfeng/pkg2/node_modules/@raymondfeng/pkg1'. This is likely not portable. A type annotation is necessary.
+/lib/lib.d.ts
+/src/pkg3/node_modules/@raymondfeng/pkg2/node_modules/@raymondfeng/pkg1/dist/types.d.ts
+/src/pkg3/node_modules/@raymondfeng/pkg2/node_modules/@raymondfeng/pkg1/dist/index.d.ts
+/src/pkg3/node_modules/@raymondfeng/pkg2/dist/types.d.ts
+/src/pkg3/node_modules/@raymondfeng/pkg2/dist/index.d.ts
+/src/pkg3/src/keys.ts
+/src/pkg3/src/index.ts
+exitCode:: 1
+
+
+//// [/src/pkg3/dist/index.d.ts]
+export * from './keys';
+
+
+//// [/src/pkg3/dist/index.js]
+"use strict";
+function __export(m) {
+    for (var p in m) if (!exports.hasOwnProperty(p)) exports[p] = m[p];
+}
+Object.defineProperty(exports, "__esModule", { value: true });
+__export(require("./keys"));
+
+
+//// [/src/pkg3/dist/keys.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+var pkg2_1 = require("@raymondfeng/pkg2");
+exports.ADMIN = pkg2_1.MetadataAccessor.create('1');
+
+