maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Only add unnecessary-await suggestion on await expressions (#32754)

Browse source
This commit is contained in:
Andrew Branch 2019-08-07 11:27:36 -07:00 committed by GitHub
parent 9971e8b560
commit 984956afec
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/compiler/checker.ts
View file

@ -24037,7 +24037,11 @@ namespace ts {
}
const operandType = checkExpression(node.expression);
return checkAwaitedType(operandType, node, Diagnostics.Type_of_await_operand_must_either_be_a_valid_promise_or_must_not_contain_a_callable_then_member);
const awaitedType = checkAwaitedType(operandType, node, Diagnostics.Type_of_await_operand_must_either_be_a_valid_promise_or_must_not_contain_a_callable_then_member);
if (awaitedType === operandType && awaitedType !== errorType && !(operandType.flags & TypeFlags.AnyOrUnknown)) {
addErrorOrSuggestion(/*isError*/ false, createDiagnosticForNode(node, Diagnostics.await_has_no_effect_on_the_type_of_this_expression));
}
return awaitedType;
}
function checkPrefixUnaryExpression(node: PrefixUnaryExpression): Type {
@ -26537,9 +26541,6 @@ namespace ts {
*/
function checkAwaitedType(type: Type, errorNode: Node, diagnosticMessage: DiagnosticMessage, arg0?: string | number): Type {
const awaitedType = getAwaitedType(type, errorNode, diagnosticMessage, arg0);
if (awaitedType === type && !(type.flags & TypeFlags.AnyOrUnknown)) {
addErrorOrSuggestion(/*isError*/ false, createDiagnosticForNode(errorNode, Diagnostics.await_has_no_effect_on_the_type_of_this_expression));
}
return awaitedType || errorType;
}

8
tests/cases/fourslash/codeFixRemoveUnnecessaryAwait_notAvailableOnReturn.ts Normal file
View file

@ -0,0 +1,8 @@
/// <reference path="fourslash.ts" />
// @target: esnext
////async function fn(): Promise<number> {
//// return 0;
////}
verify.getSuggestionDiagnostics([]);