maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Set syntheticLiteralTypeOrigin on synthetic undefined-type members (#22216)

Browse source 
* Have getNameOfSymbolAsWritten quote nonidentifier nonnumeric symbols all the time

* Revert checker changes

* Reuse synthetic origin to indicate that derived declaration name may need to be quoted
This commit is contained in:
Wesley Wigham 2018-02-28 16:03:05 -08:00 committed by GitHub
parent 1a43ad01a7
commit b8e0009c9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 58 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/compiler/checker.ts
View file

@ -11150,6 +11150,10 @@ namespace ts {
}
const result = createSymbol(SymbolFlags.Property | SymbolFlags.Optional, name);
result.type = undefinedType;
const associatedKeyType = getLiteralType(unescapeLeadingUnderscores(name));
if (associatedKeyType.flags & TypeFlags.StringLiteral) {
result.syntheticLiteralTypeOrigin = associatedKeyType as StringLiteralType;
}
undefinedProperties.set(name, result);
return result;
}

22
tests/baselines/reference/inferredNonidentifierTypesGetQuotes.js Normal file
View file

@ -0,0 +1,22 @@
//// [inferredNonidentifierTypesGetQuotes.ts]
var x = [{ "a-b": "string" }, {}];
var y = [{ ["a-b"]: "string" }, {}];
//// [inferredNonidentifierTypesGetQuotes.js]
var x = [{ "a-b": "string" }, {}];
var y = [(_a = {}, _a["a-b"] = "string", _a), {}];
var _a;
//// [inferredNonidentifierTypesGetQuotes.d.ts]
declare var x: ({
"a-b": string;
} | {
"a-b"?: undefined;
})[];
declare var y: ({
["a-b"]: string;
} | {
"a-b"?: undefined;
})[];

10
tests/baselines/reference/inferredNonidentifierTypesGetQuotes.symbols Normal file
View file

@ -0,0 +1,10 @@
=== tests/cases/compiler/inferredNonidentifierTypesGetQuotes.ts ===
var x = [{ "a-b": "string" }, {}];
>x : Symbol(x, Decl(inferredNonidentifierTypesGetQuotes.ts, 0, 3))
>"a-b" : Symbol("a-b", Decl(inferredNonidentifierTypesGetQuotes.ts, 0, 10))
var y = [{ ["a-b"]: "string" }, {}];
>y : Symbol(y, Decl(inferredNonidentifierTypesGetQuotes.ts, 2, 3))
>["a-b"] : Symbol(["a-b"], Decl(inferredNonidentifierTypesGetQuotes.ts, 2, 10))
>"a-b" : Symbol(["a-b"], Decl(inferredNonidentifierTypesGetQuotes.ts, 2, 10))

18
tests/baselines/reference/inferredNonidentifierTypesGetQuotes.types Normal file
View file

@ -0,0 +1,18 @@
=== tests/cases/compiler/inferredNonidentifierTypesGetQuotes.ts ===
var x = [{ "a-b": "string" }, {}];
>x : ({ "a-b": string; } | { "a-b"?: undefined; })[]
>[{ "a-b": "string" }, {}] : ({ "a-b": string; } | {})[]
>{ "a-b": "string" } : { "a-b": string; }
>"a-b" : string
>"string" : "string"
>{} : {}
var y = [{ ["a-b"]: "string" }, {}];
>y : ({ ["a-b"]: string; } | { "a-b"?: undefined; })[]
>[{ ["a-b"]: "string" }, {}] : ({ ["a-b"]: string; } | {})[]
>{ ["a-b"]: "string" } : { ["a-b"]: string; }
>["a-b"] : string
>"a-b" : "a-b"
>"string" : "string"
>{} : {}

4
tests/cases/compiler/inferredNonidentifierTypesGetQuotes.ts Normal file
View file

@ -0,0 +1,4 @@
// @declaration: true
var x = [{ "a-b": "string" }, {}];
var y = [{ ["a-b"]: "string" }, {}];