maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Switch to Set of Symbols in extractSymbol.

Browse source
This commit is contained in:
Daniel Rosenwasser 2021-11-09 00:35:10 +00:00 committed by GitHub
parent ced38f315e
commit cc3836911f
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/services/refactors/extractSymbol.ts
View file

@ -1597,7 +1597,7 @@ namespace ts.refactor.extractSymbol {
const functionErrorsPerScope: Diagnostic[][] = [];
const constantErrorsPerScope: Diagnostic[][] = [];
const visibleDeclarationsInExtractedRange: NamedDeclaration[] = [];
const exposedVariableSymbolSet = new Map<string, true>(); // Key is symbol ID
const exposedVariableSymbolSet = new Set<Symbol>(); // Key is symbol ID
const exposedVariableDeclarations: VariableDeclaration[] = [];
let firstExposedNonVariableDeclaration: NamedDeclaration | undefined;
@ -1903,10 +1903,10 @@ namespace ts.refactor.extractSymbol {
const decl = find(visibleDeclarationsInExtractedRange, d => d.symbol === sym);
if (decl) {
if (isVariableDeclaration(decl)) {
const idString = decl.symbol.id!.toString();
if (!exposedVariableSymbolSet.has(idString)) {
const declSymbol = decl.symbol;
if (!exposedVariableSymbolSet.has(declSymbol)) {
exposedVariableDeclarations.push(decl);
exposedVariableSymbolSet.set(idString, true);
exposedVariableSymbolSet.add(declSymbol);
}
}
else {