maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Revert "Fix and updated tests"

Browse source 
This reverts commit 33829fa4a4.
This commit is contained in:
Armando Aguirre 2021-08-23 16:27:51 -07:00
parent 2249d6c83e
commit e1a2b9ed19
5 changed files with 27 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/services/completions.ts
View file

@ -416,10 +416,6 @@ namespace ts.Completions {
}
}
if (!isNewIdentifierLocation && (!symbols || symbols.length === 0) && keywordFilters === KeywordCompletionFilters.None) {
return undefined;
}
const entries: CompletionEntry[] = [];
if (isUncheckedFile(sourceFile, compilerOptions)) {
@ -447,6 +443,10 @@ namespace ts.Completions {
getJSCompletionEntries(sourceFile, location.pos, uniqueNames, compilerOptions.target!, entries); // TODO: GH#18217
}
else {
if (!isNewIdentifierLocation && (!symbols || symbols.length === 0) && keywordFilters === KeywordCompletionFilters.None) {
return undefined;
}
getCompletionEntriesFromSymbols(
symbols,
entries,

13
tests/cases/fourslash/completionInUncheckedJSFile.ts
View file

@ -13,5 +13,16 @@
verify.completions({
marker: "0",
exact: undefined
includes: [
{
name: "hello",
sortText: completion.SortText.JavascriptIdentifiers,
isFromUncheckedFile: true
},
{
name: "goodbye",
sortText: completion.SortText.JavascriptIdentifiers,
isFromUncheckedFile: true
}
]
});

2
tests/cases/fourslash/getJavaScriptCompletions12.ts
View file

@ -26,5 +26,5 @@
verify.completions(
{ marker: "1", includes: { name: "charCodeAt", kind: "method", kindModifiers: "declare" } },
{ marker: ["2", "3", "4"], includes: { name: "toExponential", kind: "method", kindModifiers: "declare" } },
{ marker: "5", exact: undefined },
{ marker: "5", includes: { name: "test1", kind: "warning", sortText: completion.SortText.JavascriptIdentifiers } },
);

2
tests/cases/fourslash/javaScriptPrototype2.ts
View file

@ -31,4 +31,4 @@ verify.completions({ includes: { name: "toFixed", kind: "method", kindModifiers:
goTo.marker('3');
edit.insert('.');
// Make sure symbols don't leak out into the constructor
verify.completions({ exact: undefined });
verify.completions({ includes: ["qua", "foo", "bar"].map(name => ({ name, kind: "warning", sortText: completion.SortText.JavascriptIdentifiers })) });

10
tests/cases/fourslash/server/jsdocTypedefTag2.ts
View file

@ -16,6 +16,14 @@
//// my2.yes./*1*/
//// }
//// /**
//// * @param {MyType} my2
//// */
//// function b(my2) {
//// my2.yes./*2*/
//// }
verify.completions(
{ marker: "1", includes: "charAt" }
{ marker: "1", includes: "charAt" },
{ marker: "2", excludes: "charAt" },
);