From fb058868ded6c36e0f278d16b93dbf636e0d73f7 Mon Sep 17 00:00:00 2001 From: uniqueiniquity Date: Tue, 24 Oct 2017 13:22:29 -0700 Subject: [PATCH] Respond to CR --- src/compiler/diagnosticMessages.json | 2 +- src/compiler/emitter.ts | 8 +------- src/compiler/parser.ts | 2 +- tests/baselines/reference/tsxFragmentErrors.errors.txt | 4 ++-- 4 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json index 68cc5a7309..d89f631f28 100644 --- a/src/compiler/diagnosticMessages.json +++ b/src/compiler/diagnosticMessages.json @@ -3611,7 +3611,7 @@ "category": "Error", "code": 17014 }, - "Expected corresponding JSX fragment closing tag.": { + "Expected corresponding closing tag for JSX fragment.": { "category": "Error", "code": 17015 }, diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts index ced57157b2..8c41eda192 100644 --- a/src/compiler/emitter.ts +++ b/src/compiler/emitter.ts @@ -2090,9 +2090,9 @@ namespace ts { if (isJsxOpeningElement(node)) { emitJsxTagName(node.tagName); - writeIfAny(node.attributes.properties, " "); // We are checking here so we won't re-enter the emitting pipeline and emit extra sourcemap if (node.attributes.properties && node.attributes.properties.length > 0) { + write(" "); emit(node.attributes); } } @@ -2627,12 +2627,6 @@ namespace ts { writer.decreaseIndent(); } - function writeIfAny(nodes: NodeArray, text: string) { - if (some(nodes)) { - write(text); - } - } - function writeToken(token: SyntaxKind, pos: number, contextNode?: Node) { return onEmitSourceMapOfToken ? onEmitSourceMapOfToken(contextNode, token, pos, writeTokenText) diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts index f99a83072b..1f37043bfd 100644 --- a/src/compiler/parser.ts +++ b/src/compiler/parser.ts @@ -4213,7 +4213,7 @@ namespace ts { parseExpected(SyntaxKind.LessThanSlashToken); if (tokenIsIdentifierOrKeyword(token())) { const unexpectedTagName = parseJsxElementName(); - parseErrorAtPosition(unexpectedTagName.pos, unexpectedTagName.end - unexpectedTagName.pos, Diagnostics.Expected_corresponding_JSX_fragment_closing_tag); + parseErrorAtPosition(unexpectedTagName.pos, unexpectedTagName.end - unexpectedTagName.pos, Diagnostics.Expected_corresponding_closing_tag_for_JSX_fragment); } if (inExpressionContext) { parseExpected(SyntaxKind.GreaterThanToken); diff --git a/tests/baselines/reference/tsxFragmentErrors.errors.txt b/tests/baselines/reference/tsxFragmentErrors.errors.txt index ad914e555e..03397452ab 100644 --- a/tests/baselines/reference/tsxFragmentErrors.errors.txt +++ b/tests/baselines/reference/tsxFragmentErrors.errors.txt @@ -1,4 +1,4 @@ -tests/cases/conformance/jsx/file.tsx(9,7): error TS17015: Expected corresponding JSX fragment closing tag. +tests/cases/conformance/jsx/file.tsx(9,7): error TS17015: Expected corresponding closing tag for JSX fragment. tests/cases/conformance/jsx/file.tsx(9,11): error TS17014: JSX fragment has no corresponding closing tag. tests/cases/conformance/jsx/file.tsx(11,17): error TS1005: 'hi // Error ~~~ -!!! error TS17015: Expected corresponding JSX fragment closing tag. +!!! error TS17015: Expected corresponding closing tag for JSX fragment. ~~~~~~~~~