maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Report identical modifiers needed error when checking the file instead of reporting it as part of another file's type check

Browse source
This commit is contained in:
Sheetal Nandi 2018-11-09 14:43:32 -08:00
parent a27b29f025
commit fdafbd6e95
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/compiler/checker.ts
View file

@ -25110,6 +25110,11 @@ namespace ts {
checkParameterInitializer(node);
}
}
if (symbol.declarations.length > 1) {
if (some(symbol.declarations, d => d !== node && !areDeclarationFlagsIdentical(d, node))) {
error(node.name, Diagnostics.All_declarations_of_0_must_have_identical_modifiers, declarationNameToString(node.name));
}
}
}
else {
// Node is a secondary declaration, check that type is identical to primary declaration and check that
@ -25125,7 +25130,6 @@ namespace ts {
checkTypeAssignableToAndOptionallyElaborate(checkExpressionCached(node.initializer), declarationType, node, node.initializer, /*headMessage*/ undefined);
}
if (!areDeclarationFlagsIdentical(node, symbol.valueDeclaration)) {
error(getNameOfDeclaration(symbol.valueDeclaration), Diagnostics.All_declarations_of_0_must_have_identical_modifiers, declarationNameToString(node.name));
error(node.name, Diagnostics.All_declarations_of_0_must_have_identical_modifiers, declarationNameToString(node.name));
}
}