From ede80c1de22b40ca13f09cd8e6019f9bcb6cbc43 Mon Sep 17 00:00:00 2001
From: Cyrus Najmabadi <cyrusn@microsoft.com>
Date: Thu, 18 Jun 2015 09:06:47 -0700
Subject: [PATCH] Don't use spread operator when pushing arrays onto other
 arrays.

Spreading emits as ".push.apply(reciver, values)".  This pushes every elements in
values onto the stack before calling the function.  This can easily stack overflow
if the amount of values is high (i hit this with ~10k values on my own system).
---
 src/services/services.ts | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/services/services.ts b/src/services/services.ts
index bab5b7707e..bed1f9b6bb 100644
--- a/src/services/services.ts
+++ b/src/services/services.ts
@@ -1789,11 +1789,6 @@ namespace ts {
             sourceFile.moduleName = moduleName;
         }
 
-        // Store syntactic diagnostics
-        if (diagnostics && sourceFile.parseDiagnostics) {
-            diagnostics.push(...sourceFile.parseDiagnostics);
-        }
-
         let newLine = getNewLineCharacter(options);
 
         // Output
@@ -1815,9 +1810,8 @@ namespace ts {
 
         var program = createProgram([inputFileName], options, compilerHost);
 
-        if (diagnostics) {
-            diagnostics.push(...program.getCompilerOptionsDiagnostics());
-        }
+        addRange(/*to*/ diagnostics, /*from*/ sourceFile.parseDiagnostics);
+        addRange(/*to*/ diagnostics, /*from*/ program.getCompilerOptionsDiagnostics());
 
         // Emit
         program.emit();
@@ -4188,7 +4182,7 @@ namespace ts {
                 var result: DefinitionInfo[] = [];
                 forEach((<UnionType>type).types, t => {
                     if (t.symbol) {
-                        result.push(...getDefinitionFromSymbol(t.symbol, node));
+                        addRange(/*to*/ result, /*from*/ getDefinitionFromSymbol(t.symbol, node));
                     }
                 });
                 return result;