Commit graph

6 commits

Author SHA1 Message Date
Wesley Wigham 7b5ef64e76
Unify JSX And Normal Call Checking Codepaths (#27627)
* Unify JSX Call Checking Codepaths

* Add tests for fixed issues

* Fix lint, move all error checking into the only-run-once resolveSignature call

* Remove unused (unreachable?) code path

* Consolidate a little more duplicated logic into signature checking

* Fix #19775 a bit more

* Cosmetic changes from CR
2018-10-16 20:16:00 -04:00
Andy 5c57e14000
goToDefinition: Don't go to jsx constructor signature (#25382) 2018-07-02 17:18:07 -07:00
Armando Aguirre 16c3255988 Updated an incredible amount of tests. 2017-10-18 15:49:46 -07:00
Kanchalai Tanglertsampan ab2e14f24e Addressing code review in previous PR. Combining below commits
Address comment: fix spelling mistakes

Address comment: calling `checkApplicableSignatureForJsxOpeningLikeElement` from inside `checkApplicableSignature`

Address comment: fix spelling, rename function to be more consistent

Address comment: minor fix indentation, fix function name isObjectLiteralPropertyDeclaration => isObjectLiteralElement

Address PR: gotoDefinition return the last signature when there is an error in statelss function component

Address PR: convert Foreach to for...of

Address comment: fix type, inline code, clarify name of variables
2017-01-19 10:10:03 -08:00
Kanchalai Tanglertsampan 2fd5667a04 Update baselines 2017-01-19 09:46:43 -08:00
Kanchalai Tanglertsampan 3d19782b1c Add language service tests 2017-01-18 15:29:38 -08:00