Mohamed Hegazy
3057be3a0b
Merge pull request #25966 from ajafff/shorthandPropertyAssignment-initializer-symbol
...
correctly resolve Symbol of destructuring shorthand intializer
2018-07-26 09:32:39 -07:00
Mohamed Hegazy
3ff667e2c5
Merge pull request #25956 from fredrb/alias-jake-help-command
...
add help alias to jake --tasks in Jakefile.js
2018-07-26 09:30:29 -07:00
Klaus Meinhardt
d282c75e73
add quickinfo test
2018-07-26 18:09:51 +02:00
Andy
5e94cf626b
Expand span of @typedef with properties to include the @typedef tag ( #25950 )
2018-07-26 08:56:24 -07:00
Klaus Meinhardt
b65bbfd42d
correctly resolve Symbol of destructuring shorthand intializer
...
Fixes : #21046
2018-07-26 14:37:52 +02:00
Klaus Meinhardt
b057bf9f01
expose escapeLeadingUnderscores
...
Fixes : #25343
2018-07-26 14:20:48 +02:00
Klaus Meinhardt
c4f9a8cd6e
accept baselines
2018-07-26 13:39:22 +02:00
Klaus Meinhardt
95f061ea0a
minor cleanup in factory.ts
...
* remove deprecated signatures
* deprecate some legacy signature
* remove 2 useless conditions
2018-07-26 13:19:45 +02:00
Frederico Bittencourt
a9fca8f575
add help alias to jake --tasks in Jakefile.js
2018-07-26 00:41:36 -03:00
Sheetal Nandi
2b14bcbb56
Merge pull request #25949 from Microsoft/resolveJsonModuleError
...
When json module is not found, include enabling --resolveJsonModule might help.
2018-07-25 17:50:43 -07:00
Sheetal Nandi
d920efe3f9
Merge branch 'master' into resolveJsonModuleError
2018-07-25 17:32:22 -07:00
Andy
f12e9a8389
Minor refactor in goToTypeDefinition ( #25951 )
2018-07-25 17:10:06 -07:00
Andy
1e8a5bf2f1
signatureHelp: Factor out 'isSyntacticOwner' function ( #25518 )
2018-07-25 17:01:35 -07:00
Daniel Rosenwasser
49468e7eb6
Merge pull request #25541 from mattmccutchen/issue-25539
...
Improve the error message when asserting to a type that is not comparable to the original.
2018-07-25 16:54:00 -07:00
Sheetal Nandi
dfb5cbd373
When json module is not found, include enabling --resolveJsonModule might help.
...
Fixes #25722
2018-07-25 16:20:37 -07:00
Matt McCutchen
da64479a64
Improve the error message when asserting to a type that is not
...
comparable to the original.
Also improve the error message for implicit conversion of a symbol to a
string in a template literal, which previously shared the error message
with type assertions.
Fixes #25539 . Addresses #25870 .
2018-07-25 19:13:10 -04:00
Mohamed Hegazy
3310ad29b2
Accept baselines
2018-07-25 15:32:51 -07:00
Mohamed Hegazy
7799ae18b4
Port generated lib files
2018-07-25 15:32:42 -07:00
Anders Hejlsberg
7473772291
Merge pull request #25938 from Microsoft/fixRestTupleArityCheck
...
Fix rest tuple arity check
2018-07-25 14:40:57 -07:00
Andy
2e89dbd769
fourslash: Don't parse lib if 'nolib' is set ( #23277 )
2018-07-25 14:25:32 -07:00
Anders Hejlsberg
0758700f7d
Accept new baselines
2018-07-25 12:43:10 -07:00
Anders Hejlsberg
1aa2b15f8c
Add regression test
2018-07-25 12:42:47 -07:00
Anders Hejlsberg
5288c37010
Rest parameter with fixed size tuple should be same as regular parameters
2018-07-25 12:42:37 -07:00
Andy
7546fd03c6
Simplify getContainers ( #23323 )
2018-07-25 12:30:13 -07:00
Andy
bd600cfd50
Fix duplicate "this" completion ( #25900 )
2018-07-25 12:29:28 -07:00
Andy
d60f4988a6
In getPropertySymbolsFromContextualType, use union discriminant to filter types ( #25914 )
2018-07-25 11:53:20 -07:00
Nathan Shively-Sanders
9658b476c2
Fix inferFromUsage on index signatures ( #25934 )
...
* Fix inferFromUsage on index signatures
1. Check the argumentExpression to determine the index signature type.
Previously, the code mistakenly checked the type of the element access
itself, which never returned a good type.
2. If inference for the index signature type fails, substitute anyType.
Previously, the code would create a bad index signature with an
undefined type.
3. Add tests. Previously, there were no tests.
* Fixing (1) means that number index signatures are now created.
Previously, only string index signatures would be created.
* Fixing (2) means that index signatures will be inferred from single
usage like `return a[0]`. Previously, the refactoring would fail,
perhaps because of a check when stringifying the index signature (I
haven't tracked down why.)
* Update fourslash test with improved inference
2018-07-25 10:51:11 -07:00
Anders Hejlsberg
7b4d13c95c
Merge pull request #25859 from Microsoft/optimizePrimitiveIntersections
...
Optimize creation of intersections of union types
2018-07-25 10:28:43 -07:00
Anders Hejlsberg
f9681e2327
Update comment
2018-07-25 07:10:44 -07:00
Anders Hejlsberg
dd4fd8c60e
Merge pull request #25913 from Microsoft/fixCircularConstraintCheck
...
Fix circular constraint check
2018-07-25 06:46:51 -07:00
Anders Hejlsberg
ff6059abf6
Address CR feedback
2018-07-24 17:58:03 -07:00
Andy
e4d4b0ae4b
Handle PropertyAssignment in getCommentOwnerInfo ( #25911 )
2018-07-24 17:43:46 -07:00
Mohamed Hegazy
fd2eb4918d
Merge pull request #25604 from mprobst/fix-exported-var-comments
...
Retain synthetic comments on exports.
2018-07-24 17:41:44 -07:00
Wesley Wigham
7d44014c56
Fix typos
2018-07-24 16:37:07 -07:00
Wesley Wigham
23eb591e01
Lookup files by resolved Path
and not by fileName
in sourcemapDecoder when querying program ( #25908 )
...
* Check if the file returned by the program actually refers to the same file as we intend
* Simplify
2018-07-24 15:44:22 -07:00
Anders Hejlsberg
fe9ca725b9
Accept new baselines
2018-07-24 15:33:10 -07:00
Anders Hejlsberg
aeae05eaf5
Add regression test
2018-07-24 15:33:02 -07:00
Anders Hejlsberg
1fd1de9625
More simplification + consistent use of getConstraintOfTypeParameter
2018-07-24 15:27:39 -07:00
Wesley Wigham
f6d3ac9b5d
Fix #25820 - handle redirected files when comparing paths ( #25902 )
...
* Fix #25820 - handle redirected files when comparing paths
* Update test to do case check
2018-07-24 15:24:52 -07:00
Mohamed Hegazy
870c55c7a5
Merge pull request #25863 from mattmccutchen/issue-9744
...
Report a semantic error for an arrow function with a "this" parameter.
2018-07-24 15:08:26 -07:00
Anders Hejlsberg
0fd89399cc
Accept new baselines
2018-07-24 14:49:45 -07:00
Anders Hejlsberg
7233cde0dc
Simplify logic in getBaseConstraint
2018-07-24 14:49:22 -07:00
Wesley Wigham
797d8bd07b
Call toPath on sourceRoot to ensure it is always absolute ( #25838 )
...
* Call toPath on sourceRoot to ensure it is always absolute
* Leave canonicalization to avoid a Path/string union
2018-07-24 14:14:41 -07:00
Wesley Wigham
59854bbd55
Inspect all possible module paths when looking for the best one to create a specifier with ( #25850 )
...
* Inspect all possible specifier paths when looking for the best one
* Add missing secondary option from test
2018-07-24 13:56:21 -07:00
Mohamed Hegazy
3502471814
Merge pull request #25901 from Microsoft/fix23339
...
Add `.mailmap` and `Test-results.xml` to .npmignore
2018-07-24 12:39:45 -07:00
Mohamed Hegazy
4ab17f2afe
Add .mailmap
and Test-results.xml
to .npmignore
2018-07-24 12:19:06 -07:00
Anders Hejlsberg
06a11456cc
Accept new baselines
2018-07-24 06:21:12 -07:00
Anders Hejlsberg
8ddeb966f5
Consistently include circularity check in type parameter constraints
2018-07-24 06:19:58 -07:00
Andy
30c41492d9
moduleSpecifiers: Allow "*" as a path mapping ( #25881 )
2018-07-23 17:11:30 -07:00
Nathan Shively-Sanders
2146a91df3
Simplify getWidenedTypeFromJSSpecialPropertyDeclarations ( #25868 )
...
* Split getWidenedTypeFromJSSpecialPropertyDeclaration
1. Handle this-property assignments
2. Handle other special property assignment
I have only started simplifying [2].
* Split into two passes
1. Look for jsdoc
2. Look for type of initializers
Both can be broken into their own functions.
* Break into two functions
* Move back to original function and single loop
Then, convert the 2 extracted functions to reduce-style functions that
take state and return the updated state.
* Cleanup suggestions from review
2018-07-23 15:52:48 -07:00