Commit graph

20839 commits

Author SHA1 Message Date
Andrew Casey
eb5797fd36
Merge pull request #20211 from amcasey/GH20084
Update project on PackageInstalledResponse
2017-11-22 10:21:33 -08:00
csigs
8e6642e78f
LEGO: Merge pull request 20226
LEGO: Merge pull request 20226
2017-11-22 09:10:25 -08:00
csigs
8c52e4ea67 LEGO: check in for master to temporary branch. 2017-11-22 17:10:08 +00:00
csigs
2621a02508
LEGO: Merge pull request 20220
LEGO: Merge pull request 20220
2017-11-22 03:10:43 -08:00
csigs
208eea156b LEGO: check in for master to temporary branch. 2017-11-22 11:10:25 +00:00
Wesley Wigham
332a61ee8b
Removes redundant comments (#20214) 2017-11-21 20:22:26 -08:00
Andrew Casey
a0dec26d25
Merge pull request #20212 from amcasey/ToEventArgs
Unswap arguments
2017-11-21 19:01:13 -08:00
Anders Hejlsberg
b4b9edc04c Make sure 'async' isn't treated as a parameter modifier 2017-11-21 18:39:01 -08:00
Andy
013ce8e36d
Catch illegal jsdoc tags on constructors (#20045) 2017-11-21 21:36:08 -05:00
Andrew Casey
5ed31cff8c Use stricter types for event bodies 2017-11-21 16:38:58 -08:00
Andrew Casey
f483495408 Use {} instead of any to improve type checking 2017-11-21 16:24:05 -08:00
Andrew Casey
82aa518ec0 Update public API baseline 2017-11-21 15:59:46 -08:00
Andrew Casey
35545d4a0a Update project on PackageInstalledResponse
As with `SetTypings`, new typings have been installed so the project
should be updated and the client should be notified (via event).

Changed PackageInstalledResponse from "event" to "action" for the sake
of explicitness.

Fixes #20084.
2017-11-21 15:59:46 -08:00
Andrew Casey
39e6a00054 Unswap arguments 2017-11-21 15:59:45 -08:00
csigs
739097a9ad
LEGO: Merge pull request 20210
LEGO: Merge pull request 20210
2017-11-21 15:11:00 -08:00
csigs
3fd6f3aa99 LEGO: check in for master to temporary branch. 2017-11-21 23:10:31 +00:00
Wesley Wigham
50866e114a
Fix visibility checking of mutually recursive exports (#19929)
* Do visibility painting from collectLinkedAliases in checker to remove statefullness in declaration emit

* Fix #17085

* Add deeply destructured array to test

* Add test case for #18634

* Add PR feedback
2017-11-21 15:06:27 -08:00
Nathan Shively-Sanders
d4f6c8cc09 Merge branch 'js-ctor-props-type-annotation-as-declaration' into jsdoc-values-as-namespaces 2017-11-21 15:06:01 -08:00
Nathan Shively-Sanders
2f0e581018 JS Property assignments create namespaces (hacky)
This version isn't done yet and I think it still causes failures in the
test suite.
2017-11-21 15:05:20 -08:00
Nathan Shively-Sanders
fa96bd4b01 More tests and update baselines 2017-11-21 15:03:44 -08:00
Nathan Shively-Sanders
082802e7a8 JS:Treat type-annotated uninitialised vars as declarations
Currently only applies to property accesses, but maybe should apply to
everything.
2017-11-21 13:17:32 -08:00
Wesley Wigham
8c6863aff8
Add dt baseline folder to gitignore (#20205) 2017-11-21 13:08:04 -08:00
Andy
6e57c2630f
Support getJSDocCommentsAndTags for special property assignments (#20193) 2017-11-21 14:29:52 -05:00
Andy
7c5a0ec9c6
Clean up outliningElementsCollector (#20143)
* Clean up outliningElementsCollector

* Use depthRemaining instead of maxDepth
2017-11-21 14:27:26 -05:00
Nathan Shively-Sanders
1d1a7d8353 Update chrome-devtools baseline
Now it turns out that we don't support Closure's property declaration
style, which doesn't require assignment in the constructor:

```js
class C {
  constructor() {
    /** @type {number} */
    this.n
  }
}
```

This means that we still miss basically all the properties of class.

Also the 'conflicting declarations' message still mentions absolute
paths :(
2017-11-21 10:41:13 -08:00
Andrew Casey
761c739824
Merge pull request #20181 from amcasey/TiRootPath
Correct project root path passed to Typings Installer
2017-11-21 10:39:28 -08:00
Andrew Casey
b6799d7c3d
Merge pull request #20180 from amcasey/CaseSensitiveSafeList
Convert legacy safe list keys to lowercase on construction
2017-11-21 10:39:13 -08:00
Nathan Shively-Sanders
418274ecb4 Merge branch 'master' into jsdoc-values-as-namespaces 2017-11-21 10:26:08 -08:00
Nathan Shively-Sanders
b1c735fea6 Test:Type references to nested JS classes 2017-11-21 10:23:23 -08:00
Nathan Shively-Sanders
d2c0ec754b JS:resolve nested static classes+on func/class exps
1. In Javascript, support type references to class expressions whose
name is obtained via "static property assignment" to another class like
so:

```ts
function Outer() {
  this.y = 2
}
Outer.Inner = class { }

/** @type {Outer.Inner} */
var inner;
```

2. In Javascript, support type references to properties of function and
class expressions that are assigned to a variable, like so:

```ts
var Outer = function {
  this.y = 2
}
Outer.Inner = class { }

/** @type {Outer.Inner} */
var inner;
```
2017-11-21 10:17:48 -08:00
Anders Hejlsberg
9abb72d920
Merge pull request #20166 from Microsoft/definiteAssignmentAssertions
Definite assignment assertions
2017-11-21 06:27:56 -08:00
Ryan Cavanaugh
ee2d436999 Always send a response to installTypings even if all types are cached 2017-11-20 21:32:56 -08:00
Andrew Casey
1793652373 Correct project root path passed to Typings Installer
`createInstallTypingsRequest` has its own logic for extracting the
project root path from the project name and it disagrees with the
versions in the project flavors.  In particular, it only drops the last
component of the name if it exists.  For folder projects and JS-only
contexts, this will not be the case, but the last entry should still be
dropped.

TL;DR: stop creating filewatchers for
"c:/foo/foo.csproj*jscontent/node_modules"
2017-11-20 18:56:27 -08:00
Andrew Casey
71e07df817 Check hasOwnProperty before copying property 2017-11-20 18:43:14 -08:00
Andrew Casey
9cbe4eb614 Convert legacy safe list keys to lowercase on construction 2017-11-20 18:30:28 -08:00
Mohamed Hegazy
cc7b46bb75
Port generated lib files (#20177)
* Port generated lib files

* Accept baselines
2017-11-20 17:28:38 -08:00
Andy
53796eed59
Clean up lexical classifier (#20123) 2017-11-20 16:25:51 -08:00
Wesley Wigham
a551c4cd64
Allow curly around @type jsdoc to be optional (#20074)
* Allow curly around `@type` jsdoc to be optional

* Incorporate restructuring from @andy-ms
2017-11-20 16:10:50 -08:00
Wesley Wigham
71ceb91c9d
Parallel runner shouldnt print nan and freeze on unestimatable tests when above batch count (#20176) 2017-11-20 15:47:46 -08:00
Wesley Wigham
2c8e49f32e
Exclude global types from devtools user test (#20172) 2017-11-20 15:17:53 -08:00
Anders Hejlsberg
9b9f3f25d7 Merge branch 'master' into definiteAssignmentAssertions 2017-11-20 15:09:50 -08:00
Anders Hejlsberg
02fd11e3bd Accept new baselines 2017-11-20 15:08:33 -08:00
Anders Hejlsberg
54d35b926a Add tests 2017-11-20 15:08:24 -08:00
Wesley Wigham
e684f30d18
Fix build in the presence of definite assignment analysis (#20170) 2017-11-20 14:49:15 -08:00
Anders Hejlsberg
005838f6df
Merge pull request #20142 from Microsoft/fixTypeVariableInstanceof
Fix instanceof with type variable constrained to class
2017-11-20 12:57:51 -08:00
Anders Hejlsberg
ed4dc57a52 Merge branch 'master' into definiteAssignmentAssertions 2017-11-20 11:08:44 -08:00
Anders Hejlsberg
148dc4e013
Merge pull request #20075 from Microsoft/strictPropertyInitialization
Strict property initialization checks in classes
2017-11-20 10:44:27 -08:00
Nathan Shively-Sanders
40c32136f1
Merge pull request #20106 from Microsoft/jsdoc-errors-become-semantic-errors
Report JSDoc errors as semantic errors in checkJS mode
2017-11-20 10:02:04 -08:00
Anders Hejlsberg
272076391b Allow '!' only on variable declarations within variable statements 2017-11-20 09:31:11 -08:00
Nathan Shively-Sanders
edf9f02bdd Merge branch 'master' into jsdoc-errors-become-semantic-errors 2017-11-20 08:34:26 -08:00