Sheetal Nandi
ff34a77ab6
Merge branch 'master' into watchImprovements
2017-07-17 16:54:28 -07:00
Sheetal Nandi
2439e7affb
Reduce the number of watched config files by watching the chain only in case of inferred root
2017-07-17 16:50:26 -07:00
Nathan Shively-Sanders
047ab9b0e3
Update name of getIntendedTypeFromJSDocTypeReference
2017-07-17 16:23:42 -07:00
Nathan Shively-Sanders
3b7a07c441
Fix lint
2017-07-17 16:21:54 -07:00
Nathan Shively-Sanders
1173dc104a
Improve naming and style a little
2017-07-17 16:18:09 -07:00
Nathan Shively-Sanders
10a91c5426
JSDoc:Object<string, T> creates index signature
...
And `Object<number, T>` creates a numeric index signature. Other uses
still create `any` as before.
2017-07-17 16:14:42 -07:00
Nathan Shively-Sanders
08ae02263a
Contextually type this in object literals in JS
...
Previously, `this` would only get a contextual type inside object
literals with `--noImplicitThis` turned on in Typescript files.
2017-07-17 15:59:18 -07:00
Nathan Shively-Sanders
73cfa64f44
Make sure not to truncate the stringified type from typeToString
2017-07-17 14:47:10 -07:00
Andy
de9a67f2f3
Issue template: Recommend to run tsc directly ( #17246 )
...
* Issue template: Recommand to run `tsc` directly
* List some common build tools
2017-07-17 14:45:21 -07:00
Sheetal Nandi
54dfdd77fb
Merge pull request #17210 from Microsoft/readfile
...
`readFile` may return undefined
2017-07-17 14:39:57 -07:00
Nathan Shively-Sanders
b13de0547e
JSDoc codefix:getTypeFromTypeNode >>> typeToString
...
Instead of trying to walk the type structure in the codefix, I changed
to call getTypeFromTypeNode in the checker and then calling
typeToString. Together, these two functions normalise out JSDoc.
Note that you only get `T | null` for `?T` if you have --strict on. This
is technically correct -- adding a null union does nothing without
strict -- but it would still serve as documentation.
2017-07-17 14:11:35 -07:00
Nathan Shively-Sanders
cbe7b4dba3
Update jsdoc codefix tests; test function(...) syntax
2017-07-17 14:11:06 -07:00
Andy
5d46ca7118
Reuse stored types for any[] and Promise<any> instead of creating new ones ( #17179 )
...
* Reuse stored types for any[] and Promise<any> instead of creating new ones
* Don't store anyPromiseType
2017-07-17 12:56:58 -07:00
Andy
2a219af308
convertFunctionToEs6Class: Bail if this is not a JavaScript file ( #17149 )
2017-07-17 12:56:16 -07:00
Andy Hanson
2ce23909b2
Fix error message
2017-07-17 12:39:01 -07:00
Sheetal Nandi
62ef6b1cda
Added another todo as now we are watching too many files
2017-07-17 12:37:36 -07:00
Andy
6cf30fbccf
Fix bug in importTracker: getExportNode must verify that we are on the LHS of a VariableDeclaration ( #17205 )
2017-07-17 12:29:29 -07:00
Andy
555776eb3c
Minor cleanups in builder ( #17208 )
...
* Minor cleanups in builder
* Use enumerateInsertsAndDeletes
2017-07-17 12:24:56 -07:00
Nathan Shively-Sanders
f9e5576d58
Codefix for ?! pre/postfix JSDoc types
...
For ?, provide two code fixes, one for jsdoc/closure semantics
(`?t -> t | null)` and one for flow semantics
(`?t -> t | null | undefined`).
The current way of doing this is the hackiest thing you can imagine, but
it was easier than lifting everything into the list monad for a code fix
that I might not actually keep.
2017-07-17 11:06:20 -07:00
Nathan Shively-Sanders
3776b0b58b
Codefix for Array.<number> -> Array<number>
2017-07-17 10:33:04 -07:00
Nathan Shively-Sanders
dba552d071
Transform trees rather than produce strings
...
1. Still pretty janky.
2. Type Reference code doesn't work yet.
3. Other transforms just aren't done.
4. Always replaces, even when there isn't any transformation of JSDoc
types. (This probably isn't an issue since we wouldn't issue an error unless there were
some JSDoc to change.)
2017-07-17 10:02:29 -07:00
Nathan Shively-Sanders
e98ac8d970
Merge branch 'parse-jsdoc-with-ts-type-parser' into quickfix-jsdoc-in-ts
2017-07-17 08:42:00 -07:00
Nathan Shively-Sanders
240f1f1be4
Merge pull request #17176 from Microsoft/parse-jsdoc-with-ts-type-parser
...
Parse jsdoc with normal TS type parser
2017-07-17 08:41:06 -07:00
Nathan Shively-Sanders
3f60364a64
Improve test of jsdoc literal type parsing
2017-07-17 08:29:40 -07:00
Sheetal Nandi
dcbd7b10f1
Combine the logic to find config file as well as the watch.
...
This should speed up the file open scenarios where the file belongs to same configured project as we would use cache to answer those fileExists answers
2017-07-15 22:26:10 -07:00
Sheetal Nandi
62663a10ba
Use map for configured project instead of the array
2017-07-15 20:12:50 -07:00
Sheetal Nandi
0572b15adc
Instead of watching directories, watch tsconfig files of inferred project root
2017-07-15 19:11:27 -07:00
Sheetal Nandi
00011a52af
Refactor root files addition/update for non inferred project
2017-07-15 15:21:14 -07:00
Sheetal Nandi
f12980dd20
Remove the duplcate error about no input files found
2017-07-15 13:37:22 -07:00
Sheetal Nandi
71d79c62d0
Some refactoring to combine files removal from inferred project
2017-07-15 11:37:32 -07:00
Sheetal Nandi
404aa8f0be
Logging of the watch add/remove/event
2017-07-14 17:39:42 -07:00
Nathan Shively-Sanders
efdba54deb
Add codefix for jsdoc types in Typescript
...
It only handles a few simple types right now, but the skeleton is there.
2017-07-14 16:27:36 -07:00
Nathan Shively-Sanders
a3a6862d43
Add simple jsdoc code fix changes
2017-07-14 16:27:09 -07:00
Andy Hanson
96d537bc54
readFile may return undefined
2017-07-14 15:57:23 -07:00
Nathan Shively-Sanders
61c9f98eef
Merge branch 'master' into parse-jsdoc-with-ts-type-parser
2017-07-14 15:04:06 -07:00
Nathan Shively-Sanders
172db13306
Parse more types in JSDoc function() syntax
...
Also some cleanup from PR comments
2017-07-14 14:34:32 -07:00
Nathan Shively-Sanders
bdc3f1f3f7
Address more PR comments
2017-07-14 13:29:44 -07:00
Daniel Rosenwasser
e8421827e0
Merge pull request #16600 from alexeagle/pretty2
...
Add missing newline in --pretty diagnostics formatter
2017-07-14 12:22:05 -07:00
Nathan Shively-Sanders
b2e892f0b9
Update baselines
2017-07-14 11:08:06 -07:00
Nathan Shively-Sanders
40ae42221e
Better JSDoc generic errors and faster isInJSDoc
2017-07-14 11:07:20 -07:00
Nathan Shively-Sanders
f1145c35ca
Improve JSDoc function checking
...
1. Remove checkJSDocFunctionType in favour of checkSignature.
2. Check that 'new', in addition to 'this', must be the first parameter.
3. Remove prematurely added JSDoc-quickfix test.
2017-07-14 10:15:30 -07:00
Nathan Shively-Sanders
6e861fd3e6
Remove JSDocConstructor/ThisType and just use named parameters
2017-07-14 09:36:12 -07:00
Nathan Shively-Sanders
da5285e979
Update baselines
2017-07-14 09:34:35 -07:00
Sheetal Nandi
0365901381
use single instance of getCanonicalFileName
2017-07-13 15:32:11 -07:00
Nathan Shively-Sanders
d24b3a3cba
Add fourslash tests for function(new/this:T) syntax
2017-07-13 14:49:50 -07:00
Sheetal Nandi
048e67c021
Merge branch 'master' into watchImprovements
2017-07-13 14:13:14 -07:00
Andy
680bfbb705
Combine moduleHasNonRelativeName with isExternalModuleNameRelative ( #16564 )
2017-07-13 13:46:04 -07:00
Nathan Shively-Sanders
ac478a9720
Add missing word in error message
2017-07-13 13:37:35 -07:00
Andy
d2ec45f354
Remove unnecessary 'ts.' qualifications ( #17163 )
2017-07-13 13:08:59 -07:00
Nathan Shively-Sanders
48d9012989
Update baselines
2017-07-13 11:34:56 -07:00
