kingwl
39ae072a1c
add missing semi
2020-05-16 08:10:51 +08:00
kingwl
f78a408ab5
Add more check
2020-05-16 08:10:51 +08:00
kingwl
11bed4456b
avoid shouldCaptureInTempVariable
2020-05-16 08:09:46 +08:00
Daniel Rosenwasser
9681c1611c
Remove newline
2020-05-16 08:09:46 +08:00
kingwl
be708bbb0a
fix assignment check of logical assignment
2020-05-16 08:09:45 +08:00
kingwl
d2be8900dc
Add type narrow
2020-05-16 08:09:45 +08:00
kingwl
67a4943e1f
Add more case
2020-05-16 08:09:43 +08:00
kingwl
81ce254a73
Refactor logical assignment
2020-05-16 08:09:42 +08:00
kingwl
ff4fca527d
Fix cfa
2020-05-16 08:09:40 +08:00
Wenlu Wang
944bcf8459
Update src/compiler/transformers/utilities.ts
...
Co-Authored-By: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
2020-05-16 08:09:39 +08:00
kingwl
ede6214157
Add more check
2020-05-16 08:09:39 +08:00
kingwl
82fe658a48
Add cfa
2020-05-16 08:09:38 +08:00
kingwl
9190a2c4e8
Add contextual types infer
2020-05-16 08:09:38 +08:00
kingwl
f922427196
Add mission semi
2020-05-16 08:09:37 +08:00
kingwl
da16b3e30b
Add more case
2020-05-16 08:09:36 +08:00
kingwl
1d93db81cc
Add logical assignment operator
2020-05-16 08:09:32 +08:00
Eli Barzilay
33c3e9e2c6
Make processTaggedTemplateExpression
visit a returned node
...
This problem was introduced in 70399e146e
(from PR #23801 ), which added
a `visitTaggedTemplateExpression` case for `TaggedTemplateExpression`,
before that, it would fallback to the default of `visitNode`. So re-add
that happen in `processTaggedTemplateExpression`.
Since it doesn't hurt, I left a `Debug.checkDefined(property.name)`
instead of `!`-ing it.
Fixes #38558 .
2020-05-15 19:46:45 -04:00
Ron Buckton
1cbe7ef000
Fix crash in JS declaration emit ( #38508 )
...
* Fix crash in JS decl emit
* Emit as class with private ctor
2020-05-15 14:00:59 -07:00
Wesley Wigham
7fc456f2d7
Include unknown in spread prop override check ( #38577 )
2020-05-14 14:36:38 -07:00
Greg Hurrell
cfc4573c82
Fix (cosmetic) typos in checker.ts comments
...
Just some small things I noticed while looking at some recent PRs.
2020-05-14 19:40:41 +02:00
Anders Hejlsberg
c1f676dd3f
Perform intersection reduction before and after getApparentType ( #38565 )
...
* Perform intersection reduction before and after getApparentType
* Add regression tests
2020-05-13 20:57:17 -07:00
Daniel Rosenwasser
b682ee1a8a
Merge pull request #38489 from microsoft/removeDuplicateInfo
...
Remove duplicate JSDoc comments
2020-05-12 12:52:15 -07:00
Daniel Rosenwasser
c2b559403d
Merge pull request #38502 from alan-agius4/export-star-colon
...
fix: add missing semi-colon to `__exportStar` unnamed function
2020-05-12 10:59:03 -07:00
Nathan Shively-Sanders
cbf15bb6ed
feat(38225): change diagnostic message for remove braces from arrow function body ( #38226 )
2020-05-12 07:27:09 -07:00
Alan Agius
7ec21e93fe
fix: add missing semi-colon to __exportStar
unnamed function
...
Fixes #38501
2020-05-12 13:27:01 +02:00
Daniel Rosenwasser
f9e1bcd0c4
Merge pull request #38439 from lissein/void-0-template-strings
...
Changed template strings to emit void 0 instead of undefined (#38430 )
2020-05-11 17:09:28 -07:00
Daniel
e9867a7353
Add and use the 'intersperse' helper function.
2020-05-11 22:17:01 +00:00
Ron Buckton
d07e866a28
Fix for jsdoc modifiers on constructor params ( #38403 )
...
* Fix for jsdoc modifiers on constructor params
* Update Public API baseline and fix unique symbol grammar check for js
2020-05-11 15:07:43 -07:00
Nathan Shively-Sanders
1a88430a7e
Improve assert message in binder ( #38270 )
...
* Improve assert message in binder
Looking at the code, I don't think the assert can ever fire, but it
clearly does, or did in the past. This will make it easier for people to
create a repro.
* fix lint
* Use BindableStaticNameExpression not BindableStaticAccessExpression
This type does allow identifiers, but those are ruled out earlier, so I added
an assert for that case.
2020-05-11 13:40:54 -07:00
Wenqi
1b7b3eb0f7
report error for duplicate @type declaration ( #38340 )
2020-05-11 12:47:49 -07:00
lissein
946abeadb0
Changed template strings to emit void 0 instead of undefined ( #38430 )
...
undefined is not a keyword in es5 and es3 so we now emit void 0 instead in template strings.
2020-05-09 04:53:14 +02:00
Wesley Wigham
7b03835b77
Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit ( #38368 )
...
* Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit
* Add special lookups test case, rename helper
* Accept slightly modified baselines
2020-05-08 10:46:28 -07:00
Anders Hejlsberg
0091fd6c64
Exclude arrays and tuples from full intersection property check ( #38395 )
...
* Exclude arrays and tuples from full intersection property check
* Add regression test
2020-05-07 15:03:51 -07:00
Anders Hejlsberg
7798f532df
Fix crash caused by assertion with evolving array type ( #38398 )
...
* Properly finalize evolving array type in getTypeAtFlowCall
* Add regression test
2020-05-07 14:05:57 -07:00
Jack Williams
05d59a1f1a
Unify logic in typeof narrowing ( #33434 )
2020-05-06 15:15:24 -07:00
Alexander T
683b3ec058
feat(37782): 'declare method' quick fix for adding a private method ( #37806 )
...
* feat(37782): add quick-fix action to declare a private method for names that start from underscore
* better merge order in messages json
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2020-05-06 15:10:02 -07:00
Wenlu Wang
e66ce879a9
expose jsdoc factory ( #29539 )
...
* expose jsdoc factory
* refactor jsdoc factory
* correctly jsdoc factory types
* update jsdoc factory
* Add check for delete expression must be optional
* accept new basseline
* Revert "Add check for delete expression must be optional"
This reverts commit 76937c3b1a
.
* remove newline
* make linter happy
* Add deprecated comment
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2020-05-06 15:06:12 -07:00
Nathan Shively-Sanders
35c1ba67ba
Update LKG 2020 05 06 ( #38371 )
...
* Update LKG
* remove now-extraneous casts
2020-05-06 14:42:05 -07:00
Josh Goldberg
be2eb8a2e1
Allowed comment directives to be multiline ( #38228 )
...
* Allowed comment directives to be multiline
* Added tests, and perhaps fixed a test runner bug?
* I think it's going to need a consistent variable to loop over
* Used dynamically computed indexes in verifies
* Added multiline tests
* Increased flexibility for multiline comment parsing
* Undid a couple of formatting changes; removed backslashes from multiline regexp
* Added baseline tests for multiline comment skipping
Co-authored-by: Orta Therox <orta.therox@gmail.com>
2020-05-06 13:09:29 -07:00
Ron Buckton
4b08c0582d
Fix regression in name resolution in parameter ( #38351 )
2020-05-06 12:04:28 -07:00
Alexander T
ec93a7cf7b
fix(36055): forbid union type with invalid types in the 'in' operator ( #37786 )
2020-05-06 11:41:50 -07:00
Anders Hejlsberg
2524fb164a
Consistent narrowing by discriminant ( #38311 )
...
* Consistent requirements for narrowing by discriminant
* Add tests
2020-05-05 20:06:07 -07:00
Alexander T
c219fdae08
fix(37703): forbid required parameter after optional ( #38155 )
2020-05-05 10:29:17 -07:00
Marcel Laverdet
44c6cf74cb
Fix updateBinary
operator
parameter ( #38129 )
...
* Fix `updateBinary` `operator` parameter
There is an issue in `updateBinary` where attempting to update
`operator` without updating `left` or `right` results in a silent no-op.
* Use defaulted parameter in `updateBinary`
2020-05-05 09:05:02 -07:00
Anders Hejlsberg
e6390efb01
Properly handle private/protected members in unions of object types ( #38277 )
...
* Property handle private/protected properties in unions of object types
* Add regression test
2020-05-04 15:28:00 -07:00
Wesley Wigham
d9c9c9d9e4
Harden node builder APIs to no longer return undefined
for a node when NodeBuilderFlags.IgnoreErrors
is provided ( #38273 )
2020-05-04 14:47:39 -07:00
Sheetal Nandi
aa37b28246
Fix incorrect line text computation to stop comment directive searching ( #38296 )
...
Fixes #38289
2020-05-04 13:02:54 -07:00
Anders Hejlsberg
a09470f013
Fix index signatures on unions of intersections ( #38278 )
...
* Add missing getApparentType call
* Add regression tests
2020-05-04 12:46:14 -07:00
Eli Barzilay
ba02f4303e
Make getAwaitedType
private
...
Also, fix an additional baseline change and break up huge line.
2020-05-04 13:18:52 -04:00
Alexander T
0503da225d
feat(36266): add a quick fix for incorrect return types in async functions
2020-05-04 13:18:52 -04:00