Commit graph

25385 commits

Author SHA1 Message Date
Benjamin Lichtman 76b0b2f1e8 Add test 2018-09-17 16:23:52 -07:00
Benjamin Lichtman a73b561dd3 Ensure name for callback is generated even when it has no args 2018-09-17 16:23:47 -07:00
Ryan Cavanaugh ba76a8412f
Merge pull request #26935 from ajafff/abstract-baseclass-property
Error accessing abstract property in constructor of abstract subclass
2018-09-17 16:23:34 -07:00
Ryan Cavanaugh 8ca01dfc9f
Merge pull request #26851 from ajafff/assert-compilerhost-readdirectory
Assert CompilerHost.readDiretory for projectReferences with include
2018-09-17 16:13:08 -07:00
Nathan Shively-Sanders 59e4770a51
Fix enum tag circular references (#27161)
* Fix enum tag circular references

Also, don't try to resolve enum tag types in Typescript.

* Improve comment
2018-09-17 16:06:17 -07:00
Benjamin Lichtman 0995869377 Stop creating empty identifier name 2018-09-17 15:53:15 -07:00
Benjamin Lichtman e90679ce6b Add baseline 2018-09-17 15:52:59 -07:00
Benjamin Lichtman 1a3ff452c1 Respond to CR 2018-09-17 15:44:08 -07:00
Sheetal Nandi e3026b0eb3
Merge pull request #27155 from Microsoft/fixIncrementalWatchProjectWithReferences
Fix incremental watch when project built has project references
2018-09-17 15:34:40 -07:00
Andy cfd0a62357
When renaming module, ensure rename span is just the last component of the path (#27151) 2018-09-17 15:26:41 -07:00
Andy 4e3e8f5ea7
convertToAsyncFunction: Reduce casts in getTransformationBody (#27158) 2018-09-17 15:23:44 -07:00
Wesley Wigham a55c0b7df9
Allow drawing inferences to conditional type branches (#27012)
* Allow drawing inferences to conditional type branches

* Fix lint
2018-09-17 15:19:23 -07:00
Wesley Wigham c3b4f72498
Improve indexed access inferences (#27015) 2018-09-17 15:19:11 -07:00
Andy bc709a87ad
Fix bug where array element is undefined (#26433)
* Fix bug where array element is undefined

* Better fix
2018-09-17 15:14:09 -07:00
Ryan Cavanaugh a5326e68d0
Merge pull request #26866 from NMinhNguyen/allowSyntheticDefaultImports-if-esModuleInterop
Enable allowSyntheticDefaultImports if esModuleInterop is enabled
2018-09-17 15:03:28 -07:00
Andy fc54a2c0a7
Include triggerSpan in protocol.RenameInfo (#27160) 2018-09-17 15:00:41 -07:00
Benjamin Lichtman 830b387765 No longer specially recognize underscore and update baselines 2018-09-17 14:34:31 -07:00
TypeScript Bot cd5b9fa7dd Update user baselines (#27141) 2018-09-17 14:19:01 -07:00
Andy bfc00935df
Fix bug: Get mapped location of definition for findAllReferencesFull (#27113) 2018-09-17 14:14:55 -07:00
Nathan Shively-Sanders c9f190283e
Fix non-toplevel prototype assignment (#27096)
* Fix non-toplevel prototype assignment

binder was using the wrong node to lookup the containing class type for
prototype assignment, so it incorrectly put the prototype declaration on
the class' symbol.

This correction to the binder in turn required a change in
getJSClassType in the checker. It now has to look at the "prototype"
property for the prototype instead of looking on the class symbol's exports
(which makes no sense).

* Refactor per PR suggestion
2018-09-17 13:07:05 -07:00
Anders Hejlsberg 17080eb58f Accept new baselines 2018-09-17 13:02:01 -07:00
Anders Hejlsberg eb06af1901 Add tests 2018-09-17 13:01:53 -07:00
Nathan Shively-Sanders 989a717b04
Definite assignment checking for expando properties (#27128) 2018-09-17 12:56:39 -07:00
Sheetal Nandi a5fd3e9176 Handle out and outFile options correctly in tsbuild 2018-09-17 12:46:10 -07:00
Klaus Meinhardt f71030f011 Simply override extendedSourceFiles array 2018-09-17 21:24:26 +02:00
Sheetal Nandi b6129b452f Fix the project reference verification to include json source file version check 2018-09-17 12:18:59 -07:00
Sheetal Nandi aac961e60d Builder to use project reference redirects to output in the dependencies instead of source files 2018-09-17 12:18:59 -07:00
Benjamin Lichtman ad43020c8b Add tests 2018-09-17 11:33:47 -07:00
Benjamin Lichtman 1b9507ad06 Wrap expressions returned from promises in awaits when appropriate 2018-09-17 11:33:28 -07:00
Andy e710645bf9
Never escape string literals from textChanges (#26971)
* Never escape string literals from textChanges

* Use `boolean | undefined`
2018-09-17 11:06:39 -07:00
Andy a57467a317
Fix bugs: Replace SourceFile if '--noUnusedLabels' changed (#27060)
* Fix bugs: Replace SourceFile if '--noUnusedLabels' changed

* Use properties on CommandLineOptionBase

* Handle "alwaysStrict" and better categorize options

* Properly handle "strict"

* Code review

* fix test
2018-09-17 10:53:48 -07:00
Benjamin Lichtman 0016fd72f7 Add test 2018-09-17 09:48:24 -07:00
Benjamin Lichtman f9072621a9 Run callback as expression statement when no arg to assign to exists 2018-09-17 09:48:19 -07:00
Anders Hejlsberg 92c17cebcb Accept new baselines 2018-09-17 09:15:52 -07:00
csigs c615718c3d
LEGO: Merge pull request 27145
LEGO: Merge pull request 27145
2018-09-17 09:10:51 -07:00
csigs 7cc7710503 LEGO: check in for master to temporary branch. 2018-09-17 16:10:23 +00:00
Anders Hejlsberg 46de5067b0 Fix resulting issue in compiler 2018-09-17 09:06:38 -07:00
Anders Hejlsberg acb8b1f65f Correct falsiness for {} empty object type 2018-09-17 09:06:26 -07:00
Klaus Meinhardt 78d221993b fix getExtendedConfig in commandLineParser
* remove invalid assertion
* fix invalid array spread on possibly undefined value
* only add unique files to extendedSourceFiles, preventing the array from growing infinitely
2018-09-17 14:41:48 +02:00
Nathan Shively-Sanders 394ee31a56
Fix cross-file merge of assignment decl valueDeclaration (#26918)
* Fix cross-file merge of assignment decl valueDeclaration

Previously mergeSymbol in the checker always updated valueDeclaration if
target.valueDeclaration was an assignment declaration. The binder only
updates target.valueDeclaration if it is an assignment declaration and
source.valueDeclaration is *not* an assignment declaration. Now the
checker behaves the same way as the binder.

* Update baselines

* Add a fix for #27099

Makes commonjs merge with globals when appropriate.

* Add a separate jsGlobalAugmentations table

Instead of trying to filter these augmentations out of the normal symbol
table of commonjs modules.
2018-09-16 07:46:03 -07:00
Benjamin Lichtman 70ce7abe12
Merge pull request #27109 from uniqueiniquity/diagnosticLocation
Report async code fix diagnostic on name whenever it exists
2018-09-15 18:36:42 -07:00
Wesley Wigham 921863eb31
Use head message at top level of elaboration if elaborating via possible call (#27107)
* Use head message at top level of elaboration if elaborating via possible call

* Accept updated baseline
2018-09-15 13:24:22 -07:00
Sheetal Nandi e4718564e5
Merge pull request #27082 from Microsoft/watchAPIAndProjectReferences
Fix tsc watch and watch API for a project that has project references
2018-09-14 17:58:42 -07:00
Sheetal Nandi 1d22e03db0
Merge pull request #27100 from Microsoft/revertResolveProjectReferencePathAPIChange
Revert the API change to resolveProjectReferencePath introduced in #27062
2018-09-14 17:58:09 -07:00
Benjamin Lichtman 32cb9ece8b Add test 2018-09-14 17:20:46 -07:00
Benjamin Lichtman 9e1a05c9ec Handle function assigned to binding pattern 2018-09-14 17:20:41 -07:00
Benjamin Lichtman 853afd9d56 Add test 2018-09-14 16:34:17 -07:00
Benjamin Lichtman 2c881fd90a Report diagnostic on expression name if it exists 2018-09-14 16:34:16 -07:00
Wesley Wigham 359930a677
Use qutemarks around new instead of ticks around new in diagnostic (#27106)
* Use qutemarks around new instead of ticks

* Accept baselines
2018-09-14 15:57:24 -07:00
Wesley Wigham 20eafb5b74
Introduce boolean literal freshness (#27042) 2018-09-14 15:00:09 -07:00