Martin Probst
a7224ec612
Do not emit comments if container had a comment suppression.
2018-07-18 17:23:27 +02:00
Martin Probst
2529b864f4
Retain synthetic comments on classes and their properties.
2018-07-18 17:23:27 +02:00
Martin Probst
1bd79af760
Reduce duplication of addSyntheticComment.
2018-07-18 16:30:32 +02:00
Martin Probst
6f114a2c9b
Fix comments for import and export declarations.
...
Previously, TypeScript would only set the text range when transforming
import and export declarations, leading it to drop synthetic comments
and emit flags.
This commit sets the original node on the statements that contains the
generated `require()` call (or similar, depending on module system),
retaining emit flags and synthetic comments.
2018-07-18 16:30:32 +02:00
Martin Probst
db888b8670
Retain synthetic comments on exported variables.
...
Variables that do not have a local variable created get transformed into
a single exports assignment expression. TypeScript previously just
created a new expression and set the text range to retain original
comments, but for synthetic comments, merging the emit nodes by setting
the original node is required.
2018-07-18 16:30:32 +02:00
Daniel Rosenwasser
806a5385cc
Accepted baselines.
2018-07-17 21:58:02 -07:00
Daniel Rosenwasser
649f294413
Elaborate on the first non-array type when object literals are compared against 'T | T[]'.
2018-07-17 21:54:33 -07:00
Daniel Rosenwasser
36e26c1a35
Accepted baselines.
2018-07-17 21:52:36 -07:00
Daniel Rosenwasser
bda32aeee2
Added test.
2018-07-17 21:52:24 -07:00
Andy
d92c26db69
Add test that getEditsForFileRename respects UserPreferences ( #25745 )
...
* Add test that getEditsForFileRename respects UserPreferences
* Test quotePreference
2018-07-17 17:05:35 -07:00
Andy
854462d383
Fix formatting at trailing comma ( #25706 )
2018-07-17 15:21:35 -07:00
Andy
6d8a5f6288
Fix invalid cast: JSDocSignature is not a SignatureDeclaration ( #25734 )
2018-07-17 13:35:55 -07:00
Andy
d28fb65a1f
Fix type of TypeParameterDeclaration#parent ( #25737 )
2018-07-17 13:35:34 -07:00
Andy
89f2af17f0
Avoid using old node in import fix to use namespace import ( #25729 )
2018-07-17 13:34:56 -07:00
Mohamed Hegazy
a87ed5335b
Merge pull request #25735 from j-oliveras/Fix_25657
...
Fixes 25657. Jakefile: make concatenateFiles third parameter optional.
2018-07-17 13:12:14 -07:00
Mohamed Hegazy
57a72f507d
Merge pull request #25733 from mattmccutchen/issue-25683
...
Check for optional type parameters before issuing a "wrong number of type arguments" error on a function call.
2018-07-17 12:51:19 -07:00
Jordi Oliveras Rovira
7880a0736f
Fixes 25657. Jakefile: make concatenateFiles third parameter optional.
2018-07-17 20:28:57 +02:00
Matt McCutchen
bd84179d82
Check for optional type parameters before issuing a "wrong number of
...
type arguments" error on a function call.
Fixes #25683 .
2018-07-17 13:25:46 -04:00
Nathan Shively-Sanders
1edc975f15
Revert the revert of explicitly typed special assignments ( #25727 )
...
* Revert "Revert "Explicitly typed special assignments are context sensitive (#25619 )""
This reverts commit 16676f2707
.
* Revert "Revert "Explicitly typed prototype assignments are context sensitive (#25688 )""
This reverts commit ff8c30d636
.
2018-07-17 10:02:51 -07:00
TypeScript Bot
d9ed9177fe
Update user baselines ( #25718 )
2018-07-17 08:37:44 -07:00
Mohamed Hegazy
204ce175dd
Merge pull request #25612 from Microsoft/updateVersionTo3.1
...
Update version
2018-07-16 14:33:25 -07:00
Mohamed Hegazy
75930f87fe
Merge pull request #25699 from Microsoft/revert-explicitly-typed-special-assignments
...
Revert explicitly typed special assignments
2018-07-16 13:15:06 -07:00
Mohamed Hegazy
d690835cb9
Merge pull request #25698 from Microsoft/navigationBarUnrelatedGrandchildren
...
navigationBar: Don't merge unrelated grandchildren
2018-07-16 13:02:35 -07:00
Nathan Shively-Sanders
16676f2707
Revert "Explicitly typed special assignments are context sensitive ( #25619 )"
...
This reverts commit 32e60a9647
.
2018-07-16 12:39:08 -07:00
Andy Hanson
1038c76f88
navigationBar: Don't merge unrelated grandchildren
2018-07-16 12:38:38 -07:00
Nathan Shively-Sanders
ff8c30d636
Revert "Explicitly typed prototype assignments are context sensitive ( #25688 )"
...
This reverts commit 5b21cbc0c9
.
2018-07-16 12:38:27 -07:00
Daniel Rosenwasser
93ab352189
Merge pull request #25565 from Microsoft/popFirst
...
Make 'pop' the first method that uses 'T' in 'Array'
2018-07-16 11:41:44 -07:00
Andy
afdd47c9ce
Simplify rules for isControlFlowEndingStatement
( #25693 )
2018-07-16 11:17:46 -07:00
Mohamed Hegazy
8ef146e658
Merge pull request #25656 from j-oliveras/Fix_25653
...
Change jsDocTagNames to lower case.
2018-07-16 10:18:12 -07:00
Nathan Shively-Sanders
5b21cbc0c9
Explicitly typed prototype assignments are context sensitive ( #25688 )
...
* Explicitly typed prototype assignments:ctx sensitive
Follow up to #25619 : Add the necessary code to type `prototype`
correctly in prototype assignments so that code like
`F.prototype = { ... }` properly makes the object literal context
sensitive.
* Fix lint
2018-07-16 10:03:39 -07:00
Alexander T
bf567b8a40
Change getModifiedTime type
2018-07-16 11:10:09 +03:00
Daniel Rosenwasser
60986adee5
Merge pull request #25507 from ajafff/leftmost-expr-tagged-template
...
getLeftmostExpression: handle TaggedTemplateExpression
2018-07-13 23:56:32 -07:00
Andy
e25a23bb3c
Fix Buffer.from uses to handle node 5.4.1 bug ( #25659 )
2018-07-13 17:08:25 -07:00
Sheetal Nandi
7ad4fcf121
Merge pull request #25649 from Microsoft/jsonFilesOnCommandLine
...
Support resolveJsonModule option when files contain the json file
2018-07-13 16:24:42 -07:00
Jordi Oliveras Rovira
4f411a8cce
Change jsDocTagNames to lower case.
2018-07-14 01:02:20 +02:00
Sheetal Nandi
49ac60f286
Support resolveJsonModule option when files contain the json file
...
Fixes #25636
2018-07-13 12:21:51 -07:00
Sheetal Nandi
47e513e151
Merge pull request #25627 from Microsoft/preserveOutputInConfig
...
Fix incorrect handling of preserveWatchOutput flag is in config file
2018-07-13 10:56:53 -07:00
Andy
3f4412b173
getContainingList: Handle TypeAliasDeclaration ( #25614 )
...
* getContainingList: Handle TypeAliasDeclaration
* Handle ClassExpression and InterfaceDeclaration
2018-07-13 10:30:22 -07:00
Andy
27da9eab8d
fixUnreachableCode: Don't delete whole block when non-first line is unreachable ( #25625 )
2018-07-13 09:57:04 -07:00
Andy
88c6ced3c6
indentMultilineCommentOrJsxText: Fix bug when 'parts' is empty ( #25645 )
2018-07-13 09:56:21 -07:00
Sheetal Nandi
ca083809a4
Fix incorrect handling of preserveWatchOutput flag is in config file
...
Fixes #25620
2018-07-12 18:29:02 -07:00
Andy
1fb050bcca
Don't report unused diagnostics when the unused node has a parse error ( #25598 )
...
* Don't report unused diagnostics when the unused node has a parse error
* Update test
2018-07-12 17:24:59 -07:00
Nathan Shively-Sanders
32e60a9647
Explicitly typed special assignments are context sensitive ( #25619 )
...
* Explicitly typed js assignments: context sensitive
Explicitly typed special assignments should be context sensitive if they
have an explicit type tag. Previously no special assignments were
context sensitive because they are declarations, and in the common,
untyped, case we inspect the right side of the assignment to get the
type of the left side, and inspect the right side of the assignment to
get the type of the left side, etc etc.
Note that some special assignments still return `any` from
checkExpression, so still don't get the right type.
Fixes #25571
* Change prototype property handling+update bselines
* Fix indentation in test
* Update baselines
2018-07-12 15:28:53 -07:00
Andy
f500289a44
Stricter test that JSDoc @type tag matches function signature ( #25615 )
2018-07-12 14:02:02 -07:00
Ryan Cavanaugh
6a2ffec53d
Merge pull request #25610 from RyanCavanaugh/buildOnWatchStartup
...
When running with -w, do an initial compilation
2018-07-12 12:51:16 -07:00
Anders Hejlsberg
0f8b6fcd27
Merge pull request #25608 from Microsoft/genericRestArityCheck
...
Fix generic rest parameter arity checks
2018-07-12 09:09:31 -10:00
Andy
af412e39cf
mapTextChangesToCodeEditsUsingScriptInfo: Handle tsconfig.json text change ( #25586 )
...
* mapTextChangesToCodeEditsUsingScriptInfo: Handle tsconfig.json text change
* Can't use `program.getSourceFile()` to determine file existence when multiple projects exist
* Use direct union instead of discriminated union
2018-07-12 12:09:04 -07:00
Mohamed Hegazy
abbaf0d06a
Update issue template
2018-07-12 11:53:04 -07:00
Mohamed Hegazy
cf18361080
Accept baselines
2018-07-12 11:51:55 -07:00
Mohamed Hegazy
ec6e37ec62
Update version
2018-07-12 11:37:19 -07:00