* If target:esnext,then useDefineForClassFields: true will now be the default.
* Added error if a private identifier is used in a static a initializer if target:ESNext and useDefineForClassFields:false.
* Added test for new useDefineForClassFields default and error message.
* Fixed tests after changing the default of useDefineForClassFields to true for target esnext
* Fixed code review suggestions.
* Updated error message.
* Added missing static check for the containing property. Fixed other code review issues.
* Support Top Level "for await of".
* Add test cases for top level "for await of".
* Apply suggestions from code review
* add test cases
* remove redundant variables
* fix test baselines
* Update diagnostic message and tests
Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>
* Allow type-only ImportEqualsDeclarations
* Suppress CJS-in-ESM error when type-only
* Add grammar error on import type in import alias
* Update API baselines
* Fix importsNotUsedAsValues with ImportEqualsDeclarations
* Make bad error talk words more good for Daniel. Fixes#41603
* One more error message baseline update
* Update transformer and emitter
* Handle when files get checked in different orders
* Fix interface extends clause
* Fix import= something type only from a module
* Revert apparently unnecessary addition
* Revert "Revert apparently unnecessary addition"
This reverts commit 7444b0b72e.
* Disallow `import = a.b.c` on anything with type-only imports
* Safety first
* Add test for TS Server single-file open
* Add big comment
* Extract error reporting function for import aliases
* Delete blank line
* Un-export, comment, and colocate some utils
* Combine 3 type-only marking function calls into one
* Add more export default tests
* Change type-only semantics to allow type queries
* Don’t error using type-only import in ambient context
* Fix default import
* Fix namespace import
* Update more baselines
* Prevent circular resolution
* Track const enum expression usage
* Update baselines
* Perf tuning 1
* Test commit for perf impact
* Weave type-only alias declaration finding into alias resolution
* Fix namespace import of type-only exported symbols
* type-only exports do not contribute to the module object type
* Update APIs
* Fix enum casing, remove type-only conversion suggestion
* Short circuit type-only checks in resolveEntityName faster
* Fix casing in API
* Remove unused parameter
* Fix error on qualified names in type queries
* Allow type-only imports in computed property names
* Fix computed property names of types and abstract members
* Remove unused util
* Commit missing baselines
* Rename “check” functions so as not to overload the word “check”
* Add type-only support for export declarations
* Use a synthetic type alias instead of binding type-only exports as a type alias
* Works for re-exports!
* isolatedModules works fine
* Diagnostic for type-only exporting a value
* Start isolated modules codefix
* Update for LKG control flow changes
* Type-only import clause parsing
* Type-only default import checking
* Type-only named imports
* Fix isolated modules error
* Filter namespaces down to type-only
* Fix class references
* Test nested namespaces
* Test circular type-only imports/exports
* Fix getTypeAtLocation for type-only import/export specifiers
* Fix type-only generic imports
* Update public APIs
* Remove unused WIP comment
* Type-only namespace imports
* Fix factory update calls
* Add grammar errors for JS usage and mixing default and named bindings
* Update updateExportDeclaration API baseline
* Fix grammar checking import clauses
* Enums, sort of
* Dedicated error for type-only enum
* Skip past type-only alias symbols in quick info
* Update error code in baseline
* WIP: convertToTypeOnlyExport
* isolatedModules codefix (single export declaration)
* isolatedModules code fix (all)
* Stop eliding non-type-only imports by default, add compiler flag
* Update to match updated diagnostic messages
* Update more baselines
* Update more tests
* Auto-import as type-only
* Add codefix for splitting type-only import with default and named bindings
* Add more services tests
* Add targeted error message for "export type T;" when T exists
* Add targeted error for "import type T = require(...)"
* Flip emit flag
* Add test for preserveUnusedImports option
* Fix flag flip on import =
* Make compiler option string-valued
* Fix merge conflicts
* Add --importsNotUsedAsValue=error
* Phrasing of messages.
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
* Update LKG
* Update version
* Update LKG
* Skip overloads with too-short function parameters
If the parameter of an overload is a function and the argument is also a
function, skip the overload if the parameter has fewer arguments than
the argument does. That overload cannot possibly apply, and should not
participate in, for example, contextual typing.
Example:
```ts
interface I {
(a: number): void;
(b: string, c): void;
}
declare function f(i: I): void;
f((x, y) => {});
```
This code now skips the first overload instead of considering.
This was a longstanding bug but was only uncovered now that more
functions expressions are context sensitive.
* Test skip overloads w/too-short function params
1. Update changed baseline.
2. Add a new test with baseline.
* Minor style improvements
* Ignore optionality when skipping overloads
* Do not use contextual signatures with too few parameters
* isAritySmaller runs later: getNonGenericSignature
* rewrite void-returning statements in constructors that capture result of super call (#11868)
* rewrite void-returning statements in constructors that capture result of super call
* linter
* Update LKG
* Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters
* Add tests and baselines
* Skip trying to use alias if there is target type
* Update baselines
* Add diagnostics to remind adding tsconfig file for certain external project (#11932)
* Add diagnostics for certain external project
* Show tsconfig suggestion
* fix lint error
* Address pr
* fix comment
* Update error message
* Flag for not overwrite js files by default without generating errors (#11980)
* WIP
* Properly naming things
* refactor
* apply the option to all files and check out options
* Fix typo
* Update LKG
* lockLinter
* use local registry to check if typings package exist (#12014) (#12032)
use local registry to check if typings package exist
* Add test for https://github.com/Microsoft/TypeScript/pull/11980 (#12027)
* add test for the fix for overwrite emitting error
* cr feedback
* enable sending telemetry events to tsserver client (#12034) (#12051)
enable sending telemetry events
* Update LKG
* Reuse subtree transform flags for incrementally parsed nodes (#12088)
* Update LKG
* Update version
* Update LKG
* Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module
* Add tests and baselines
* [Release 2.1] fix11754 global augmentation (#12133)
* Exclude global augmentation from module resolution logic
* Address PR: check using string literal instead of NodeFlags.globalAugmentation
* Remove comment
* Improve error message
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix#10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Don't allow ".d.ts" extension in an import either.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes#10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* wip - fix error
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* Fix error from using merging master
* avoid using the global name
* Fix single-quote lint
* Update baselines
* Fix linting
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Rename 'find' functions
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes#10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Assign and instantiate contextual this type if not present
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* JSDoc supports null, undefined and never types
* Update baselines in jsDocParsing unit tests
* Restored comments to explain spreading 'arguments' into calls to 'super'.
* Added test.
* Use the non-nullable type of the contextual type for object completions.
* Return non-JsDocComment children
... to make syntactic classification work
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
* Move supportedTypescriptExtensionsWithDtsFirst next to supportedTypeScriptExtensions and rename
* Fix comment
* Fix RWC Runner (#10420)
* Use /// <reference types
* Don't report an errors if it comes from lib.d.ts
* Treat special property access symbol differently
... when retriving documentation
* Fix tests
* Update shim version to be 2.1 (#10424)
* Check return code paths on getters (#10102)
* Check return paths on getters
* Remove TODO comment
* Remove extraneous arguments from harness's runBaseline (#10419)
* Remove extraneous arguments from runBaseline
* Address comments from @yuit
* Remove needless call to basename
* Refactor baseliners out of compiler runner (#10440)
* CR feedback
* fix broken tests
* Pass in baselineOpts into types baselines so that RWC baselines can be written to internal folder (#10443)
* Add error message
Add error message when trying to relate primitives to the boxed/apparent
backing types.
* fix linting error
* follow advise
* remove extra code
* Add more test for 10426
* fix some errors
* routine update of dom libs
* Add test for jsdoc syntactic classification for function declaration
* Simplify implementation
* Tolerate certain errors in tsconfig.json
* Add test for configFile error tolerance
* Use TS parser to tolerate more errors in tsconfig.json
* Implement tuple types as type references to synthesized generic types
* Add comments + minor changes
* Accept new baselines
* Add .types extension
* Properly guard for undefined in getTypeReferenceArity
* Add jsdoc nullable union test case to fourslash
* Fix class/interface merging issue + lint error
* Allow "typings" in a package.json to be missing its extension (but also allow it to have an extension)
* Contextually type this in getDeclFromSig, not checkThisExpr
* Update parser comment with es7 grammar (#10459)
* Use ES7 term of ExponentiationExpression
* Update timeout for mac OS
* Address PR: add space
* allowSyntheticDefaultImports resolves to modules instead of variables
Fixes#10429 by improving the fix in #10096
* Rename getContextuallyTypedThisParameter to getContextualThisParameter
* Fix 10472: Invalid emitted code for await expression (#10483)
* Properly emit await expression with yield expression
* Add tests and update baselines
* Move parsing await expression into parse unary-expression
* Update incorrect comment
* change error message
* Fix broken build from merging with master
* Fix linting error
* Remove check narrowing only certain types, add test showing issues with this
* string literal case test
* Reconcile fix with CFA work
* Defaultable -> NotNarrowable to align with use
* Missed a defaultable in comments
* Add test for narrowing to unions of string literals
* Rewrite isInStringLiteral to accomodate for unterminated strings
* Refactor signatureHelp to expose helper functions
* Add support for completion in string literals
* Remove unused check
* Use const instead of let
* Fix error
* Formatting changes
* Use shorthand properties
* Add failing test for #8738
* Sort baseline reference identifier by name
* Detects assignment to internal module export clause, fixes#8738
* add SharedArrayBuffer
fix
* Factor out assignment op check
* Add test for composite assignment
* Factor out the behaviour and handles x++ and ++x
* Handles ES3 default as identifier name
* Fix missing else statement
* isNameOfExportedDeclarationInNonES6Module
* Reorder options alphabetically
* Mark diagnostics, and skipDefaultLibCheck as internal
* Allow an import of "foo.js" to be matched by a file "foo.ts"
* Improve loadModuleFromFile code
* Respond to PR comments
* Respond to more PR comments
* Fix test
* Actually merge from master
* Revert to old tryLoad implementation
* Run fixupParentReferences when parsing isolated jsDocComment
* initial revision of unit test support for project system in tsserver
* Allow wildcard ("*") patterns in ambient module declarations
* Add non-widening forms of null and undefined
* Create separate control flows for property declarations with initializers
* Add regression test
* Allow trailing commas in function parameter and argument lists
* Add tests
* Remove unused variable
* Add null check and CR feedback
* Support shorthand ambient module declarations
* Revert "Merge pull request #7235 from weswigham/narrow-all-types"
This reverts commit ef0f6c8fe4, reversing
changes made to 9f087cb62a.
* reuse the fixupParentReferences function
* Improve typing of && operator with --strictNullChecks
* Add test
* Respond to PR comments
* Respond to PR comments
* Add merging tests
* Use a function `stringify` to simplify calls to `JSON.stringify(xyz, undefined, 2)`
* Update tests
* Fix mistake
* Include indent in navigation bar protocol
Previously navbar01 test had indents when run in the browser but not when run from node. Now they run the same.
* Remove unnecessary restrictions in property access narrowing
* Fix fourslash test
* Add regression test
* Consider property declarations to be control flow containers
* Adding regression test
* Remove restriction on --target es5 and --module es6
* change type definition for Object.create
* Fix signature help
* Add "implicit any" warning for shorthand ambient modules
* Remove trailing whitespace
* Support using string values in enums for CompilerOptions in transpile methods
* Remove trailing whitespace in jakefile
* Make `jake runtests-browser` support test regexes with spaces
For example: `jake runtests-browser t="transpile .js files"` now works.
* Add another test
* factor out isJsxOrTsxExtension
* Move to a conformance test
* Revert "Revert "Merge pull request #7235 from weswigham/narrow-all-types""
This reverts commit fc3e040c51.
* Use inclusive flag, as originally done, but include almost everything
* Add additional tests
* Respond to PR comments
* Fix typo
* add tests for tsserver project system
* Fix test
* Allow case comparison to undefined and null in strict null checking mode
* Remove incorrectly added tests
* check if moduleResolution when verifying that program can be reused
* more tests for module resolution change and exclude
* Fix linting issues
* Merge JSDoc of assignments from function expressions
* Allow nested assignments in type guards
* Add tests
* Improve order of parameter's merged jsdoc
* Force LF newlines for LKG builds/non debug builds
Fixes 6630
* Create intersection types in type guards for unrelated types
* Split commentsFunction test into expr/decl
And renumber.
* Remove TODO comments
* Accept new baselines
* Add tests
* Remove comments
* Fix test helper
* Recognize relative path using in outDir property (#9025)
* Recognize relative path using in outDir property
* Add projects tests
* Add project .json files
* Update baselines
* Add comments
* Add test case
The test passes in 1.8 and fails in master.
* Return trace when exception happens
* Remove Long-Done TODO
AFAIK, the harness sources have been concatenated into `run.js` for as long as I've known. This stops executing them twice (and in turn makes debugging tests much easier, since you no longer have to debug into eval'd code).
* Allow primitive type guards with typeof on right
Previously, only type guards of the form `typeof x === 'string'` were
allowed. Now you can write `'string' === typeof x`.
* Primitive type guards are now order independent
* Fix comments in tests
* Add handleing for classes
* Add more tests for target=es5 module=es6
* addExportToArgumentListKind
* Accept baseline
* Add more tests
* wip-fixing transforms
* Adds progress indicators to the runtests-parallel build task.
* Fixed typo
* Fix comment
* Add test for out-of-range error
* Use proper method of not resolving alias
* Fix module loading error
(commandLineOptions_stringToEnum would be undefined if optionDeclarations wasn't loaded yet)
* Port 8739
* Update tests
* Update baselines
* Contextually type return statement in async function
* Remove stale files
* Undo change
* Improve perf
* Improve tests
* Fix sourcemaps for debugging tests
* Allow --sourceRoot with --inlineSources option
Fixes#8445
* this in parameter initializers resolves to class
Accept baselines now that the test passes.
* Add tests for more kinds of import/export
* Fix7334 Disallow async in functionExpression and ArrowFunction (#9062)
* Error when using async modifier in function-expression and arrow-function when target es5
* Add tests and baselines
* Resolve function-this in parameter initialisers when explicitly provided
* Allow null/undefined guard with null/undefined on left
Also add a test with baselines.
* Code review comments
* Update more diagnostic messages ES6->2015
Fix#8996 CC @mhegazy.
* Fixes an issue with runtests-parallel when global mocha is not installed.
* Update LKG
* Add tests
* fix baselines
* Recommend runtests-parallel in CONTRIBUTING
* Only inlineSourceMap when debugging through jake-browser (#9080)
* Only inlineSourceMap when debugging through jake-browser
* Address PR: fix typo in opt's property
* Manually port tests from PR 8470
* minor fix: add missing return clause
* Support using string values in enums for CompilerOptions in transpile methods
* Support using string values in enums for CompilerOptions in transpile methods
# Conflicts:
# tests/cases/unittests/transpile.ts
* Fix test helper
* Add test for out-of-range error
* Fix module loading error
(commandLineOptions_stringToEnum would be undefined if optionDeclarations wasn't loaded yet)
* Use camel-case instead of snake-case (#9134)
* Manually add tests for PR 8988
* Allow wildcard ("*") patterns in ambient module declarations
* Respond to PR comments
* Add another test
* Improve perf
* Improve tests
* Update baseline from merging with master
* Address PR comment
* Update baseline
* Refactor how we retrieve binding-name cache in module transformer
* Temporary accept so we get a clean run-tests result
