Commit graph

22392 commits

Author SHA1 Message Date
Anders Hejlsberg dc42febf1e Accept new baselines 2018-03-28 13:16:36 -07:00
Anders Hejlsberg 0e446fe8c2 Add regression test 2018-03-28 13:16:29 -07:00
Anders Hejlsberg dc3eb3c27e Erase 'infer T' locations in conditional type constraints 2018-03-28 13:16:11 -07:00
Wenlu Wang cb9f436b54 fix accessor parse with line terminator (#22893) 2018-03-28 10:59:09 -07:00
Nathan Shively-Sanders adf30dd694
isMethodLike recognises prototype-assignment methods (#22935)
* isMethodLike recognises prototype-assignment methods

* Require js prototype methods to be in JS files
2018-03-28 10:41:24 -07:00
Mohamed Hegazy 66bf5b4e9d
Merge pull request #22941 from andfaulkner/patch-1
Fix typo in Array Type Literals section of spec
2018-03-27 22:04:23 -07:00
Andrew Faulkner 0e40308792
Fix typo in Array Type Literals section of spec
Extra end bracket in 1st example code block under Array Type Literals subsection of the spec
2018-03-27 23:42:01 -04:00
Andy e60348be46
Inline isParameterOfConstructorDeclaration (#22838) 2018-03-27 20:15:43 -07:00
Andy 659dc03f68
completions: isNewIdentifierLocation = false for string literal where all legal values are known (#22933) 2018-03-27 19:36:54 -07:00
Andy 6118f211d1
Add 'isParameterPropertyModifier' helper (#22841) 2018-03-27 19:36:42 -07:00
Andy 4f1656035b
findAllReferences: Consistently use getTextSpan (#22847)
* findAllReferences: Consistently use getTextSpan

* Remove initializer
2018-03-27 19:36:16 -07:00
Wesley Wigham ddb7bb22dc
Add regression test for GH #21871 (#22733) 2018-03-27 19:28:58 -07:00
Andy b518120883
findAllReferences: Respect search file set searching for references to an exported symbol (#22657)
* findAllReferences: Respect search file set searching for references to an exported symbol

* Remove debugging code
2018-03-27 18:48:27 -07:00
Andy 3e32e15895
Add 'fixAllDescription' property to CodeFixAction (#22616)
* Add 'fixAllDescription' property to CodeFixAction

* Code review

* Add to protocol

* Make fixAllDescription be just a string
2018-03-27 18:21:21 -07:00
Andy 2cbad6ab06
Support completion details for string literal completions (#22664) 2018-03-27 17:02:04 -07:00
Mohamed Hegazy 4699c829de
Merge pull request #22898 from Kingwl/fix-return-type-lookup-rule
fix type lookup rule
2018-03-27 17:01:56 -07:00
Andy b9f48c1d5d
refactorConvertToEs6Module: Preserve quote style of imports (#22929) 2018-03-27 17:01:31 -07:00
Andy 07a890dbbb
Reuse getBinaryOperatorPrecedence (#22844)
* Reuse getBinaryOperatorPrecedence

* Code review

* Consistently sort cases in ascending order
2018-03-27 16:38:39 -07:00
Andy 47d768ceb3
Anything after Debug.failBadSyntaxKind is dead code (#22922) 2018-03-27 15:36:05 -07:00
Wesley Wigham 1db769d566
Transform setter bodies if they contain es2015 (#22931) 2018-03-27 15:16:56 -07:00
Andy 6ef4d7774a
Always test replacementSpan, and don't provide if it would just be an identifier (#22918) 2018-03-27 15:15:50 -07:00
Andy 0a2c160dd1
Debug.failBadSyntaxKind should always be defined and return 'never' (#22091) 2018-03-27 13:35:48 -07:00
Andy 21cd68dd04
Test for isNewIdentifierLocation, and make true for type with index signature (#22910) 2018-03-27 13:05:41 -07:00
Andy ccd6a010e0
completions: Use keywordForNode helper instead of .getText() (#22751) 2018-03-27 12:56:30 -07:00
Nathan Shively-Sanders 61aad4c7b8
Handle toplevel this-assignment (#22913)
Do nothing now. Someday we might handle it correctly.
2018-03-27 12:24:37 -07:00
Andy 2bd66b3292
textChanges: Add insertCommentBeforeLine method (#22902) 2018-03-27 11:50:48 -07:00
Andy e9e1d0d70b
textChanges: Use InsertNodeOptions instead of ChangeNodeOptions where possible (#22903) 2018-03-27 11:50:34 -07:00
Andy 85f11cc5e4
textChanges: Use replaceRange in more places (#22904) 2018-03-27 10:57:42 -07:00
Andy ea6740fa91
replaceNode: Always use non-adjusted end (#22519)
* replaceNode: Always use non-adjusted end

* Never adjust start position either

* Fix excess property checks, remove unnecessary arguments

* Make 'insertText' and 'newLineCharacter' private

* Use replaceNode in one more place now that it doesn't affect comments

* Update replaceNodeRange too

* Always ask for ChangeNodeOptions
2018-03-27 10:34:16 -07:00
Kevin Donnelly 4fa96056ea Make T[never] = never instead of erroring or being any (#22787)
* Add tests showing existing behavior for indexing types with never.

* Make T[never] = never instead of erroring or being any.

And update the baselines for the tests for this change.

* Add test case for indexing an expression with never showing existing behavior.

* Make indexing an object with never expression result in never.

And update baseline to reflect new behavior.
2018-03-27 07:45:25 -07:00
王文璐 9b7e5e212f fix type lookup rule 2018-03-27 17:37:19 +08:00
Arthur Ozga 1ced600efe pass in sourceFile and revert child to TextRangeOfKind 2018-03-26 17:53:50 -07:00
Arthur Ozga 6786d7473d fix test 2018-03-26 16:53:20 -07:00
Arthur Ozga b86b923aef Merge branch 'master' into dev/aozgaa/cSharpObjLiteralFormatting 2018-03-26 16:45:19 -07:00
Arthur Ozga d41070a966 more tests 2018-03-26 16:37:55 -07:00
Wesley Wigham dcbc478efa
Tighten heuristic for definite dts moduleness to check for syntactic default (#22814)
* Tighten heuristic for definite dts moduleness to check for syntactic default exports

* Inline function
2018-03-26 16:35:03 -07:00
Mohamed Hegazy 36b49c06cd
Merge pull request #22775 from adriengibrat/FixFunctionApplyDefinition
Fix function.apply type definition
2018-03-26 16:34:24 -07:00
Andy a9d65b8b00
textChanges: Clean up *Options interfaces (#22813) 2018-03-26 15:34:58 -07:00
Mohamed Hegazy faa3fca247
Merge pull request #22886 from Microsoft/Fix22866
Fix #22866: Condition checking for name collision of generated variable names on emit happening
2018-03-26 14:24:59 -07:00
Adrien Gibrat 4f0a2e24e4 Fix function.apply type definition
Thanks @DanielRosenwasser #fix 22600
2018-03-26 23:11:16 +02:00
Andy ced4c00522
importFixes: Distinguish when we need to import JSX constructor or JSX namespace (#22828) 2018-03-26 14:05:03 -07:00
Mohamed Hegazy 2483719e6e Fix lint issues 2018-03-26 13:49:57 -07:00
Nathan Shively-Sanders c9ac15ae56
In JS, this assignments in constructors are preferred and nullable initializers become any (#22882)
* First draft:in js, constructor declaration is preferred

* Add tests

* initializer of null|undefined gives any in JS

Also move this-assignment fixes out of binder. I'm going to put it in
the checker instead.

* In JS, initializer null|undefined: any, []: any[]

* First draft of js prefer-ctor-types overhaul

* Update tests, update baselines

* Improve readability of constructor-type preference

* Cleanup: Remove TODO and duplication

* Add noImplicitAny errors

* Add comment
2018-03-26 13:42:34 -07:00
Andy fa794f6ee1
Remove unnecessary 'forEachEntry' call (#22653) 2018-03-26 13:04:47 -07:00
Mohamed Hegazy 7fd602e594 Fix #22866: Condition checking for name collision of generated variable names on emit happening 2018-03-26 13:02:09 -07:00
Wesley Wigham 6af764c560
Declaration maps and transparent goto definition using them (#22658)
* Add compiler option to enable declaration sourcemaps

* Transparent goto definition for sourcemapped declaration files

* Post-rebase touchups

* Rename API methods

* Fix lints

* Fix typo in name XD

* Log sourcemap decode errors

* Share the cache more, but also invalidate it more

* Remove todo

* Enable mapping on go to implementation as well

* Allow fourslash to test declaration maps mroe easily

* more test

* Handle sourceRoot

* Add tests documenting current behavior with other sourcemapping flags

* Ignore inline options for declaration file maps, simplify dispatch in emitter

* Change program diagnostic

* Fix nit

* Use charCodeAt

* Rename internal methods + veriables

* Avoid filter

* span -> position

* Use character codes

* Dont parse our sourcemap names until we need to start using them

* zero-index parsed positions

* Handle sourceMappingURL comments, including base64 encoded ones

* Unittest b64 decoder, make mroe robust to handle unicode properly

* Fix lint

* declarationMaps -> declarationMap

* Even more feedback

* USE Mroe lenient combined regexp

* only match base64 characters

* Fix nit
2018-03-26 12:15:34 -07:00
Anders Hejlsberg fe8f239648
Merge pull request #22869 from Microsoft/fixConditionalTypeVariance
Fix conditional type variance
2018-03-26 09:36:16 -07:00
Anders Hejlsberg d7df84d641
Merge pull request #22850 from Microsoft/tupleTypeInference
Only make inferences from tuple types of right arity
2018-03-26 09:35:45 -07:00
Andy fdc468976e
Remove unused function (#22848) 2018-03-26 08:03:24 -07:00
Anders Hejlsberg 9acdb7575e Accept new baselines 2018-03-25 15:32:06 -07:00