Commit graph

23599 commits

Author SHA1 Message Date
Sheetal Nandi
a0d4e4f059 Fix getter of local symbol for export= when it is json module
Fixes #24341
2018-05-22 17:10:56 -07:00
Wesley Wigham
44da834551
Add fix option to lint task (#24344) 2018-05-22 17:01:45 -07:00
Wesley Wigham
7e4b20e587
Use compare paths for comparing diagnostic paths, since the canonicalization of fileName and unitName differ (#24340) 2018-05-22 17:01:34 -07:00
Wesley Wigham
0102f8050c
Check for keyof constraint type instead of syntactic check (#24098)
* Check for keyof constraint type instead of syntactic check

* Readopt older candidateType check, even though it shouldnt really matter

* OK. Just use maybetypeOfKind

* Remove redundant boolean check
2018-05-22 16:58:31 -07:00
Wesley Wigham
8b8cd31784
Use unknown serialization kind when type symbol isnt resolved (#24332)
* Use unknown serialization kind when type symbol isnt resolved

* Add test for the isolated modules case
2018-05-22 16:56:12 -07:00
Andy
aed0eb6693
Improve verify.codeFixAvailable (#24325)
* Improve verify.codeFixAvailable

* Revert change to `verify.not.codeFixAvailable()`, and use `assertObjectsEqual` for better errors
2018-05-22 16:04:39 -07:00
Andy
56f33ad3bb
Remove duplicate class 'NodeSet' (#24337) 2018-05-22 15:33:03 -07:00
Andy
ba63f49513
moveToNewFile: Don't provide refactor if selection is just imports (#24336) 2018-05-22 15:21:04 -07:00
Andy
e53e56cf82
Enable '--strictNullChecks' (#22088)
* Enable '--strictNullChecks'

* Fix API baselines

* Make sys.getEnvironmentVariable non-nullable

* make properties optional instead of using `| undefined` in thier type

* reportDiagnostics should be required

* Declare firstAccessor as non-nullable

* Make `some` a type guard

* Fix `getEnvironmentVariable` definition in tests

* Pretend transformFlags are always defined

* Fix one more use of sys.getEnvironmentVariable

* `requiredResponse` accepts undefined, remove assertions

* Mark optional properties as optional instead of using `| undefined`

* Mark optional properties as optional instead of using ` | undefined`

* Remove unnecessary null assertions

* Put the bang on the declaration instead of every use

* Make `createMapFromTemplate` require a parameter

* Mark `EmitResult.emittedFiles` and `EmitResult.sourceMaps` as optional

* Plumb through undefined in emitLsit and EmitExpressionList

* `ElementAccessExpression.argumentExpression` can not be `undefined`

* Add overloads for `writeTokenText`

* Make `shouldWriteSeparatingLineTerminator` argument non-nullable

* Make `synthesizedNodeStartsOnNewLine` argument required

* `PropertyAssignment.initializer` cannot be undefined

* Use one `!` at declaration site instead of on every use site

* Capture host in a constant and avoid null assertions

* Remove few more unused assertions

* Update baselines

* Use parameter defaults

* Update baselines

* Fix lint

* Make Symbol#valueDeclaration and Symbol#declarations non-optional to reduce assertions

* Make Node#symbol and Type#symbol non-optional to reduce assertions

* Make `flags` non-nullable to reduce assertions

* Convert some asserts to type guards

* Make `isNonLocalAlias` a type guard

* Add overload for `getSymbolOfNode` for `Declaration`

* Some more `getSymbolOfNode` changes

* Push undefined suppression into `typeToTypeNodeHelper`

* `NodeBuilderContext.tracker` is never `undefined`

* use `Debug.assertDefined`

* Remove unnecessary tag

* Mark `LiteralType.freshType` and `LiteralTupe.regularType` as required
2018-05-22 14:46:57 -07:00
Wesley Wigham
3fe946df78
Use symbolToTypeNode for class & interface references (#24330)
* Use merged symbols when calculating qualification, use symbolToTypeNode

* Accept baselines
2018-05-22 14:09:45 -07:00
Andy
5622bc2dd6
moveToNewFile: Support selecting the name of a declaration (#24331) 2018-05-22 14:00:29 -07:00
Andy Hanson
900e269872 Don't need to check failedLookupLocations if resolved successfully 2018-05-22 13:39:30 -07:00
Andy
9cda2bdba0
Support recommended completion for union (#24326)
* Support recommended completion for union

* Fix for empty enum, which is not a union
2018-05-22 13:38:28 -07:00
Andy
694a985b49
For completions, treat a '// @ts-check' file like a TypeScript one (#24321) 2018-05-22 13:06:59 -07:00
Armando Aguirre
b5d882ebd6
Merge pull request #24262 from armanio123/FixObjectLiteralExpression
Fix issue with formatting object literal csharp style
2018-05-22 12:39:14 -07:00
Andy Hanson
46eaf62abb getEditsForFileRename: Handle old file still being present 2018-05-22 12:20:34 -07:00
Sheetal Nandi
f44dd6f53b
Merge pull request #24206 from Microsoft/documentRegistery
Cache the latest source file from document registery in script info so that we do not have to reparse orphan script info
2018-05-22 12:11:16 -07:00
Sheetal Nandi
e8a0e56e3e Add a test when orphan file changes before it gets added back to project 2018-05-22 11:45:52 -07:00
Andrew Casey
bedc110c74
Merge pull request #24311 from amcasey/GH23287
Preserve jsx imports even when the compiler option is not set
2018-05-22 11:23:15 -07:00
Sheetal Nandi
66590a9391 Verify ref counts are set correctly when reusing the source file from script info cache 2018-05-22 11:18:40 -07:00
Andy
7106a587cc
Add type for diagnostics where location is defined (#23686)
* Add type for diagnostics where location is defined

* getSemanticDiagnostics may return global diagnostics

* Reduce array creation
2018-05-22 11:01:18 -07:00
Mohamed Hegazy
7fb3123984
Merge pull request #24298 from Microsoft/noErrOnBackgroundUpdate
Add noGetErrOnBackgroundUpdate session option to not queue diagnostics check for open files
2018-05-22 10:56:18 -07:00
Andrew Casey
2e0cc63067 Check TransformFlags.ContainsJsx, rather than LanguageVariant.JSX 2018-05-22 10:51:19 -07:00
Anders Hejlsberg
a5029e3d4e
Merge pull request #23794 from Microsoft/fixDiscriminatedContextualType
Fix discriminant checking in contextual types
2018-05-22 10:35:29 -07:00
Mohamed Hegazy
9d57903630
Merge pull request #24312 from Kingwl/multiline-type-literal-formatter
fix wrong formatting with multiline type literals with IntersectionTy…
2018-05-22 10:06:24 -07:00
TypeScript Bot
a8715d0c10 Update user baselines (#24289) 2018-05-22 09:52:58 -07:00
Mine Starks
5e5c5a761a
Merge pull request #24139 from minestarks/dynamicprojectassert
Normalize ProjectService.currentDirectory
2018-05-22 09:04:45 -07:00
Andy
982c8d0af9
Add suggestion diagnostics for unused label and unreachable code (#24261)
* Add suggestion diagnostics for unused label and unreachable code

* Always error on unused left hand side of comma
2018-05-22 07:56:29 -07:00
Anders Hejlsberg
f52c4af448
Merge pull request #24310 from Microsoft/nonWideningLiteralInferences
Non-widening literal type inferences
2018-05-22 06:56:34 -07:00
王文璐
4b47c0cb82 fix wrong formatting with multiline type literals with IntersectionType and UnionType 2018-05-22 14:01:04 +08:00
Armando Aguirre
0b18bdf590 Added tests 2018-05-21 18:22:13 -07:00
Mohamed Hegazy
a9e89ce3f1
Merge pull request #24180 from Microsoft/updateVersion
Update version
2018-05-21 17:18:39 -07:00
Andrew Casey
edd31a1505 Preserver jsx imports even when the compiler option is not set
...based on feedback from VS Code users.

Fixes #23287
2018-05-21 16:57:18 -07:00
Anders Hejlsberg
b31c414a31 Accept new baselines 2018-05-21 16:44:03 -07:00
Anders Hejlsberg
9d4096f9c4 Add tests 2018-05-21 16:43:55 -07:00
Anders Hejlsberg
5bbadb66ab Accept new baselines 2018-05-21 16:43:46 -07:00
Anders Hejlsberg
8528dbee76 Handle union types in getRegularTypeOfLiteralType 2018-05-21 16:17:56 -07:00
Andy
802dc2bb9b
fixUnusedIdentifier: If every VariableDeclaration is unused, remove the VariableStatement (#24231) 2018-05-21 15:54:33 -07:00
Anders Hejlsberg
c8ac085498 Infer non-widening literal types when type parameter constraint includes primitive types 2018-05-21 15:28:51 -07:00
Sheetal Nandi
f1acbc93ef Add noGetErrOnBackgroundUpdate session option to not queue diagnostics check for open files
This will ensure that the getErr will be queued in by host and hence would make sure that it is cancellable.
Handles one of the scenario delaying completions in #19458
2018-05-21 12:53:31 -07:00
Mohamed Hegazy
d2f6f6a0a4
Merge pull request #24296 from Microsoft/npmPackageSize
Remove unneeded files from npm package
2018-05-21 12:35:00 -07:00
Sheetal Nandi
e4c380a698 Merge branch 'master' into documentRegistery 2018-05-21 12:27:12 -07:00
Mohamed Hegazy
5abe4fead4 builf lib.es2018.full.d.ts 2018-05-21 11:01:56 -07:00
Mohamed Hegazy
85dcfec33c Update LKG 2018-05-21 11:01:35 -07:00
Mohamed Hegazy
7016dfd246 Remove .js.map and .d.ts files added in #23844 2018-05-21 10:51:08 -07:00
Andy
440291e316
Fix bug: Get merged module symbol in forEachExternalModule (#24295) 2018-05-21 10:48:50 -07:00
Mohamed Hegazy
7c86c7afff update .npmignore 2018-05-21 10:41:09 -07:00
Andy
c09cc70ebe
Fix bug: VariableDeclaration initializer may be undefined (#24256) 2018-05-21 07:58:33 -07:00
Mohamed Hegazy
153c1806d3
Merge pull request #24271 from Microsoft/portRegExpDotAllFix
Port changes in #24238 to source file
2018-05-19 11:44:58 -07:00
Mohamed Hegazy
8f6e6487f7
Merge pull request #24265 from Microsoft/quoteTypeof
Use single quotes around 'typeof' in message.
2018-05-19 11:31:41 -07:00