Commit graph

22538 commits

Author SHA1 Message Date
Anders Hejlsberg e584243d60 Only look up identifiers that could actually be type parameters 2018-04-03 09:04:24 -07:00
Nathan Shively-Sanders 11eabc0946
Skip parens and non-null assertions when looking for this-context (#23097)
* Skip parens and ! for getting this-context of call

* Add test and improve code a bit

* Use skipOuterExpressions instead
2018-04-03 06:23:59 -07:00
csigs a2c11bb7a0
LEGO: Merge pull request 23108
LEGO: Merge pull request 23108
2018-04-03 03:10:53 -07:00
csigs 1ca68d0d96 LEGO: check in for master to temporary branch. 2018-04-03 10:10:33 +00:00
csigs ae61ebac8d
LEGO: Merge pull request 23102
LEGO: Merge pull request 23102
2018-04-02 22:23:16 -07:00
csigs 79aa1995da LEGO: check in for master to temporary branch. 2018-04-03 05:22:53 +00:00
王文璐 414266cc32 Merge branch 'master' into spelling-fix 2018-04-03 10:51:40 +08:00
Andy 92dfde0067
matchTextChunk: combine a) and b) cases (#23083) 2018-04-02 18:09:09 -07:00
Andy 1e04bd4168
Support completions for members with symbol names (#23091) 2018-04-02 18:08:00 -07:00
Anders Hejlsberg 751eab9eed
Merge pull request #23067 from Microsoft/fixTPReferenceInConditional
Fix type parameter reference checks in conditional types
2018-04-02 17:30:32 -07:00
Mohamed Hegazy e6fa4e4415
Merge pull request #23043 from alan-agius4/feature/compiler-host-falsy-file
fix: `CompilerHost.getSourceFile` is being called for odd filenames
2018-04-02 17:08:31 -07:00
uniqueiniquity 36cdb52b17 Handle double quotes for every argument 2018-04-02 16:41:29 -07:00
Andy 955542df8e
Simplify matchTextChunk (#23081) 2018-04-02 16:20:07 -07:00
Wesley Wigham fd553df3a6
Path completions for import types (#23082)
* Path completions

* Add missing flag to test

* Minify test, fix lint
2018-04-02 16:15:50 -07:00
uniqueiniquity 8f503fb483 Close over getLogPath 2018-04-02 15:38:04 -07:00
uniqueiniquity e625a6a9b4 Use object destructuring instead of tuple 2018-04-02 15:12:26 -07:00
Andy 7eaad14bf9
Work around bug with global completion with invalid identifier (#23086) 2018-04-02 14:58:08 -07:00
uniqueiniquity ffbb046cd4 Consume extra parts of file path 2018-04-02 13:58:31 -07:00
Andy 8e14ac7d51
Improve string literal completions from a signature (#23062) 2018-04-02 13:01:31 -07:00
uniqueiniquity 361be11a04 Remove trailing whitespace 2018-04-02 12:32:15 -07:00
Andy 65323e046a
Unclosurefy patternMatcher (#23071) 2018-04-02 12:21:48 -07:00
Nathan Shively-Sanders d3e0929b14
Mark js-assignment functions' symbols as methods (#23078)
This make display more accurate:
1. The functions now print as methods
2. When the type of the function references the class, the type of the
function itself is now printed correctly instead of as `any`.
2018-04-02 12:17:35 -07:00
Andy 72e92a0558
Remove unused properties from patternMatcher (#23076) 2018-04-02 12:02:35 -07:00
Alan Agius 7e482b27fb fix: CompilerHost.getSourceFile is being called for odd filenames besides the one being compiled
Ignore falsy file names from `getDefaultLibraryFileName`

Closes: #13629
2018-04-02 20:58:37 +02:00
Andy 8cdd1aecca
Simplify 'bestMatchKind' (#23073) 2018-04-02 11:57:19 -07:00
Andy 0d063d6161
Update baselines for chained prototype assignments (#23075) 2018-04-02 11:15:17 -07:00
uniqueiniquity 0238991cd3 Ensure TSS_LOG handles paths with spaces 2018-04-02 11:04:52 -07:00
Mohamed Hegazy 5ae14bc038
Merge pull request #23069 from Microsoft/portGenerat3edLibFiles4-2
Port generated lib files
2018-04-02 10:44:48 -07:00
Andy d5142a7f45
Don't offer import completions in non-module files unless "--module" is set (#22951)
* Don't offer import completions in non-module files unless "--module" is set

* Even smarter shouldOfferImportCompletions
2018-04-02 10:21:14 -07:00
Wesley Wigham 414bc49cc4
Module or import types (#22592)
* Type side of import types

* Value side of import types

* Accept library changes

* Refined implementation, more tests

* Allow resolutions to be performed late if the resolution still results in a file already in the build

* Add another test case

* Add some jsdoc usages

* Allow nodebuilder to use import types where appropriate

* Parse & check generic instantiations

* use import types in nodebuilder for typeof module symbols

* Wire up go to definition for import types

* Accept updated type/symbol baselines now that symbols are wired in

* PR feedback

* Fix changes from merge

* Walk back late import handling

* Remove unused diagnostic

* Remove unrelated changes

* Use recursive function over loop

* Emit type arguments

* undo unrelated change

* Test for and support import type nodes in bundled declaration emit
2018-04-02 10:18:23 -07:00
Mohamed Hegazy f29a51fd2e Port generated lib files 2018-04-02 10:12:03 -07:00
Nathan Shively-Sanders 5c442419dc
Include arrow functions as javascript initializers (#23068)
This means that they are treated as valid js containers, methods, etc.
2018-04-02 10:11:39 -07:00
Nathan Shively-Sanders 6d9a8250bd
Improve binding and jsdoc of chained special js assignments (#23038)
* Search for jsdoc on chained assignments

* Fix binding of chained binary expression js-assignments

* Test:chained jsdoc+chained prototype assignment

* Improve naming
2018-04-02 09:47:01 -07:00
Anders Hejlsberg c2f96a3c7d Accept new baselines 2018-04-02 09:23:16 -07:00
Anders Hejlsberg ec02ccd575 Add regression test 2018-04-02 09:23:00 -07:00
Anders Hejlsberg d093d6a1f8 Less aggressive test for type parameter references in conditional types 2018-04-02 09:22:46 -07:00
csigs c02b4f2d7d
LEGO: Merge pull request 23064
LEGO: Merge pull request 23064
2018-04-02 09:10:46 -07:00
csigs b3b7909a2a LEGO: check in for master to temporary branch. 2018-04-02 16:10:24 +00:00
Andy ea65f21677
textChanges: Don't crash when inserting type annotation on function with no parens (#23034) 2018-04-02 08:41:22 -07:00
Andy 86a8e269fa
Add 'getNameFromPropertyName' helper (#23036) 2018-04-02 08:14:15 -07:00
Josh Goldberg cf0a0ec001 Fixed unit tests for error counts 2018-04-01 22:57:38 -07:00
csigs 0fd8fb8697
LEGO: Merge pull request 23051
LEGO: Merge pull request 23051
2018-04-01 22:14:09 -07:00
csigs 71b50aad5f LEGO: check in for master to temporary branch. 2018-04-02 05:13:44 +00:00
Josh Goldberg d268279c8e Merge branch 'master' into pretty-watch-error-summaries 2018-04-01 21:44:55 -07:00
Anders Hejlsberg b3829523b2
Merge pull request #23039 from Microsoft/fixConditionalConstraints
Improve conditional type constraints
2018-03-31 11:56:05 -07:00
Wesley Wigham 9b558f9535
Remove _this, _super, and _newTarget name conflict errors (#22890)
* Add new generated name kind for reused transpiler variables

* Remove error on _super or _newTarget conflict

* Add test with super helper conflict

* Remove error on _this conflict

* Fix lint

* Use flags instead of generated kinds, inline some things

* Accept rename

* Remove trailing whitespace

* Move helper emit into printer, rather than emitter"

* passthru module and target

* New test, accept baselines

* Make members private
2018-03-30 17:43:37 -07:00
Wesley Wigham 8543d30372
Add union check to improved error message (#23027) 2018-03-30 16:23:24 -07:00
Anders Hejlsberg 3d91736f6c Accept new baselines 2018-03-30 16:21:23 -07:00
Anders Hejlsberg b84e05e669 Add tests 2018-03-30 16:21:16 -07:00
Wesley Wigham a53f9e8ec3
Call ensureModifiers on private property modifiers (#23026) 2018-03-30 16:07:09 -07:00