Commit graph

20163 commits

Author SHA1 Message Date
Nathan Shively-Sanders e962e4abfb Update baselines 2017-10-17 16:35:28 -07:00
Nathan Shively-Sanders 64fc495234 Collapse jsdoc annotation refactors to one
Previously there were two, and two always fired.
2017-10-17 16:33:52 -07:00
Wesley Wigham 2cc4f537af This wasnt required before... (#19262) 2017-10-17 15:41:16 -07:00
Sheetal Nandi e99e9333fa Merge pull request #19263 from Microsoft/directoryWatcherInsteadOfFileWatch
This fixes the issue with tsc --watch when module emit kind is none and directory watcher gets invoked instead of file
2017-10-17 15:08:08 -07:00
Andy d05443bb1d Add quickfix and refactoring to install @types packages (#19130)
* Add quickfix and refactoring to install @types packages

* Move `validatePackageName` to `jsTyping.ts`

* Remove combinePaths overloads

* Respond to code review

* Update api baselines

* Use native PromiseConstructor

* Return false instead of undefined

* Remove getProjectRootPath

* Update api
2017-10-17 15:04:09 -07:00
Sheetal Nandi bd0c2103cf Merge branch 'master' into directoryWatcherInsteadOfFileWatch 2017-10-17 14:34:40 -07:00
Sheetal Nandi a5861af00e Handle when directory watcher is invoked on file change
Fixes #19206
2017-10-17 14:13:12 -07:00
uniqueiniquity 75665294a9 Respond to CR 2017-10-17 13:39:16 -07:00
Sheetal Nandi 314172a988 Merge pull request #19239 from Microsoft/reduceWatchedDirectories
Do not watch root folders for failed lookup locations and effective type roots
2017-10-17 13:05:46 -07:00
Sheetal Nandi 49cfbb438f Added test for windows style paths watched directories 2017-10-17 12:18:17 -07:00
Andy 28509e1732 noUnusedLocals: Warn for recursive call to private method (#18920) 2017-10-17 11:57:47 -07:00
Andy d0c4d13fe2 In tsserver, indent logged JSON (#19080) 2017-10-17 11:34:59 -07:00
Nathan Shively-Sanders 487504da46 Merge pull request #19250 from Microsoft/mark-fresh-spread-types-with-ContainsObjectLiteral
Mark fresh spread types with ContainsObjectLiteral
2017-10-17 11:01:34 -07:00
Wesley Wigham f09fe3d0ec Dont try to run unit tests with rwc tests again (#19240) 2017-10-17 10:45:48 -07:00
Andy 2b566b9a53 Add exported members of all project files in the global completion list (#19069)
* checker.ts: Remove null check on symbols

* tsserverProjectSystem.ts: add two tests

* client.ts, completions.ts, types.ts: Add codeActions member to CompletionEntryDetails

* protocol.ts, session.ts: Add codeActions member to CompletionEntryDetails protocol

* protocol.ts, session.ts, types.ts: add hasAction to CompletionEntry

* session.ts, services.ts, types.ts: Add formattingOptions parameter to getCompletionEntryDetails

* completions.ts: define SymbolOriginInfo type

* completions.ts, services.ts: Add allSourceFiles parameter to getCompletionsAtPosition

* completions.ts, services.ts: Plumb allSourceFiles into new function getSymbolsFromOtherSourceFileExports inside getCompletionData

* completions.ts: add symbolToOriginInfoMap parameter to getCompletionEntriesFromSymbols and to return value of getCompletionData

* utilities.ts: Add getOtherModuleSymbols, getUniqueSymbolIdAsString, getUniqueSymbolId

* completions.ts: Set CompletionEntry.hasAction when symbol is found in symbolToOriginInfoMap (meaning there's an import action)

* completions.ts: Populate list with possible exports (implement getSymbolsFromOtherSourceFileExports)

* completions.ts, services.ts: Plumb host and rulesProvider into getCompletionEntryDetails

* completions.ts: Add TODO comment

* importFixes.ts: Add types ImportDeclarationMap and ImportCodeFixContext

* Move getImportDeclarations into getCodeActionForImport, immediately after the implementation

* importFixes.ts: Move createChangeTracker into getCodeActionForImport, immediately after getImportDeclarations

* importFixes.ts: Add convertToImportCodeFixContext function and reference it from the getCodeActions lambda

* importFixes.ts: Add context: ImportCodeFixContext parameter to getCodeActionForImport, update call sites, destructure it, use compilerOptions in getModuleSpecifierForNewImport

* importFixes.ts: Remove moduleSymbol parameter from getImportDeclarations and use the ambient one

* importFixes.ts: Use cachedImportDeclarations from context in getCodeActionForImport

* importFixes.ts: Move createCodeAction out, immediately above convertToImportCodeFixContext

* Move the declaration for lastImportDeclaration out of the getCodeActions lambda into getCodeActionForImport

* importFixes.ts: Use symbolToken in getCodeActionForImport

* importFixes.ts: Remove useCaseSensitiveFileNames altogether from getCodeActions lambda

* importFixes.ts: Remove local getUniqueSymbolId function and add checker parameter to calls to it

* importFixes.ts: Move getCodeActionForImport out into an export, immediately below convertToImportCodeFixContext

* completions.ts: In getCompletionEntryDetails, if there's symbolOriginInfo, call getCodeActionForImport

* importFixes.ts: Create and use importFixContext within getCodeActions lambda

* importFixes.ts: Use local newLineCharacter instead of context.newLineCharacter in getCodeActionForImport

* importFixes.ts: Use local host instead of context.host in getCodeActionForImport

* importFixes.ts: Remove dummy getCanonicalFileName line

* Filter symbols after gathering exports instead of before

* Lint

* Test, fix bugs, refactor

* Suggestions from code review

* Update api baseline

* Fix bug if previousToken is not an Identifier

* Replace `startsWith` with `stringContainsCharactersInOrder`
2017-10-17 10:20:11 -07:00
Nathan Shively-Sanders e58aa10068 Test excess property checks of spreads of unions. 2017-10-17 09:56:28 -07:00
Nathan Shively-Sanders 08d7e182cd Mark fresh spread objects w/ContainsObjectLiteral 2017-10-17 09:56:04 -07:00
uniqueiniquity 845f5737cf Update API baselines 2017-10-17 09:38:23 -07:00
uniqueiniquity 5f8a1b5b56 Add baselines 2017-10-17 09:38:23 -07:00
uniqueiniquity 269d37a2e6 Update tests 2017-10-17 09:38:22 -07:00
uniqueiniquity abb3f58db2 Add support for JSX fragment syntax 2017-10-17 09:38:09 -07:00
csigs 3a84b661b5 LEGO: Merge pull request 19248
LEGO: Merge pull request 19248
2017-10-17 09:10:23 -07:00
csigs 1af25ae9f1 LEGO: check in for master to temporary branch. 2017-10-17 16:10:05 +00:00
csigs fcb48dd906 LEGO: Merge pull request 19241
LEGO: Merge pull request 19241
2017-10-16 21:10:23 -07:00
csigs 92d191990a LEGO: check in for master to temporary branch. 2017-10-17 04:10:06 +00:00
Sheetal Nandi 50628e73c5 Do not watch root folders for failed lookup locations and effective type roots
Fixes #19170
2017-10-16 18:40:21 -07:00
Armando Aguirre b86153da88 Changed command designed based on review input 2017-10-16 17:50:35 -07:00
Mohamed Hegazy 3c452057c2 Add release-2.6 to covered branches 2017-10-16 16:09:16 -07:00
Ron Buckton 06fd5e0bfe Merge pull request #19230 from Microsoft/fix18186
Do not reduce subtypes of awaited union type
2017-10-16 15:17:30 -07:00
Ron Buckton 169b8e436a Merge pull request #19232 from Microsoft/fix19187
Fix generated name scope when emitting async functions
2017-10-16 15:17:14 -07:00
csigs 95715603bc LEGO: Merge pull request 19234
LEGO: Merge pull request 19234
2017-10-16 15:11:04 -07:00
csigs fd86cd5a2e LEGO: check in for master to temporary branch. 2017-10-16 22:10:47 +00:00
Ron Buckton eebb0447ab Fix generated name scope when emitting async functions 2017-10-16 14:47:43 -07:00
Ron Buckton 9563246993 Do not reduce subtypes of awaited union type 2017-10-16 14:26:16 -07:00
Sheetal Nandi 5de6366e8a Merge pull request #19222 from Microsoft/projectCompilerOptions
Add getCompilerOptions method to project
2017-10-16 14:23:35 -07:00
Wesley Wigham aea7e9a7a8 Fix instantiated generic mixin declaration emit (#19144)
* Fix #18545, dont use declared type of class expression

* Accept API Baselines

* Add thus far unused flag from node builder

* Accept baseline update
2017-10-16 14:17:55 -07:00
Arthur Ozga 63074bcba0 Merge pull request #16695 from aozgaa/fixIifeIndentation
Fix indentation for function argument in call expression
2017-10-16 14:03:25 -07:00
Sheetal Nandi 734bda833c Add comments about why we need two methods that return compilerOptions 2017-10-16 13:06:15 -07:00
Andy 2cb0403e2d Support 'package.json' not in package root (#19133)
* Support 'package.json' not in package root

* Test "foo/@bar"

* More tests, and don't use "types" from the root package.json if not loading the root module
2017-10-16 13:02:15 -07:00
Wesley Wigham 40222d1a77 Fix for-in emit under systemjs (#19223) 2017-10-16 12:57:23 -07:00
Andy bac30fc1a2 In convertFunctionToEs6Class.ts, share code for getting symbol (#19160) 2017-10-16 11:41:35 -07:00
Sheetal Nandi 3c27e782da Add getCompilerOptions method to project
Fixes #19218
2017-10-16 11:22:49 -07:00
Nathan Shively-Sanders 49beac919c Abstract property access error only on this access 2017-10-16 09:43:49 -07:00
Nathan Shively-Sanders fb45b49afc Test:abstract prop access in non-declaring ctor 2017-10-16 09:20:28 -07:00
Nathan Shively-Sanders 5e7bfad2a7 Check own-constructor in abstract prop access error 2017-10-16 09:19:46 -07:00
csigs 8d47ef60a9 LEGO: Merge pull request 19217
LEGO: Merge pull request 19217
2017-10-16 09:10:42 -07:00
csigs 9306543431 LEGO: check in for master to temporary branch. 2017-10-16 16:10:13 +00:00
kingwl 30c51ed324 fix super call from class that has no basetype but with same symbol interface (#19068) 2017-10-16 10:42:22 +08:00
Anders Hejlsberg d4c0377395 Merge pull request #19185 from Microsoft/fixMappedTypesKeyofAny
Fix 'any' and 'keyof any' in mapped types
2017-10-14 12:12:25 -07:00
Mohamed Hegazy abe45ed2b9 Merge branch 'RyanCavanaugh-fix11857' 2017-10-14 11:33:21 -07:00