Commit graph

28370 commits

Author SHA1 Message Date
Alexander T 64baa804a8 Merge branch 'master' of https://github.com/Microsoft/TypeScript into feature/eslint 2019-07-15 18:35:34 +03:00
Orta 4bb0aaea06
Merge pull request #32359 from orta/fix_14589
Don't add extra indentation for objects inside function parameters
2019-07-15 11:33:48 -04:00
Orta Therox 1d78218053 Handle feedback from #32359 2019-07-15 10:49:08 -04:00
Anders Hejlsberg 6f637b0870 Accept new baselines 2019-07-12 17:57:11 -10:00
Anders Hejlsberg 044d70fc24 Add regression tests 2019-07-12 17:57:05 -10:00
Anders Hejlsberg 303297aa27
Merge pull request #32362 from microsoft/fix32230
Fix type parameter inference cache invalidation logic
2019-07-12 16:57:34 -07:00
Daniel Rosenwasser 851156d73d
Add kind to JsxAttributes (#32369)
Add kind to JsxAttributes
2019-07-12 14:40:30 -07:00
Anders Hejlsberg e0599fd19c Instantiate contextual type for return type in getReturnTypeFromBody 2019-07-12 11:11:36 -10:00
Andrew Branch 4f3412153a
Parse quoted constructors as constructors, not methods (#31949)
* Parse quoted constructors as constructors, not methods

* Update baselines

* Fix disambiguation between quoted constructor and property named constructor

* Clean up parsing a bit

* Support escapes in constructor name

* Update baselines
2019-07-12 14:01:57 -07:00
Titian Cernicova-Dragomir ba79b5ffac Fixed auto completion after a < token to return types not values. 2019-07-12 23:14:42 +03:00
Wesley Wigham 37f2e5972f
Cache & widen assigned js prototype type (#32381) 2019-07-12 12:49:34 -07:00
Orta Therox 59d5585814 Don't indent properties if an object literal follows directly from another object on the same line 2019-07-12 15:24:07 -04:00
Andrew Branch 89badcc9d5
Add 'Remove unnecessary await' suggestion and fix (#32363)
* Add remove unnecessary await fix

* Add test for removing unnecessary parens after await is gone

* Fix handling of numbers in property access expressions

* Don’t offer suggestion when awaited type is any/unknown

* Fix random other test

* Fix new expression edge cases

* Only remove parens for identifiers and call expressions
2019-07-12 11:03:20 -07:00
Andrew Branch 60a1b1dc1a
Proposal: If there’s a package.json, only auto-import things in it, more or less (#31893)
* Move package.json related utils to utilities

* Add failing test

* Make first test pass

* Don’t filter when there’s no package.json, fix scoped package imports

* Use type acquisition as a heuristic for whether a JS project is using node core

* Make same fix in getCompletionDetails

* Fix re-exporting

* Change JS node core module heuristic to same-file utilization

* Remove unused method

* Remove other unused method

* Remove unused triple-slash ref

* Update comment

* Refactor findAlias to forEachAlias to reduce iterations

* Really fix re-exporting

* Use getModuleSpecifier instead of custom hack

* Fix offering auto imports to paths within node modules

* Rename things and make comments better

* Add another reexport test

* Inline `symbolHasBeenSeen`

* Simplify forEachAlias to findAlias

* Add note that symbols is mutated

* Symbol order doesn’t matter here

* Style nits

* Add test with nested package.jsons

* Fix and add tests for export * re-exports
2019-07-12 10:08:55 -07:00
Andrew Branch 71bec5b698
Add quick fix to add missing 'await' (#32356)
* Start prototyping addMissingAwait codefix

* Filter by diagnostics that have missing-await related info

* Start writing tests and checking precedence

* Implement codeFixAll, add test for binary expressions

* Add test for iterables

* Add test for passing argument

* Add test for call/construct signatures

* Add test for awaiting initializer

* Improve assertion error

* Replace specific property access error with general one and add await related info

* Add test for property access

* Require code to be inside a function body to offer await

* Accept suggestion

Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Add explicit test for code fix being not available unless something is a Promise

* Skip looking for function body if already in AwaitContext flags

* Inline getCodeActions function for symmetry
2019-07-12 10:07:55 -07:00
csigs d4b214901c
LEGO: Merge pull request 32379
LEGO: Merge pull request 32379
2019-07-12 09:10:43 -07:00
csigs 4e49706c72 LEGO: check in for master to temporary branch. 2019-07-12 16:10:19 +00:00
Andrew Branch 8516127a05
Fix regression of generic T assignability to Partial<T> (#32354) 2019-07-12 07:57:55 -07:00
Dmitrijs Minajevs b2c555a57d Added new keword compeltion filter for assertions 2019-07-12 15:25:00 +03:00
Dmitrijs Minajevs 74805c2e23 Fixed failing test due to changed details 2019-07-12 14:11:23 +03:00
Dmitrijs Minajevs 1d93b76b3f Added "readonly" to Type Keywords 2019-07-12 14:04:19 +03:00
David Sherret 84f4acdb89 Add kind to JsxAttributes. 2019-07-11 20:34:41 -04:00
Anders Hejlsberg 4b9ca33e1d Accept new baselines 2019-07-11 10:47:34 -10:00
Anders Hejlsberg c53246fa35 Add regression test 2019-07-11 10:47:27 -10:00
Sheetal Nandi ea730939d7
Merge pull request #32360 from microsoft/incrementalPaths
Ensure that the filePaths in compiler options are absolute before getting relative path to buildInfo directory
2019-07-11 13:45:39 -07:00
Anders Hejlsberg 0e273c3e07 Fix type parameter inference cache invalidation 2019-07-11 10:45:19 -10:00
Sheetal Nandi fd4f4fe5a2 Ensure that the filePaths in compiler options are absolute before getting relative path to buildInfo directory
Fixes #32353
2019-07-11 13:18:35 -07:00
Orta Therox dfc97db323 Don't add extra indentation for objects inside function parameters 2019-07-11 14:26:03 -04:00
Nathan Shively-Sanders f209995a01
Update DOM: Remove carriage returns from comments (#32352) 2019-07-11 10:16:46 -07:00
Titian Cernicova-Dragomir d2c9d6cc1b Improved parameter names for call signatures resulting from unions when only one parameter name is available. (#32056) 2019-07-11 10:06:49 -07:00
TypeScript Bot fbdbb141a2 Update user baselines (#32346) 2019-07-11 09:46:37 -07:00
csigs c6b28690db
LEGO: Merge pull request 32343
LEGO: Merge pull request 32343
2019-07-11 03:10:49 -07:00
csigs 6b89c72b5e LEGO: check in for master to temporary branch. 2019-07-11 10:10:20 +00:00
Andrew Branch 8eb3822ae0
Merge pull request #28290 from rflorian/add-codefix-cannot-find-name-in-for-loop
Add codefix for 'Cannot find name' diagnostic
2019-07-10 21:47:36 -07:00
Wesley Wigham 6839973bf7
Generate a unique type parameter name for each nested type parameter (#31544)
* Generate a unique type parameter name for each nested type parameter

* Add testcase from 31605

* Fix typo

* Liiiiiine eeeendingggggss
2019-07-10 17:12:20 -07:00
Wesley Wigham daf0a73346
Fix lookup of optional methods in declaration emit (#32094) 2019-07-10 16:39:07 -07:00
Nathan Shively-Sanders 5289f2ede9
Update DOM from TSJS-lib-generator (#32335)
* Update DOM from TSJS-lib-generator

1. Update Navigator and other small updates.
2. Make ProgressEvent generic.
3. Make `window: Window & typeof globalThis`.
4. Add types:
  * CSS Overflow
  * CSS Masking
  * Web Authentication
  * WebGL 2

The big change is that `window` now includes globals in its type via
`typeof globalThis`. This helps some codebases a lot, such as
chrome-devtools-frontend.

* Update baselines
2019-07-10 16:36:50 -07:00
Andrew Branch 00e7d9cb1a
Merge pull request #32334 from andrewbranch/no-missing-await-on-unary-arithmetic-expressions
Remove "Did you forget to use await" for unary arithmetic expressions
2019-07-10 14:21:29 -07:00
Andrew Branch f41c9b2c20
Rename parameter 2019-07-10 13:34:58 -07:00
Andrew Branch ab9e583e45
Remove "Did you forget to use await" for unary arithmetic expressions 2019-07-10 13:18:37 -07:00
TypeScript Bot 34ffefb922 Update user baselines (#32324) 2019-07-10 13:00:30 -07:00
Alexander T ccba537962 Merge branch 'feature/eslint' of https://github.com/a-tarasyuk/TypeScript into feature/eslint 2019-07-10 14:36:56 +03:00
Alexander T 9d01ef0f8e Merge branch 'master' of https://github.com/Microsoft/TypeScript into feature/eslint 2019-07-10 14:36:10 +03:00
Florian Regensburger 196db5bbcb Fixed lint error 2019-07-10 02:35:40 +02:00
Florian Regensburger f273448925 Added addMissingConst codefix for comma separated initializers 2019-07-10 02:11:02 +02:00
Andrew Branch a4cddd4647
Merge pull request #32239 from andrewbranch/enhancement/missing-await-errors
Improve error messages for potentially missing 'await'
2019-07-09 16:28:54 -07:00
Nathan Shively-Sanders 949956b586
Improve multiple overloads error span (#32315)
* Improve multiple overloads error span

When all errors for a multiple-overload error refer to the same span,
use that span instead of the one for the entire call.

This situation is quite common for 2-overload sets in React.

* Update baselines

* Fix lint
2019-07-09 15:39:42 -07:00
Anders Hejlsberg b0f050f4ee
Merge pull request #32260 from microsoft/fix32169
Include conditional types in top-level type parameter check
2019-07-09 10:30:44 -07:00
Florian Regensburger 1de7881141 Add negative test case for addMissingConst codeFix with unexpected array elements 2019-07-09 02:07:54 +02:00
Florian Regensburger 384669a1ce Finish addMissingConst codefix for single variable and array literal assignments 2019-07-09 01:56:50 +02:00