maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
29663 commits 490 branches 166 tags 2.2 GiB
Commit graph

386 commits

Author SHA1 Message Date
Wesley Wigham 2cd3500197
origin/master because ref is fetched not pulled 2019-05-31 14:45:06 -07:00
Wesley Wigham 619648e8c2
Trim whitespace, fetch origin master 2019-05-31 14:36:39 -07:00
Wesley Wigham 8813ceb3ce
Cant use stdio inherit and stash a result away 2019-05-31 14:24:49 -07:00
Wesley Wigham 9a2957717e
Strictify the cherry-pick pr script 2019-05-31 14:12:45 -07:00
Wesley Wigham cb2df757d7
Add initial edition of cherry-pick script (#31705) 2019-05-31 13:42:15 -07:00
Wesley Wigham 1fe9a0ad4e
Small fix to user PR script (#31679) 2019-05-30 15:20:41 -07:00
Wesley Wigham bb1ac81bb1
Experimental management scripts (#31067) 
* Add configure-experimental

* Add script for synchronizing branches with master and creating an experimental branch with the result of merging those
 2019-04-23 13:52:23 -07:00
Wesley Wigham 53c92d608f
Add configure-experimental (#31064) 2019-04-22 13:20:34 -07:00
Wesley Wigham 0574c1fae1
Hide the table of perf results from the bot inside an expando element (#31007) 2019-04-18 09:09:22 -07:00
Wesley Wigham 60346b56a8
Do not request reviewers for fork-triggered PRs, just mention them 2019-04-05 18:29:30 -07:00
Wesley Wigham 73616c9725
More conditional linkage in user PR responses when manually triggered 2019-04-05 17:52:24 -07:00
Wesley Wigham 0ddd847e03
Small addition to user PR script to support fork/branch PRs 2019-04-05 16:28:25 -07:00
Wesley Wigham e20b87f66d
Add script for posting perf results back to GH (#30526) 
* Add script for posting perf results back to GH

* Slightly more logging, use html url, not api url, lol

* Log even more, nonzero exit code on error
 2019-03-22 17:39:20 -07:00
Wesley Wigham 3127962cd1
Fix authors script (#30440) 2019-03-18 12:26:27 -07:00
Wesley Wigham a887c6ba40
Remove unused (and sometimes broken) targets and scripts (#30054) 
* Remove unused (and sometimes broken) targets and scripts

* Remove browser-specific harness code
 2019-03-08 10:34:35 -08:00
Wesley Wigham c2f1998387
Fix baseline accept when there are multiple .delete files (#30091) 2019-02-25 16:18:03 -08:00
Wesley Wigham fb0dcd4987
Have runtests always throw on failure, make rm stream signal end of read queue (#30035) 2019-02-21 18:17:53 -08:00
Wesley Wigham b67f2d6bdf
Remove jake (hopefully for real this time) (#29085) 
* Remove jake (hopefully for real this time)

* Fix gulpfile non-lkg build, add sanity-check build to posttest on CI, accept older baseline style to go with lkgd build

* More docs/scripts jake -> gulp
 2019-02-20 15:32:15 -08:00
Ryan Cavanaugh 02b1f71612
Merge branch 'master' into typos 2019-02-01 13:43:44 -08:00
Wesley Wigham ea74ed477c
Update user pr script for latest version of octokit (#29639) 2019-01-29 14:01:10 -08:00
Ron Buckton 47c2708a9c Simplify gulp to just use 'tsc -b' to build, update to gulp@4 2019-01-27 21:56:56 -08:00
Wesley Wigham fdeb8f01df
Fix typo in runner selection in gulp 2019-01-24 12:58:46 -08:00
Ron Buckton 6b32f4edcb Fix gulp builds not building some targets 2019-01-16 17:32:58 -08:00
Nathan Shively-Sanders ad85e4fd22
Fix gulp baseline-accept (#29301) 
* Fix gulp baseline-accept

I think it was ported incorrectly from jake and then never used.

* Re-add read:false to baselineDelete
 2019-01-08 11:20:54 -08:00
Wesley Wigham dcf825e3cd
Add types entry to tslint build to prevent inclusion of unwanted types installed via user tests 2019-01-04 12:59:11 -08:00
Wesley Wigham fd7fd133e2
Fix the up-to-date-ness checks of sucessive gulp invocations (#29088) 2018-12-18 16:41:02 -08:00
Daniel Rosenwasser d1cafe7751 Always generate lowercase locale names so 'LKG's produce identical results on case-sensitive file systems. 2018-12-10 14:19:53 -08:00
fullheightcoding 8e8a2397ca Fixed some typos. 2018-10-25 17:55:28 +11:00
Ron Buckton 4982803a38 Merge branch 'master' into sourceMapGenerator 2018-10-08 18:01:37 -07:00
Ron Buckton d224ee02d7 Free up space in the TransformFlags enum 2018-09-27 17:55:07 -07:00
Ron Buckton b006287cb1 Refactor and clean up sourcemap decoder 2018-09-04 17:50:06 -07:00
Ron Buckton 111300ccd5 Fix overlapping test runs in 'gulp watch' 2018-08-29 12:57:05 -07:00
Ron Buckton 1de8cd3f62 Emit lib reference directives in declaration output 2018-08-20 16:54:51 -07:00
Andy 746e39e9e9
Set "rootDir" for cancellationToken project (#26498) 2018-08-16 15:12:38 -07:00
Wesley Wigham c6fd0c8d29
Ping ryan instead of mohammed for user PRs now 2018-08-08 13:36:03 -07:00
Wesley Wigham 2e017b8ce1
Hardcode xunit reporter output file into failed tests reporter 2018-08-06 14:09:41 -07:00
Ron Buckton 0713e754e7 Build script updates 2018-07-10 12:13:27 -07:00
John Doe 2522a264e7 actuallty -> actually 2018-06-28 18:50:39 -07:00
Ron Buckton f4a2ee456d
Merge pull request #25250 from Microsoft/gulpTypeScriptReporter 
Report errors in corrrect process for gulp-typescript-oop
 2018-06-26 16:04:28 -07:00
Ron Buckton cff0f831a6 Report errors in corrrect process for gulp-typescript-oop 2018-06-26 15:43:04 -07:00
Ron Buckton e705c15c14 Add exists check before unlink 2018-06-26 12:28:28 -07:00
Ron Buckton bc3268b654
Merge pull request #25211 from Microsoft/gulpBrowserify 
Clean up browserify task, remove unused 'debugMode.js' script
 2018-06-25 16:56:47 -07:00
Ron Buckton 78bf10ad80
Merge pull request #25004 from Microsoft/trackFailedTests 
Adds failed test tracking
 2018-06-25 16:55:43 -07:00
Ron Buckton 72a00b148c
Merge pull request #25146 from Microsoft/gulpWatch 
Adds support for gulp.watch
 2018-06-25 16:55:13 -07:00
Ron Buckton 5ed96ec072 Clean up browserify task, remove unused 'debugMode.js' script 2018-06-25 16:21:28 -07:00
Ron Buckton a9b4763249 Ensure upToDate also handles referenced project outputs 2018-06-25 14:14:19 -07:00
Ron Buckton d3ef20caf0 Fix bad merge 2018-06-25 11:36:37 -07:00
Ron Buckton 52fa900b5c Merge branch 'master' into trackFailedTests 2018-06-25 11:26:08 -07:00
Ron Buckton f557d7cd1b Adds support for gulp.watch 2018-06-22 00:09:21 -07:00
Ron Buckton b7918bf92d Fix runtests-parallel, tsserverlibrary, up-to-date checks 2018-06-21 21:27:46 -07:00
Ron Buckton 272e5554c8 Merge branch 'master' into gulpProjectRefs 2018-06-21 10:55:35 -07:00
Martin Probst 4b7208a79f Fix the build on case-sensitive file systems. 
Dashed locale names like `pt-BR` were misspelled as `pt-br` in several
locations.

This is a follow up fix to #23146.
 2018-06-21 13:52:53 +02:00
Ron Buckton c8c0428162 Cleanup, remove some unneeded dependencies, make it easier to add gulp.watch support later 2018-06-20 18:24:12 -07:00
Ron Buckton ad4338dd76 Remove excess exports from exec.js 2018-06-18 23:00:30 -07:00
Ron Buckton 21c23d4e4e Merge branch 'master' into gulpProjectRefs 2018-06-18 22:51:37 -07:00
Ron Buckton 891b15f60a Update gulpfile to support project references 2018-06-18 22:45:13 -07:00
Ron Buckton 0944c29a47 Adds failed test tracking 2018-06-18 13:25:29 -07:00
Wesley Wigham 657d0119cc
Dont use unreliable inodes for checking file identity (#25008) 
* Dont use unreliable inode as unique identifier

* Just concat with `\n

* Introduce path-overriding code to allow local executables ot be found
 2018-06-15 15:53:03 -07:00
Ron Buckton 23c7571e27 Merge branch 'master' into parallelAsyncTests 2018-06-15 13:26:27 -07:00
Ryan Cavanaugh 1bbe6610a4 Merge branch 'master' into esau-squash 2018-06-13 15:35:18 -07:00
Ryan Cavanaugh 5822cacf96 Add publishing tasks 2018-06-13 15:07:48 -07:00
Ryan Cavanaugh de82c54e6b Remove extra dependency + build smaller tsc.js into lkg 2018-06-13 14:50:01 -07:00
Ryan Cavanaugh 73309c9282 Fix buildProtocol to handle lib+noresolve 2018-06-13 10:43:48 -07:00
Ryan Cavanaugh 4a4c47a20b Add produceLKG script 2018-06-13 10:43:37 -07:00
Nathan Shively-Sanders 51fb07523a
Use / in paths in the auto-generated files' header (#24883) 2018-06-12 09:04:29 -07:00
Ryan Cavanaugh 066b191982 Collapse core/compiler/parser into parser 2018-06-11 17:07:58 -07:00
Ron Buckton ece8f2691b Support async tests in runtests-parallel 2018-06-11 14:22:37 -07:00
Ryan Cavanaugh ab10b86205 Almost working? 2018-06-10 19:28:38 -07:00
Ryan Cavanaugh a61a7a2a6e Attempt to rewrite the jakefile and fail 2018-06-10 10:58:16 -07:00
Ryan Cavanaugh 336c37662d Projzilla phase 1 2018-06-09 16:48:08 -07:00
Wesley Wigham f17fe8713e
Actually forward sourcemaps to gulp-typescript doesnt disable sourcemaps (#24766) 2018-06-08 10:54:18 -07:00
Steven 06f411c4de Change getDirSize to default export 2018-06-07 20:58:54 -04:00
Steven 38a46b754d Rename get-dir-size.js to getDirSize.js 2018-06-07 20:58:54 -04:00
Steven f89273a31f Remove unused promisify 2018-06-07 20:58:54 -04:00
Steven bceb08b36f build: add check for lib size 2018-06-07 20:58:54 -04:00
Ron Buckton ec0af20f5a Merge branch 'master' into libReference 2018-05-29 14:13:00 -07:00
Mohamed Hegazy 94c455792a Remove unneeded assertions 2018-05-29 09:06:35 -07:00
Mohamed Hegazy 4683cb5bad Add assertions 2018-05-29 09:06:16 -07:00
Wesley Wigham 198722d46a
Make configure prerelease script compile under strict null checks (#24417) 2018-05-25 12:10:19 -07:00
Andy e53e56cf82
Enable '--strictNullChecks' (#22088) 
* Enable '--strictNullChecks'

* Fix API baselines

* Make sys.getEnvironmentVariable non-nullable

* make properties optional instead of using `| undefined` in thier type

* reportDiagnostics should be required

* Declare firstAccessor as non-nullable

* Make `some` a type guard

* Fix `getEnvironmentVariable` definition in tests

* Pretend transformFlags are always defined

* Fix one more use of sys.getEnvironmentVariable

* `requiredResponse` accepts undefined, remove assertions

* Mark optional properties as optional instead of using `| undefined`

* Mark optional properties as optional instead of using ` | undefined`

* Remove unnecessary null assertions

* Put the bang on the declaration instead of every use

* Make `createMapFromTemplate` require a parameter

* Mark `EmitResult.emittedFiles` and `EmitResult.sourceMaps` as optional

* Plumb through undefined in emitLsit and EmitExpressionList

* `ElementAccessExpression.argumentExpression` can not be `undefined`

* Add overloads for `writeTokenText`

* Make `shouldWriteSeparatingLineTerminator` argument non-nullable

* Make `synthesizedNodeStartsOnNewLine` argument required

* `PropertyAssignment.initializer` cannot be undefined

* Use one `!` at declaration site instead of on every use site

* Capture host in a constant and avoid null assertions

* Remove few more unused assertions

* Update baselines

* Use parameter defaults

* Update baselines

* Fix lint

* Make Symbol#valueDeclaration and Symbol#declarations non-optional to reduce assertions

* Make Node#symbol and Type#symbol non-optional to reduce assertions

* Make `flags` non-nullable to reduce assertions

* Convert some asserts to type guards

* Make `isNonLocalAlias` a type guard

* Add overload for `getSymbolOfNode` for `Declaration`

* Some more `getSymbolOfNode` changes

* Push undefined suppression into `typeToTypeNodeHelper`

* `NodeBuilderContext.tracker` is never `undefined`

* use `Debug.assertDefined`

* Remove unnecessary tag

* Mark `LiteralType.freshType` and `LiteralTupe.regularType` as required
 2018-05-22 14:46:57 -07:00
Wesley Wigham a9ff9c2231
Have the bot link the build associated with the PR (#24176) 2018-05-16 13:12:17 -07:00
Wesley Wigham e509ee59df
Have bot force push his branch so he can run multiple times a day 2018-05-16 12:44:03 -07:00
Wesley Wigham 560371d7a0
Alter basic auth strategy 2018-05-14 10:27:13 -07:00
Wesley Wigham 8a0aa99327
Inject token into push like vsts does 2018-05-14 08:39:32 -07:00
Ron Buckton 8548fb835a Merge branch 'master' into libReference 2018-05-11 20:05:26 -07:00
Wesley Wigham e296301c09
VSTS prefers to pass secrets as command line params (#24041) 2018-05-10 15:37:44 -07:00
Wesley Wigham 2dd0ff3ea8
Add script for automatically creating PRs for user test updates (#24036) 
* Draft of script to automatically create user baseline update PRs

* Some modifications to make testing easier
 2018-05-10 15:02:35 -07:00
Ron Buckton f4ca7ee767 Fork gulp-typescript tasks to run out-of-process 2018-05-04 15:51:13 -07:00
Andy 4a379d66d4
Use @types/travis-fold (#23694) 2018-04-25 16:15:06 -07:00
Andy 3ebcbd4d44
Handle diagnostic with unknown file (#23681) 2018-04-25 13:11:35 -07:00
Wesley Wigham c645f1753f
Update configurePrerelease to not utilize ts internals (#23476) 
* update configure nightly to not utilize ts internals

* Nightly -> Prerelease

* Remove alias
 2018-04-17 15:42:31 -04:00
Nathan Shively-Sanders a0b08f31f9 Fix jakefile case and circular references 
Fails on Linux but not on Windows. Weird!
 2018-04-12 16:11:16 -07:00
Ryan Cavanaugh 8e36afa5bd Remove reference emit from diagnostics 2018-04-12 12:41:00 -07:00
Ryan Cavanaugh bbcf00c040 Remove ref comments from processDiagnosticMessages 2018-04-12 12:35:56 -07:00
Ryan Cavanaugh f24d57f1ac Update diagnostic tasks in jakefile 2018-04-12 12:20:27 -07:00
Andy 28455c65b3
patternMatcher: Return single best match instead of list (#23166) 2018-04-11 15:35:22 -07:00
Andy 556a8010b9
Fix bug: ensure 'reportsUnnecessary' is actually sent by tsserver (#23293) 2018-04-10 10:15:15 -07:00
Andy b3edc8f9f4
Apply 'no-unnecessary-type-assertion' lint rule (#22005) 
* Apply 'no-unnecessary-type-assertion' lint rule

* Fix type error

* Fix tsconfig.json

* Add --format back
 2018-02-16 18:38:00 -08:00
Mohamed Hegazy 384527aa09
Add -dev to version patch number in master (#21741) 2018-02-07 23:45:37 -08:00
Daniel Rosenwasser 6b9ea7cab8 configureNightly -> configurePrerelease 2018-01-19 16:03:02 -08:00
Daniel Rosenwasser 9db45dff6d Create a 'configure-insiders' and 'publish-insiders' task. 2018-01-19 15:58:35 -08:00
Mohamed Hegazy 48ac3019b4 Add example to command description 2018-01-17 11:59:01 -08:00
Andy 86eab34758
type-operator-spacing: Just check for presence of space, not double-space (#20817) 2018-01-08 12:29:43 -08:00
Andy 6f2ba15446
Start linting for double spaces (#20820) 
* Start linting for double spaces

* Code review

* Fix cases that were excluded by countDoubleSpaces

* Remove extraneous closing parenthesis
 2018-01-08 08:52:13 -08:00
Josh Goldberg 423ab2e03d Removed colors devDependency (#20430) 
* Replaced colors with chalk

* Used chalk's preferred import style
 2017-12-14 16:05:25 -08:00
Adrian Leonhard 80d1aa0b4f processDiagnosticMessages.ts: linted, removed unused code (#18697) 
Added following line to generated output:
"// generated from 'src/diagnosticMessages.json' by 'scripts/processDiagnosticMessages.ts'\r\n" +

Fixes https://github.com/Microsoft/TypeScript/issues/3591
 2017-11-08 12:56:39 -08:00
Andy 0a7b7e07ee
Apply 'variable-name' tslint rule (#19743) 2017-11-06 09:23:47 -08:00
Mohamed Hegazy 1e89e78dd2
Fix incorrect relative module name detection (#19702) 2017-11-03 08:59:19 -07:00
Andy 8528667a61 Use lowercased names for generated locale directories (#19581) 2017-10-30 19:18:35 -07:00
Andy 1f282f19e0 Fix "noStringLiteral" lint errors (#19310) 2017-10-19 08:15:48 -07:00
Mohamed Hegazy 5fa8db55b2 Fix https://github.com/Microsoft/TypeScript/issues/19270: ensure output name is a valid locale name (#19308) 
* Fix https://github.com/Microsoft/TypeScript/issues/19270: ensure output name is a valid locale name

* Use const instead of var

* Add comment

* Fix typo

* Split the concat logic for generatedLCGFile
 2017-10-18 15:46:09 -07:00
Andy d05443bb1d Add quickfix and refactoring to install @types packages (#19130) 
* Add quickfix and refactoring to install @types packages

* Move `validatePackageName` to `jsTyping.ts`

* Remove combinePaths overloads

* Respond to code review

* Update api baselines

* Use native PromiseConstructor

* Return false instead of undefined

* Remove getProjectRootPath

* Update api
 2017-10-17 15:04:09 -07:00
Mohamed Hegazy a8b7f7d1e5 Include localized diagnostics (#18702) 
* Add lcl files

* Add loclalization script

* Add localization build targets

* use async exists, and add assert

* Generate lcg file

* Add localize task to gulpFile

* Only run loclaize if the generated files neededs update. Also run localize as part of local

* Fix lint errors

* Linter love

* Respond to code review comments
 2017-10-02 17:16:08 -07:00
Wesley Wigham 1821735136 Add custom formatter which has clickable links, reduce error duplication in gulp output (#18613) 2017-09-21 08:36:50 -07:00
Wesley Wigham d1c4754b37 Better-scheduled parallel tests (#18462) 
* Out with the old...

* Brave new world

* Throttle console output

* Batches test messages on large inputs initially

* Move parallel runner code into seperate files
 2017-09-14 15:42:06 -07:00
Wesley Wigham dc8d47c51d Remove bisect.cmd, remove reference to missing dts, update usage (#18353) 2017-09-09 15:56:11 -07:00
Mohamed Hegazy 07e1d3b13d Ensure string enums are generated in protocol.d.ts (#17914) 2017-08-21 09:44:03 -07:00
Andy ceae613e4c Add lint rule to check that Debug.assert calls do not eagerly interpolate strings (#17125) 
* And lint rule to check that `Debug.assert` calls do not eagerly interpolate strings

* Use more specific 'assert' functions to avoid callbacks

* Respond to PR feedback
 2017-08-08 07:56:14 -07:00
Wesley Wigham 2c2df9eec2 Fix runtests-browser in gulp, including RWC, remove into-stream (#17540) 2017-08-01 11:14:39 -07:00
Wesley Wigham 32d9292a83 Generate diagnostics without a leading comma, retain old spaces (#17534) 
* Generate diagnostics without a leading comma, reatain space

* Add small assertion that we generate valid json
 2017-07-31 12:51:25 -07:00
Andy b81e71d905 processDiagnosticMessages: Simplify code and emit (#17463) 2017-07-28 10:11:57 -07:00
Andy 12acc141c0 processDiagnosticMessages: Simplify check for uniqueness of names (#17331) 
* processDiagnosticMessages: Simplify check for uniqueness of names

* Be case-sensitive
 2017-07-27 12:30:37 -07:00
Wesley Wigham ed87b40902 Fix linter (#17312) 
We just merged a change which makes the `.types` member of a union or intersection type a readonly array. Our lint rule's type annotation needs to reflect that.
 2017-07-19 17:06:31 -07:00
Andy f37d9068ff Fix configure-nightly script to match new contents of core.ts (#17014) 
* Fix configureNightly script to match new contents of core.ts

* Use ts.Debug.assert

* Use a regexp for parsePackageJsonVersion
 2017-07-19 14:47:25 -07:00
Wesley Wigham f888c88f31 Cast identifier names to string in lint rule (#17027) 
To be compatible with both the current version of the compiler and the nightly (which uses a branded string for the text member).
 2017-07-07 16:30:02 -07:00
Yui T ef3e7e6ab5 Add semi-colon 2017-06-16 11:12:31 -07:00
Yui T 4b21358582 Merge branch 'master' into fixRunParallel 2017-06-16 11:09:34 -07:00
Yui T e9bbe866f5 Address comment: fix comment 2017-06-16 11:09:18 -07:00
Kanchalai Tanglertsampan f82c45eb98 Address PR 2017-06-15 13:40:57 -07:00
Ryan Cavanaugh f725d7de5f Rename function 2017-06-06 17:43:30 -07:00
Ryan Cavanaugh 1f3ef7df7a Refactor refactor 2017-06-06 14:58:18 -07:00
Kanchalai Tanglertsampan f476ecec07 Wip-report error when sof happen while running in parallel 2017-06-05 20:23:23 -07:00
Andy 8ace7b826f importFixes: Support missing "React" at a JSXOpeningElement (#16066) 
* importFixes: Support missing "React" at a JSXOpeningElement

* Fix nextLineRule linting

* Rename to resolveJsxNamespaceAtLocation

* Expose getJsxNamespace and resolveNameAtLocation separately
 2017-06-05 14:23:39 -07:00
Andy Hanson 7347e5e4fd Merge branch 'master' into lint-linter 2017-04-11 14:34:38 -07:00
Andy Hanson ed5eca2b7b boolean-trivia lint rule: Enforce space between comment and argument 2017-04-11 09:44:58 -07:00
Andy Hanson e73fffd964 Lint custom lint rules 2017-04-07 13:17:50 -07:00
Andy Hanson 7320891933 boolean-trivia lint rule: Lint for null/undefined too 2017-04-07 13:13:39 -07:00
Ryan Cavanaugh 008cd89c0d Update booleanTriviaRule.ts 2017-04-05 11:29:47 -07:00
Ryan Cavanaugh 40393c59ea Update booleanTriviaRule.ts 2017-04-05 07:35:03 -07:00
Ryan Cavanaugh e3bb5d3f28 Update linting to avoid typechecking for booleanTriviaRule 2017-04-04 22:34:51 -07:00
Andy Hanson d58cfa238b Merge branch 'master' into lint_better 2017-03-06 06:20:48 -08:00
Vladimir Matveev b1520345be use ES6 library when building tslint rules (#14474) 2017-03-05 15:41:47 -08:00
Andy Hanson 8371eb6401 Update tslint to latest (next is still on 4.3) and lint for BOM 2017-03-01 10:37:13 -08:00
Ryan Cavanaugh aec310996c Language service extensibility 2017-02-14 13:35:16 -08:00
Andy Hanson 9e33585a80 Merge branch 'master' into map5 2016-12-27 12:56:05 -08:00
Kagami Sascha Rosylight 27ed5b8504 remove preferConstRule.ts 2016-12-19 13:30:32 +09:00
Andy Hanson 6b1cc8972d Use native maps when they're available 2016-12-08 06:40:31 -08:00
Vladimir Matveev eaf791e328 update to tslint@next 2016-11-18 22:53:38 -08:00
Andy Hanson 12f6dcefa1 Revert "Merge pull request #11354 from Microsoft/map4" 
This reverts commit adfdae0dc4, reversing
changes made to aad663cebf.
 2016-10-27 15:50:21 -07:00
Andy Hanson bcc0807198 Respond to PR comments 2016-10-27 13:14:56 -07:00