Commit graph

17876 commits

Author SHA1 Message Date
Nathan Shively-Sanders
995f1a6757 Update baselines 2017-05-16 09:53:38 -07:00
Nathan Shively-Sanders
353d9e2310 Clean up original errors
The old "supplied parameters do not match any call signature" was
either inaccurate, redundant or vague. The previous commits fix the
vagueness problem. This commit fixes the inaccuracy and redundancy.

1. When there are NO candidates, the error should say so. (This only
happens once in our tests, when calling `super()` with a base class of
type `any` in a JS file.)
2. When the call is to a decorator, `resolveCall` already receives a
specific fallback error message from the decorator handling code. Adding
"supplied parameters do not match ..." is not helpful.

I also cleaned up the new code a bit after I noticed that all the error
creation functions take `string | number`, so I didn't need calls to
`toString` in my code.
2017-05-16 09:48:23 -07:00
Andy Hanson
badfcbfb43 findAncestor: Add generic overload for use with type predicates 2017-05-16 09:45:01 -07:00
Andy Hanson
ffa21fe271 getDeclarationOfKind: Improve type safety 2017-05-16 09:38:26 -07:00
Anders Hejlsberg
2a9a6e821f Merge pull request #15863 from Microsoft/fixRedundantTypeInference
Eliminate redundant work in type inference
2017-05-16 09:34:31 -07:00
Anders Hejlsberg
ed1a6c10e2 Address CR feedback + defer creation of visited map 2017-05-16 09:12:32 -07:00
Nathan Shively-Sanders
ca61755eb5 Update baselines with new error numbers 2017-05-16 08:07:04 -07:00
Nathan Shively-Sanders
381f056c68 Split error messages so they are localisable 2017-05-16 08:05:07 -07:00
Andy Hanson
2d3c7bae24 break -> continue 2017-05-16 07:10:38 -07:00
Arthur Ozga
b2176c1872 no ascii escaping in param names 2017-05-15 19:11:36 -07:00
Arthur Ozga
a9ab30c068 revert baselines 2017-05-15 18:43:06 -07:00
Arthur Ozga
bba41a8a0c avoid ascii escaping literal text 2017-05-15 18:42:49 -07:00
Nathan Shively-Sanders
c9308fc610 Update baselines 2017-05-15 16:22:35 -07:00
Nathan Shively-Sanders
35a9be3b6c Improve arity errors for all calls
Not just ones with a single call signature.
This is pretty great!
2017-05-15 16:22:04 -07:00
Mohamed Hegazy
d51e467238 Fix #15463: use intersection types to emulate spread in generic react components (#15851)
* Fix #15463: use intersection types to emulate spread in generic react components

* Fix lint errors

* reverse condition
2017-05-15 15:46:50 -07:00
Ron Buckton
f93c71c34e Merge pull request #15862 from Microsoft/fix15829
Fix issue with throw in async delegator.
2017-05-15 15:37:48 -07:00
Anders Hejlsberg
e9ccb16642 Eliminate redundant exploration in type inference 2017-05-15 15:32:14 -07:00
Ron Buckton
05d2f2d5d9 Fix issue with throw in async delegator. 2017-05-15 15:28:55 -07:00
Nathan Shively-Sanders
e5e833e53e Update baselines 2017-05-15 15:26:22 -07:00
Nathan Shively-Sanders
93b1eafb9f Improve arity error messages
For calls with one signature.
2017-05-15 15:25:21 -07:00
Andy Hanson
4d028a81ee getTokenAtPositionWorker: Remove duplicate loop 2017-05-15 15:18:31 -07:00
Andy Hanson
0140e6df77 Remove goToImplementation test, not supported for parameters 2017-05-15 15:02:47 -07:00
Andy Hanson
38784b761a Support for JSDoc in services 2017-05-15 14:45:30 -07:00
Arthur Ozga
d8f29a5fe8 update tests 2017-05-15 12:42:28 -07:00
Nathan Shively-Sanders
cefcc668a8 Correct test argument in callwithSpread2 2017-05-15 10:55:58 -07:00
Nathan Shively-Sanders
4c80aa17b3 Clean up comments in tests 2017-05-15 10:38:51 -07:00
Andy
687ab54d17 Merge pull request #15846 from Microsoft/findAllRefs_symbolNoName
findAllReferences: In `export default foo`, symbol name is `foo`
2017-05-15 10:38:21 -07:00
Nathan Shively-Sanders
b61eaf70a1 Inline function that is called once 2017-05-15 10:31:47 -07:00
Nathan Shively-Sanders
9ba0668afa Test:spread array after required params 2017-05-15 10:20:28 -07:00
Arthur Ozga
20a4e32bec parenthesization in factory 2017-05-15 10:19:00 -07:00
Nathan Shively-Sanders
26416c32f3 Allow spreading arrays after required parameters
This allows:

1. Spreading arrays into all-optional parameters whose types match.
2. Spreading arrays into parameter lists that are too short and whose
body presumably uses `arguments`.
2017-05-15 10:17:36 -07:00
Andy
278fb803b1 Merge pull request #15781 from Microsoft/inline
Inline resolvedModuleFromResolved
2017-05-15 09:51:01 -07:00
Nathan Shively-Sanders
fceb897f75 Merge pull request #15843 from DickvdBrink/issue-15828
Allow const enum to be used before declaration
2017-05-15 09:06:08 -07:00
Andy Hanson
5eb2bd08ac findAllReferences: In export default foo, symbol name is foo 2017-05-15 08:34:05 -07:00
Dick van den Brink
0cd2245c9a Accept baselines for const enum changes 2017-05-15 14:57:24 +02:00
Dick van den Brink
8af5910555 Only report used before declaration errors on regular enums
const enums don't generate code and the values are inlined so now error is necessary
2017-05-15 14:55:17 +02:00
Arthur Ozga
6fd86b47f9 temp 2017-05-12 17:51:14 -07:00
Arthur Ozga
9e9054bd2b handle todo 2017-05-12 17:42:10 -07:00
Ron Buckton
50e2912cd2 Merge pull request #15791 from Microsoft/fix13935
Adds CommaList to avoid large deeply nested comma expressions
2017-05-12 16:49:13 -07:00
Mohamed Hegazy
3e13fadd95 Merge pull request #15808 from alexeagle/master
Extract diagnostics formatter used by --pretty
2017-05-12 16:45:14 -07:00
Arthur Ozga
a32bc985bf respond to comments 2017-05-12 16:27:35 -07:00
Alex Eagle
4240f6f5d9 Extract diagnostics formatter used by --pretty
This allows compilers other than tsc.js to display nice in-context diagnostics
2017-05-12 16:19:46 -07:00
Sheetal Nandi
2300a99606 Merge pull request #15614 from Microsoft/completionListForClassElementDeclarations
When writing class elements show completion with allowed keywords and inheritted properties
2017-05-12 16:10:47 -07:00
Sheetal Nandi
303d7b209e Merge branch 'master' into completionListForClassElementDeclarations 2017-05-12 15:31:52 -07:00
Mohamed Hegazy
0455aaf427 Merge pull request #15805 from Microsoft/Fix14661
Add insertSpaceAfterTypeAssertion to the server protocol
2017-05-12 15:10:46 -07:00
Mohamed Hegazy
ca748d6c02 Add insertSpaceAfterTypeAssertion to the server protocol 2017-05-12 14:48:13 -07:00
Arthur Ozga
0588f8b380 cleanup 2017-05-12 13:56:54 -07:00
Arthur Ozga
62dbf12825 Merge branch 'master' into typeToStringViaTypeNode 2017-05-12 13:09:43 -07:00
Mohamed Hegazy
d68b436e7d Merge pull request #15789 from Microsoft/master-fix15742
[Master] fix15742
2017-05-12 12:22:43 -07:00
Sheetal Nandi
99ea9c730f Add the members of interfaces that need to be implemented to class element completion 2017-05-12 12:13:16 -07:00