Commit graph

213 commits

Author SHA1 Message Date
Mohamed Hegazy 901c72808d Merge branch 'master' into emitDeclarationWithNoResolve 2014-09-05 13:07:14 -07:00
Mohamed Hegazy cc3cae34e9 respond to code review remarks and reverted tryResolveScriptReference to resolveScriptReference 2014-09-05 13:06:10 -07:00
Sheetal Nandi 0dc95ceb60 Use double quotes in declaration file's reference path generation so that quotes in file name wouldnt affect reference resolution
Fixes #474
2014-09-04 16:21:56 -07:00
Mohamed Hegazy acf557dd3c Do not emit references in generated declaration files if the --noresolve flag was set. This fixes a crash in the compiler when generating declarations with /// reference and noResolve 2014-09-04 13:16:22 -07:00
Sheetal Nandi 3cc4b73858 Merge pull request #570 from Microsoft/linemaps
Handles all the line breaks in calculation of line-character position
2014-09-04 09:53:06 -07:00
Sheetal Nandi 7181184e32 Fixed the parenthesis around the expression around line indent calculation 2014-09-02 21:13:11 -07:00
Sheetal Nandi 223aaca674 Corrected linepos assignment 2014-09-02 21:11:21 -07:00
Sheetal Nandi 816b018ae2 Fix the tab and indent calculation when formatting comments in the emitted output 2014-08-29 20:49:47 -07:00
Sheetal Nandi c2b78ead05 Handles all the line breaks in calculation of line-character position
lineFeed = 0x0A,              // \n
        carriageReturn = 0x0D,        // \r
        lineSeparator = 0x2028,
        paragraphSeparator = 0x2029,
        nextLine = 0x0085,

Fixes #131
2014-08-29 17:27:47 -07:00
Mohamed Hegazy 49d8157d28 ensure that sys is not used outside tsc.ts 2014-08-28 23:10:05 -07:00
Sheetal Nandi c4fdccacb8 Emit pinned/tripleslash reference comments of elided module declaration
Fixes #501
2014-08-22 16:10:33 -07:00
Sheetal Nandi 5353128387 Emit pinned/tripleslash reference comments of ambient declarations
Fixes #501
2014-08-22 16:10:26 -07:00
Sheetal Nandi 393464eb18 Emit pinned/tripleslash reference comments of interfaces
Fixes #501
2014-08-22 16:10:19 -07:00
Sheetal Nandi 85b892fd6a Emit pinned/tripleslash reference comments of signatures
Fixes #501
2014-08-22 16:10:11 -07:00
Sheetal Nandi 53d79a25d3 Emit leading comments for '}' of the constructor block
Fixes #503
2014-08-21 17:17:32 -07:00
Sheetal Nandi 45e76e2bd2 Emit leading comments for '}' of the function block
Fixes #503
2014-08-21 17:17:02 -07:00
Sheetal Nandi 3e2de14933 Emit new lines between source files emit so that the file contents always start on new line
Fixes #500
2014-08-21 13:44:26 -07:00
Sheetal Nandi 6e4d0ef1ef Merge pull request #452 from Microsoft/emitComments
Emit comments in the .js and .d.ts files
2014-08-20 17:07:24 -07:00
Sheetal Nandi 8050959c10 Some minor changes as per code review feedback 2014-08-20 16:50:28 -07:00
Sheetal Nandi 21020a71d1 Use local source file text to record source map span start 2014-08-19 20:33:36 -07:00
Sheetal Nandi 0636a067fc Fix the new sourceMapRecording correctly if the multiple files output to single js file and the file ends with interface definition 2014-08-19 20:21:54 -07:00
Sheetal Nandi b5bd1bf505 Emit detached comments for constructor body 2014-08-19 12:38:56 -07:00
Sheetal Nandi ebd00bd1bc Emit detached comments for function body 2014-08-19 12:06:52 -07:00
Sheetal Nandi a11ad539c4 Emit copyright headers before anything else in the sourceFile 2014-08-19 10:43:13 -07:00
Sheetal Nandi ce89da227d Include previous token trailing comments for parameters and type parameters as part of leading comments of them 2014-08-19 10:00:38 -07:00
Sheetal Nandi e0faa65d4b Merge pull request #455 from Microsoft/formatComment
Align the multiline comments in the generated outputs by retaining its position relative to the first line in the comment
2014-08-18 13:26:18 -07:00
Sheetal Nandi 6ad8fa6377 Simplify comment alignment logic 2014-08-15 16:58:38 -07:00
Sheetal Nandi 94e0d953c5 Makes sure leading comments are emitting only once 2014-08-15 15:52:30 -07:00
Sheetal Nandi c4b22d338f Emit comments for expression statements 2014-08-15 15:49:09 -07:00
Sheetal Nandi 0a75cc2926 Emit comments for if statement 2014-08-15 15:32:43 -07:00
Sheetal Nandi 6036c92784 Emit leading/trailing comments of ifStatement 2014-08-15 15:24:44 -07:00
Sheetal Nandi 1b5023bad3 Emit leading/trailing comments for return statement
Note the detachedComments and copyright headers comment emitting is not part of this change
2014-08-15 15:16:17 -07:00
Sheetal Nandi 09b20d5357 Fixed according to code review feedback 2014-08-15 14:43:22 -07:00
Sheetal Nandi 6ab3adfd43 Modified the emitComment logic to handle emitting leading or trailing spaces depending on flags
Leading comments have trailing separator while trailing comments have leading space
This removes the extra trailing space in the trailing comments
2014-08-15 14:32:08 -07:00
Sheetal Nandi 45e8ff8467 Emit the new line before leading declaration comments in the declaration file if source code had it 2014-08-15 14:21:41 -07:00
Sheetal Nandi 3dd21fc3a7 Trailing comment tests for parameters, fixes the trailing // comments and parameter indentation 2014-08-15 13:18:54 -07:00
Sheetal Nandi 29dcc5ba41 Start leading comments on new line if the comment starts on different line as node 2014-08-15 12:17:36 -07:00
Sheetal Nandi adc700aba5 Emit space before emitting trailing comments 2014-08-14 16:36:33 -07:00
Sheetal Nandi f428a16680 Fix the trailing comments for variable declaration and function/arrow expressions 2014-08-14 16:32:21 -07:00
Sheetal Nandi 895a9e7ac5 Some refactoring as suggested in code review feedback 2014-08-14 15:41:57 -07:00
Sheetal Nandi e76d8f36b6 Align the multiline comments in the generated outputs by retaining its position relative to the first line in the comment 2014-08-14 14:43:28 -07:00
Sheetal Nandi 0caa1f6dc7 Emit trailing comments 2014-08-14 09:47:50 -07:00
Sheetal Nandi c949543f49 Fix the indent for the parameter and typeparameter emit in .d.ts file 2014-08-14 09:38:22 -07:00
Sheetal Nandi b8bbb0d547 Declaration comments for parameters in .d.ts file 2014-08-14 09:35:58 -07:00
Sheetal Nandi 6bf73a691a Declaration comments for call, constructo and index signatures in .d.ts 2014-08-14 09:12:20 -07:00
Sheetal Nandi d970c89856 Declaration comments for function declarations in .d.ts 2014-08-14 09:08:53 -07:00
Sheetal Nandi 758fc937e4 Declaration comments for accessors in .d.ts 2014-08-14 09:01:38 -07:00
Sheetal Nandi 83ea28cf39 Declaration comments for the variable declaration in .d.ts 2014-08-14 08:57:28 -07:00
Sheetal Nandi 77a336689f Declaration comments for the property declaration in .d.ts 2014-08-14 08:53:02 -07:00
Sheetal Nandi 5f8f184f9a Declaration comments for the interface declaration in .d.ts 2014-08-14 08:50:17 -07:00
Sheetal Nandi 84dc3ff419 Declaration comments for the class declaration in .d.ts 2014-08-14 08:47:21 -07:00
Sheetal Nandi a828507e4e Declaration comments for the type parameter declaration in .d.ts 2014-08-14 08:23:42 -07:00
Sheetal Nandi 93790c5709 Declaration comments for the enum member declaration in .d.ts 2014-08-14 08:02:03 -07:00
Sheetal Nandi bf2f795807 Declaration comments for the enum declaration in .d.ts 2014-08-14 07:59:41 -07:00
Sheetal Nandi 95a473c6e6 Declaration comments for the module declaration in .d.ts 2014-08-14 07:56:46 -07:00
Sheetal Nandi 5accc9962a Write JsDoc comments for ImportDeclaration in .d.ts file 2014-08-14 07:48:14 -07:00
Sheetal Nandi ea238c47e8 Comments for import declaration 2014-08-14 06:57:59 -07:00
Sheetal Nandi c9d16b002d Comments for module declaration 2014-08-14 06:53:37 -07:00
Sheetal Nandi 84fa5b421a Emit commens for enum and enum members 2014-08-14 06:48:40 -07:00
Sheetal Nandi 6d6f27cdce Emit comments for class and constructor 2014-08-14 06:42:18 -07:00
Sheetal Nandi 72cff32c96 Emit comments for properties 2014-08-14 06:31:00 -07:00
Sheetal Nandi 86c2f2c444 Emit comments for function and method declarations 2014-08-14 06:21:30 -07:00
Sheetal Nandi c9b7c63b63 Emit comments for accessors 2014-08-14 06:12:14 -07:00
Sheetal Nandi d815c14943 Emit the property assignment comments of the object literal 2014-08-14 05:57:24 -07:00
Sheetal Nandi 871507e386 Emit leading and trailing comments for parameter 2014-08-14 05:47:38 -07:00
Sheetal Nandi 3e95358486 Emit comments in the javascript code if --removecomments is not specified 2014-08-14 05:41:04 -07:00
Sheetal Nandi f622cb4d11 Merge pull request #381 from branch 'remote/privacyErrors'
Report privacy errors on variable/property declarations and also emit import declarations that get used to defined visible type
2014-08-13 18:48:05 -07:00
Sheetal Nandi e26d9e57d4 Remove unnecessary sort call in alias declarations that get written 2014-08-13 18:01:58 -07:00
Sheetal Nandi 98f631e23f Make changes to report error if the type used from external module cannot be named
Adds test cases too
2014-08-11 14:15:57 -07:00
Sheetal Nandi 09ea12d95c Use typeof function in the declaration emitter instead of unwinding first level 2014-08-08 16:15:09 -07:00
Sheetal Nandi 1347621d0c Report error if the entityname reference in the import declaration is using private module 2014-08-08 13:56:53 -07:00
Sheetal Nandi 2654eed32d Report privacy errors for accessors 2014-08-06 18:42:14 -07:00
Sheetal Nandi 4cd2d3f8dd Report privacy errors on return types 2014-08-06 17:58:03 -07:00
Sheetal Nandi 41150776d1 Report privacy errors on parameter types 2014-08-06 17:06:59 -07:00
Sheetal Nandi 4b12353a78 Test case for the privacy check of variables and properties during declaration emit 2014-08-06 15:17:44 -07:00
Mohamed Hegazy 9222711ace change name of the flag to emitBOM 2014-08-06 14:24:47 -07:00
Sheetal Nandi 875d0c0c75 Emit unexported aliases that need to be emitted to .d.ts to make correct result 2014-08-06 13:12:49 -07:00
Mohamed Hegazy f125ee20bb Merge branch 'master' into bom
Conflicts:
	src/compiler/commandLineParser.ts
	src/compiler/emitter.ts
2014-08-06 12:55:57 -07:00
Sheetal Nandi 00b4c2e96d Report errors on properties and variable type visibility
Fixes #69
2014-08-06 11:53:54 -07:00
Sheetal Nandi 5c4009a163 Merge pull request #161 from Microsoft/privacyErrors
Report errors for usage of private types when generating declaration file
2014-08-06 11:51:55 -07:00
Mohamed Hegazy b1335e1795 add generateBOM switch 2014-08-06 11:37:59 -07:00
Sheetal Nandi 0e76a82072 Fix the incorrect error reporting and declaration file emit for the type parameter constraint of private methods
Also incorporates code review feedback
2014-08-04 12:06:07 -07:00
Vladimir Matveev c0b3efbbb4 emit this capturing as a first action in the constructor 2014-08-01 11:16:09 -07:00
Mohamed Hegazy 2ed3de1c28 push newline to compilerhost instead of using sys directelly. This allows the language service to set it, as sys is not defined in language service scenarios 2014-07-29 12:06:43 -07:00
Vladimir Matveev 9112a0e2e2 enabled strict mode 2014-07-24 13:01:25 -07:00
Anders Hejlsberg 85225c8f29 Ensuring local module names are unique in emit.
Fixes #41 and #42.
2014-07-21 11:17:44 -07:00
Jason Freeman 91d31c7f51 Add error about missing module flag to createProgram 2014-07-21 09:38:59 -07:00
Sheetal Nandi 9fd95fcb95 Report errors if the type parameter uses constraint that is using private type/module
Fixes #86
2014-07-18 18:11:04 -07:00
Sheetal Nandi 09ec1bb9ae Report error on Class/Interface heritage clause if it cant be accessed
Fixes #78 and #83
2014-07-18 18:07:38 -07:00
Sheetal Nandi 999b7fed92 Checker and emitter changes to report errors on inaccessibility of symbols when writing types in declaration file 2014-07-18 18:06:37 -07:00
Sheetal Nandi bbb36dc933 Make the symbol writing api on the text writer 2014-07-18 17:50:12 -07:00
Vladimir Matveev 36c22d10c7 emit 'use strict' at the beginning of the function 2014-07-18 16:59:52 -07:00
Mohamed Hegazy 91b8a4531f Merge pull request #145 from Microsoft/restConstructorParam
Issue #144: Do not emit the name of the rest paramter in constructors
2014-07-18 09:57:49 -07:00
Mohamed Hegazy c9c0166b04 fix typo in function name 2014-07-18 09:56:18 -07:00
Sheetal Nandi 3665e45d19 Merge pull request #141 from Microsoft/typoInDeclFileEmit
Fixed the typo in declaration emitter of implements clause
2014-07-17 22:21:51 -07:00
Mohamed Hegazy b744633656 Issue# 144: Do not emit the name of the rest paramter in constructors 2014-07-17 19:54:21 -07:00
Sheetal Nandi 586b773fbe Fixed the typo in declaration emitter of implements clause 2014-07-17 18:16:24 -07:00
Vladimir Matveev 4068404cd4 emit prologue directives as first lines in file 2014-07-17 17:43:48 -07:00
Sheetal Nandi 96700069fc renamed isEmitToOwnFile to shouldEmitToOwnFile as per feedback 2014-07-17 12:53:07 -07:00
Sheetal Nandi b7feb1555b Renamed emitToOwnOutputFile to isEmitToOwnOutputFile 2014-07-17 09:27:28 -07:00
Sheetal Nandi d9196d66b6 Moved the emit functionality into emitFiles 2014-07-16 15:39:14 -07:00
Sheetal Nandi fe1fea3710 Merge pull request #30 from Microsoft/declarations
Changes to determine when to qualify the symbol in given enclosing declaration
2014-07-16 15:20:00 -07:00
Sheetal Nandi 148abea09d Use the isDeclarationVisible in checker to determine if the declaration needs to be emitted
This would help in unifying logic of when to check if the type is visible
2014-07-16 11:37:49 -07:00
Anders Hejlsberg c1d0fd979d More I/O fixes
Support for --charset command line option
File read and write errors are propagated into compiler diagnostics
emitFiles returns diagnostics in EmitResult
2014-07-16 10:57:05 -07:00
Sheetal Nandi 574c075dba Emit the types in declaration file 2014-07-15 13:08:10 -07:00
Sheetal Nandi 455364cf5a Do not emit the signature for implementation of overload in the declaration file 2014-07-15 08:58:02 -07:00
Sheetal Nandi d1cdf03d53 Correct the external module check to determine if declaration is part of export assignment 2014-07-15 08:57:48 -07:00
Sheetal Nandi bb7f7fb8dd Correct the condition for variable statement emit in the declaraiton file 2014-07-15 08:57:39 -07:00
Sheetal Nandi cd14e36460 Emit alias declaration if its name is used as identifier of export assignment 2014-07-15 08:57:30 -07:00
Sheetal Nandi 063399d228 Emit declaration if its identifier is used in export assignment of external module 2014-07-15 08:57:22 -07:00
Sheetal Nandi ea7c23eb63 Emit global context declarations into the declaration file 2014-07-15 08:57:12 -07:00
Daniel Rosenwasser ef67d5740e Support emit for trailing comma in array literals. 2014-07-14 14:26:17 -07:00
Mohamed Hegazy 214df64e28 Add snapshot of compiler sources 2014-07-12 17:30:19 -07:00