Update package-lock.json

* Plain JS binder errors

Issue select errors from the binder in JS files that do not have checkJS
explicitly turned on or off. These errors mirror runtime checks done by
Javascript.

* Rest of plain JS binder errors

* address PR comments

* Only issue binder errors in plain JS.

Checker errors require requesting diagnostics, which stll needs to be
peformance tested.

This commit removes one cross-file duplicate declaration error in the tests.

* fix const lint

package-lock.json

@@ -676,9 +676,9 @@
             "dev": true
         },
         "@types/node": {
-            "version": "16.11.7",
-            "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.7.tgz",
-            "integrity": "sha512-QB5D2sqfSjCmTuWcBWyJ+/44bcjO7VbjSbOE0ucoVbAsSNQc4Lt6QkgkVXkTDwkL4z/beecZNDvVX15D4P8Jbw==",
+            "version": "16.11.10",
+            "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.10.tgz",
+            "integrity": "sha512-3aRnHa1KlOEEhJ6+CvyHKK5vE9BcLGjtUpwvqYLRvYNQKMfabu3BwfJaA/SLW8dxe28LsNDjtHwePTuzn3gmOA==",
             "dev": true
         },
         "@types/node-fetch": {
@@ -6997,9 +6997,9 @@
             }
         },
         "source-map-support": {
-            "version": "0.5.20",
-            "resolved": "https://registry.npmjs.org/source-map-support/-/source-map-support-0.5.20.tgz",
-            "integrity": "sha512-n1lZZ8Ve4ksRqizaBQgxXDgKwttHDhyfQjA6YZZn8+AroHbsIz+JjwxQDxbp+7y5OYCI8t1Yk7etjD9CRd2hIw==",
+            "version": "0.5.21",
+            "resolved": "https://registry.npmjs.org/source-map-support/-/source-map-support-0.5.21.tgz",
+            "integrity": "sha512-uBHU3L3czsIyYXKX88fdrGovxdSCoTGDRZ6SYXtSRxLZUzHg5P/66Ht6uoUlHu9EZod+inXhKo3qQgwXUT/y1w==",
             "dev": true,
             "requires": {
                 "buffer-from": "^1.0.0",

src/compiler/checker.ts

@@ -5657,8 +5657,8 @@ namespace ts {
                 const expandedParams = getExpandedParameters(signature, /*skipUnionExpanding*/ true)[0];
                 // If the expanded parameter list had a variadic in a non-trailing position, don't expand it
                 const parameters = (some(expandedParams, p => p !== expandedParams[expandedParams.length - 1] && !!(getCheckFlags(p) & CheckFlags.RestParameter)) ? signature.parameters : expandedParams).map(parameter => symbolToParameterDeclaration(parameter, context, kind === SyntaxKind.Constructor, options?.privateSymbolVisitor, options?.bundledImports));
-                if (signature.thisParameter) {
-                    const thisParameter = symbolToParameterDeclaration(signature.thisParameter, context);
+                const thisParameter = tryGetThisParameterDeclaration(signature, context);
+                if (thisParameter) {
                     parameters.unshift(thisParameter);
                 }
 
@@ -5713,6 +5713,25 @@ namespace ts {
                 return node;
             }
 
+            function tryGetThisParameterDeclaration(signature: Signature, context: NodeBuilderContext) {
+                if (signature.thisParameter) {
+                    return symbolToParameterDeclaration(signature.thisParameter, context);
+                }
+                if (signature.declaration) {
+                    const thisTag = getJSDocThisTag(signature.declaration);
+                    if (thisTag && thisTag.typeExpression) {
+                        return factory.createParameterDeclaration(
+                            /* decorators */ undefined,
+                            /* modifiers */ undefined,
+                            /* dotDotDotToken */ undefined,
+                            "this",
+                            /* questionToken */ undefined,
+                            typeToTypeNodeHelper(getTypeFromTypeNode(thisTag.typeExpression), context)
+                        );
+                    }
+                }
+            }
+
             function typeParameterToDeclarationWithConstraint(type: TypeParameter, context: NodeBuilderContext, constraintNode: TypeNode | undefined): TypeParameterDeclaration {
                 const savedContextFlags = context.flags;
                 context.flags &= ~NodeBuilderFlags.WriteTypeParametersInQualifiedName; // Avoids potential infinite loop when building for a claimspace with a generic
@@ -6204,12 +6223,8 @@ namespace ts {
                             firstChar = symbolName.charCodeAt(0);
                         }
                         let expression: Expression | undefined;
-                        if (isSingleOrDoubleQuote(firstChar)) {
-                            expression = factory.createStringLiteral(
-                                symbolName
-                                    .substring(1, symbolName.length - 1)
-                                    .replace(/\\./g, s => s.substring(1)),
-                                firstChar === CharacterCodes.singleQuote);
+                        if (isSingleOrDoubleQuote(firstChar) && !(symbol.flags & SymbolFlags.EnumMember)) {
+                           expression = factory.createStringLiteral(stripQuotes(symbolName).replace(/\\./g, s => s.substring(1)), firstChar === CharacterCodes.singleQuote);
                         }
                         else if (("" + +symbolName) === symbolName) {
                             expression = factory.createNumericLiteral(+symbolName);
@@ -40407,9 +40422,8 @@ namespace ts {
             const enclosingFile = getSourceFileOfNode(node);
             const links = getNodeLinks(enclosingFile);
             if (!(links.flags & NodeCheckFlags.TypeChecked)) {
-                links.deferredNodes = links.deferredNodes || new Map();
-                const id = getNodeId(node);
-                links.deferredNodes.set(id, node);
+                links.deferredNodes ||= new Set();
+                links.deferredNodes.add(node);
             }
         }
 

src/compiler/core.ts

@@ -23,34 +23,6 @@ namespace ts {
     export const emptyMap: ReadonlyESMap<never, never> = new Map<never, never>();
     export const emptySet: ReadonlySet<never> = new Set<never>();
 
-    /**
-     * Create a new map.
-     * @deprecated Use `new Map()` instead.
-     */
-    export function createMap<K, V>(): ESMap<K, V>;
-    export function createMap<T>(): ESMap<string, T>;
-    export function createMap<K, V>(): ESMap<K, V> {
-        return new Map<K, V>();
-    }
-
-    /**
-     * Create a new map from a template object is provided, the map will copy entries from it.
-     * @deprecated Use `new Map(getEntries(template))` instead.
-     */
-    export function createMapFromTemplate<T>(template: MapLike<T>): ESMap<string, T> {
-        const map: ESMap<string, T> = new Map<string, T>();
-
-        // Copies keys/values from template. Note that for..in will not throw if
-        // template is undefined, and instead will just exit the loop.
-        for (const key in template) {
-            if (hasOwnProperty.call(template, key)) {
-                map.set(key, template[key]);
-            }
-        }
-
-        return map;
-    }
-
     export function length(array: readonly any[] | undefined): number {
         return array ? array.length : 0;
     }

src/compiler/debug.ts

@@ -171,12 +171,6 @@ namespace ts {
             return value;
         }
 
-        /**
-         * @deprecated Use `checkDefined` to check whether a value is defined inline. Use `assertIsDefined` to check whether
-         * a value is defined at the statement level.
-         */
-        export const assertDefined = checkDefined;
-
         export function assertEachIsDefined<T extends Node>(value: NodeArray<T>, message?: string, stackCrawlMark?: AnyFunction): asserts value is NodeArray<T>;
         export function assertEachIsDefined<T>(value: readonly T[], message?: string, stackCrawlMark?: AnyFunction): asserts value is readonly NonNullable<T>[];
         export function assertEachIsDefined<T>(value: readonly T[], message?: string, stackCrawlMark?: AnyFunction) {
@@ -190,12 +184,6 @@ namespace ts {
             return value;
         }
 
-        /**
-         * @deprecated Use `checkEachDefined` to check whether the elements of an array are defined inline. Use `assertEachIsDefined` to check whether
-         * the elements of an array are defined at the statement level.
-         */
-        export const assertEachDefined = checkEachDefined;
-
         export function assertNever(member: never, message = "Illegal value:", stackCrawlMark?: AnyFunction): never {
             const detail = typeof member === "object" && hasProperty(member, "kind") && hasProperty(member, "pos") && formatSyntaxKind ? "SyntaxKind: " + formatSyntaxKind((member as Node).kind) : JSON.stringify(member);
             return fail(`${message} ${detail}`, stackCrawlMark || assertNever);

src/compiler/factory/nodeFactory.ts

@@ -6387,7 +6387,7 @@ namespace ts {
             sourceMapText = mapTextOrStripInternal as string;
         }
         const node = oldFileOfCurrentEmit ?
-            parseOldFileOfCurrentEmit(Debug.assertDefined(bundleFileInfo)) :
+            parseOldFileOfCurrentEmit(Debug.checkDefined(bundleFileInfo)) :
             parseUnparsedSourceFile(bundleFileInfo, stripInternal, length);
         node.fileName = fileName;
         node.sourceMapPath = sourceMapPath;
@@ -6587,13 +6587,13 @@ namespace ts {
             };
             node.javascriptPath = declarationTextOrJavascriptPath;
             node.javascriptMapPath = javascriptMapPath;
-            node.declarationPath = Debug.assertDefined(javascriptMapTextOrDeclarationPath);
+            node.declarationPath = Debug.checkDefined(javascriptMapTextOrDeclarationPath);
             node.declarationMapPath = declarationMapPath;
             node.buildInfoPath = declarationMapTextOrBuildInfoPath;
             Object.defineProperties(node, {
                 javascriptText: { get() { return definedTextGetter(declarationTextOrJavascriptPath); } },
                 javascriptMapText: { get() { return textGetter(javascriptMapPath); } }, // TODO:: if there is inline sourceMap in jsFile, use that
-                declarationText: { get() { return definedTextGetter(Debug.assertDefined(javascriptMapTextOrDeclarationPath)); } },
+                declarationText: { get() { return definedTextGetter(Debug.checkDefined(javascriptMapTextOrDeclarationPath)); } },
                 declarationMapText: { get() { return textGetter(declarationMapPath); } }, // TODO:: if there is inline sourceMap in dtsFile, use that
                 buildInfo: { get() { return getAndCacheBuildInfo(() => textGetter(declarationMapTextOrBuildInfoPath)); } }
             });

src/compiler/program.ts

@@ -818,6 +818,25 @@ namespace ts {
         }
     }
 
+    /** @internal */
+    export const plainJSErrors: Set<number> = new Set([
+        Diagnostics.Cannot_redeclare_block_scoped_variable_0.code,
+        Diagnostics.A_module_cannot_have_multiple_default_exports.code,
+        Diagnostics.Another_export_default_is_here.code,
+        Diagnostics.The_first_export_default_is_here.code,
+        Diagnostics.Identifier_expected_0_is_a_reserved_word_at_the_top_level_of_a_module.code,
+        Diagnostics.Identifier_expected_0_is_a_reserved_word_in_strict_mode_Modules_are_automatically_in_strict_mode.code,
+        Diagnostics.Identifier_expected_0_is_a_reserved_word_that_cannot_be_used_here.code,
+        Diagnostics.constructor_is_a_reserved_word.code,
+        Diagnostics.delete_cannot_be_called_on_an_identifier_in_strict_mode.code,
+        Diagnostics.Code_contained_in_a_class_is_evaluated_in_JavaScript_s_strict_mode_which_does_not_allow_this_use_of_0_For_more_information_see_https_Colon_Slash_Slashdeveloper_mozilla_org_Slashen_US_Slashdocs_SlashWeb_SlashJavaScript_SlashReference_SlashStrict_mode.code,
+        Diagnostics.Invalid_use_of_0_Modules_are_automatically_in_strict_mode.code,
+        Diagnostics.Invalid_use_of_0_in_strict_mode.code,
+        Diagnostics.A_label_is_not_allowed_here.code,
+        Diagnostics.Octal_literals_are_not_allowed_in_strict_mode.code,
+        Diagnostics.with_statements_are_not_allowed_in_strict_mode.code,
+    ]);
+
     /**
      * Determine if source file needs to be re-created even if its text hasn't changed
      */
@@ -1577,6 +1596,7 @@ namespace ts {
                 newSourceFile.originalFileName = oldSourceFile.originalFileName;
                 newSourceFile.resolvedPath = oldSourceFile.resolvedPath;
                 newSourceFile.fileName = oldSourceFile.fileName;
+                newSourceFile.impliedNodeFormat = oldSourceFile.impliedNodeFormat;
 
                 const packageName = oldProgram.sourceFileToPackageName.get(oldSourceFile.path);
                 if (packageName !== undefined) {
@@ -2004,15 +2024,24 @@ namespace ts {
 
                 Debug.assert(!!sourceFile.bindDiagnostics);
 
-                const isCheckJs = isCheckJsEnabledForFile(sourceFile, options);
+                const isJs = sourceFile.scriptKind === ScriptKind.JS || sourceFile.scriptKind === ScriptKind.JSX;
+                const isCheckJs = isJs && isCheckJsEnabledForFile(sourceFile, options);
+                const isPlainJs = isJs && !sourceFile.checkJsDirective && options.checkJs === undefined;
                 const isTsNoCheck = !!sourceFile.checkJsDirective && sourceFile.checkJsDirective.enabled === false;
-                // By default, only type-check .ts, .tsx, 'Deferred' and 'External' files (external files are added by plugins)
-                const includeBindAndCheckDiagnostics = !isTsNoCheck && (sourceFile.scriptKind === ScriptKind.TS || sourceFile.scriptKind === ScriptKind.TSX
-                    || sourceFile.scriptKind === ScriptKind.External || isCheckJs || sourceFile.scriptKind === ScriptKind.Deferred);
-                const bindDiagnostics: readonly Diagnostic[] = includeBindAndCheckDiagnostics ? sourceFile.bindDiagnostics : emptyArray;
-                const checkDiagnostics = includeBindAndCheckDiagnostics ? typeChecker.getDiagnostics(sourceFile, cancellationToken) : emptyArray;
 
-                return getMergedBindAndCheckDiagnostics(sourceFile, includeBindAndCheckDiagnostics, bindDiagnostics, checkDiagnostics, isCheckJs ? sourceFile.jsDocDiagnostics : undefined);
+                // By default, only type-check .ts, .tsx, Deferred, plain JS, checked JS and External
+                // - plain JS: .js files with no // ts-check and checkJs: undefined
+                // - check JS: .js files with either // ts-check or checkJs: true
+                // - external: files that are added by plugins
+                const includeBindAndCheckDiagnostics = !isTsNoCheck && (sourceFile.scriptKind === ScriptKind.TS || sourceFile.scriptKind === ScriptKind.TSX
+                        || sourceFile.scriptKind === ScriptKind.External || isPlainJs || isCheckJs || sourceFile.scriptKind === ScriptKind.Deferred);
+                let bindDiagnostics: readonly Diagnostic[] = includeBindAndCheckDiagnostics ? sourceFile.bindDiagnostics : emptyArray;
+                const checkDiagnostics = includeBindAndCheckDiagnostics && !isPlainJs ? typeChecker.getDiagnostics(sourceFile, cancellationToken) : emptyArray;
+                if (isPlainJs) {
+                    bindDiagnostics = filter(bindDiagnostics, d => plainJSErrors.has(d.code));
+                }
+                // skip ts-expect-error errors in plain JS files, and skip JSDoc errors except in checked JS
+                return getMergedBindAndCheckDiagnostics(sourceFile, includeBindAndCheckDiagnostics && !isPlainJs, bindDiagnostics, checkDiagnostics, isCheckJs ? sourceFile.jsDocDiagnostics : undefined);
             });
         }
 
@@ -3160,7 +3189,7 @@ namespace ts {
         }
 
         function verifyCompilerOptions() {
-            const isNightly = stringContains(version, "-dev");
+            const isNightly = stringContains(version, "-dev") || stringContains(version, "-insiders");
             if (!isNightly) {
                 if (getEmitModuleKind(options) === ModuleKind.Node12) {
                     createOptionValueDiagnostic("module", Diagnostics.Compiler_option_0_of_value_1_is_unstable_Use_nightly_TypeScript_to_silence_this_error_Try_updating_with_npm_install_D_typescript_next, "module", "node12");

src/compiler/resolutionCache.ts

@@ -619,7 +619,7 @@ namespace ts {
         ) {
             if (resolution.refCount) {
                 resolution.refCount++;
-                Debug.assertDefined(resolution.files);
+                Debug.assertIsDefined(resolution.files);
             }
             else {
                 resolution.refCount = 1;
@@ -696,7 +696,7 @@ namespace ts {
             filePath: Path,
             getResolutionWithResolvedFileName: GetResolutionWithResolvedFileName<T, R>,
         ) {
-            unorderedRemoveItem(Debug.assertDefined(resolution.files), filePath);
+            unorderedRemoveItem(Debug.checkDefined(resolution.files), filePath);
             resolution.refCount!--;
             if (resolution.refCount) {
                 return;
@@ -798,7 +798,7 @@ namespace ts {
             for (const resolution of resolutions) {
                 if (resolution.isInvalidated || !canInvalidate(resolution)) continue;
                 resolution.isInvalidated = invalidated = true;
-                for (const containingFilePath of Debug.assertDefined(resolution.files)) {
+                for (const containingFilePath of Debug.checkDefined(resolution.files)) {
                     (filesWithInvalidatedResolutions || (filesWithInvalidatedResolutions = new Set())).add(containingFilePath);
                     // When its a file with inferred types resolution, invalidate type reference directive resolution
                     hasChangedAutomaticTypeDirectiveNames = hasChangedAutomaticTypeDirectiveNames || endsWith(containingFilePath, inferredTypesContainingFile);

src/compiler/transformers/es2018.ts

@@ -282,7 +282,7 @@ namespace ts {
         function visitYieldExpression(node: YieldExpression) {
             if (enclosingFunctionFlags & FunctionFlags.Async && enclosingFunctionFlags & FunctionFlags.Generator) {
                 if (node.asteriskToken) {
-                    const expression = visitNode(Debug.assertDefined(node.expression), visitor, isExpression);
+                    const expression = visitNode(Debug.checkDefined(node.expression), visitor, isExpression);
 
                     return setOriginalNode(
                         setTextRange(

src/compiler/transformers/jsx.ts

@@ -48,11 +48,11 @@ namespace ts {
                 return existing.name;
             }
             if (!currentFileState.utilizedImplicitRuntimeImports) {
-                currentFileState.utilizedImplicitRuntimeImports = createMap();
+                currentFileState.utilizedImplicitRuntimeImports = new Map();
             }
             let specifierSourceImports = currentFileState.utilizedImplicitRuntimeImports.get(importSource);
             if (!specifierSourceImports) {
-                specifierSourceImports = createMap();
+                specifierSourceImports = new Map();
                 currentFileState.utilizedImplicitRuntimeImports.set(importSource, specifierSourceImports);
             }
             const generatedName = factory.createUniqueName(`_${name}`, GeneratedIdentifierFlags.Optimistic | GeneratedIdentifierFlags.FileLevel | GeneratedIdentifierFlags.AllowNameSubstitution);

src/compiler/types.ts

@@ -1609,7 +1609,7 @@ namespace ts {
     export interface TypePredicateNode extends TypeNode {
         readonly kind: SyntaxKind.TypePredicate;
         readonly parent: SignatureDeclaration | JSDocTypeExpression;
-        readonly assertsModifier?: AssertsToken;
+        readonly assertsModifier?: AssertsKeyword;
         readonly parameterName: Identifier | ThisTypeNode;
         readonly type?: TypeNode;
     }
@@ -1702,7 +1702,7 @@ namespace ts {
 
     export interface MappedTypeNode extends TypeNode, Declaration {
         readonly kind: SyntaxKind.MappedType;
-        readonly readonlyToken?: ReadonlyToken | PlusToken | MinusToken;
+        readonly readonlyToken?: ReadonlyKeyword | PlusToken | MinusToken;
         readonly typeParameter: TypeParameterDeclaration;
         readonly nameType?: TypeNode;
         readonly questionToken?: QuestionToken | PlusToken | MinusToken;
@@ -2756,7 +2756,7 @@ namespace ts {
 
     export interface ForOfStatement extends IterationStatement {
         readonly kind: SyntaxKind.ForOfStatement;
-        readonly awaitModifier?: AwaitKeywordToken;
+        readonly awaitModifier?: AwaitKeyword;
         readonly initializer: ForInitializer;
         readonly expression: Expression;
     }
@@ -5107,7 +5107,7 @@ namespace ts {
         jsxNamespace?: Symbol | false;      // Resolved jsx namespace symbol for this node
         jsxImplicitImportContainer?: Symbol | false; // Resolved module symbol the implicit jsx import of this file should refer to
         contextFreeType?: Type;             // Cached context-free type used by the first pass of inference; used when a function's return is partially contextually sensitive
-        deferredNodes?: ESMap<NodeId, Node>; // Set of nodes whose checking has been deferred
+        deferredNodes?: Set<Node>;          // Set of nodes whose checking has been deferred
         capturedBlockScopeBindings?: Symbol[]; // Block-scoped bindings captured beneath this part of an IterationStatement
         outerTypeParameters?: TypeParameter[]; // Outer type parameters of anonymous object type
         isExhaustive?: boolean;             // Is node an exhaustive switch statement

src/compiler/utilities.ts

@@ -20,21 +20,6 @@ namespace ts {
         return undefined;
     }
 
-    /**
-     * Create a new escaped identifier map.
-     * @deprecated Use `new Map<__String, T>()` instead.
-     */
-    export function createUnderscoreEscapedMap<T>(): UnderscoreEscapedMap<T> {
-        return new Map<__String, T>();
-    }
-
-    /**
-     * @deprecated Use `!!map?.size` instead
-     */
-    export function hasEntries(map: ReadonlyCollection<any> | undefined): map is ReadonlyCollection<any> {
-        return !!map && !!map.size;
-    }
-
     export function createSymbolTable(symbols?: readonly Symbol[]): SymbolTable {
         const result = new Map<__String, Symbol>();
         if (symbols) {
@@ -6994,18 +6979,6 @@ namespace ts {
         return { min, max };
     }
 
-    /** @deprecated Use `ReadonlySet<TNode>` instead. */
-    export type ReadonlyNodeSet<TNode extends Node> = ReadonlySet<TNode>;
-
-    /** @deprecated Use `Set<TNode>` instead. */
-    export type NodeSet<TNode extends Node> = Set<TNode>;
-
-    /** @deprecated Use `ReadonlyMap<TNode, TValue>` instead. */
-    export type ReadonlyNodeMap<TNode extends Node, TValue> = ReadonlyESMap<TNode, TValue>;
-
-    /** @deprecated Use `Map<TNode, TValue>` instead. */
-    export type NodeMap<TNode extends Node, TValue> = ESMap<TNode, TValue>;
-
     export function rangeOfNode(node: Node): TextRange {
         return { pos: getTokenPosOfNode(node), end: node.end };
     }

src/harness/fourslashImpl.ts

@@ -637,7 +637,8 @@ namespace FourSlash {
             ts.forEachKey(this.inputFiles, fileName => {
                 if (!ts.isAnySupportedFileExtension(fileName)
                     || Harness.getConfigNameFromFileName(fileName)
-                    || !ts.getAllowJSCompilerOption(this.getProgram().getCompilerOptions()) && !ts.resolutionExtensionIsTSOrJson(ts.extensionFromPath(fileName))
+                    // Can't get a Program in Server tests
+                    || this.testType !== FourSlashTestType.Server && !ts.getAllowJSCompilerOption(this.getProgram().getCompilerOptions()) && !ts.resolutionExtensionIsTSOrJson(ts.extensionFromPath(fileName))
                     || ts.getBaseFileName(fileName) === "package.json") return;
                 const errors = this.getDiagnostics(fileName).filter(e => e.category !== ts.DiagnosticCategory.Suggestion);
                 if (errors.length) {

src/server/project.ts

@@ -1944,15 +1944,15 @@ namespace ts.server {
                 for (const resolution of resolutions) {
                     if (!resolution.resolvedFileName) continue;
                     const { resolvedFileName, originalPath } = resolution;
+                    if (originalPath) {
+                        symlinkCache.setSymlinkedDirectoryFromSymlinkedFile(originalPath, resolvedFileName);
+                    }
                     if (!program.getSourceFile(resolvedFileName) && (!originalPath || !program.getSourceFile(originalPath))) {
                         rootNames = append(rootNames, resolvedFileName);
                         // Avoid creating a large project that would significantly slow down time to editor interactivity
                         if (dependencySelection === PackageJsonAutoImportPreference.Auto && rootNames.length > this.maxDependencies) {
                             return ts.emptyArray;
                         }
-                        if (originalPath) {
-                            symlinkCache.setSymlinkedDirectoryFromSymlinkedFile(originalPath, resolvedFileName);
-                        }
                     }
                 }
             }

src/server/session.ts

@@ -2112,7 +2112,7 @@ namespace ts.server {
         private getFullNavigateToItems(args: protocol.NavtoRequestArgs): CombineOutputResult<NavigateToItem> {
             const { currentFileOnly, searchValue, maxResultCount, projectFileName } = args;
             if (currentFileOnly) {
-                Debug.assertDefined(args.file);
+                Debug.assertIsDefined(args.file);
                 const { file, project } = this.getFileAndProject(args as protocol.FileRequestArgs);
                 return [{ project, result: project.getLanguageService().getNavigateToItems(searchValue, maxResultCount, file) }];
             }

src/services/codefixes/fixImplicitThis.ts

@@ -26,9 +26,9 @@ namespace ts.codefix {
         if (!isFunctionDeclaration(fn) && !isFunctionExpression(fn)) return undefined;
 
         if (!isSourceFile(getThisContainer(fn, /*includeArrowFunctions*/ false))) { // 'this' is defined outside, convert to arrow function
-            const fnKeyword = Debug.assertDefined(findChildOfKind(fn, SyntaxKind.FunctionKeyword, sourceFile));
+            const fnKeyword = Debug.checkDefined(findChildOfKind(fn, SyntaxKind.FunctionKeyword, sourceFile));
             const { name } = fn;
-            const body = Debug.assertDefined(fn.body); // Should be defined because the function contained a 'this' expression
+            const body = Debug.checkDefined(fn.body); // Should be defined because the function contained a 'this' expression
             if (isFunctionExpression(fn)) {
                 if (name && FindAllReferences.Core.isSymbolReferencedInFile(name, checker, sourceFile, body)) {
                     // Function expression references itself. To fix we would have to extract it to a const.

src/services/goToDefinition.ts

@@ -198,14 +198,17 @@ namespace ts.GoToDefinition {
             return undefined;
         }
 
-        const symbol = typeChecker.getSymbolAtLocation(node);
+        const symbol = getSymbol(node, typeChecker);
         if (!symbol) return undefined;
 
         const typeAtLocation = typeChecker.getTypeOfSymbolAtLocation(symbol, node);
         const returnType = tryGetReturnTypeOfFunction(symbol, typeAtLocation, typeChecker);
         const fromReturnType = returnType && definitionFromType(returnType, typeChecker, node);
         // If a function returns 'void' or some other type with no definition, just return the function definition.
-        return fromReturnType && fromReturnType.length !== 0 ? fromReturnType : definitionFromType(typeAtLocation, typeChecker, node);
+        const typeDefinitions = fromReturnType && fromReturnType.length !== 0 ? fromReturnType : definitionFromType(typeAtLocation, typeChecker, node);
+        return typeDefinitions.length ? typeDefinitions
+            : !(symbol.flags & SymbolFlags.Value) && symbol.flags & SymbolFlags.Type ? getDefinitionFromSymbol(typeChecker, skipAlias(symbol, typeChecker), node)
+            : undefined;
     }
 
     function definitionFromType(type: Type, checker: TypeChecker, node: Node): readonly DefinitionInfo[] {

src/testRunner/unittests/tsserver/autoImportProvider.ts

@@ -326,7 +326,7 @@ namespace ts.projectSystem {
         };
 
         function updateFile(path: string, newText: string) {
-            Debug.assertDefined(files.find(f => f.path === path));
+            Debug.assertIsDefined(files.find(f => f.path === path));
             session.executeCommandSeq<protocol.ApplyChangedToOpenFilesRequest>({
                 command: protocol.CommandTypes.ApplyChangedToOpenFiles,
                 arguments: {
@@ -339,7 +339,7 @@ namespace ts.projectSystem {
         }
 
         function findAllReferences(file: string, line: number, offset: number) {
-            Debug.assertDefined(files.find(f => f.path === file));
+            Debug.assertIsDefined(files.find(f => f.path === file));
             session.executeCommandSeq<protocol.ReferencesRequest>({
                 command: protocol.CommandTypes.References,
                 arguments: {

tests/baselines/reference/api/tsserverlibrary.d.ts

@@ -897,7 +897,7 @@ declare namespace ts {
     export interface TypePredicateNode extends TypeNode {
         readonly kind: SyntaxKind.TypePredicate;
         readonly parent: SignatureDeclaration | JSDocTypeExpression;
-        readonly assertsModifier?: AssertsToken;
+        readonly assertsModifier?: AssertsKeyword;
         readonly parameterName: Identifier | ThisTypeNode;
         readonly type?: TypeNode;
     }
@@ -968,7 +968,7 @@ declare namespace ts {
     }
     export interface MappedTypeNode extends TypeNode, Declaration {
         readonly kind: SyntaxKind.MappedType;
-        readonly readonlyToken?: ReadonlyToken | PlusToken | MinusToken;
+        readonly readonlyToken?: ReadonlyKeyword | PlusToken | MinusToken;
         readonly typeParameter: TypeParameterDeclaration;
         readonly nameType?: TypeNode;
         readonly questionToken?: QuestionToken | PlusToken | MinusToken;
@@ -1465,7 +1465,7 @@ declare namespace ts {
     }
     export interface ForOfStatement extends IterationStatement {
         readonly kind: SyntaxKind.ForOfStatement;
-        readonly awaitModifier?: AwaitKeywordToken;
+        readonly awaitModifier?: AwaitKeyword;
         readonly initializer: ForInitializer;
         readonly expression: Expression;
     }

tests/baselines/reference/api/typescript.d.ts

@@ -897,7 +897,7 @@ declare namespace ts {
     export interface TypePredicateNode extends TypeNode {
         readonly kind: SyntaxKind.TypePredicate;
         readonly parent: SignatureDeclaration | JSDocTypeExpression;
-        readonly assertsModifier?: AssertsToken;
+        readonly assertsModifier?: AssertsKeyword;
         readonly parameterName: Identifier | ThisTypeNode;
         readonly type?: TypeNode;
     }
@@ -968,7 +968,7 @@ declare namespace ts {
     }
     export interface MappedTypeNode extends TypeNode, Declaration {
         readonly kind: SyntaxKind.MappedType;
-        readonly readonlyToken?: ReadonlyToken | PlusToken | MinusToken;
+        readonly readonlyToken?: ReadonlyKeyword | PlusToken | MinusToken;
         readonly typeParameter: TypeParameterDeclaration;
         readonly nameType?: TypeNode;
         readonly questionToken?: QuestionToken | PlusToken | MinusToken;
@@ -1465,7 +1465,7 @@ declare namespace ts {
     }
     export interface ForOfStatement extends IterationStatement {
         readonly kind: SyntaxKind.ForOfStatement;
-        readonly awaitModifier?: AwaitKeywordToken;
+        readonly awaitModifier?: AwaitKeyword;
         readonly initializer: ForInitializer;
         readonly expression: Expression;
     }

tests/baselines/reference/argumentsReferenceInConstructor4_Js.errors.txt

@@ -0,0 +1,46 @@
+/a.js(18,9): error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'arguments'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
+
+
+==== /a.js (1 errors) ====
+    class A {
+    	/**
+    	 * Constructor
+    	 *
+    	 * @param {object} [foo={}]
+    	 */
+    	constructor(foo = {}) {
+    		const key = "bar";
+    
+    		/**
+    		 * @type object
+    		 */
+    		this.foo = foo;
+    
+    		/**
+    		 * @type object
+    		 */
+    		const arguments = this.arguments;
+    		      ~~~~~~~~~
+!!! error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'arguments'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
+    
+    		/**
+    		 * @type object
+    		 */
+    		this.bar = arguments.bar;
+    
+    		/**
+    		 * @type object
+    		 */
+    		this.baz = arguments[key];
+    
+    		/**
+    		 * @type object
+    		 */
+    		this.options = arguments;
+    	}
+    
+    	get arguments() {
+    		return { bar: {} };
+    	}
+    }
+    

tests/baselines/reference/argumentsReferenceInMethod4_Js.errors.txt

@@ -0,0 +1,44 @@
+/a.js(16,9): error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'arguments'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
+
+
+==== /a.js (1 errors) ====
+    class A {
+    	/**
+    	 * @param {object} [foo={}]
+    	 */
+    	m(foo = {}) {
+    		const key = "bar";
+    
+    		/**
+    		 * @type object
+    		 */
+    		this.foo = foo;
+    
+    		/**
+    		 * @type object
+    		 */
+    		const arguments = this.arguments;
+    		      ~~~~~~~~~
+!!! error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'arguments'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
+    
+    		/**
+    		 * @type object
+    		 */
+    		this.bar = arguments.bar;
+    
+    		/**
+    		 * @type object
+    		 */
+    		this.baz = arguments[key];
+    
+    		/**
+    		 * @type object
+    		 */
+    		this.options = arguments;
+    	}
+    
+    	get arguments() {
+    		return { bar: {} };
+    	}
+    }
+    

tests/baselines/reference/enumWithUnicodeEscape1.symbols

@@ -3,6 +3,6 @@ enum E {
 >E : Symbol(E, Decl(enumWithUnicodeEscape1.ts, 0, 0))
 
   'gold \u2730'
->'gold \u2730' : Symbol(E['gold u2730'], Decl(enumWithUnicodeEscape1.ts, 0, 8))
+>'gold \u2730' : Symbol(E['gold \u2730'], Decl(enumWithUnicodeEscape1.ts, 0, 8))
 }
 

tests/baselines/reference/jsdocTypedefNoCrash2.errors.txt

@@ -1,12 +1,18 @@
+tests/cases/compiler/export.js(1,13): error TS2451: Cannot redeclare block-scoped variable 'foo'.
 tests/cases/compiler/export.js(1,13): error TS8008: Type aliases can only be used in TypeScript files.
+tests/cases/compiler/export.js(6,14): error TS2451: Cannot redeclare block-scoped variable 'foo'.
 
 
-==== tests/cases/compiler/export.js (1 errors) ====
+==== tests/cases/compiler/export.js (3 errors) ====
     export type foo = 5;
                 ~~~
+!!! error TS2451: Cannot redeclare block-scoped variable 'foo'.
+                ~~~
 !!! error TS8008: Type aliases can only be used in TypeScript files.
     /**
      * @typedef {{
      * }}
      */
-    export const foo = 5;
+    export const foo = 5;
+                 ~~~
+!!! error TS2451: Cannot redeclare block-scoped variable 'foo'.

tests/baselines/reference/plainJSBinderErrors.errors.txt

@@ -0,0 +1,97 @@
+tests/cases/conformance/salsa/plainJSBinderErrors.js(1,1): error TS2528: A module cannot have multiple default exports.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(2,1): error TS2528: A module cannot have multiple default exports.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(3,7): error TS1262: Identifier expected. 'await' is a reserved word at the top-level of a module.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(4,7): error TS1214: Identifier expected. 'yield' is a reserved word in strict mode. Modules are automatically in strict mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(6,11): error TS1359: Identifier expected. 'await' is a reserved word that cannot be used here.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(9,11): error TS1214: Identifier expected. 'yield' is a reserved word in strict mode. Modules are automatically in strict mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(12,5): error TS18012: '#constructor' is a reserved word.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(15,20): error TS1102: 'delete' cannot be called on an identifier in strict mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(18,16): error TS1102: 'delete' cannot be called on an identifier in strict mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(19,16): error TS1102: 'delete' cannot be called on an identifier in strict mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(22,15): error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'eval'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(23,15): error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'arguments'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(26,27): error TS1121: Octal literals are not allowed in strict mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(27,9): error TS1101: 'with' statements are not allowed in strict mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(33,13): error TS1344: 'A label is not allowed here.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(39,7): error TS1215: Invalid use of 'eval'. Modules are automatically in strict mode.
+tests/cases/conformance/salsa/plainJSBinderErrors.js(40,7): error TS1215: Invalid use of 'arguments'. Modules are automatically in strict mode.
+
+
+==== tests/cases/conformance/salsa/plainJSBinderErrors.js (17 errors) ====
+    export default 12
+    ~~~~~~~~~~~~~~~~~
+!!! error TS2528: A module cannot have multiple default exports.
+!!! related TS2753 tests/cases/conformance/salsa/plainJSBinderErrors.js:2:1: Another export default is here.
+    export default 13
+    ~~~~~~~~~~~~~~~~~
+!!! error TS2528: A module cannot have multiple default exports.
+!!! related TS2752 tests/cases/conformance/salsa/plainJSBinderErrors.js:1:1: The first export default is here.
+    const await = 1
+          ~~~~~
+!!! error TS1262: Identifier expected. 'await' is a reserved word at the top-level of a module.
+    const yield = 2
+          ~~~~~
+!!! error TS1214: Identifier expected. 'yield' is a reserved word in strict mode. Modules are automatically in strict mode.
+    async function f() {
+        const await = 3
+              ~~~~~
+!!! error TS1359: Identifier expected. 'await' is a reserved word that cannot be used here.
+    }
+    function* g() {
+        const yield = 4
+              ~~~~~
+!!! error TS1214: Identifier expected. 'yield' is a reserved word in strict mode. Modules are automatically in strict mode.
+    }
+    class C {
+        #constructor = 5
+        ~~~~~~~~~~~~
+!!! error TS18012: '#constructor' is a reserved word.
+        deleted() {
+            function container(f) {
+                delete f
+                       ~
+!!! error TS1102: 'delete' cannot be called on an identifier in strict mode.
+            }
+            var g = 6
+            delete g
+                   ~
+!!! error TS1102: 'delete' cannot be called on an identifier in strict mode.
+            delete container
+                   ~~~~~~~~~
+!!! error TS1102: 'delete' cannot be called on an identifier in strict mode.
+        }
+        evalArguments() {
+            const eval = 7
+                  ~~~~
+!!! error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'eval'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
+            const arguments = 8
+                  ~~~~~~~~~
+!!! error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'arguments'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
+        }
+        withOctal() {
+            const redundant = 010
+                              ~~~
+!!! error TS1121: Octal literals are not allowed in strict mode.
+            with (redundant) {
+            ~~~~
+!!! error TS1101: 'with' statements are not allowed in strict mode.
+                return toFixed()
+            }
+        }
+        label() {
+            for(;;) {
+                label: var x = 1
+                ~~~~~
+!!! error TS1344: 'A label is not allowed here.
+                break label
+            }
+            return x
+        }
+    }
+    const eval = 9
+          ~~~~
+!!! error TS1215: Invalid use of 'eval'. Modules are automatically in strict mode.
+    const arguments = 10
+          ~~~~~~~~~
+!!! error TS1215: Invalid use of 'arguments'. Modules are automatically in strict mode.
+    

tests/baselines/reference/plainJSBinderErrors.js

@@ -0,0 +1,84 @@
+//// [plainJSBinderErrors.js]
+export default 12
+export default 13
+const await = 1
+const yield = 2
+async function f() {
+    const await = 3
+}
+function* g() {
+    const yield = 4
+}
+class C {
+    #constructor = 5
+    deleted() {
+        function container(f) {
+            delete f
+        }
+        var g = 6
+        delete g
+        delete container
+    }
+    evalArguments() {
+        const eval = 7
+        const arguments = 8
+    }
+    withOctal() {
+        const redundant = 010
+        with (redundant) {
+            return toFixed()
+        }
+    }
+    label() {
+        for(;;) {
+            label: var x = 1
+            break label
+        }
+        return x
+    }
+}
+const eval = 9
+const arguments = 10
+
+
+//// [plainJSBinderErrors.js]
+export default 12;
+export default 13;
+const await = 1;
+const yield = 2;
+async function f() {
+    const await = 3;
+}
+function* g() {
+    const yield = 4;
+}
+class C {
+    #constructor = 5;
+    deleted() {
+        function container(f) {
+            delete f;
+        }
+        var g = 6;
+        delete g;
+        delete container;
+    }
+    evalArguments() {
+        const eval = 7;
+        const arguments = 8;
+    }
+    withOctal() {
+        const redundant = 010;
+        with (redundant) {
+            return toFixed();
+        }
+    }
+    label() {
+        for (;;) {
+            label: var x = 1;
+            break label;
+        }
+        return x;
+    }
+}
+const eval = 9;
+const arguments = 10;

tests/baselines/reference/plainJSBinderErrors.symbols

@@ -0,0 +1,86 @@
+=== tests/cases/conformance/salsa/plainJSBinderErrors.js ===
+export default 12
+export default 13
+const await = 1
+>await : Symbol(await, Decl(plainJSBinderErrors.js, 2, 5))
+
+const yield = 2
+>yield : Symbol(yield, Decl(plainJSBinderErrors.js, 3, 5))
+
+async function f() {
+>f : Symbol(f, Decl(plainJSBinderErrors.js, 3, 15))
+
+    const await = 3
+>await : Symbol(await, Decl(plainJSBinderErrors.js, 5, 9))
+}
+function* g() {
+>g : Symbol(g, Decl(plainJSBinderErrors.js, 6, 1))
+
+    const yield = 4
+>yield : Symbol(yield, Decl(plainJSBinderErrors.js, 8, 9))
+}
+class C {
+>C : Symbol(C, Decl(plainJSBinderErrors.js, 9, 1))
+
+    #constructor = 5
+>#constructor : Symbol(C.#constructor, Decl(plainJSBinderErrors.js, 10, 9))
+
+    deleted() {
+>deleted : Symbol(C.deleted, Decl(plainJSBinderErrors.js, 11, 20))
+
+        function container(f) {
+>container : Symbol(container, Decl(plainJSBinderErrors.js, 12, 15))
+>f : Symbol(f, Decl(plainJSBinderErrors.js, 13, 27))
+
+            delete f
+>f : Symbol(f, Decl(plainJSBinderErrors.js, 13, 27))
+        }
+        var g = 6
+>g : Symbol(g, Decl(plainJSBinderErrors.js, 16, 11))
+
+        delete g
+>g : Symbol(g, Decl(plainJSBinderErrors.js, 16, 11))
+
+        delete container
+>container : Symbol(container, Decl(plainJSBinderErrors.js, 12, 15))
+    }
+    evalArguments() {
+>evalArguments : Symbol(C.evalArguments, Decl(plainJSBinderErrors.js, 19, 5))
+
+        const eval = 7
+>eval : Symbol(eval, Decl(plainJSBinderErrors.js, 21, 13))
+
+        const arguments = 8
+>arguments : Symbol(arguments, Decl(plainJSBinderErrors.js, 22, 13))
+    }
+    withOctal() {
+>withOctal : Symbol(C.withOctal, Decl(plainJSBinderErrors.js, 23, 5))
+
+        const redundant = 010
+>redundant : Symbol(redundant, Decl(plainJSBinderErrors.js, 25, 13))
+
+        with (redundant) {
+>redundant : Symbol(redundant, Decl(plainJSBinderErrors.js, 25, 13))
+
+            return toFixed()
+        }
+    }
+    label() {
+>label : Symbol(C.label, Decl(plainJSBinderErrors.js, 29, 5))
+
+        for(;;) {
+            label: var x = 1
+>x : Symbol(x, Decl(plainJSBinderErrors.js, 32, 22))
+
+            break label
+        }
+        return x
+>x : Symbol(x, Decl(plainJSBinderErrors.js, 32, 22))
+    }
+}
+const eval = 9
+>eval : Symbol(eval, Decl(plainJSBinderErrors.js, 38, 5))
+
+const arguments = 10
+>arguments : Symbol(arguments, Decl(plainJSBinderErrors.js, 39, 5))
+

tests/baselines/reference/plainJSBinderErrors.types

@@ -0,0 +1,105 @@
+=== tests/cases/conformance/salsa/plainJSBinderErrors.js ===
+export default 12
+export default 13
+const await = 1
+>await : 1
+>1 : 1
+
+const yield = 2
+>yield : 2
+>2 : 2
+
+async function f() {
+>f : () => Promise<void>
+
+    const await = 3
+>await : 3
+>3 : 3
+}
+function* g() {
+>g : () => Generator<never, void, unknown>
+
+    const yield = 4
+>yield : 4
+>4 : 4
+}
+class C {
+>C : C
+
+    #constructor = 5
+>#constructor : number
+>5 : 5
+
+    deleted() {
+>deleted : () => void
+
+        function container(f) {
+>container : (f: any) => void
+>f : any
+
+            delete f
+>delete f : boolean
+>f : any
+        }
+        var g = 6
+>g : number
+>6 : 6
+
+        delete g
+>delete g : boolean
+>g : number
+
+        delete container
+>delete container : boolean
+>container : (f: any) => void
+    }
+    evalArguments() {
+>evalArguments : () => void
+
+        const eval = 7
+>eval : 7
+>7 : 7
+
+        const arguments = 8
+>arguments : 8
+>8 : 8
+    }
+    withOctal() {
+>withOctal : () => any
+
+        const redundant = 010
+>redundant : 10
+>010 : 10
+
+        with (redundant) {
+>redundant : 10
+
+            return toFixed()
+>toFixed() : any
+>toFixed : any
+        }
+    }
+    label() {
+>label : () => number
+
+        for(;;) {
+            label: var x = 1
+>label : any
+>x : number
+>1 : 1
+
+            break label
+>label : any
+        }
+        return x
+>x : number
+    }
+}
+const eval = 9
+>eval : 9
+>9 : 9
+
+const arguments = 10
+>arguments : 10
+>10 : 10
+

tests/baselines/reference/plainJSModuleStrict.errors.txt

@@ -0,0 +1,37 @@
+tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js(1,1): error TS2528: A module cannot have multiple default exports.
+tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js(2,1): error TS2528: A module cannot have multiple default exports.
+tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js(3,7): error TS1262: Identifier expected. 'await' is a reserved word at the top-level of a module.
+tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js(4,7): error TS1214: Identifier expected. 'yield' is a reserved word in strict mode. Modules are automatically in strict mode.
+tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js(6,11): error TS1359: Identifier expected. 'await' is a reserved word that cannot be used here.
+tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js(9,11): error TS1214: Identifier expected. 'yield' is a reserved word in strict mode. Modules are automatically in strict mode.
+
+
+==== tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js (6 errors) ====
+    export default 12
+    ~~~~~~~~~~~~~~~~~
+!!! error TS2528: A module cannot have multiple default exports.
+!!! related TS2753 tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js:2:1: Another export default is here.
+    export default 13
+    ~~~~~~~~~~~~~~~~~
+!!! error TS2528: A module cannot have multiple default exports.
+!!! related TS2752 tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js:1:1: The first export default is here.
+    const await = 1
+          ~~~~~
+!!! error TS1262: Identifier expected. 'await' is a reserved word at the top-level of a module.
+    const yield = 2
+          ~~~~~
+!!! error TS1214: Identifier expected. 'yield' is a reserved word in strict mode. Modules are automatically in strict mode.
+    async function f() {
+        const await = 3
+              ~~~~~
+!!! error TS1359: Identifier expected. 'await' is a reserved word that cannot be used here.
+    }
+    function* g() {
+        const yield = 4
+              ~~~~~
+!!! error TS1214: Identifier expected. 'yield' is a reserved word in strict mode. Modules are automatically in strict mode.
+    }
+    class C {
+        #constructor = 1
+    }
+    

tests/baselines/reference/plainJSModuleStrict.js

@@ -0,0 +1,30 @@
+//// [plainJSMultipleDefaultExport.js]
+export default 12
+export default 13
+const await = 1
+const yield = 2
+async function f() {
+    const await = 3
+}
+function* g() {
+    const yield = 4
+}
+class C {
+    #constructor = 1
+}
+
+
+//// [plainJSMultipleDefaultExport.js]
+export default 12;
+export default 13;
+const await = 1;
+const yield = 2;
+async function f() {
+    const await = 3;
+}
+function* g() {
+    const yield = 4;
+}
+class C {
+    #constructor = 1;
+}

tests/baselines/reference/plainJSModuleStrict.symbols

@@ -0,0 +1,28 @@
+=== tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js ===
+export default 12
+export default 13
+const await = 1
+>await : Symbol(await, Decl(plainJSMultipleDefaultExport.js, 2, 5))
+
+const yield = 2
+>yield : Symbol(yield, Decl(plainJSMultipleDefaultExport.js, 3, 5))
+
+async function f() {
+>f : Symbol(f, Decl(plainJSMultipleDefaultExport.js, 3, 15))
+
+    const await = 3
+>await : Symbol(await, Decl(plainJSMultipleDefaultExport.js, 5, 9))
+}
+function* g() {
+>g : Symbol(g, Decl(plainJSMultipleDefaultExport.js, 6, 1))
+
+    const yield = 4
+>yield : Symbol(yield, Decl(plainJSMultipleDefaultExport.js, 8, 9))
+}
+class C {
+>C : Symbol(C, Decl(plainJSMultipleDefaultExport.js, 9, 1))
+
+    #constructor = 1
+>#constructor : Symbol(C.#constructor, Decl(plainJSMultipleDefaultExport.js, 10, 9))
+}
+

tests/baselines/reference/plainJSModuleStrict.types

@@ -0,0 +1,33 @@
+=== tests/cases/conformance/salsa/plainJSMultipleDefaultExport.js ===
+export default 12
+export default 13
+const await = 1
+>await : 1
+>1 : 1
+
+const yield = 2
+>yield : 2
+>2 : 2
+
+async function f() {
+>f : () => Promise<void>
+
+    const await = 3
+>await : 3
+>3 : 3
+}
+function* g() {
+>g : () => Generator<never, void, unknown>
+
+    const yield = 4
+>yield : 4
+>4 : 4
+}
+class C {
+>C : C
+
+    #constructor = 1
+>#constructor : number
+>1 : 1
+}
+

tests/baselines/reference/plainJSRedeclare.errors.txt

@@ -0,0 +1,13 @@
+tests/cases/conformance/salsa/plainJSRedeclare.js(1,7): error TS2451: Cannot redeclare block-scoped variable 'orbitol'.
+tests/cases/conformance/salsa/plainJSRedeclare.js(2,5): error TS2451: Cannot redeclare block-scoped variable 'orbitol'.
+
+
+==== tests/cases/conformance/salsa/plainJSRedeclare.js (2 errors) ====
+    const orbitol = 1
+          ~~~~~~~
+!!! error TS2451: Cannot redeclare block-scoped variable 'orbitol'.
+    var orbitol = 1 + false
+        ~~~~~~~
+!!! error TS2451: Cannot redeclare block-scoped variable 'orbitol'.
+    orbitol.toExponential()
+    

tests/baselines/reference/plainJSRedeclare.js

@@ -0,0 +1,10 @@
+//// [plainJSRedeclare.js]
+const orbitol = 1
+var orbitol = 1 + false
+orbitol.toExponential()
+
+
+//// [plainJSRedeclare.js]
+var orbitol = 1;
+var orbitol = 1 + false;
+orbitol.toExponential();

tests/baselines/reference/plainJSRedeclare.symbols

@@ -0,0 +1,12 @@
+=== tests/cases/conformance/salsa/plainJSRedeclare.js ===
+const orbitol = 1
+>orbitol : Symbol(orbitol, Decl(plainJSRedeclare.js, 0, 5))
+
+var orbitol = 1 + false
+>orbitol : Symbol(orbitol, Decl(plainJSRedeclare.js, 1, 3))
+
+orbitol.toExponential()
+>orbitol.toExponential : Symbol(Number.toExponential, Decl(lib.es5.d.ts, --, --))
+>orbitol : Symbol(orbitol, Decl(plainJSRedeclare.js, 0, 5))
+>toExponential : Symbol(Number.toExponential, Decl(lib.es5.d.ts, --, --))
+

tests/baselines/reference/plainJSRedeclare.types

@@ -0,0 +1,17 @@
+=== tests/cases/conformance/salsa/plainJSRedeclare.js ===
+const orbitol = 1
+>orbitol : 1
+>1 : 1
+
+var orbitol = 1 + false
+>orbitol : any
+>1 + false : any
+>1 : 1
+>false : false
+
+orbitol.toExponential()
+>orbitol.toExponential() : string
+>orbitol.toExponential : (fractionDigits?: number) => string
+>orbitol : 1
+>toExponential : (fractionDigits?: number) => string
+

tests/baselines/reference/plainJSRedeclare2.errors.txt

@@ -0,0 +1,16 @@
+tests/cases/conformance/salsa/plainJSRedeclare.js(1,7): error TS2451: Cannot redeclare block-scoped variable 'orbitol'.
+tests/cases/conformance/salsa/plainJSRedeclare.js(2,5): error TS2451: Cannot redeclare block-scoped variable 'orbitol'.
+tests/cases/conformance/salsa/plainJSRedeclare.js(2,15): error TS2365: Operator '+' cannot be applied to types 'number' and 'boolean'.
+
+
+==== tests/cases/conformance/salsa/plainJSRedeclare.js (3 errors) ====
+    const orbitol = 1
+          ~~~~~~~
+!!! error TS2451: Cannot redeclare block-scoped variable 'orbitol'.
+    var orbitol = 1 + false
+        ~~~~~~~
+!!! error TS2451: Cannot redeclare block-scoped variable 'orbitol'.
+                  ~~~~~~~~~
+!!! error TS2365: Operator '+' cannot be applied to types 'number' and 'boolean'.
+    orbitol.toExponential()
+    

tests/baselines/reference/plainJSRedeclare2.js

@@ -0,0 +1,10 @@
+//// [plainJSRedeclare.js]
+const orbitol = 1
+var orbitol = 1 + false
+orbitol.toExponential()
+
+
+//// [plainJSRedeclare.js]
+var orbitol = 1;
+var orbitol = 1 + false;
+orbitol.toExponential();

tests/baselines/reference/plainJSRedeclare2.symbols

@@ -0,0 +1,12 @@
+=== tests/cases/conformance/salsa/plainJSRedeclare.js ===
+const orbitol = 1
+>orbitol : Symbol(orbitol, Decl(plainJSRedeclare.js, 0, 5))
+
+var orbitol = 1 + false
+>orbitol : Symbol(orbitol, Decl(plainJSRedeclare.js, 1, 3))
+
+orbitol.toExponential()
+>orbitol.toExponential : Symbol(Number.toExponential, Decl(lib.es5.d.ts, --, --))
+>orbitol : Symbol(orbitol, Decl(plainJSRedeclare.js, 0, 5))
+>toExponential : Symbol(Number.toExponential, Decl(lib.es5.d.ts, --, --))
+

tests/baselines/reference/plainJSRedeclare2.types

@@ -0,0 +1,17 @@
+=== tests/cases/conformance/salsa/plainJSRedeclare.js ===
+const orbitol = 1
+>orbitol : 1
+>1 : 1
+
+var orbitol = 1 + false
+>orbitol : any
+>1 + false : any
+>1 : 1
+>false : false
+
+orbitol.toExponential()
+>orbitol.toExponential() : string
+>orbitol.toExponential : (fractionDigits?: number) => string
+>orbitol : 1
+>toExponential : (fractionDigits?: number) => string
+

tests/baselines/reference/plainJSRedeclare3.js

@@ -0,0 +1,10 @@
+//// [plainJSRedeclare.js]
+const orbitol = 1
+var orbitol = 1 + false
+orbitol.toExponential()
+
+
+//// [plainJSRedeclare.js]
+var orbitol = 1;
+var orbitol = 1 + false;
+orbitol.toExponential();

tests/baselines/reference/plainJSRedeclare3.symbols

@@ -0,0 +1,12 @@
+=== tests/cases/conformance/salsa/plainJSRedeclare.js ===
+const orbitol = 1
+>orbitol : Symbol(orbitol, Decl(plainJSRedeclare.js, 0, 5))
+
+var orbitol = 1 + false
+>orbitol : Symbol(orbitol, Decl(plainJSRedeclare.js, 1, 3))
+
+orbitol.toExponential()
+>orbitol.toExponential : Symbol(Number.toExponential, Decl(lib.es5.d.ts, --, --))
+>orbitol : Symbol(orbitol, Decl(plainJSRedeclare.js, 0, 5))
+>toExponential : Symbol(Number.toExponential, Decl(lib.es5.d.ts, --, --))
+

tests/baselines/reference/plainJSRedeclare3.types

@@ -0,0 +1,17 @@
+=== tests/cases/conformance/salsa/plainJSRedeclare.js ===
+const orbitol = 1
+>orbitol : 1
+>1 : 1
+
+var orbitol = 1 + false
+>orbitol : any
+>1 + false : any
+>1 : 1
+>false : false
+
+orbitol.toExponential()
+>orbitol.toExponential() : string
+>orbitol.toExponential : (fractionDigits?: number) => string
+>orbitol : 1
+>toExponential : (fractionDigits?: number) => string
+

tests/baselines/reference/plainJSReservedStrict.errors.txt

@@ -0,0 +1,13 @@
+tests/cases/conformance/salsa/plainJSReservedStrict.js(2,7): error TS1100: Invalid use of 'eval' in strict mode.
+tests/cases/conformance/salsa/plainJSReservedStrict.js(3,7): error TS1100: Invalid use of 'arguments' in strict mode.
+
+
+==== tests/cases/conformance/salsa/plainJSReservedStrict.js (2 errors) ====
+    "use strict"
+    const eval = 1
+          ~~~~
+!!! error TS1100: Invalid use of 'eval' in strict mode.
+    const arguments = 2
+          ~~~~~~~~~
+!!! error TS1100: Invalid use of 'arguments' in strict mode.
+    

tests/baselines/reference/plainJSReservedStrict.js

@@ -0,0 +1,10 @@
+//// [plainJSReservedStrict.js]
+"use strict"
+const eval = 1
+const arguments = 2
+
+
+//// [plainJSReservedStrict.js]
+"use strict";
+const eval = 1;
+const arguments = 2;

tests/baselines/reference/plainJSReservedStrict.symbols

@@ -0,0 +1,8 @@
+=== tests/cases/conformance/salsa/plainJSReservedStrict.js ===
+"use strict"
+const eval = 1
+>eval : Symbol(eval, Decl(plainJSReservedStrict.js, 1, 5))
+
+const arguments = 2
+>arguments : Symbol(arguments, Decl(plainJSReservedStrict.js, 2, 5))
+

tests/baselines/reference/plainJSReservedStrict.types

@@ -0,0 +1,12 @@
+=== tests/cases/conformance/salsa/plainJSReservedStrict.js ===
+"use strict"
+>"use strict" : "use strict"
+
+const eval = 1
+>eval : 1
+>1 : 1
+
+const arguments = 2
+>arguments : 2
+>2 : 2
+

tests/baselines/reference/quickInfoDisplayPartsEnum2.baseline

@@ -69,7 +69,7 @@
         },
         {
           "text": "\"e1\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -135,7 +135,7 @@
         },
         {
           "text": "'e2'",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -201,7 +201,7 @@
         },
         {
           "text": "\"e3\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -411,7 +411,7 @@
         },
         {
           "text": "\"e1\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -549,7 +549,7 @@
         },
         {
           "text": "'e2'",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -687,7 +687,7 @@
         },
         {
           "text": "\"e3\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -791,7 +791,7 @@
         },
         {
           "text": "\"e1\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -857,7 +857,7 @@
         },
         {
           "text": "'e2'",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -923,7 +923,7 @@
         },
         {
           "text": "\"e3\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -1149,7 +1149,7 @@
         },
         {
           "text": "\"e1\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -1295,7 +1295,7 @@
         },
         {
           "text": "'e2'",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -1441,7 +1441,7 @@
         },
         {
           "text": "\"e3\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",

tests/baselines/reference/quickInfoDisplayPartsEnum3.baseline

@@ -69,7 +69,7 @@
         },
         {
           "text": "\"e1\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -135,7 +135,7 @@
         },
         {
           "text": "'e2'",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -201,7 +201,7 @@
         },
         {
           "text": "\"e3\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -411,7 +411,7 @@
         },
         {
           "text": "\"e1\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -549,7 +549,7 @@
         },
         {
           "text": "'e2'",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -687,7 +687,7 @@
         },
         {
           "text": "\"e3\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -791,7 +791,7 @@
         },
         {
           "text": "\"e1\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -857,7 +857,7 @@
         },
         {
           "text": "'e2'",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -923,7 +923,7 @@
         },
         {
           "text": "\"e3\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -1149,7 +1149,7 @@
         },
         {
           "text": "\"e1\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -1295,7 +1295,7 @@
         },
         {
           "text": "'e2'",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",
@@ -1441,7 +1441,7 @@
         },
         {
           "text": "\"e3\"",
-          "kind": "stringLiteral"
+          "kind": "enumMemberName"
         },
         {
           "text": "]",

tests/baselines/reference/quickInfoDisplayPartsEnum4.baseline

@@ -0,0 +1,134 @@
+[
+  {
+    "marker": {
+      "fileName": "/tests/cases/fourslash/quickInfoDisplayPartsEnum4.ts",
+      "position": 51,
+      "name": "1"
+    },
+    "quickInfo": {
+      "kind": "enum member",
+      "kindModifiers": "",
+      "textSpan": {
+        "start": 51,
+        "length": 4
+      },
+      "displayParts": [
+        {
+          "text": "(",
+          "kind": "punctuation"
+        },
+        {
+          "text": "enum member",
+          "kind": "text"
+        },
+        {
+          "text": ")",
+          "kind": "punctuation"
+        },
+        {
+          "text": " ",
+          "kind": "space"
+        },
+        {
+          "text": "Foo",
+          "kind": "enumName"
+        },
+        {
+          "text": "[",
+          "kind": "punctuation"
+        },
+        {
+          "text": "\"\\t\"",
+          "kind": "enumMemberName"
+        },
+        {
+          "text": "]",
+          "kind": "punctuation"
+        },
+        {
+          "text": " ",
+          "kind": "space"
+        },
+        {
+          "text": "=",
+          "kind": "operator"
+        },
+        {
+          "text": " ",
+          "kind": "space"
+        },
+        {
+          "text": "9",
+          "kind": "numericLiteral"
+        }
+      ],
+      "documentation": []
+    }
+  },
+  {
+    "marker": {
+      "fileName": "/tests/cases/fourslash/quickInfoDisplayPartsEnum4.ts",
+      "position": 61,
+      "name": "2"
+    },
+    "quickInfo": {
+      "kind": "enum member",
+      "kindModifiers": "",
+      "textSpan": {
+        "start": 61,
+        "length": 8
+      },
+      "displayParts": [
+        {
+          "text": "(",
+          "kind": "punctuation"
+        },
+        {
+          "text": "enum member",
+          "kind": "text"
+        },
+        {
+          "text": ")",
+          "kind": "punctuation"
+        },
+        {
+          "text": " ",
+          "kind": "space"
+        },
+        {
+          "text": "Foo",
+          "kind": "enumName"
+        },
+        {
+          "text": "[",
+          "kind": "punctuation"
+        },
+        {
+          "text": "\"\\u007f\"",
+          "kind": "enumMemberName"
+        },
+        {
+          "text": "]",
+          "kind": "punctuation"
+        },
+        {
+          "text": " ",
+          "kind": "space"
+        },
+        {
+          "text": "=",
+          "kind": "operator"
+        },
+        {
+          "text": " ",
+          "kind": "space"
+        },
+        {
+          "text": "127",
+          "kind": "numericLiteral"
+        }
+      ],
+      "documentation": []
+    }
+  }
+]

tests/baselines/reference/thisTag1.types

@@ -4,7 +4,7 @@
  * @return {number}
  */
 function f(s) {
->f : (s: string) => number
+>f : (this: { n: number; }, s: string) => number
 >s : string
 
     return this.n + s.length
@@ -18,11 +18,11 @@ function f(s) {
 }
 
 const o = {
->o : { f: (s: string) => number; n: number; }
->{    f,    n: 1} : { f: (s: string) => number; n: number; }
+>o : { f: (this: { n: number; }, s: string) => number; n: number; }
+>{    f,    n: 1} : { f: (this: { n: number; }, s: string) => number; n: number; }
 
     f,
->f : (s: string) => number
+>f : (this: { n: number; }, s: string) => number
 
     n: 1
 >n : number
@@ -30,8 +30,8 @@ const o = {
 }
 o.f('hi')
 >o.f('hi') : number
->o.f : (s: string) => number
->o : { f: (s: string) => number; n: number; }
->f : (s: string) => number
+>o.f : (this: { n: number; }, s: string) => number
+>o : { f: (this: { n: number; }, s: string) => number; n: number; }
+>f : (this: { n: number; }, s: string) => number
 >'hi' : "hi"
 

tests/baselines/reference/thisTag2.js

@@ -0,0 +1,15 @@
+//// [a.js]
+/** @this {string} */
+export function f1() {}
+
+/** @this */
+export function f2() {}
+
+
+
+
+//// [a.d.ts]
+/** @this {string} */
+export function f1(this: string): void;
+/** @this */
+export function f2(this: any): void;

tests/baselines/reference/thisTag2.symbols

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/jsdoc/a.js ===
+/** @this {string} */
+export function f1() {}
+>f1 : Symbol(f1, Decl(a.js, 0, 0))
+
+/** @this */
+export function f2() {}
+>f2 : Symbol(f2, Decl(a.js, 1, 23))
+

tests/baselines/reference/thisTag2.types

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/jsdoc/a.js ===
+/** @this {string} */
+export function f1() {}
+>f1 : (this: string) => void
+
+/** @this */
+export function f2() {}
+>f2 : (this: any) => void
+

tests/cases/conformance/jsdoc/thisTag2.ts

@@ -0,0 +1,11 @@
+// @target: esnext
+// @allowJs: true
+// @declaration: true
+// @emitDeclarationOnly: true
+// @filename: a.js
+
+/** @this {string} */
+export function f1() {}
+
+/** @this */
+export function f2() {}

tests/cases/conformance/salsa/plainJSBinderErrors.ts

@@ -0,0 +1,44 @@
+// @outdir: out/
+// @target: esnext
+// @allowJS: true
+// @filename: plainJSBinderErrors.js
+export default 12
+export default 13
+const await = 1
+const yield = 2
+async function f() {
+    const await = 3
+}
+function* g() {
+    const yield = 4
+}
+class C {
+    #constructor = 5
+    deleted() {
+        function container(f) {
+            delete f
+        }
+        var g = 6
+        delete g
+        delete container
+    }
+    evalArguments() {
+        const eval = 7
+        const arguments = 8
+    }
+    withOctal() {
+        const redundant = 010
+        with (redundant) {
+            return toFixed()
+        }
+    }
+    label() {
+        for(;;) {
+            label: var x = 1
+            break label
+        }
+        return x
+    }
+}
+const eval = 9
+const arguments = 10

tests/cases/conformance/salsa/plainJSRedeclare.ts

@@ -0,0 +1,6 @@
+// @outdir: out/
+// @allowJS: true
+// @filename: plainJSRedeclare.js
+const orbitol = 1
+var orbitol = 1 + false
+orbitol.toExponential()

tests/cases/conformance/salsa/plainJSRedeclare2.ts

@@ -0,0 +1,7 @@
+// @outdir: out/
+// @allowJS: true
+// @checkJS: true
+// @filename: plainJSRedeclare.js
+const orbitol = 1
+var orbitol = 1 + false
+orbitol.toExponential()

tests/cases/conformance/salsa/plainJSRedeclare3.ts

@@ -0,0 +1,7 @@
+// @outdir: out/
+// @allowJS: true
+// @checkJS: false
+// @filename: plainJSRedeclare.js
+const orbitol = 1
+var orbitol = 1 + false
+orbitol.toExponential()

tests/cases/conformance/salsa/plainJSReservedStrict.ts

@@ -0,0 +1,7 @@
+// @outdir: out/
+// @target: esnext
+// @allowJS: true
+// @filename: plainJSReservedStrict.js
+"use strict"
+const eval = 1
+const arguments = 2

tests/cases/fourslash/goToTypeDefinition3.ts

@@ -0,0 +1,6 @@
+/// <reference path='fourslash.ts' />
+
+////type /*definition*/T = string;
+////const x: /*reference*/T;
+
+verify.goToType("reference", "definition");

tests/cases/fourslash/goToTypeDefinition4.ts

@@ -0,0 +1,12 @@
+/// <reference path='fourslash.ts' />
+
+// @Filename: foo.ts
+////export type /*def0*/T = string;
+////export const /*def1*/T = "";
+
+// @Filename: bar.ts
+////import { T } from "./foo";
+////let x: [|/*reference*/T|];
+
+verify.goToType("reference", []);
+verify.goToDefinition("reference", ["def0", "def1"]);

tests/cases/fourslash/goToTypeDefinition5.ts

@@ -0,0 +1,10 @@
+/// <reference path='fourslash.ts' />
+
+// @Filename: foo.ts
+////let Foo: /*definition*/unresolved;
+////type Foo = { x: string };
+
+/////*reference*/Foo;
+
+
+verify.goToType("reference", []);

tests/cases/fourslash/quickInfoDisplayPartsEnum4.ts

@@ -0,0 +1,10 @@
+/// <reference path='fourslash.ts'/>
+
+////const enum Foo {
+////	"\t" = 9,
+////	"\u007f" = 127,
+////}
+////Foo[/*1*/"\t"]
+////Foo[/*2*/"\u007f"]
+
+verify.baselineQuickInfo();

tests/cases/fourslash/server/autoImportProvider7.ts

@@ -0,0 +1,68 @@
+/// <reference path="../fourslash.ts" />
+
+// @Filename: /tsconfig.json
+//// { "compilerOptions": { "module": "commonjs" } }
+
+// @Filename: /package.json
+//// { "dependencies": { "mylib": "file:packages/mylib" } }
+
+// @Filename: /packages/mylib/package.json
+//// { "name": "mylib", "version": "1.0.0", "main": "index.js", "types": "index" }
+
+// @Filename: /packages/mylib/index.ts
+//// export * from "./mySubDir";
+
+// @Filename: /packages/mylib/mySubDir/index.ts
+//// export * from "./myClass";
+//// export * from "./myClass2";
+
+// @Filename: /packages/mylib/mySubDir/myClass.ts
+//// export class MyClass {}
+
+// @Filename: /packages/mylib/mySubDir/myClass2.ts
+//// export class MyClass2 {}
+
+// @link: /packages/mylib -> /node_modules/mylib
+
+// @Filename: /src/index.ts
+//// 
+//// const a = new MyClass/*1*/();
+//// const b = new MyClass2/*2*/();
+
+goTo.marker("1");
+format.setOption("newLineCharacter", "\n");
+
+verify.completions({
+  marker: "1",
+  includes: [{
+    name: "MyClass",
+    source: "mylib",
+    sourceDisplay: "mylib",
+    hasAction: true,
+    sortText: completion.SortText.AutoImportSuggestions,
+  }],
+  preferences: {
+    includeCompletionsForModuleExports: true,
+    includeInsertTextCompletions: true,
+    allowIncompleteCompletions: true,
+  }
+});
+
+verify.applyCodeActionFromCompletion("1", {
+  name: "MyClass",
+  source: "mylib",
+  description: `Import 'MyClass' from module "mylib"`,
+  data: {
+    exportName: "MyClass",
+    fileName: "/packages/mylib/index.ts",
+  },
+  preferences: {
+    includeCompletionsForModuleExports: true,
+    includeCompletionsWithInsertText: true,
+    allowIncompleteCompletions: true,
+  },
+  newFileContent: `import { MyClass } from "mylib";
+
+const a = new MyClass();
+const b = new MyClass2();`,
+});

tests/cases/fourslash/server/impliedNodeFormat.ts

@@ -0,0 +1,20 @@
+/// <reference path="../fourslash.ts" />
+
+// @Filename: /tsconfig.json
+//// { "compilerOptions": { "module": "nodenext" } }
+
+// @Filename: /package.json
+//// { "name": "foo", "type": "module", "exports": { ".": "./main.js" } }
+
+// @Filename: /main.ts
+//// export {};
+
+// @Filename: /index.ts
+//// import {} from "foo";
+
+goTo.file("/index.ts");
+verify.noErrors();
+
+edit.paste(`\n"${"a".repeat(256)}";`);
+
+verify.noErrors();