53a756ea63
* Type `this` in more constructor functions Previously, `this: this` in constructor functions only when there was an explicit `@constructor` tag on the function. Now, `this: this` for any function that's known to be a constructor function. This improves completions inside constructor functions; also note that previously the compiler *did* type `this: this` inside methods of constructor functions, so this fix makes us more consistent. This is reflected in the large number of baselines that improve. The fix is a simple switch to `isJSConstructor`, which is the standard way to detect constructor functions. I'm not sure why the original PR didn't use this method. I remember discussing this limitation in the original bug, #25979, and I guess I decided that it made sense. But I was heavily primed by the bug's framing of the problem in terms of `noImplicitThis`, which *should* require an explicit `@constructor` tag. With better typing comes better detection of `@readonly` assignment; I had to fix the readonly detection code to use `isJSConstructor` as well. * Remove `Add @class tag` fix for noImplicitThis. The new rules mean that it never applies. It's possible that it should apply to functions like ```js function f() { this.init() } ``` In which `init` is never defined, but I think this program is incomplete enough that not offering the fix is fine. * Fix precedence of `@this` Previously, both `@class` and `@this` in a jsdoc would cause the `@this` annotation to be ignored. This became a worse problem with this PR, because `this` is correctly typed even without the annotation. This commit makes sure that `@this` is checked first and used if present.
87 lines
1.3 KiB
Plaintext
87 lines
1.3 KiB
Plaintext
=== tests/cases/conformance/salsa/assignmentToVoidZero2.js ===
|
|
exports.j = 1;
|
|
>exports.j = 1 : 1
|
|
>exports.j : number
|
|
>exports : typeof import("tests/cases/conformance/salsa/assignmentToVoidZero2")
|
|
>j : number
|
|
>1 : 1
|
|
|
|
exports.k = void 0;
|
|
>exports.k = void 0 : undefined
|
|
>exports.k : any
|
|
>exports : typeof import("tests/cases/conformance/salsa/assignmentToVoidZero2")
|
|
>k : any
|
|
>void 0 : undefined
|
|
>0 : 0
|
|
|
|
var o = {}
|
|
>o : typeof o
|
|
>{} : {}
|
|
|
|
o.x = 1
|
|
>o.x = 1 : 1
|
|
>o.x : number
|
|
>o : typeof o
|
|
>x : number
|
|
>1 : 1
|
|
|
|
o.y = void 0
|
|
>o.y = void 0 : undefined
|
|
>o.y : any
|
|
>o : typeof o
|
|
>y : any
|
|
>void 0 : undefined
|
|
>0 : 0
|
|
|
|
o.x + o.y
|
|
>o.x + o.y : any
|
|
>o.x : number
|
|
>o : typeof o
|
|
>x : number
|
|
>o.y : any
|
|
>o : typeof o
|
|
>y : any
|
|
|
|
function C() {
|
|
>C : typeof C
|
|
|
|
this.p = 1
|
|
>this.p = 1 : 1
|
|
>this.p : any
|
|
>this : this
|
|
>p : any
|
|
>1 : 1
|
|
|
|
this.q = void 0
|
|
>this.q = void 0 : undefined
|
|
>this.q : any
|
|
>this : this
|
|
>q : any
|
|
>void 0 : undefined
|
|
>0 : 0
|
|
}
|
|
var c = new C()
|
|
>c : C
|
|
>new C() : C
|
|
>C : typeof C
|
|
|
|
c.p + c.q
|
|
>c.p + c.q : any
|
|
>c.p : number
|
|
>c : C
|
|
>p : number
|
|
>c.q : any
|
|
>c : C
|
|
>q : any
|
|
|
|
=== tests/cases/conformance/salsa/importer.js ===
|
|
import { j, k } from './assignmentToVoidZero2'
|
|
>j : number
|
|
>k : any
|
|
|
|
j + k
|
|
>j + k : any
|
|
>j : number
|
|
>k : any
|
|
|