53a756ea63
* Type `this` in more constructor functions Previously, `this: this` in constructor functions only when there was an explicit `@constructor` tag on the function. Now, `this: this` for any function that's known to be a constructor function. This improves completions inside constructor functions; also note that previously the compiler *did* type `this: this` inside methods of constructor functions, so this fix makes us more consistent. This is reflected in the large number of baselines that improve. The fix is a simple switch to `isJSConstructor`, which is the standard way to detect constructor functions. I'm not sure why the original PR didn't use this method. I remember discussing this limitation in the original bug, #25979, and I guess I decided that it made sense. But I was heavily primed by the bug's framing of the problem in terms of `noImplicitThis`, which *should* require an explicit `@constructor` tag. With better typing comes better detection of `@readonly` assignment; I had to fix the readonly detection code to use `isJSConstructor` as well. * Remove `Add @class tag` fix for noImplicitThis. The new rules mean that it never applies. It's possible that it should apply to functions like ```js function f() { this.init() } ``` In which `init` is never defined, but I think this program is incomplete enough that not offering the fix is fine. * Fix precedence of `@this` Previously, both `@class` and `@this` in a jsdoc would cause the `@this` annotation to be ignored. This became a worse problem with this PR, because `this` is correctly typed even without the annotation. This commit makes sure that `@this` is checked first and used if present.
40 lines
787 B
Plaintext
40 lines
787 B
Plaintext
=== /a.js ===
|
|
exports.x = 0;
|
|
>exports.x = 0 : 0
|
|
>exports.x : number
|
|
>exports : typeof import("/a")
|
|
>x : number
|
|
>0 : 0
|
|
|
|
exports.x;
|
|
>exports.x : number
|
|
>exports : typeof import("/a")
|
|
>x : number
|
|
|
|
// Works nested
|
|
{
|
|
// 'exports' does not provide a contextual type to a function-class
|
|
exports.Cls = function() {
|
|
>exports.Cls = function() { this.x = 0; } : typeof Cls
|
|
>exports.Cls : typeof Cls
|
|
>exports : typeof import("/a")
|
|
>Cls : typeof Cls
|
|
>function() { this.x = 0; } : typeof Cls
|
|
|
|
this.x = 0;
|
|
>this.x = 0 : 0
|
|
>this.x : any
|
|
>this : this
|
|
>x : any
|
|
>0 : 0
|
|
}
|
|
}
|
|
|
|
const instance = new exports.Cls();
|
|
>instance : Cls
|
|
>new exports.Cls() : Cls
|
|
>exports.Cls : typeof Cls
|
|
>exports : typeof import("/a")
|
|
>Cls : typeof Cls
|
|
|