Previously, when getting jsdoc for signatures, the services layer would get the jsdoc tags for the base symbol of a signature if it was present. This is fine except when the base was overloaded. In that case, the multiple signatures of the overload would all contribute jsdoc, which is not correct. A more correct fix would be to resolve overloads to the base, but the compiler doesn't have this capability and adding it or jury-rigging it seems like it would be complex, inappropriate for a fix to ship in a patch version. Co-authored-by: Orta Therox <git@orta.io> Co-authored-by: Orta Therox <git@orta.io>
140 lines
2.6 KiB
Plaintext
140 lines
2.6 KiB
Plaintext
[
|
|
{
|
|
"marker": {
|
|
"fileName": "/tests/cases/fourslash/deprecatedInheritedJSDocOverload.ts",
|
|
"position": 1183,
|
|
"name": ""
|
|
},
|
|
"quickInfo": {
|
|
"kind": "method",
|
|
"kindModifiers": "",
|
|
"textSpan": {
|
|
"start": 1174,
|
|
"length": 9
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "method",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "ThingWithDeprecations",
|
|
"kind": "interfaceName"
|
|
},
|
|
{
|
|
"text": "<",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "void",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": ">",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": ".",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "subscribe",
|
|
"kind": "methodName"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "observer",
|
|
"kind": "parameterName"
|
|
},
|
|
{
|
|
"text": "?",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "PartialObserver",
|
|
"kind": "interfaceName"
|
|
},
|
|
{
|
|
"text": "<",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "void",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": ">",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "Subscription",
|
|
"kind": "interfaceName"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "+",
|
|
"kind": "operator"
|
|
},
|
|
{
|
|
"text": "2",
|
|
"kind": "numericLiteral"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "overloads",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
}
|
|
],
|
|
"documentation": []
|
|
}
|
|
}
|
|
] |