f0fe1b88ca
* Make isDefinition aware of target symbol
Initial code, haven't fixed any tests yet.
* Update baselines
This commit includes a regression for commonjs aliases:
```js
// @filename: a.js
function f() { }
module.exports.f = f
// @filename: b.js
const { f } = require('./a')
f/**/
```
Now says that `f` in b.js has 1 reference --
the alias `module.exports.f = f`. This is not correct (or not exactly
correct), but correctly fixing will involve re-creating the ad-hoc
commonjs alias resolution code from the checker. I don't think it's
worth it for an edge case like this.
* update more unit tests
* Fix symbol lookup for constructors
* More baselines + two fixes
1. Fix `default` support.
2. Add a secondary declaration location for commonjs assignment
declarations.
* Update rest of baselines
* Switch a few more tests over to baselines
791 lines
14 KiB
Plaintext
791 lines
14 KiB
Plaintext
// === /b.ts ===
|
|
// import [|A|] = require("./a");
|
|
// [|A|];
|
|
|
|
// === /a.ts ===
|
|
// export = class /*FIND ALL REFS*/[|A|] {
|
|
// m() { [|A|]; }
|
|
// };
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "local class",
|
|
"name": "(local class) A",
|
|
"textSpan": {
|
|
"start": 15,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "local class",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "className"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 9,
|
|
"length": 26
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 15,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 9,
|
|
"length": 26
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 29,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/b.ts",
|
|
"kind": "alias",
|
|
"name": "(alias) (local class) A\nimport A = require(\"./a\")",
|
|
"textSpan": {
|
|
"start": 7,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "alias",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "local class",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "aliasName"
|
|
},
|
|
{
|
|
"text": "\n",
|
|
"kind": "lineBreak"
|
|
},
|
|
{
|
|
"text": "import",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "aliasName"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "=",
|
|
"kind": "operator"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "require",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "\"./a\"",
|
|
"kind": "stringLiteral"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 26
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 7,
|
|
"length": 1
|
|
},
|
|
"fileName": "/b.ts",
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 26
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 27,
|
|
"length": 1
|
|
},
|
|
"fileName": "/b.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /b.ts ===
|
|
// import [|A|] = require("./a");
|
|
// [|A|];
|
|
|
|
// === /a.ts ===
|
|
// export = class [|A|] {
|
|
// m() { /*FIND ALL REFS*/[|A|]; }
|
|
// };
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "local class",
|
|
"name": "(local class) A",
|
|
"textSpan": {
|
|
"start": 15,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "local class",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "className"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 9,
|
|
"length": 26
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 15,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 9,
|
|
"length": 26
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 29,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/b.ts",
|
|
"kind": "alias",
|
|
"name": "(alias) (local class) A\nimport A = require(\"./a\")",
|
|
"textSpan": {
|
|
"start": 7,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "alias",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "local class",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "aliasName"
|
|
},
|
|
{
|
|
"text": "\n",
|
|
"kind": "lineBreak"
|
|
},
|
|
{
|
|
"text": "import",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "aliasName"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "=",
|
|
"kind": "operator"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "require",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "\"./a\"",
|
|
"kind": "stringLiteral"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 26
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 7,
|
|
"length": 1
|
|
},
|
|
"fileName": "/b.ts",
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 26
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 27,
|
|
"length": 1
|
|
},
|
|
"fileName": "/b.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /b.ts ===
|
|
// import /*FIND ALL REFS*/[|A|] = require("./a");
|
|
// [|A|];
|
|
|
|
// === /a.ts ===
|
|
// export = class [|A|] {
|
|
// m() { [|A|]; }
|
|
// };
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/b.ts",
|
|
"kind": "alias",
|
|
"name": "(alias) (local class) A\nimport A = require(\"./a\")",
|
|
"textSpan": {
|
|
"start": 7,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "alias",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "local class",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "aliasName"
|
|
},
|
|
{
|
|
"text": "\n",
|
|
"kind": "lineBreak"
|
|
},
|
|
{
|
|
"text": "import",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "aliasName"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "=",
|
|
"kind": "operator"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "require",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "\"./a\"",
|
|
"kind": "stringLiteral"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 26
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 7,
|
|
"length": 1
|
|
},
|
|
"fileName": "/b.ts",
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 26
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 27,
|
|
"length": 1
|
|
},
|
|
"fileName": "/b.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "local class",
|
|
"name": "(local class) A",
|
|
"textSpan": {
|
|
"start": 15,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "local class",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "className"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 9,
|
|
"length": 26
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 15,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 9,
|
|
"length": 26
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 29,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /b.ts ===
|
|
// import [|A|] = require("./a");
|
|
// /*FIND ALL REFS*/[|A|];
|
|
|
|
// === /a.ts ===
|
|
// export = class [|A|] {
|
|
// m() { [|A|]; }
|
|
// };
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/b.ts",
|
|
"kind": "alias",
|
|
"name": "(alias) (local class) A\nimport A = require(\"./a\")",
|
|
"textSpan": {
|
|
"start": 7,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "alias",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "local class",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "aliasName"
|
|
},
|
|
{
|
|
"text": "\n",
|
|
"kind": "lineBreak"
|
|
},
|
|
{
|
|
"text": "import",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "aliasName"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "=",
|
|
"kind": "operator"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "require",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "\"./a\"",
|
|
"kind": "stringLiteral"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 26
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 7,
|
|
"length": 1
|
|
},
|
|
"fileName": "/b.ts",
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 26
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 27,
|
|
"length": 1
|
|
},
|
|
"fileName": "/b.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "local class",
|
|
"name": "(local class) A",
|
|
"textSpan": {
|
|
"start": 15,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "local class",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "A",
|
|
"kind": "className"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 9,
|
|
"length": 26
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 15,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 9,
|
|
"length": 26
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 29,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
] |