f0fe1b88ca
* Make isDefinition aware of target symbol Initial code, haven't fixed any tests yet. * Update baselines This commit includes a regression for commonjs aliases: ```js // @filename: a.js function f() { } module.exports.f = f // @filename: b.js const { f } = require('./a') f/**/ ``` Now says that `f` in b.js has 1 reference -- the alias `module.exports.f = f`. This is not correct (or not exactly correct), but correctly fixing will involve re-creating the ad-hoc commonjs alias resolution code from the checker. I don't think it's worth it for an edge case like this. * update more unit tests * Fix symbol lookup for constructors * More baselines + two fixes 1. Fix `default` support. 2. Add a secondary declaration location for commonjs assignment declarations. * Update rest of baselines * Switch a few more tests over to baselines
481 lines
8.7 KiB
Plaintext
481 lines
8.7 KiB
Plaintext
// === /a.ts ===
|
|
// class C {
|
|
// get /*FIND ALL REFS*/[|g|](): number { return 0; }
|
|
//
|
|
// set s(value: number) {}
|
|
// }
|
|
// const { [|g|], s } = new C();
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "property",
|
|
"name": "(property) C.g: number",
|
|
"textSpan": {
|
|
"start": 18,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "property",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "C",
|
|
"kind": "className"
|
|
},
|
|
{
|
|
"text": ".",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "g",
|
|
"kind": "propertyName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "number",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 14,
|
|
"length": 29
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 18,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 14,
|
|
"length": 29
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 83,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 75,
|
|
"length": 25
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /a.ts ===
|
|
// class C {
|
|
// get [|g|](): number { return 0; }
|
|
//
|
|
// set s(value: number) {}
|
|
// }
|
|
// const { /*FIND ALL REFS*/[|g|], s } = new C();
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "property",
|
|
"name": "(property) C.g: number",
|
|
"textSpan": {
|
|
"start": 18,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "property",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "C",
|
|
"kind": "className"
|
|
},
|
|
{
|
|
"text": ".",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "g",
|
|
"kind": "propertyName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "number",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 14,
|
|
"length": 29
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 18,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 14,
|
|
"length": 29
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "const",
|
|
"name": "const g: number",
|
|
"textSpan": {
|
|
"start": 83,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "const",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "g",
|
|
"kind": "localName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "number",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 75,
|
|
"length": 25
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 83,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 75,
|
|
"length": 25
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /a.ts ===
|
|
// class C {
|
|
// get g(): number { return 0; }
|
|
//
|
|
// set /*FIND ALL REFS*/[|s|](value: number) {}
|
|
// }
|
|
// const { g, [|s|] } = new C();
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "property",
|
|
"name": "(property) C.s: number",
|
|
"textSpan": {
|
|
"start": 53,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "property",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "C",
|
|
"kind": "className"
|
|
},
|
|
{
|
|
"text": ".",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "s",
|
|
"kind": "propertyName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "number",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 49,
|
|
"length": 23
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 53,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 49,
|
|
"length": 23
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 86,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 75,
|
|
"length": 25
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /a.ts ===
|
|
// class C {
|
|
// get g(): number { return 0; }
|
|
//
|
|
// set [|s|](value: number) {}
|
|
// }
|
|
// const { g, /*FIND ALL REFS*/[|s|] } = new C();
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "property",
|
|
"name": "(property) C.s: number",
|
|
"textSpan": {
|
|
"start": 53,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "property",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "C",
|
|
"kind": "className"
|
|
},
|
|
{
|
|
"text": ".",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "s",
|
|
"kind": "propertyName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "number",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 49,
|
|
"length": 23
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 53,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 49,
|
|
"length": 23
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/a.ts",
|
|
"kind": "const",
|
|
"name": "const s: number",
|
|
"textSpan": {
|
|
"start": 86,
|
|
"length": 1
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "const",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "s",
|
|
"kind": "localName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "number",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 75,
|
|
"length": 25
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 86,
|
|
"length": 1
|
|
},
|
|
"fileName": "/a.ts",
|
|
"contextSpan": {
|
|
"start": 75,
|
|
"length": 25
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
}
|
|
]
|
|
}
|
|
] |